[GitHub] [spark] MichaelChirico commented on a change in pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
MichaelChirico commented on a change in pull request #28386: URL: https://github.com/apache/spark/pull/28386#discussion_r416376995 ## File path: R/pkg/R/DataFrame.R ## @@ -2287,16 +2287,19 @@ setMethod("mutate", # For named arguments, use the names for arguments

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620419395 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] MichaelChirico commented on a change in pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
MichaelChirico commented on a change in pull request #28386: URL: https://github.com/apache/spark/pull/28386#discussion_r416376851 ## File path: R/pkg/R/DataFrame.R ## @@ -3445,7 +3448,7 @@ setMethod("as.data.frame", #' @note attach since 1.6.0 setMethod("attach",

[GitHub] [spark] MichaelChirico commented on a change in pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
MichaelChirico commented on a change in pull request #28386: URL: https://github.com/apache/spark/pull/28386#discussion_r416375375 ## File path: R/pkg/R/DataFrame.R ## @@ -2287,16 +2287,19 @@ setMethod("mutate", # For named arguments, use the names for arguments

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620419395 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620418942 **[Test build #121964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121964/testReport)** for PR 28386 at commit

[GitHub] [spark] MichaelChirico commented on a change in pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
MichaelChirico commented on a change in pull request #28386: URL: https://github.com/apache/spark/pull/28386#discussion_r416372474 ## File path: R/pkg/R/DataFrame.R ## @@ -2287,16 +2287,19 @@ setMethod("mutate", # For named arguments, use the names for arguments

[GitHub] [spark] baohe-zhang commented on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
baohe-zhang commented on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620416506 @gengliangwang sure, I will add unit tests. This is an automated message from the Apache Git Service. To

[GitHub] [spark] gengliangwang edited a comment on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
gengliangwang edited a comment on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620409199 @baohe-zhang Thanks for the fix! Could you follow @HeartSaVioR 's suggestion to add unit tests?

[GitHub] [spark] MichaelChirico commented on pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
MichaelChirico commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620416479 @HyukjinKwon please advise on how to test this. I did an ad hoc test that it's working as intended but we should formalize.

[GitHub] [spark] MichaelChirico opened a new pull request #28386: [SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
MichaelChirico opened a new pull request #28386: URL: https://github.com/apache/spark/pull/28386 ### What changes were proposed in this pull request? Change the strategy for how the varargs are handled in the default `mutate` method ### Why are the changes needed?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620415137 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620415124 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620415124 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620299487 **[Test build #121934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121934/testReport)** for PR 28370 at commit

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620414158 **[Test build #121934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121934/testReport)** for PR 28370 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-620413472 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-620413472 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-04-28 Thread GitBox
SparkQA commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-620412995 **[Test build #121963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121963/testReport)** for PR 27690 at commit

[GitHub] [spark] kiszk commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-04-28 Thread GitBox
kiszk commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-620411164 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620410579 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620410579 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
SparkQA commented on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620410205 **[Test build #121962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121962/testReport)** for PR 27803 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
HyukjinKwon commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620409919 cc also @felixcheung and @shivaram This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] gengliangwang commented on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
gengliangwang commented on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620409199 @baohe-zhang Thanks for the fix! Could you follow @HeartSaVioR 's to add unit tests? This is an

[GitHub] [spark] AmplabJenkins commented on pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28385: URL: https://github.com/apache/spark/pull/28385#issuecomment-620407779 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28385: URL: https://github.com/apache/spark/pull/28385#issuecomment-620407779 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620407764 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620407764 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
SparkQA commented on pull request #28385: URL: https://github.com/apache/spark/pull/28385#issuecomment-620407468 **[Test build #121961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121961/testReport)** for PR 28385 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620306258 **[Test build #121936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121936/testReport)** for PR 28377 at commit

[GitHub] [spark] maropu commented on a change in pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
maropu commented on a change in pull request #27803: URL: https://github.com/apache/spark/pull/27803#discussion_r416360187 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala ## @@ -425,38 +425,35 @@ class

[GitHub] [spark] SparkQA commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-28 Thread GitBox
SparkQA commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620406736 **[Test build #121936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121936/testReport)** for PR 28377 at commit

[GitHub] [spark] maropu commented on a change in pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
maropu commented on a change in pull request #27803: URL: https://github.com/apache/spark/pull/27803#discussion_r416359123 ## File path: sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala ## @@ -344,12 +345,73 @@ class GeneratorFunctionSuite extends

[GitHub] [spark] HeartSaVioR commented on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
HeartSaVioR commented on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620405834 cc. @gengliangwang This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620405134 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620404728 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620405134 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] LantaoJin opened a new pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
LantaoJin opened a new pull request #28385: URL: https://github.com/apache/spark/pull/28385 ### What changes were proposed in this pull request? In our production, we find that many shuffle files could be located in

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620404718 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] yaooqinn commented on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
yaooqinn commented on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620404977 cc @cloud-fan, please also notice that the flakiness of CliSuite is still there according the test failure above.

[GitHub] [spark] dbtsai commented on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-28 Thread GitBox
dbtsai commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620404585 Ping @jerryshao @tgravescs @ulysses-you who work on this area for more eyes. This is an automated message from

[GitHub] [spark] SparkQA commented on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
SparkQA commented on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620404705 **[Test build #121960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121960/testReport)** for PR 28381 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620404718 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620404013 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620404007 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] yaooqinn commented on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
yaooqinn commented on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620404507 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620404007 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on pull request #28106: [SPARK-31335][SQL] Add try function support

2020-04-28 Thread GitBox
maropu commented on pull request #28106: URL: https://github.com/apache/spark/pull/28106#issuecomment-620403960 Yea, I'm also +1 on this idea. But, we need more feedbacks from others. This is an automated message from the

[GitHub] [spark] maropu edited a comment on pull request #28106: [SPARK-31335][SQL] Add try function support

2020-04-28 Thread GitBox
maropu edited a comment on pull request #28106: URL: https://github.com/apache/spark/pull/28106#issuecomment-620403960 Yea, I'm also +1 on this idea. But, we need more feedbacks from others. also cc: @dongjoon-hyun This

[GitHub] [spark] SparkQA removed a comment on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620344715 **[Test build #121946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121946/testReport)** for PR 28381 at commit

[GitHub] [spark] SparkQA commented on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
SparkQA commented on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620403432 **[Test build #121946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121946/testReport)** for PR 28381 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620340295 **[Test build #121944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121944/testReport)** for PR 28379 at commit

[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620402749 **[Test build #121944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121944/testReport)** for PR 28379 at commit

[GitHub] [spark] MaxGekk commented on a change in pull request #28343: [SPARK-31563][SQL] Fix failure of InSet.sql for collections of Catalyst's internal types

2020-04-28 Thread GitBox
MaxGekk commented on a change in pull request #28343: URL: https://github.com/apache/spark/pull/28343#discussion_r416351119 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -519,7 +520,9 @@ case class InSet(child:

[GitHub] [spark] MaxGekk commented on a change in pull request #28343: [SPARK-31563][SQL] Fix failure of InSet.sql for collections of Catalyst's internal types

2020-04-28 Thread GitBox
MaxGekk commented on a change in pull request #28343: URL: https://github.com/apache/spark/pull/28343#discussion_r416350651 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -519,7 +520,9 @@ case class InSet(child:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28380: URL: https://github.com/apache/spark/pull/28380#issuecomment-620399220 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28380: URL: https://github.com/apache/spark/pull/28380#issuecomment-620399217 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] imback82 commented on a change in pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
imback82 commented on a change in pull request #28375: URL: https://github.com/apache/spark/pull/28375#discussion_r416349712 ## File path: docs/sql-migration-guide.md ## @@ -59,7 +59,7 @@ license: | - In Spark 3.0, you can use `ADD FILE` to add file directories as well.

[GitHub] [spark] AmplabJenkins commented on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28380: URL: https://github.com/apache/spark/pull/28380#issuecomment-620399217 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-28 Thread GitBox
MaxGekk commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-620399241 After offline discussion with @gatorsmile @cloud-fan @HyukjinKwon, we decided to revert https://github.com/apache/spark/pull/25754 . I will open a PR for that and close this

[GitHub] [spark] imback82 commented on a change in pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
imback82 commented on a change in pull request #28375: URL: https://github.com/apache/spark/pull/28375#discussion_r416349786 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala ## @@ -193,18 +193,16 @@ class HiveCommandSuite

[GitHub] [spark] SparkQA removed a comment on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28380: URL: https://github.com/apache/spark/pull/28380#issuecomment-620342487 **[Test build #121945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121945/testReport)** for PR 28380 at commit

[GitHub] [spark] MaxGekk commented on a change in pull request #28343: [SPARK-31563][SQL] Fix failure of InSet.sql for collections of Catalyst's internal types

2020-04-28 Thread GitBox
MaxGekk commented on a change in pull request #28343: URL: https://github.com/apache/spark/pull/28343#discussion_r416348966 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -519,7 +520,9 @@ case class InSet(child:

[GitHub] [spark] SparkQA commented on pull request #28380: [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions

2020-04-28 Thread GitBox
SparkQA commented on pull request #28380: URL: https://github.com/apache/spark/pull/28380#issuecomment-620398517 **[Test build #121945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121945/testReport)** for PR 28380 at commit

<    4   5   6   7   8   9