[GitHub] [spark] gengliangwang edited a comment on pull request #28383: [SPARK-31590][SQL] Metadata-only queries should not include subquery in partition filters

gengliangwang edited a comment on pull request #28383: URL: https://github.com/apache/spark/pull/28383#issuecomment-623875587 > Shall we remove OptimizeMetadataOnlyQuery? IIRC it has a correcness issue and we disable it by default. cc @gengliangwang On second thought: I think we

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623885385 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

SparkQA removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623879122 **[Test build #122307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122307/testReport)** for PR 26624 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623885385 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

SparkQA commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623885348 **[Test build #122307 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122307/testReport)** for PR 26624 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

AmplabJenkins commented on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623883859 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

AmplabJenkins removed a comment on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623883859 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

SparkQA commented on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623883544 **[Test build #122308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122308/testReport)** for PR 28451 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419892413 ## File path: project/SparkBuild.scala ## @@ -905,7 +905,7 @@ object Unidoc { object Checkstyle { lazy val settings = Seq( -

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419892755 ## File path: project/SparkBuild.scala ## @@ -905,7 +905,7 @@ object Unidoc { object Checkstyle { lazy val settings = Seq( -

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419891389 ## File path: project/SparkBuild.scala ## @@ -172,7 +172,7 @@ object SparkBuild extends PomBuild { val configV = (baseDirectory in

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623879484 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

AmplabJenkins commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623879484 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

AmplabJenkins removed a comment on pull request #28441: URL: https://github.com/apache/spark/pull/28441#issuecomment-623879398 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

AmplabJenkins commented on pull request #28441: URL: https://github.com/apache/spark/pull/28441#issuecomment-623879398 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419890587 ## File path: project/SparkBuild.scala ## @@ -172,7 +172,7 @@ object SparkBuild extends PomBuild { val configV = (baseDirectory in

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419890734 ## File path: project/SparkBuild.scala ## @@ -172,7 +172,7 @@ object SparkBuild extends PomBuild { val configV = (baseDirectory in

[GitHub] [spark] SparkQA commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

SparkQA commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623879122 **[Test build #122307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122307/testReport)** for PR 26624 at commit

[GitHub] [spark] SparkQA commented on pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

SparkQA commented on pull request #28441: URL: https://github.com/apache/spark/pull/28441#issuecomment-623879076 **[Test build #122306 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122306/testReport)** for PR 28441 at commit

[GitHub] [spark] cloud-fan commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

cloud-fan commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-623877465 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maropu commented on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

maropu commented on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623877304 Ur, the jira ID is incorrect? @dilipbiswal This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] maropu commented on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

maropu commented on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623876997 Thanks! Merged to master/3.0. If @srowen has more comments, please ping @huaxingao so that she can include more fixes in her PR (#28451).

[GitHub] [spark] dilipbiswal commented on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

dilipbiswal commented on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623876888 Thanks a lot @maropu @huaxingao @srowen @gatorsmile This is an automated message from the Apache Git

[GitHub] [spark] MaxGekk commented on a change in pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

MaxGekk commented on a change in pull request #28441: URL: https://github.com/apache/spark/pull/28441#discussion_r419886514 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala ## @@ -286,6 +286,17 @@ object RebaseDateTime { */

[GitHub] [spark] maropu commented on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

maropu commented on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623875717 Looks fine and I'll merge this first. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] gengliangwang commented on pull request #28383: [SPARK-31590][SQL] Metadata-only queries should not include subquery in partition filters

gengliangwang commented on pull request #28383: URL: https://github.com/apache/spark/pull/28383#issuecomment-623875587 > Shall we remove OptimizeMetadataOnlyQuery? IIRC it has a correcness issue and we disable it by default. cc @gengliangwang I am +1 with that. The correctness

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28366: [SPARK-31365][SQL] Enable nested predicate pushdown per data sources

AmplabJenkins removed a comment on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-623875337 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28366: [SPARK-31365][SQL] Enable nested predicate pushdown per data sources

AmplabJenkins commented on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-623875337 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28224: [SPARK-31429][SQL][DOC] Automatically generates a SQL document for built-in functions

maropu commented on a change in pull request #28224: URL: https://github.com/apache/spark/pull/28224#discussion_r419884736 ## File path: docs/sql-ref-functions-builtin.md ## @@ -0,0 +1,77 @@ +--- +layout: global +title: Built-in Functions +displayTitle: Built-in Functions

[GitHub] [spark] dilipbiswal commented on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

dilipbiswal commented on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623875264 Nice @huaxingao . LGTM - had some very minor comments. This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #28366: [SPARK-31365][SQL] Enable nested predicate pushdown per data sources

SparkQA commented on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-623874913 **[Test build #122305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122305/testReport)** for PR 28366 at commit

[GitHub] [spark] maropu commented on pull request #28239: [SPARK-31467][SQL][TEST] Refactor the sql tests to prevent TableAlreadyExistsException

maropu commented on pull request #28239: URL: https://github.com/apache/spark/pull/28239#issuecomment-623874394 Thanks! Merged to master/3.0. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419884091 ## File path: docs/configuration.md ## @@ -2670,6 +2670,9 @@ Spark uses [log4j](http://logging.apache.org/log4j/) for logging. You can config

[GitHub] [spark] huaxingao commented on a change in pull request #28224: [SPARK-31429][SQL][DOC] Automatically generates a SQL document for built-in functions

huaxingao commented on a change in pull request #28224: URL: https://github.com/apache/spark/pull/28224#discussion_r419884345 ## File path: docs/sql-ref-functions-builtin.md ## @@ -0,0 +1,77 @@ +--- +layout: global +title: Built-in Functions +displayTitle: Built-in Functions

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

AmplabJenkins removed a comment on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623874343 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

SparkQA commented on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623874239 **[Test build #122303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122303/testReport)** for PR 28451 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

AmplabJenkins commented on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623874343 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

SparkQA removed a comment on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623870833 **[Test build #122303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122303/testReport)** for PR 28451 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28393: [SPARK-31595][SQL] Spark sql should allow unescaped quote mark in quoted string

cloud-fan commented on a change in pull request #28393: URL: https://github.com/apache/spark/pull/28393#discussion_r419883101 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala ## @@ -500,4 +500,13 @@ class CliSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28366: [SPARK-31365][SQL] Enable nested predicate pushdown per data sources

AmplabJenkins removed a comment on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-623873145 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28366: [SPARK-31365][SQL] Enable nested predicate pushdown per data sources

AmplabJenkins commented on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-623873145 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28224: [SPARK-31429][SQL][DOC] Automatically generates a SQL document for built-in functions

maropu commented on a change in pull request #28224: URL: https://github.com/apache/spark/pull/28224#discussion_r419882097 ## File path: docs/sql-ref-functions-builtin.md ## @@ -0,0 +1,77 @@ +--- +layout: global +title: Built-in Functions +displayTitle: Built-in Functions

[GitHub] [spark] cloud-fan commented on pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

cloud-fan commented on pull request #28441: URL: https://github.com/apache/spark/pull/28441#issuecomment-623872965 LGTM, let's regenerate the benchmark result to fix conflicts. This is an automated message from the Apache

[GitHub] [spark] dilipbiswal commented on a change in pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

dilipbiswal commented on a change in pull request #28451: URL: https://github.com/apache/spark/pull/28451#discussion_r419882287 ## File path: docs/sql-ref-syntax-aux-show-partitions.md ## @@ -27,37 +27,28 @@ partition spec. ### Syntax -{% highlight sql %} +```sql SHOW

[GitHub] [spark] maropu commented on a change in pull request #28224: [SPARK-31429][SQL][DOC] Automatically generates a SQL document for built-in functions

maropu commented on a change in pull request #28224: URL: https://github.com/apache/spark/pull/28224#discussion_r419882097 ## File path: docs/sql-ref-functions-builtin.md ## @@ -0,0 +1,77 @@ +--- +layout: global +title: Built-in Functions +displayTitle: Built-in Functions

[GitHub] [spark] SparkQA commented on pull request #28366: [SPARK-31365][SQL] Enable nested predicate pushdown per data sources

SparkQA commented on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-623872783 **[Test build #122304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122304/testReport)** for PR 28366 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28441: [SPARK-31630][SQL] Fix perf regression by skipping timestamps rebasing after some threshold

cloud-fan commented on a change in pull request #28441: URL: https://github.com/apache/spark/pull/28441#discussion_r419882017 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala ## @@ -286,6 +286,17 @@ object RebaseDateTime {

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419881372 ## File path: docs/configuration.md ## @@ -2670,6 +2670,9 @@ Spark uses [log4j](http://logging.apache.org/log4j/) for logging. You can config

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419881372 ## File path: docs/configuration.md ## @@ -2670,6 +2670,9 @@ Spark uses [log4j](http://logging.apache.org/log4j/) for logging. You can config

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

AmplabJenkins removed a comment on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623871603 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

AmplabJenkins commented on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623871603 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28451: [SPARK-31636][SQL][DOCS] Remove HTML syntax in SQL reference

SparkQA commented on pull request #28451: URL: https://github.com/apache/spark/pull/28451#issuecomment-623870833 **[Test build #122303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122303/testReport)** for PR 28451 at commit

<    1   2   3   4   5