bart-samwel commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427840563
##
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##
@@ -1,5 +1,10 @@
-- date time functions
+-- [SPARK-31710]
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631330392
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427836231
##
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##
@@ -1,5 +1,10 @@
-- date time functions
+-- [SPARK-31710]
AmplabJenkins removed a comment on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631329672
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631330392
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631329672
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631329021
**[Test build #122882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122882/testReport)**
for PR 28534 at commit
SparkQA commented on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631329030
**[Test build #122881 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122881/testReport)**
for PR 28591 at commit
bart-samwel commented on a change in pull request #28576:
URL: https://github.com/apache/spark/pull/28576#discussion_r427836822
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##
@@ -31,17 +31,50 @@ import
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427836231
##
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##
@@ -1,5 +1,10 @@
-- date time functions
+-- [SPARK-31710]
Ngone51 commented on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631327746
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427835502
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,78 @@ case class
AmplabJenkins removed a comment on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631325110
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427833760
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,78 @@ case class
AmplabJenkins commented on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631325110
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427833425
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,78 @@ case class
bart-samwel commented on a change in pull request #28576:
URL: https://github.com/apache/spark/pull/28576#discussion_r427831829
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##
@@ -31,17 +31,50 @@ import
SparkQA commented on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631324288
**[Test build #122880 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122880/testReport)**
for PR 28576 at commit
viirya commented on pull request #28575:
URL: https://github.com/apache/spark/pull/28575#issuecomment-631316606
I don't look at this PR yet, but yes, a general one should be better.
This is an automated message from the
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427821455
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,24 @@ class SQLQuerySuite extends QueryTest with
bart-samwel commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427818024
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,78 @@ case class
maropu commented on pull request #28575:
URL: https://github.com/apache/spark/pull/28575#issuecomment-631312585
IIRC we had some activities (not merged though) for CNF normalization, e.g.,
SPARK-6624 and SPARK-17357 (https://github.com/apache/spark/pull/15558). I'm
not sure about why they
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631311275
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631311275
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631310532
**[Test build #122879 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122879/testReport)**
for PR 28534 at commit
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427813430
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,24 @@ class SQLQuerySuite extends QueryTest with
AmplabJenkins removed a comment on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-631302710
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427809138
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,84 @@ case class
AmplabJenkins commented on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-631302710
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-631302121
**[Test build #122878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122878/testReport)**
for PR 27006 at commit
cloud-fan commented on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-631301560
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
cloud-fan commented on a change in pull request #27006:
URL: https://github.com/apache/spark/pull/27006#discussion_r427807877
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -130,6 +130,7 @@ abstract class
cloud-fan closed pull request #26624:
URL: https://github.com/apache/spark/pull/26624
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-631297689
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
igreenfield commented on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-631290151
@cloud-fan now all test pass what next?
This is an automated message from the Apache Git Service.
To
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427795388
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,24 @@ class SQLQuerySuite extends QueryTest with
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427793896
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,84 @@ case class
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427793499
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,84 @@ case class
SparkQA commented on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631286052
**[Test build #122877 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122877/testReport)**
for PR 28576 at commit
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427791380
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,84 @@ case class
AmplabJenkins removed a comment on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631282910
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631283001
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631283001
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631282910
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631282246
**[Test build #122876 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122876/testReport)**
for PR 28588 at commit
AmplabJenkins removed a comment on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631279934
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631280076
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631279925
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631280069
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631266015
**[Test build #122875 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122875/testReport)**
for PR 28591 at commit
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631279915
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631228091
**[Test build #122871 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122871/testReport)**
for PR 28588 at commit
SparkQA removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631263075
**[Test build #122874 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122874/testReport)**
for PR 28534 at commit
gengliangwang commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631280374
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631279923
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631279915
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631280069
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631279923
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631279838
**[Test build #122874 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122874/testReport)**
for PR 28534 at commit
SparkQA commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631279834
**[Test build #122871 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122871/testReport)**
for PR 28588 at commit
SparkQA commented on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631279837
**[Test build #122875 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122875/testReport)**
for PR 28591 at commit
AmplabJenkins removed a comment on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-631275560
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-631275560
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-631221221
**[Test build #122870 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122870/testReport)**
for PR 26624 at commit
SparkQA commented on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-631274324
**[Test build #122870 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122870/testReport)**
for PR 26624 at commit
HyukjinKwon edited a comment on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631260648
+1 from my side too.
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631266469
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631266469
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631266015
**[Test build #122875 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122875/testReport)**
for PR 28591 at commit
Ngone51 commented on pull request #28591:
URL: https://github.com/apache/spark/pull/28591#issuecomment-631266080
I checked the related module and only found these two are missing the
annotation. Please let me know if I missed someone else. Thanks!
cc @HyukjinKwon @tgravescs
AmplabJenkins removed a comment on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631264365
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631264354
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631264354
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631146065
**[Test build #122858 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122858/testReport)**
for PR 28544 at commit
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427767257
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,24 @@ class SQLQuerySuite extends QueryTest with
Ngone51 opened a new pull request #28591:
URL: https://github.com/apache/spark/pull/28591
### What changes were proposed in this pull request?
Added `@since 3.0.0` for `ResourceDiscoveryScriptPlugin` and
`ResourceInformation`.
### Why are the changes needed?
SparkQA commented on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631263822
**[Test build #122858 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122858/testReport)**
for PR 28544 at commit
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631263539
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631263539
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28590:
URL: https://github.com/apache/spark/pull/28590#issuecomment-631262591
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631263075
**[Test build #122874 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122874/testReport)**
for PR 28534 at commit
SparkQA removed a comment on pull request #28590:
URL: https://github.com/apache/spark/pull/28590#issuecomment-631237557
**[Test build #122873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122873/testReport)**
for PR 28590 at commit
AmplabJenkins commented on pull request #28590:
URL: https://github.com/apache/spark/pull/28590#issuecomment-631262591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28590:
URL: https://github.com/apache/spark/pull/28590#issuecomment-631262177
**[Test build #122873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122873/testReport)**
for PR 28590 at commit
viirya commented on pull request #28589:
URL: https://github.com/apache/spark/pull/28589#issuecomment-631261973
Yea, LGTM too.
This is an automated message from the Apache Git Service.
To respond to the message, please log
AmplabJenkins removed a comment on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631261256
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631261256
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631151915
**[Test build #122861 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122861/testReport)**
for PR 28544 at commit
gengliangwang commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631260790
@HyukjinKwon oh thanks for reminder
This is an automated message from the Apache Git Service.
To respond
SparkQA commented on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-631260783
**[Test build #122861 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122861/testReport)**
for PR 28544 at commit
HyukjinKwon commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631260648
+1 from me side too.
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631260536
@gengliangwang test is still running
This is an automated message from the Apache Git Service.
To respond
gengliangwang commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631258734
merging to 3.0
This is an automated message from the Apache Git Service.
To respond to the message,
erenavsarogullari commented on pull request #28588:
URL: https://github.com/apache/spark/pull/28588#issuecomment-631256412
Hi @gengliangwang,
Sure, make sense so end-user can start to use single version(`3.1`) directly
without backward compatibility requirement. Thanks for the effort.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631255845
Ah, I remember that some tests will fail because the latest HtmlUnit can't
properly interpret JavaScript code used in those tests.
So PR should follow #28578 .
401 - 495 of 495 matches
Mail list logo