[GitHub] [spark] SparkQA commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

SparkQA commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-635430213 **[Test build #123238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123238/testReport)** for PR 28439 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431937437 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -1053,93 +1018,34 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431937279 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -1053,93 +1018,34 @@ case class

[GitHub] [spark] zsxwing commented on pull request #27694: [SPARK-30946][SS] Serde entry with UnsafeRow on FileStream(Source/Sink)Log with LZ4 compression

zsxwing commented on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-635425691 One lesson I learned from the past is UnsafeRow is not designed to be persisted across Spark versions. I'd avoid to introduce another place that persists data in the UnsafeRow

[GitHub] [spark] iRakson commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

iRakson commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-635425045 It's ok. Please check according to your convenience. :) This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

HyukjinKwon edited a comment on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635404514 I actually didn't quite care about it but realised that people actually pretty hate the JVM stacktrace in Python exceptions. Maybe it's because you (and I .. and

[GitHub] [spark] AmplabJenkins commented on pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

AmplabJenkins commented on pull request #28626: URL: https://github.com/apache/spark/pull/28626#issuecomment-635414936 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

AmplabJenkins removed a comment on pull request #28626: URL: https://github.com/apache/spark/pull/28626#issuecomment-635414936 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

SparkQA removed a comment on pull request #28626: URL: https://github.com/apache/spark/pull/28626#issuecomment-635262473 **[Test build #123233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123233/testReport)** for PR 28626 at commit

[GitHub] [spark] SparkQA commented on pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

SparkQA commented on pull request #28626: URL: https://github.com/apache/spark/pull/28626#issuecomment-635413784 **[Test build #123233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123233/testReport)** for PR 28626 at commit

[GitHub] [spark] sarutak commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

sarutak commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-635410668 @iRakson Sorry for the late reply. I'll check this weekend. This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

HyukjinKwon edited a comment on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635404514 I actually didn't quite care about it but realised that people actually pretty hate the JVM stacktrace in Python exceptions. Maybe it's because you (and I .. and

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

HyukjinKwon edited a comment on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635404514 I actually didn't quite care about it but realised that people actually pretty hate the JVM stacktrace in Python exceptions. Maybe it's because you (and I .. and

[GitHub] [spark] yaooqinn commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

yaooqinn commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431909066 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -1053,93 +1018,34 @@ case class

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

HyukjinKwon edited a comment on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635404514 I actually didn't quite care about it but realised that people actually pretty hate the JVM stacktrace in Python exceptions. Maybe it's because you (and I .. and

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

HyukjinKwon edited a comment on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635404514 I actually didn't quite care about it but realised that people actually pretty hate the JVM stacktrace in Python exceptions. Maybe it's because you (and I .. and

[GitHub] [spark] HyukjinKwon commented on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

HyukjinKwon commented on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635404514 I actually didn't quite care about it but realised that people actually pretty hate the JVM stacktrace in Python exceptions. Maybe it's because you (and I .. and most of

[GitHub] [spark] cloud-fan commented on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

cloud-fan commented on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635400642 can we also remove the hack mentioned in https://github.com/apache/spark/pull/27207#discussion_r400237091 ?

[GitHub] [spark] cloud-fan commented on a change in pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

cloud-fan commented on a change in pull request #28656: URL: https://github.com/apache/spark/pull/28656#discussion_r431897015 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ## @@ -1107,10 +1107,16 @@ private[spark] class TaskSetManager(

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28648: [SPARK-31788][CORE][DSTREAM][PYTHON] Recover the support of union for different types of RDD and DStreams

HyukjinKwon commented on a change in pull request #28648: URL: https://github.com/apache/spark/pull/28648#discussion_r431888138 ## File path: python/pyspark/context.py ## @@ -864,8 +865,21 @@ def union(self, rdds): first_jrdd_deserializer = rdds[0]._jrdd_deserializer

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431882336 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -160,3 +156,83 @@ select from_json('{"time":"26/October/2015"}', 'time

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

AmplabJenkins removed a comment on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-635385025 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

AmplabJenkins removed a comment on pull request #28626: URL: https://github.com/apache/spark/pull/28626#issuecomment-635385036 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

AmplabJenkins commented on pull request #28626: URL: https://github.com/apache/spark/pull/28626#issuecomment-635385036 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431878950 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -1053,93 +1018,34 @@ case class

[GitHub] [spark] AmplabJenkins commented on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

AmplabJenkins commented on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-635385025 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

SparkQA commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-635384233 **[Test build #123238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123238/testReport)** for PR 28439 at commit

[GitHub] [spark] SparkQA commented on pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

SparkQA commented on pull request #28626: URL: https://github.com/apache/spark/pull/28626#issuecomment-635384195 **[Test build #123237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123237/testReport)** for PR 28626 at commit

[GitHub] [spark] SparkQA commented on pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

SparkQA commented on pull request #28654: URL: https://github.com/apache/spark/pull/28654#issuecomment-635384182 **[Test build #123236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123236/testReport)** for PR 28654 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28648: [SPARK-31788][CORE][DSTREAM][PYTHON] Recover the support of union for different types of RDD and DStreams

HyukjinKwon commented on a change in pull request #28648: URL: https://github.com/apache/spark/pull/28648#discussion_r431875923 ## File path: python/pyspark/context.py ## @@ -864,8 +865,21 @@ def union(self, rdds): first_jrdd_deserializer = rdds[0]._jrdd_deserializer

[GitHub] [spark] srowen commented on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

srowen commented on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635383500 Yeah that stack trace can be the only useful info in some cases, when the real error is on the JVM side. I get that Python users don't understand it as well. But otherwise by

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28648: [SPARK-31788][CORE][DSTREAM][PYTHON] Recover the support of union for different types of RDD and DStreams

HyukjinKwon commented on a change in pull request #28648: URL: https://github.com/apache/spark/pull/28648#discussion_r431875923 ## File path: python/pyspark/context.py ## @@ -864,8 +865,21 @@ def union(self, rdds): first_jrdd_deserializer = rdds[0]._jrdd_deserializer

[GitHub] [spark] xuanyuanking commented on pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

xuanyuanking commented on pull request #28607: URL: https://github.com/apache/spark/pull/28607#issuecomment-635383169 Thanks for reviving, I think it's an important metrics. How about also attach a screenshot of SQL UI contains this metric?

[GitHub] [spark] srowen commented on pull request #28663: [SPARK-31853][DOCS] Mention removal of params mixins setter in migration guide

srowen commented on pull request #28663: URL: https://github.com/apache/spark/pull/28663#issuecomment-635382221 Dumb question, but does that affect callers? This is an automated message from the Apache Git Service. To

[GitHub] [spark] srowen commented on pull request #27805: [SPARK-31056][SQL] Add CalendarIntervals division

srowen commented on pull request #27805: URL: https://github.com/apache/spark/pull/27805#issuecomment-635381702 Do other RDBMSes support this? or can you just divide their number of seconds, etc? This is an automated

[GitHub] [spark] xuanyuanking commented on a change in pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

xuanyuanking commented on a change in pull request #28607: URL: https://github.com/apache/spark/pull/28607#discussion_r431873551 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala ## @@ -132,6 +135,16 @@ trait

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

AmplabJenkins removed a comment on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635381610 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

AmplabJenkins commented on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635381610 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

SparkQA removed a comment on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635235689 **[Test build #123230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123230/testReport)** for PR 28650 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

AmplabJenkins removed a comment on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-635380769 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

SparkQA commented on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635380517 **[Test build #123230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123230/testReport)** for PR 28650 at commit

[GitHub] [spark] srowen commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

srowen commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-635380337 Jenkins test this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

AmplabJenkins commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-635380758 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] tgravescs commented on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

tgravescs commented on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635377056 ah, sorry I missed that, it is covered. This looks good to me then. I can file another jlira to investigate possibly handling better.

[GitHub] [spark] AmplabJenkins commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

AmplabJenkins commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-635375714 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

AmplabJenkins removed a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-635375714 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

SparkQA removed a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-635235753 **[Test build #123231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123231/testReport)** for PR 27019 at commit

[GitHub] [spark] SparkQA commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

SparkQA commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-635374582 **[Test build #123231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123231/testReport)** for PR 27019 at commit

[GitHub] [spark] srowen commented on a change in pull request #28648: [SPARK-31788][CORE][DSTREAM][PYTHON] Recover the support of union for different types of RDD and DStreams

srowen commented on a change in pull request #28648: URL: https://github.com/apache/spark/pull/28648#discussion_r431864565 ## File path: python/pyspark/context.py ## @@ -864,8 +865,21 @@ def union(self, rdds): first_jrdd_deserializer = rdds[0]._jrdd_deserializer

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

AmplabJenkins removed a comment on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635370749 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

AmplabJenkins commented on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635370749 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

SparkQA removed a comment on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635228183 **[Test build #123229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123229/testReport)** for PR 28650 at commit

[GitHub] [spark] SparkQA commented on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

SparkQA commented on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635369596 **[Test build #123229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123229/testReport)** for PR 28650 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

AmplabJenkins commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-635357163 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

AmplabJenkins removed a comment on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-635357163 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

SparkQA removed a comment on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-635217026 **[Test build #123227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123227/testReport)** for PR 28391 at commit

[GitHub] [spark] SparkQA commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

SparkQA commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-635356053 **[Test build #123227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123227/testReport)** for PR 28391 at commit

[GitHub] [spark] SparkQA commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

SparkQA commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-635355138 **[Test build #123235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123235/testReport)** for PR 27690 at commit

[GitHub] [spark] maropu commented on pull request #27648: [SPARK-24994][SQL] : Support filter pushdown for short and byte without explicit casting

maropu commented on pull request #27648: URL: https://github.com/apache/spark/pull/27648#issuecomment-635352606 yea, +1 on closing this for now. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

AmplabJenkins commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-635351710 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

AmplabJenkins removed a comment on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-635351710 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

maropu commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-635350888 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] yaooqinn commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

yaooqinn commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431704557 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -56,6 +56,28 @@ trait

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

AmplabJenkins removed a comment on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635228838 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

AmplabJenkins commented on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635228838 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

SparkQA commented on pull request #28650: URL: https://github.com/apache/spark/pull/28650#issuecomment-635228183 **[Test build #123229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123229/testReport)** for PR 28650 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431700042 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -160,3 +156,83 @@ select from_json('{"time":"26/October/2015"}', 'time

[GitHub] [spark] sarutak edited a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

sarutak edited a comment on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-635121208 @HyukjinKwon @shaneknapp The time limit for CI seems to be too short for Maven. Tests for this PR has failed 9 times due to the limit. I see [another

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431699759 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -56,6 +56,28 @@ trait

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635225190 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635225190 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635224555 **[Test build #123228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123228/testReport)** for PR 28593 at commit

[GitHub] [spark] cloud-fan commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

cloud-fan commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635223865 let's update the doc of `CreateTableLikeCommand` to make it clear that we copy table properties as well.

[GitHub] [spark] cloud-fan commented on a change in pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

cloud-fan commented on a change in pull request #28626: URL: https://github.com/apache/spark/pull/28626#discussion_r431696816 ## File path: sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala ## @@ -156,4 +157,38 @@ class ExpressionInfoSuite

[GitHub] [spark] yaooqinn commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

yaooqinn commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431693463 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -859,127 +865,80 @@ case class

[GitHub] [spark] SparkQA commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

SparkQA commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-635217026 **[Test build #123227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123227/testReport)** for PR 28391 at commit

[GitHub] [spark] yaooqinn commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

yaooqinn commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431688117 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -160,3 +156,83 @@ select from_json('{"time":"26/October/2015"}', 'time

[GitHub] [spark] HyukjinKwon commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

HyukjinKwon commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-635214739 I couldn't find some time to test it by myself with a close look but looks okay given that it's not effective by default.

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431686512 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -160,3 +156,83 @@ select from_json('{"time":"26/October/2015"}', 'time

[GitHub] [spark] HyukjinKwon commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

HyukjinKwon commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-635213364 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431685602 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -1053,93 +1012,35 @@ case class

[GitHub] [spark] AmplabJenkins commented on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

AmplabJenkins commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-635213731 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

AmplabJenkins removed a comment on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-635213731 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431685071 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -859,127 +865,80 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431682397 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -859,127 +865,80 @@ case class

[GitHub] [spark] yaooqinn commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

yaooqinn commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431681215 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -56,6 +56,28 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431680313 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -859,127 +865,80 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431679045 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -859,127 +865,80 @@ case class

[GitHub] [spark] yaooqinn commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

yaooqinn commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431679085 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -859,127 +865,80 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431678713 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -859,127 +865,80 @@ case class

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635205684 **[Test build #123226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123226/testReport)** for PR 28593 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28650: [SPARK-31830][SQL] Consistent error handling for datetime formatting and parsing functions

cloud-fan commented on a change in pull request #28650: URL: https://github.com/apache/spark/pull/28650#discussion_r431675407 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -56,6 +56,28 @@ trait

[GitHub] [spark] HyukjinKwon commented on pull request #28663: [SPARK-31853][DOCS] Mention removal of params mixins setter in migration guide

HyukjinKwon commented on pull request #28663: URL: https://github.com/apache/spark/pull/28663#issuecomment-635204211 @zhengruifeng FYI This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635202318 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635202318 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

AmplabJenkins removed a comment on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635194757 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28663: [SPARK-31853][DOCS] Mention removal of params mixins setter in migration guide

AmplabJenkins removed a comment on pull request #28663: URL: https://github.com/apache/spark/pull/28663#issuecomment-635193791 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

AmplabJenkins commented on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635194757 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

SparkQA commented on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635193973 **[Test build #123225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123225/testReport)** for PR 28656 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28663: [SPARK-31853][DOCS] Mention removal of params mixins setter in migration guide

AmplabJenkins commented on pull request #28663: URL: https://github.com/apache/spark/pull/28663#issuecomment-63519 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

<    1   2   3   4   5   6   >