AmplabJenkins commented on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643081793
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643081793
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643024924
**[Test build #123878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123878/testReport)**
for PR 28769 at commit
SparkQA commented on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643080999
**[Test build #123878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123878/testReport)**
for PR 28769 at commit
AmplabJenkins commented on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643079900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wangyum commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-643079877
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message, please
AmplabJenkins removed a comment on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643079900
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wangyum closed pull request #28734:
URL: https://github.com/apache/spark/pull/28734
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
maropu commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439219332
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
SparkQA commented on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643079173
**[Test build #123892 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123892/testReport)**
for PR 28802 at commit
zhli1142015 commented on a change in pull request #28769:
URL: https://github.com/apache/spark/pull/28769#discussion_r439218088
##
File path:
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java
##
@@ -247,17 +266,28 @@ public void close() throws
AmplabJenkins removed a comment on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-643078708
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-643078708
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-642999598
**[Test build #123873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123873/testReport)**
for PR 28715 at commit
SparkQA commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-643078161
**[Test build #123873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123873/testReport)**
for PR 28715 at commit
zhli1142015 commented on a change in pull request #28769:
URL: https://github.com/apache/spark/pull/28769#discussion_r439218088
##
File path:
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java
##
@@ -247,17 +266,28 @@ public void close() throws
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643075974
> OK, how about we merge #28806 to 3.0/2.4 first.
> And start the pagination feature from 3.1 if you insist?
I agree. I'll check that PR soon.
ulysses-you edited a comment on pull request #28778:
URL: https://github.com/apache/spark/pull/28778#issuecomment-643073718
How about `defaultSessionParallelism` or `sessionDefaultParallelism` ?
Sounds like more logical.
ulysses-you commented on pull request #28778:
URL: https://github.com/apache/spark/pull/28778#issuecomment-643073718
How about `defaultSessionParallelism` ? Sounds like more logical.
This is an automated message from the
gengliangwang edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643070561
> Even if no performance issue exists, lots of items rendered in one page
can be too noisy.
OK, how about we merge #28806 to 3.0/2.4 first.
And start the
AmplabJenkins removed a comment on pull request #28641:
URL: https://github.com/apache/spark/pull/28641#issuecomment-643070215
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643070561
> Even if no performance issue exists, lots of items rendered in one page
can be too noisy.
OK, how about we merge #28806 to 3.0/2.4 first.
And start the
AmplabJenkins removed a comment on pull request #28641:
URL: https://github.com/apache/spark/pull/28641#issuecomment-643070210
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28641:
URL: https://github.com/apache/spark/pull/28641#issuecomment-643070210
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28641:
URL: https://github.com/apache/spark/pull/28641#issuecomment-643032435
**[Test build #123879 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123879/testReport)**
for PR 28641 at commit
SparkQA commented on pull request #28641:
URL: https://github.com/apache/spark/pull/28641#issuecomment-643069579
**[Test build #123879 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123879/testReport)**
for PR 28641 at commit
cloud-fan commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439208897
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
AmplabJenkins removed a comment on pull request #28806:
URL: https://github.com/apache/spark/pull/28806#issuecomment-643067125
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643067241
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28806:
URL: https://github.com/apache/spark/pull/28806#issuecomment-643067120
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643067149
@sarutak I just created https://github.com/apache/spark/pull/28806.
I believe downgrading the vis version is a safer solution. We need to hotfix
this to Spark 3.0 ASAP
AmplabJenkins commented on pull request #28806:
URL: https://github.com/apache/spark/pull/28806#issuecomment-643067120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643067241
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28806:
URL: https://github.com/apache/spark/pull/28806#issuecomment-643066909
**[Test build #123889 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123889/testReport)**
for PR 28806 at commit
SparkQA commented on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643066913
**[Test build #123890 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123890/testReport)**
for PR 28805 at commit
SparkQA commented on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643066919
**[Test build #123891 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123891/testReport)**
for PR 28802 at commit
gengliangwang commented on pull request #28806:
URL: https://github.com/apache/spark/pull/28806#issuecomment-643066852
I didn't find vis-timeline-graph2d.min.css.map and
vis-timeline-graph2d.min.js.map in https://cdnjs.com/libraries/vis, so I
deleted them. It should be minor.
gengliangwang opened a new pull request #28806:
URL: https://github.com/apache/spark/pull/28806
### What changes were proposed in this pull request?
After #28192, the job list page becomes very slow.
For example, after the following operation, the UI loading can take >40
AmplabJenkins removed a comment on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643065269
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
maropu commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439206847
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-643065456
cc @srowen
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643065266
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #28391:
URL: https://github.com/apache/spark/pull/28391#issuecomment-643065274
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
maropu commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439206847
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
SparkQA commented on pull request #28391:
URL: https://github.com/apache/spark/pull/28391#issuecomment-643065075
**[Test build #123888 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123888/testReport)**
for PR 28391 at commit
maropu commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439206847
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
AmplabJenkins commented on pull request #28391:
URL: https://github.com/apache/spark/pull/28391#issuecomment-643065274
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643065266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439206847
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
AmplabJenkins removed a comment on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643064053
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sarutak edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643063667
> 1. if there are many stages in one job, the perf issue still exists
> 2. the two paginations in one page seem weird.
For 1), AllJobsPage is not affected even
cloud-fan commented on pull request #28778:
URL: https://github.com/apache/spark/pull/28778#issuecomment-643064091
The most confusing part is, default parallelism is more like a physical
stuff (related to cluster resource), and it's weird to have a per session
setting for it.
AmplabJenkins commented on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643064053
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sarutak edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643063667
> 1. if there are many stages in one job, the perf issue still exists
> 2. the two paginations in one page seem weird.
For 1), AllJobsPage is not affected even
AmplabJenkins removed a comment on pull request #28788:
URL: https://github.com/apache/spark/pull/28788#issuecomment-643063537
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HyukjinKwon commented on pull request #28391:
URL: https://github.com/apache/spark/pull/28391#issuecomment-643063847
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
SparkQA commented on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-643063405
**[Test build #123871 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123871/testReport)**
for PR 28802 at commit
SparkQA removed a comment on pull request #28802:
URL: https://github.com/apache/spark/pull/28802#issuecomment-642984785
**[Test build #123871 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123871/testReport)**
for PR 28802 at commit
cloud-fan commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439205389
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
AmplabJenkins commented on pull request #28788:
URL: https://github.com/apache/spark/pull/28788#issuecomment-643063537
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643063667
> 1. if there are many stages in one job, the perf issue still exists
> 2. the two paginations in one page seem weird.
For 1), AllJobsPage is not affected even if a job has
HyukjinKwon commented on pull request #28391:
URL: https://github.com/apache/spark/pull/28391#issuecomment-643063655
I am going to merge this in few days if there's no more comments given that
multiple LGTMs from the community. Let me know if there's any concern @tdas
@zsxwing
maropu commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439205161
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
cloud-fan commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r439204978
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##
@@ -285,334 +290,86 @@ class
SparkQA commented on pull request #28788:
URL: https://github.com/apache/spark/pull/28788#issuecomment-643063224
**[Test build #123887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123887/testReport)**
for PR 28788 at commit
AmplabJenkins removed a comment on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-643061704
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-643061704
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #28788:
URL: https://github.com/apache/spark/pull/28788#discussion_r439203785
##
File path: docs/running-on-yarn.md
##
@@ -82,6 +82,19 @@ In `cluster` mode, the driver runs on a different machine
than the client, so `S
cloud-fan commented on pull request #28801:
URL: https://github.com/apache/spark/pull/28801#issuecomment-643061871
yea the log4j property file is kind of the config to control this MDC
feature, and it's off by default.
This
SparkQA commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-643061412
**[Test build #123886 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123886/testReport)**
for PR 28593 at commit
dbtsai commented on a change in pull request #28788:
URL: https://github.com/apache/spark/pull/28788#discussion_r439203266
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
##
@@ -74,10 +76,11 @@ package object config {
dbtsai commented on a change in pull request #28788:
URL: https://github.com/apache/spark/pull/28788#discussion_r439203081
##
File path: docs/running-on-yarn.md
##
@@ -82,6 +82,19 @@ In `cluster` mode, the driver runs on a different machine
than the client, so `S
Running
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643059905
Let me create a PR for downgrading to 4.21.0 now.
This is an automated message from the Apache Git
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643059040
So, I am actually -1 in this solution, for two reasons:
1. if there are many stages in one job, the perf issue still exists
2. the two paginations in one page seem
AmplabJenkins removed a comment on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643058213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643046954
**[Test build #123882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123882/testReport)**
for PR 28805 at commit
AmplabJenkins commented on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643058206
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643058206
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-643058109
**[Test build #123882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123882/testReport)**
for PR 28805 at commit
sarutak edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643057633
@gengliangwang Yes, I've noticed that. [The performance issue of
`vis-timeline`](https://github.com/visjs/vis-timeline/issues/379) happens for
newer version of `vis.js`.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643057633
@gengliangwang Yes, I've noticed that. The performance issue of
`vis-timeline`https://github.com/visjs/vis-timeline/issues/379 happen for newer
version of `vis.js`.
viirya commented on a change in pull request #28123:
URL: https://github.com/apache/spark/pull/28123#discussion_r439196147
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##
@@ -165,6 +166,7 @@ case class FileSourceScanExec(
agrawaldevesh commented on a change in pull request #28708:
URL: https://github.com/apache/spark/pull/28708#discussion_r439197120
##
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache
agrawaldevesh commented on a change in pull request #28708:
URL: https://github.com/apache/spark/pull/28708#discussion_r439197120
##
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache
agrawaldevesh commented on a change in pull request #28708:
URL: https://github.com/apache/spark/pull/28708#discussion_r439197120
##
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache
AmplabJenkins removed a comment on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-643053409
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28801:
URL: https://github.com/apache/spark/pull/28801#issuecomment-643053415
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-643053409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28801:
URL: https://github.com/apache/spark/pull/28801#issuecomment-643053415
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
agrawaldevesh commented on a change in pull request #28708:
URL: https://github.com/apache/spark/pull/28708#discussion_r439183738
##
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache
SparkQA commented on pull request #28801:
URL: https://github.com/apache/spark/pull/28801#issuecomment-643053148
**[Test build #123884 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123884/testReport)**
for PR 28801 at commit
AmplabJenkins removed a comment on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643052703
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-643053181
**[Test build #123885 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123885/testReport)**
for PR 28593 at commit
AmplabJenkins removed a comment on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643052698
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643052698
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643012406
**[Test build #123875 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123875/testReport)**
for PR 28769 at commit
SparkQA commented on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-643052476
**[Test build #123875 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123875/testReport)**
for PR 28769 at commit
srowen commented on a change in pull request #28769:
URL: https://github.com/apache/spark/pull/28769#discussion_r439194927
##
File path:
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java
##
@@ -247,17 +266,28 @@ public void close() throws IOException {
viirya commented on a change in pull request #28123:
URL: https://github.com/apache/spark/pull/28123#discussion_r439194182
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed
SparkQA commented on pull request #28123:
URL: https://github.com/apache/spark/pull/28123#issuecomment-643050029
**[Test build #123883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123883/testReport)**
for PR 28123 at commit
1 - 100 of 806 matches
Mail list logo
