[GitHub] [spark] jiangxb1987 commented on a change in pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
jiangxb1987 commented on a change in pull request #28746: URL: https://github.com/apache/spark/pull/28746#discussion_r440589823 ## File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala ## @@ -63,23 +65,34 @@ class LocalSparkCluster( /* Start the

[GitHub] [spark] sarutak edited a comment on pull request #28837: [SPARK-31996][BUILD] Specify the version of ChromeDriver and RemoteWebDriver which can work with guava 14.0.1

2020-06-15 Thread GitBox
sarutak edited a comment on pull request #28837: URL: https://github.com/apache/spark/pull/28837#issuecomment-644531999 Note for reviewers that this fix affects tests with both `sbt` and `Maven` so we need to test with `sbt` and `Maven`. Tests with `sbt` runs first and I'll run tests wit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28837: [SPARK-31996][BUILD] Specify the version of ChromeDriver and RemoteWebDriver which can work with guava 14.0.1

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28837: URL: https://github.com/apache/spark/pull/28837#issuecomment-644531403 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28837: [SPARK-31996][BUILD] Specify the version of ChromeDriver and RemoteWebDriver which can work with guava 14.0.1

2020-06-15 Thread GitBox
SparkQA commented on pull request #28837: URL: https://github.com/apache/spark/pull/28837#issuecomment-644532968 **[Test build #124094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124094/testReport)** for PR 28837 at commit [`6a1e8c0`](https://github.com

[GitHub] [spark] sarutak commented on pull request #28837: [SPARK-31996][BUILD] Specify the version of ChromeDriver and RemoteWebDriver which can work with guava 14.0.1

2020-06-15 Thread GitBox
sarutak commented on pull request #28837: URL: https://github.com/apache/spark/pull/28837#issuecomment-644531999 Note for reviewers that this PR modifies both `SparkBuild.scala` and `pom.xml` so we need to test with `sbt` and `Maven`. Tests with `sbt` runs first and I'll run tests with `

[GitHub] [spark] cloud-fan closed pull request #28809: [SPARK-31959][SQL][3.0] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

2020-06-15 Thread GitBox
cloud-fan closed pull request #28809: URL: https://github.com/apache/spark/pull/28809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] sarutak opened a new pull request #28837: [SPARK-31996][BUILD] Specify the version of ChromeDriver and RemoteWebDriver which can work with guava 14.0.1

2020-06-15 Thread GitBox
sarutak opened a new pull request #28837: URL: https://github.com/apache/spark/pull/28837 ### What changes were proposed in this pull request? This PR proposes to specify the version of ChromeDriver and RemoteWebDriver which work with guava 14.0.1 explicitly. ### Why are the c

[GitHub] [spark] AmplabJenkins commented on pull request #28837: [SPARK-31996][BUILD] Specify the version of ChromeDriver and RemoteWebDriver which can work with guava 14.0.1

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28837: URL: https://github.com/apache/spark/pull/28837#issuecomment-644531403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on pull request #28809: [SPARK-31959][SQL][3.0] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28809: URL: https://github.com/apache/spark/pull/28809#issuecomment-644530812 thanks, merging to 3.0! This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644530173 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644530166 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644530166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644522490 **[Test build #124090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124090/testReport)** for PR 28836 at commit [`77730c0`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644530103 **[Test build #124090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124090/testReport)** for PR 28836 at commit [`77730c0`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644527823 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644527787 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644527823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644527787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644527550 **[Test build #124092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124092/testReport)** for PR 28836 at commit [`154edef`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644527552 **[Test build #124093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124093/testReport)** for PR 28710 at commit [`61e93d0`](https://github.com

[GitHub] [spark] huaxingao commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
huaxingao commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644526286 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644525663 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644525654 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644525654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644478474 **[Test build #124082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124082/testReport)** for PR 28710 at commit [`61e93d0`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644524371 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644524536 **[Test build #124082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124082/testReport)** for PR 28710 at commit [`61e93d0`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644524371 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644524138 **[Test build #124091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124091/testReport)** for PR 28836 at commit [`be81da3`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644522712 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644522712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644522490 **[Test build #124090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124090/testReport)** for PR 28836 at commit [`77730c0`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28831: [WIP][SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed stri

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644519334 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28831: [WIP][SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed string/array

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644519334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28831: [WIP][SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed string/array types

2020-06-15 Thread GitBox
SparkQA commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644519042 **[Test build #124089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124089/testReport)** for PR 28831 at commit [`623aed0`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644516069 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644515694 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] SparkQA removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644508803 **[Test build #124085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124085/testReport)** for PR 28836 at commit [`087f8a5`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644516069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644515692 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644515665 **[Test build #124085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124085/testReport)** for PR 28836 at commit [`087f8a5`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644515692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644515779 **[Test build #124088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124088/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com

[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
yaooqinn commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644514845 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644514283 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644514283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644514044 **[Test build #124087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124087/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644509192 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644509162 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644509162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644509192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
SparkQA commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644508863 **[Test build #124086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124086/testReport)** for PR 28799 at commit [`7969e44`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644508803 **[Test build #124085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124085/testReport)** for PR 28836 at commit [`087f8a5`](https://github.com

[GitHub] [spark] AngersZhuuuu opened a new pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AngersZh opened a new pull request #28836: URL: https://github.com/apache/spark/pull/28836 ### What changes were proposed in this pull request? In a SELECT statement, the QUALIFY clause filters the results of window functions. QUALIFY does with window functions what HAVING doe

[GitHub] [spark] sarutak commented on a change in pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
sarutak commented on a change in pull request #28799: URL: https://github.com/apache/spark/pull/28799#discussion_r440561755 ## File path: core/src/main/resources/org/apache/spark/ui/static/webui-dataTables.css ## @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] liucht-inspur commented on a change in pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
liucht-inspur commented on a change in pull request #28799: URL: https://github.com/apache/spark/pull/28799#discussion_r440560179 ## File path: core/src/main/resources/org/apache/spark/ui/static/webui-dataTables.css ## @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software F

[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
sarutak commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644503270 @liucht-inspur Could you reflect my last comment? This is an automated message from the Apache Git Service. To r

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #28746: URL: https://github.com/apache/spark/pull/28746#discussion_r440555618 ## File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala ## @@ -63,23 +65,34 @@ class LocalSparkCluster( /* Start th

[GitHub] [spark] liucht-inspur commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
liucht-inspur commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644497872 cc @sarutak and @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #28746: URL: https://github.com/apache/spark/pull/28746#discussion_r440554399 ## File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala ## @@ -63,23 +65,34 @@ class LocalSparkCluster( /* Start th

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644497141 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #28746: URL: https://github.com/apache/spark/pull/28746#discussion_r440554399 ## File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala ## @@ -63,23 +65,34 @@ class LocalSparkCluster( /* Start th

[GitHub] [spark] AmplabJenkins commented on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644497141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
SparkQA commented on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644496861 **[Test build #124084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124084/testReport)** for PR 28746 at commit [`a3ed5c1`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644405360 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] dongjoon-hyun commented on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
dongjoon-hyun commented on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644495908 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
yaooqinn commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644490708 Thanks, @dongjoon-hyun, and sorry for the inconvenience. I will keep working on this. This is an automated mes

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440547026 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644488817 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440547026 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite

[GitHub] [spark] AmplabJenkins commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644488817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] maropu commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440546771 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite ex

[GitHub] [spark] SparkQA commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
SparkQA commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644488405 **[Test build #124083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124083/testReport)** for PR 28635 at commit [`0a71849`](https://github.com

[GitHub] [spark] zhli1142015 commented on pull request #28769: [SPARK-31929][WEBUI] Close leveldbiterator when leveldb.close

2020-06-15 Thread GitBox
zhli1142015 commented on pull request #28769: URL: https://github.com/apache/spark/pull/28769#issuecomment-644488465 Kindly ping, @srowen , @gengliangwang , do you have any other comments? Is this ok to merge? This is an aut

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-15 Thread GitBox
dongjoon-hyun edited a comment on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644485683 Sorry, @yaooqinn and @cloud-fan . As I mentioned on @yaooqinn's followup PR , it seems that we need to revert this again. - https://github.com/apache/spark/pull/2

[GitHub] [spark] vanzin commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
vanzin commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644487378 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644486208 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440544556 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite

[GitHub] [spark] AmplabJenkins commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644486208 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-62574 **[Test build #124078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124078/testReport)** for PR 28412 at commit [`3412d29`](https://gi

[GitHub] [spark] maropu commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440544007 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite ex

[GitHub] [spark] dongjoon-hyun commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-15 Thread GitBox
dongjoon-hyun commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644485683 Sorry, @yaooqinn and @cloud-fan . As I mentioned on @yaooqinn , it seems that we need to revert this again. - https://github.com/apache/spark/pull/28835#issuecomment-644

[GitHub] [spark] SparkQA commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644485557 **[Test build #124078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124078/testReport)** for PR 28412 at commit [`3412d29`](https://github.co

[GitHub] [spark] dongjoon-hyun commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
dongjoon-hyun commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644485307 Sorry, @yaooqinn and @cloud-fan . It seems that we had better revert the patch first because it's too flaky. - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%2

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440543326 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644482579 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644482579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644429902 **[Test build #124077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124077/testReport)** for PR 28412 at commit [`025b13c`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644481897 **[Test build #124077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124077/testReport)** for PR 28412 at commit [`025b13c`](https://github.co

[GitHub] [spark] beliefer commented on pull request #28641: [SPARK-31824][CORE][TESTS] DAGSchedulerSuite: Improve and reuse completeShuffleMapStageSuccessfully

2020-06-15 Thread GitBox
beliefer commented on pull request #28641: URL: https://github.com/apache/spark/pull/28641#issuecomment-644481669 @jiangxb1987 @Ngone51 Thanks for your help! This is an automated message from the Apache Git Service. To respon

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440539782 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,22 @@ class HiveDDLSuite } }

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644478729 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644478729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] imback82 commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-15 Thread GitBox
imback82 commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r440536834 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala ## @@ -0,0 +1,112 @@ +/* + * License

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644478474 **[Test build #124082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124082/testReport)** for PR 28710 at commit [`61e93d0`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-644477975 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-644477975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-644373853 **[Test build #124074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124074/testReport)** for PR 28828 at commit [`c496eb5`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
SparkQA commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-644477261 **[Test build #124074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124074/testReport)** for PR 28828 at commit [`c496eb5`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644476807 This is an automated message from the Apache Git Service. To respond to the message, please log on

<    1   2   3   4   5   6   7   8   >