[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654805313 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654805313 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654733951 **[Test build #125204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125204/testReport)** for PR 28969 at commit

[GitHub] [spark] SparkQA commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
SparkQA commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654804380 **[Test build #125204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125204/testReport)** for PR 28969 at commit

[GitHub] [spark] frgomes edited a comment on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes edited a comment on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654801380 @srowen :: #25146 only covers ShortType (smallint) and FloatType (real). ByteType (tinyint) seems to be covered here and only here. However, I'm facing an issue which

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28971: [WIP][SPARK-29292][SPARK-30010][CORE] Let core compile for Scala 2.13

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28971: URL: https://github.com/apache/spark/pull/28971#issuecomment-654802645 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28971: [WIP][SPARK-29292][SPARK-30010][CORE] Let core compile for Scala 2.13

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28971: URL: https://github.com/apache/spark/pull/28971#issuecomment-654802645 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28971: [WIP][SPARK-29292][SPARK-30010][CORE] Let core compile for Scala 2.13

2020-07-07 Thread GitBox
SparkQA commented on pull request #28971: URL: https://github.com/apache/spark/pull/28971#issuecomment-654802030 **[Test build #125213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125213/testReport)** for PR 28971 at commit

[GitHub] [spark] SparkQA commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-07 Thread GitBox
SparkQA commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-654802053 **[Test build #125214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125214/testReport)** for PR 27366 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654801044 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] frgomes edited a comment on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes edited a comment on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654801380 @srowen :: #25146 only covers ShortType (smallint) and FloatType (real). TinyType (tinyint) seems to be covered here and only here. However, I'm facing an issue which

[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654801380 @srowen :: #25146 only covers ShortType (smallint) and FloatType (real). TinyType (tinyint) seems to be covered here and only here. However, I'm facing an issue which makes be

[GitHub] [spark] LantaoJin edited a comment on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

2020-07-07 Thread GitBox
LantaoJin edited a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-654796439 I think it's safe to use database level R/W locks here with thread-unsafe hive-client. Use one object lock is over kill in `HiveExternalCatalog`. You never know how

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654801032 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] LantaoJin edited a comment on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

2020-07-07 Thread GitBox
LantaoJin edited a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-650868622 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654801032 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] LantaoJin edited a comment on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

2020-07-07 Thread GitBox
LantaoJin edited a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-650868622 > Hi, @LantaoJin . Since this PR aims to use multiple locks instead of a global one, could you add some explanation briefly about how this PR is deadlock-free? Thanks.

[GitHub] [spark] LantaoJin edited a comment on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

2020-07-07 Thread GitBox
LantaoJin edited a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-654796439 I think it's safe to use database level R/W locks here with thread-unsafe hive-client. Use one object lock is over kill in `HiveExternalCatalog`. You never know how

[GitHub] [spark] srowen commented on pull request #28971: [WIP][SPARK-29292][SPARK-30010][CORE] Let core compile for Scala 2.13

2020-07-07 Thread GitBox
srowen commented on pull request #28971: URL: https://github.com/apache/spark/pull/28971#issuecomment-654799525 Jenkins retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654798908 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654798897 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654798897 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-654798444 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] frgomes removed a comment on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes removed a comment on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654784071 @srowen : Thanks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654693321 **[Test build #125201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125201/testReport)** for PR 28683 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-654798444 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
SparkQA commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654798062 **[Test build #125201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125201/testReport)** for PR 28683 at commit

[GitHub] [spark] MaxGekk commented on a change in pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-07 Thread GitBox
MaxGekk commented on a change in pull request #27366: URL: https://github.com/apache/spark/pull/27366#discussion_r450800288 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonFilters.scala ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] [spark] LantaoJin commented on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-654796439 I think it's safe to use database level R/W locks here with thread-unsafe hive-client. Use one object lock is over kill in `HiveExternalCatalog`. You never know how slow a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654794498 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654794498 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654793622 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654793610 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654793610 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
SparkQA commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654793884 **[Test build #125212 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125212/testReport)** for PR 28989 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654660996 **[Test build #125189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125189/testReport)** for PR 29021 at commit

[GitHub] [spark] srowen commented on a change in pull request #29018: [SPARK-32202][ML][WIP] tree models auto infer compact integer type

2020-07-07 Thread GitBox
srowen commented on a change in pull request #29018: URL: https://github.com/apache/spark/pull/29018#discussion_r450796336 ## File path: mllib/src/main/scala/org/apache/spark/ml/util/MLUtils.scala ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] SparkQA commented on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
SparkQA commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654792784 **[Test build #125189 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125189/testReport)** for PR 29021 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28924: [SPARK-32091][CORE] Ignore timeout error when remove blocks on the lost executor

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28924: URL: https://github.com/apache/spark/pull/28924#issuecomment-654788834 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28924: [SPARK-32091][CORE] Ignore timeout error when remove blocks on the lost executor

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28924: URL: https://github.com/apache/spark/pull/28924#issuecomment-654788834 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28924: [SPARK-32091][CORE] Ignore timeout error when remove blocks on the lost executor

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28924: URL: https://github.com/apache/spark/pull/28924#issuecomment-654653686 **[Test build #125186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125186/testReport)** for PR 28924 at commit

[GitHub] [spark] SparkQA commented on pull request #28924: [SPARK-32091][CORE] Ignore timeout error when remove blocks on the lost executor

2020-07-07 Thread GitBox
SparkQA commented on pull request #28924: URL: https://github.com/apache/spark/pull/28924#issuecomment-654787187 **[Test build #125186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125186/testReport)** for PR 28924 at commit

[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654784071 @srowen : Thanks This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] frgomes edited a comment on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes edited a comment on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654781496 @dongjoon-hyun @shivsood:: I'm getting this exception below which makes me consider that maybe the fix was not applied??

[GitHub] [spark] srowen commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
srowen commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654783699 https://github.com/apache/spark/pull/25146 ? see above This is an automated message from the Apache Git Service.

[GitHub] [spark] srowen commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
srowen commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654783170 I also prefer 'format' in general, but if this change is the smaller one, let's just do it rather than argue it much more. Someone can bulk change it again to format if desired.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654782537 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654782529 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654781741 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654782529 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654781331 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654680358 **[Test build #125196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125196/testReport)** for PR 28989 at commit

[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654781966 no, since there are subtle but important differences and the respective APIs are easy to find right alongside one another on the Spark docs website. I can

[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654781731 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654781731 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
SparkQA commented on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654781261 **[Test build #125211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125211/testReport)** for PR 27735 at commit

[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654781496 @dongjoon-hyun :: I'm getting this exception below which makes me consider that maybe your fix was not applied. com.microsoft.sqlserver.jdbc.SQLServerException:

[GitHub] [spark] SparkQA commented on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
SparkQA commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654781616 **[Test build #125196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125196/testReport)** for PR 28989 at commit

[GitHub] [spark] SparkQA commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
SparkQA commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654781049 **[Test build #125202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125202/testReport)** for PR 29022 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654697634 **[Test build #125202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125202/testReport)** for PR 29022 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654774144 **[Test build #125211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125211/testReport)** for PR 27735 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654781317 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654781317 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] frgomes removed a comment on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes removed a comment on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654777950 @shivsood Hi, what is the PR for ByteType, please? This is an automated message from the Apache Git

[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654777950 @shivsood Hi, what is the PR for ByteType, please? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-654776105 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-654776097 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-654776097 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-07 Thread GitBox
SparkQA commented on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-654775105 **[Test build #125190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125190/testReport)** for PR 28965 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark versio

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-654661023 **[Test build #125190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125190/testReport)** for PR 28965 at commit

[GitHub] [spark] SparkQA commented on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
SparkQA commented on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-654774144 **[Test build #125211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125211/testReport)** for PR 27735 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27735: [RFC][SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-652806473 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] bart-samwel commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
bart-samwel commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654773542 People don't use those references for non-SQL calls? This is an automated message from the Apache Git

[GitHub] [spark] bart-samwel commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
bart-samwel commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654771295 > Hive 2.3 and PostgreSQL seem to be aliases: > > ```sql > hive> CREATE TABLE test_float1 as SELECT 1.0F, 2.0D; > hive> DESC test_float1; > OK > f

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28912: [SPARK-32057][SQL][test-hive1.2][test-hadoop2.7] ExecuteStatement: cancel and close should not transiently ERROR

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28912: URL: https://github.com/apache/spark/pull/28912#issuecomment-654771100 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28912: [SPARK-32057][SQL][test-hive1.2][test-hadoop2.7] ExecuteStatement: cancel and close should not transiently ERROR

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28912: URL: https://github.com/apache/spark/pull/28912#issuecomment-654771100 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28912: [SPARK-32057][SQL][test-hive1.2][test-hadoop2.7] ExecuteStatement: cancel and close should not transiently ERROR

2020-07-07 Thread GitBox
SparkQA commented on pull request #28912: URL: https://github.com/apache/spark/pull/28912#issuecomment-654770465 **[Test build #125210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125210/testReport)** for PR 28912 at commit

[GitHub] [spark] SparkQA commented on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-07 Thread GitBox
SparkQA commented on pull request #28998: URL: https://github.com/apache/spark/pull/28998#issuecomment-654770478 **[Test build #125209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125209/testReport)** for PR 28998 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654767354 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28998: URL: https://github.com/apache/spark/pull/28998#issuecomment-654767488 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654767345 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654767345 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654759370 **[Test build #125208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125208/testReport)** for PR 28996 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28912: [SPARK-32057][SQL][test-hive1.2][test-hadoop2.7] ExecuteStatement: cancel and close should not transiently ERROR

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28912: URL: https://github.com/apache/spark/pull/28912#issuecomment-654767459 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28998: URL: https://github.com/apache/spark/pull/28998#issuecomment-654767488 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
SparkQA commented on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654767299 **[Test build #125208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125208/testReport)** for PR 28996 at commit

[GitHub] [spark] MaxGekk commented on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-07 Thread GitBox
MaxGekk commented on pull request #28998: URL: https://github.com/apache/spark/pull/28998#issuecomment-654766489 jenkins, retest this, please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654764068 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654764058 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654764058 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654676289 **[Test build #125195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125195/testReport)** for PR 28901 at commit

[GitHub] [spark] SparkQA commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
SparkQA commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654763077 **[Test build #125195 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125195/testReport)** for PR 28901 at commit

[GitHub] [spark] MaxGekk commented on a change in pull request #28999: [SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate

2020-07-07 Thread GitBox
MaxGekk commented on a change in pull request #28999: URL: https://github.com/apache/spark/pull/28999#discussion_r450767742 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -1450,8 +1450,7 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654760146 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654760111 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654760111 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654760146 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
SparkQA commented on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654759370 **[Test build #125208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125208/testReport)** for PR 28996 at commit

[GitHub] [spark] SparkQA commented on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
SparkQA commented on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654759347 **[Test build #125207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125207/testReport)** for PR 29019 at commit

[GitHub] [spark] SparkQA commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
SparkQA commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654759313 **[Test build #125206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125206/testReport)** for PR 29022 at commit

<    6   7   8   9   10   11   12   13   14   >