HyukjinKwon opened a new pull request #29057:
URL: https://github.com/apache/spark/pull/29057
### What changes were proposed in this pull request?
This PR aims to run the Spark tests in Github Actions.
To briefly explain the main idea:
- Reuse `dev/run-tests.py` with
maropu commented on a change in pull request #29055:
URL: https://github.com/apache/spark/pull/29055#discussion_r452243955
##
File path: docs/sql-ref-ansi-compliance.md
##
@@ -193,7 +193,7 @@ Below is a list of all the keywords in Spark SQL.
HyukjinKwon commented on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656149858
I already individually tested, and I am pretty sure it will show a green
light. See also https://github.com/HyukjinKwon/spark/runs/854113657
AmplabJenkins removed a comment on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656148940
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on a change in pull request #29055:
URL: https://github.com/apache/spark/pull/29055#discussion_r452243955
##
File path: docs/sql-ref-ansi-compliance.md
##
@@ -193,7 +193,7 @@ Below is a list of all the keywords in Spark SQL.
tgravescs commented on pull request #28412:
URL: https://github.com/apache/spark/pull/28412#issuecomment-656148922
yeah 10x definitely seems safe as most of the number are more at the 8x
number for zstd. I'm fine with leaving the current logic for the small files,
we can always follow up
AmplabJenkins commented on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656148940
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Ngone51 commented on pull request #28850:
URL: https://github.com/apache/spark/pull/28850#issuecomment-656148667
@srowen Let me help explain a bit more:
`activeThreadSession` is a `InheritableThreadLocal`. Therefore, any child
thread of the Spark main thread could keep a reference
SparkQA removed a comment on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656111930
**[Test build #125471 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125471/testReport)**
for PR 29036 at commit
SparkQA commented on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656147462
**[Test build #125471 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125471/testReport)**
for PR 29036 at commit
AmplabJenkins removed a comment on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656145312
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656145164
**[Test build #125480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125480/testReport)**
for PR 29055 at commit
AmplabJenkins commented on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656145312
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-656144321
Can one of the admins verify this patch?
This is an automated message from the Apache Git
AmplabJenkins commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-656144859
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-656144321
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
GuoPhilipse opened a new pull request #29056:
URL: https://github.com/apache/spark/pull/29056
### What changes were proposed in this pull request?
update sql-ref docs
### Why are the changes needed?
let more users know the sql key words usage
### Does this PR
cloud-fan commented on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656141772
cc @maropu @dongjoon-hyun
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #28971:
URL: https://github.com/apache/spark/pull/28971#issuecomment-656141200
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan opened a new pull request #29055:
URL: https://github.com/apache/spark/pull/29055
### What changes were proposed in this pull request?
This PR improves the test to make sure all the SQL keywords are documented
correctly. It fixes several issues:
1. some keywords
AmplabJenkins commented on pull request #28971:
URL: https://github.com/apache/spark/pull/28971#issuecomment-656141200
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28971:
URL: https://github.com/apache/spark/pull/28971#issuecomment-656140374
**[Test build #125479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125479/testReport)**
for PR 28971 at commit
srowen commented on pull request #28971:
URL: https://github.com/apache/spark/pull/28971#issuecomment-656137859
Jenkins retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #27690:
URL: https://github.com/apache/spark/pull/27690#issuecomment-656136676
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #27690:
URL: https://github.com/apache/spark/pull/27690#issuecomment-656136676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #27690:
URL: https://github.com/apache/spark/pull/27690#issuecomment-656136201
**[Test build #125478 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125478/testReport)**
for PR 27690 at commit
AmplabJenkins removed a comment on pull request #28874:
URL: https://github.com/apache/spark/pull/28874#issuecomment-656132649
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on pull request #27690:
URL: https://github.com/apache/spark/pull/27690#issuecomment-656132974
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins commented on pull request #28874:
URL: https://github.com/apache/spark/pull/28874#issuecomment-656132649
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28874:
URL: https://github.com/apache/spark/pull/28874#issuecomment-656131960
**[Test build #125477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125477/testReport)**
for PR 28874 at commit
srowen commented on pull request #28850:
URL: https://github.com/apache/spark/pull/28850#issuecomment-656131143
Does this help actually clear the reference though?
This is an automated message from the Apache Git Service.
To
srowen commented on pull request #28874:
URL: https://github.com/apache/spark/pull/28874#issuecomment-656129769
Jenkins test this please
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on a change in pull request #28904:
URL: https://github.com/apache/spark/pull/28904#discussion_r452217417
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLog.scala
##
@@ -97,18 +97,13 @@ class
HeartSaVioR commented on a change in pull request #28904:
URL: https://github.com/apache/spark/pull/28904#discussion_r452217417
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLog.scala
##
@@ -97,18 +97,13 @@ class
AmplabJenkins removed a comment on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656124585
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28979:
URL: https://github.com/apache/spark/pull/28979#issuecomment-656124662
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656124585
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28979:
URL: https://github.com/apache/spark/pull/28979#issuecomment-656124662
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28979:
URL: https://github.com/apache/spark/pull/28979#issuecomment-656123915
**[Test build #125476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125476/testReport)**
for PR 28979 at commit
SparkQA commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656123851
**[Test build #125475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125475/testReport)**
for PR 29039 at commit
Ngone51 commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452210183
##
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##
@@ -504,23 +511,92 @@ class UDFSuite extends QueryTest with
Ngone51 commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452208986
##
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##
@@ -4521,9 +4522,10 @@ object functions {
* @since 1.3.0
*/
def
AmplabJenkins commented on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-656120178
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-656120178
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-656119749
**[Test build #125474 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125474/testReport)**
for PR 29054 at commit
HeartSaVioR commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656119403
cc. @dongjoon-hyun @alismess-db
This is an automated message from the Apache Git Service.
To respond to
AngersZh commented on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-656117807
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Ngone51 commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452188555
##
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##
@@ -4521,9 +4522,10 @@ object functions {
* @since 1.3.0
*/
def
AmplabJenkins removed a comment on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656116457
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AngersZh opened a new pull request #29054:
URL: https://github.com/apache/spark/pull/29054
### What changes were proposed in this pull request?
When we create a UDAF function use class extended
`UserDefinedAggregeteFunction`, when we call the function, in support hive
mode, in
AmplabJenkins removed a comment on pull request #29053:
URL: https://github.com/apache/spark/pull/29053#issuecomment-656112505
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656116457
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29053:
URL: https://github.com/apache/spark/pull/29053#issuecomment-656115749
**[Test build #125472 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125472/testReport)**
for PR 29053 at commit
SparkQA commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656115713
**[Test build #125473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125473/testReport)**
for PR 29039 at commit
AmplabJenkins removed a comment on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656112514
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
ulysses-you commented on pull request #29034:
URL: https://github.com/apache/spark/pull/29034#issuecomment-656113225
It's ok to add an attribute `isCached` but it is not enough. 2 reasons:
1. A database can contains hundreds tables, `spark.sql("show
tables").where("isCached=
HeartSaVioR commented on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656112823
cc. @cloud-fan @HyukjinKwon
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656112507
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656112507
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29053:
URL: https://github.com/apache/spark/pull/29053#issuecomment-656112505
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656111930
**[Test build #125471 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125471/testReport)**
for PR 29036 at commit
peter-toth opened a new pull request #29053:
URL: https://github.com/apache/spark/pull/29053
### What changes were proposed in this pull request?
This PR removes the empty child relations of a `Union`.
E.g. the query `SELECT c FROM t UNION ALL SELECT c FROM t WHERE FALSE` has
the
maropu commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452192794
##
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##
@@ -4521,9 +4522,10 @@ object functions {
* @since 1.3.0
*/
def
erikerlandson commented on a change in pull request #28983:
URL: https://github.com/apache/spark/pull/28983#discussion_r452189220
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/udaf.scala
##
@@ -517,3 +519,18 @@ case class ScalaAggregator[IN,
Ngone51 commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452188555
##
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##
@@ -4521,9 +4522,10 @@ object functions {
* @since 1.3.0
*/
def
HeartSaVioR commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656102306
Another summary for next set of builds
> 125405
(https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125405/testReport/)
All suites passed
AmplabJenkins removed a comment on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656098962
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on a change in pull request #27988:
URL: https://github.com/apache/spark/pull/27988#discussion_r452181258
##
File path: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala
##
@@ -1298,18 +1298,18 @@ class SizeBasedCoalescer(val maxSize: Int) extends
AmplabJenkins commented on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656098962
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wankunde commented on pull request #28850:
URL: https://github.com/apache/spark/pull/28850#issuecomment-656098500
@Ngone51 Agree with you, and updated the code.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656098472
**[Test build #125469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125469/testReport)**
for PR 29016 at commit
SparkQA commented on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656098521
**[Test build #125470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125470/testReport)**
for PR 28957 at commit
HyukjinKwon removed a comment on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656003020
retest this please
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656096044
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28977:
URL: https://github.com/apache/spark/pull/28977#issuecomment-656095735
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656096037
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656096037
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656095656
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28977:
URL: https://github.com/apache/spark/pull/28977#issuecomment-656095735
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656004596
**[Test build #125457 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125457/testReport)**
for PR 28957 at commit
AmplabJenkins commented on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656095656
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sarutak commented on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656094949
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please
SparkQA commented on pull request #28977:
URL: https://github.com/apache/spark/pull/28977#issuecomment-656095044
**[Test build #125468 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125468/testReport)**
for PR 28977 at commit
SparkQA commented on pull request #28957:
URL: https://github.com/apache/spark/pull/28957#issuecomment-656095215
**[Test build #125457 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125457/testReport)**
for PR 28957 at commit
AmplabJenkins removed a comment on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656093310
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656093300
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656093300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on pull request #28977:
URL: https://github.com/apache/spark/pull/28977#issuecomment-656092718
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
SparkQA commented on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656092721
**[Test build #125456 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125456/testReport)**
for PR 29016 at commit
SparkQA removed a comment on pull request #29016:
URL: https://github.com/apache/spark/pull/29016#issuecomment-656004530
**[Test build #125456 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125456/testReport)**
for PR 29016 at commit
cloud-fan commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452171846
##
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##
@@ -504,23 +511,92 @@ class UDFSuite extends QueryTest with
cloud-fan commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452171570
##
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##
@@ -4521,9 +4522,10 @@ object functions {
* @since 1.3.0
*/
cloud-fan commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452171203
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
##
@@ -102,6 +105,25 @@ case class ScalaUDF(
}
cloud-fan commented on a change in pull request #28979:
URL: https://github.com/apache/spark/pull/28979#discussion_r452171081
##
File path: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala
##
@@ -173,15 +174,11 @@ class UDFRegistration private[sql]
AmplabJenkins removed a comment on pull request #29051:
URL: https://github.com/apache/spark/pull/29051#issuecomment-656085904
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #29051:
URL: https://github.com/apache/spark/pull/29051#issuecomment-655956165
**[Test build #125446 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125446/testReport)**
for PR 29051 at commit
AmplabJenkins removed a comment on pull request #29051:
URL: https://github.com/apache/spark/pull/29051#issuecomment-656085897
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29051:
URL: https://github.com/apache/spark/pull/29051#issuecomment-656085897
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29051:
URL: https://github.com/apache/spark/pull/29051#issuecomment-656085567
**[Test build #125446 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125446/testReport)**
for PR 29051 at commit
cloud-fan commented on a change in pull request #28924:
URL: https://github.com/apache/spark/pull/28924#discussion_r452164478
##
File path: core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala
##
@@ -177,6 +181,95 @@ class BlockManagerSuite extends
801 - 900 of 1210 matches
Mail list logo