[GitHub] [spark] AmplabJenkins commented on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657736117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] attilapiros opened a new pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
attilapiros opened a new pull request #29090: URL: https://github.com/apache/spark/pull/29090 ### What changes were proposed in this pull request? Fixing inconsistency between Spark memory configs and JVM option by adding the "m" default unit before setting Xmx/Xms JVM options when n

[GitHub] [spark] SparkQA commented on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
SparkQA commented on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657735646 **[Test build #125786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125786/testReport)** for PR 28957 at commit [`f2356c8`](https://github.com

[GitHub] [spark] BryanCutler commented on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
BryanCutler commented on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657733254 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is l

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657729251 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657729251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29084: [SPARK-32220][SQL][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29084: URL: https://github.com/apache/spark/pull/29084#issuecomment-657728417 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29084: [SPARK-32220][SQL][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29084: URL: https://github.com/apache/spark/pull/29084#issuecomment-657728417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
SparkQA commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657728722 **[Test build #125785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125785/testReport)** for PR 28848 at commit [`56f3ae5`](https://github.com

[GitHub] [spark] wypoon commented on a change in pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
wypoon commented on a change in pull request #28848: URL: https://github.com/apache/spark/pull/28848#discussion_r453857178 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1912,12 +1934,8 @@ private[spark] class DAGScheduler( * modify t

[GitHub] [spark] SparkQA removed a comment on pull request #29084: [SPARK-32220][SQL][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29084: URL: https://github.com/apache/spark/pull/29084#issuecomment-657557130 **[Test build #125771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125771/testReport)** for PR 29084 at commit [`d24dbed`](https://gi

[GitHub] [spark] wypoon commented on a change in pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
wypoon commented on a change in pull request #28848: URL: https://github.com/apache/spark/pull/28848#discussion_r453856811 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -170,13 +170,34 @@ private[spark] class DAGScheduler( */ priva

[GitHub] [spark] SparkQA commented on pull request #29084: [SPARK-32220][SQL][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
SparkQA commented on pull request #29084: URL: https://github.com/apache/spark/pull/29084#issuecomment-657727502 **[Test build #125771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125771/testReport)** for PR 29084 at commit [`d24dbed`](https://github.co

[GitHub] [spark] viirya commented on a change in pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
viirya commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r453851262 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -981,6 +982,10 @@ object EliminateSorts extends Ru

[GitHub] [spark] imback82 commented on a change in pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-07-13 Thread GitBox
imback82 commented on a change in pull request #28375: URL: https://github.com/apache/spark/pull/28375#discussion_r453850728 ## File path: sql/core/src/test/resources/sql-tests/inputs/show-tblproperties.sql ## @@ -0,0 +1,26 @@ +-- create a table with properties +CREATE TABLE tb

[GitHub] [spark] imback82 commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
imback82 commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r453846870 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala ## @@ -155,4 +155,31 @@ private[sql] trait LookupCa

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is l

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657718459 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657718459 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29015: [SPARK-32215] Expose a (protected) /workers/kill endpoint on the MasterWebUI

2020-07-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29015: URL: https://github.com/apache/spark/pull/29015#discussion_r453845348 ## File path: core/src/main/scala/org/apache/spark/deploy/master/ui/MasterWebUI.scala ## @@ -49,6 +56,23 @@ class MasterWebUI( "/app/kill",

[GitHub] [spark] SparkQA commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-13 Thread GitBox
SparkQA commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-657717862 **[Test build #125784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125784/testReport)** for PR 28848 at commit [`4301291`](https://github.com

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29015: [SPARK-32215] Expose a (protected) /workers/kill endpoint on the MasterWebUI

2020-07-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29015: URL: https://github.com/apache/spark/pull/29015#discussion_r453843780 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -863,7 +872,36 @@ private[deploy] class Master( true }

[GitHub] [spark] dongjoon-hyun commented on pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
dongjoon-hyun commented on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657713339 Thank you for pinging me, @aokolnychyi . This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28942: [SPARK-32125][UI] Support get taskList by status in Web UI and SHS Rest API

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28942: URL: https://github.com/apache/spark/pull/28942#issuecomment-657711496 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28942: [SPARK-32125][UI] Support get taskList by status in Web UI and SHS Rest API

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28942: URL: https://github.com/apache/spark/pull/28942#issuecomment-657711496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28942: [SPARK-32125][UI] Support get taskList by status in Web UI and SHS Rest API

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #28942: URL: https://github.com/apache/spark/pull/28942#issuecomment-657625932 **[Test build #125777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125777/testReport)** for PR 28942 at commit [`e8e5d6a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28942: [SPARK-32125][UI] Support get taskList by status in Web UI and SHS Rest API

2020-07-13 Thread GitBox
SparkQA commented on pull request #28942: URL: https://github.com/apache/spark/pull/28942#issuecomment-657710836 **[Test build #125777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125777/testReport)** for PR 28942 at commit [`e8e5d6a`](https://github.co

[GitHub] [spark] aokolnychyi commented on pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
aokolnychyi commented on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657697965 cc @dongjoon-hyun @dbtsai @cloud-fan @viirya @gengliangwang for feedback This is an automated message from t

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657694140 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657694129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
SparkQA commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657693900 **[Test build #125776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125776/testReport)** for PR 29088 at commit [`bfab2a5`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657625853 **[Test build #125776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125776/testReport)** for PR 29088 at commit [`bfab2a5`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657693684 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657694129 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657693672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657693672 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] srowen commented on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
srowen commented on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657693660 Weird one: ``` KafkaContinuousSinkSuite: [info] - streaming - write to kafka with topic field *** FAILED *** (31 seconds, 238 milliseconds) [info] The code passed to

[GitHub] [spark] SparkQA removed a comment on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657601013 **[Test build #125774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125774/testReport)** for PR 28957 at commit [`f2356c8`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-07-13 Thread GitBox
SparkQA commented on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-657692680 **[Test build #125774 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125774/testReport)** for PR 28957 at commit [`f2356c8`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28287: [SPARK-31418][SCHEDULER] Request more executors in case of dynamic allocation is enabled and a task becomes unschedulable due t

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28287: URL: https://github.com/apache/spark/pull/28287#issuecomment-657690538 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28287: [SPARK-31418][SCHEDULER] Request more executors in case of dynamic allocation is enabled and a task becomes unschedulable due to spark'

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28287: URL: https://github.com/apache/spark/pull/28287#issuecomment-657690538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28287: [SPARK-31418][SCHEDULER] Request more executors in case of dynamic allocation is enabled and a task becomes unschedulable due to spark's blac

2020-07-13 Thread GitBox
SparkQA commented on pull request #28287: URL: https://github.com/apache/spark/pull/28287#issuecomment-657689826 **[Test build #125783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125783/testReport)** for PR 28287 at commit [`b4c27fb`](https://github.com

[GitHub] [spark] tgravescs commented on pull request #28287: [SPARK-31418][SCHEDULER] Request more executors in case of dynamic allocation is enabled and a task becomes unschedulable due to spark's bl

2020-07-13 Thread GitBox
tgravescs commented on pull request #28287: URL: https://github.com/apache/spark/pull/28287#issuecomment-657686732 test this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] venkata91 commented on pull request #28287: [SPARK-31418][SCHEDULER] Request more executors in case of dynamic allocation is enabled and a task becomes unschedulable due to spark's bl

2020-07-13 Thread GitBox
venkata91 commented on pull request #28287: URL: https://github.com/apache/spark/pull/28287#issuecomment-657682658 > **[Test build #125723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125723/testReport)** for PR 28287 at commit [`b4c27fb`](https://githu

[GitHub] [spark] aokolnychyi commented on pull request #29066: [WIP][SPARK-23889] DataSourceV2: required sorting and clustering for writes

2020-07-13 Thread GitBox
aokolnychyi commented on pull request #29066: URL: https://github.com/apache/spark/pull/29066#issuecomment-657680636 The test failure in `ArrowConvertersSuite` is related to the optimization I did to dedup sorts. I've created [another](https://github.com/apache/spark/pull/29089) PR to addr

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657679907 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28864: URL: https://github.com/apache/spark/pull/28864#issuecomment-657679868 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657679907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28864: URL: https://github.com/apache/spark/pull/28864#issuecomment-657679868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] aokolnychyi commented on a change in pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
aokolnychyi commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r453798200 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala ## @@ -1299,8 +1299,9 @@ class ArrowConvertersS

[GitHub] [spark] aokolnychyi commented on a change in pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
aokolnychyi commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r453798200 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala ## @@ -1299,8 +1299,9 @@ class ArrowConvertersS

[GitHub] [spark] SparkQA commented on pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
SparkQA commented on pull request #28864: URL: https://github.com/apache/spark/pull/28864#issuecomment-657679389 **[Test build #125782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125782/testReport)** for PR 28864 at commit [`9c43172`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
SparkQA commented on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-657679330 **[Test build #125781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125781/testReport)** for PR 29089 at commit [`d71b9e6`](https://github.com

[GitHub] [spark] gatorsmile commented on pull request #28852: [SPARK-30616][SQL] Introduce TTL config option for SQL Metadata Cache

2020-07-13 Thread GitBox
gatorsmile commented on pull request #28852: URL: https://github.com/apache/spark/pull/28852#issuecomment-657678672 cc @cloud-fan @maryannxue @gengliangwang @hvanhovell This is an automated message from the Apache Git Servic

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29032: URL: https://github.com/apache/spark/pull/29032#discussion_r453796305 ## File path: core/src/main/scala/org/apache/spark/scheduler/DecommissionInfo.scala ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] holdenk commented on pull request #28864: [SPARK-32004][ALL] Drop references to slave

2020-07-13 Thread GitBox
holdenk commented on pull request #28864: URL: https://github.com/apache/spark/pull/28864#issuecomment-657677543 Updated to the latest in our primary development branch, sorry for the delay I was out with a new puppy. I'll try and Shepard this in today in between my other tasks.

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29032: URL: https://github.com/apache/spark/pull/29032#discussion_r453796305 ## File path: core/src/main/scala/org/apache/spark/scheduler/DecommissionInfo.scala ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] aokolnychyi commented on a change in pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
aokolnychyi commented on a change in pull request #29089: URL: https://github.com/apache/spark/pull/29089#discussion_r453796416 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -981,6 +982,10 @@ object EliminateSorts exten

[GitHub] [spark] aokolnychyi opened a new pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

2020-07-13 Thread GitBox
aokolnychyi opened a new pull request #29089: URL: https://github.com/apache/spark/pull/29089 ### What changes were proposed in this pull request? This PR removes redundant sorts before repartition, repartitionByExpression and coalesce. ### Why are the changes nee

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29032: URL: https://github.com/apache/spark/pull/29032#discussion_r453794030 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -136,6 +136,8 @@ private[spark] class TaskSchedulerImpl(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28874: [SPARK-32036] Replace references to blacklist/whitelist language with more appropriate terminology, excluding the blacklisting

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28874: URL: https://github.com/apache/spark/pull/28874#issuecomment-657672557 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657671295 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins commented on pull request #28874: [SPARK-32036] Replace references to blacklist/whitelist language with more appropriate terminology, excluding the blacklisting feature.

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28874: URL: https://github.com/apache/spark/pull/28874#issuecomment-657672557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657633896 **[Test build #125779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125779/testReport)** for PR 29078 at commit [`77fb2be`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657671287 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28874: [SPARK-32036] Replace references to blacklist/whitelist language with more appropriate terminology, excluding the blacklisting feature.

2020-07-13 Thread GitBox
SparkQA commented on pull request #28874: URL: https://github.com/apache/spark/pull/28874#issuecomment-657672039 **[Test build #125780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125780/testReport)** for PR 28874 at commit [`5cd7d81`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657671287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
SparkQA commented on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657671011 **[Test build #125779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125779/testReport)** for PR 29078 at commit [`77fb2be`](https://github.co

[GitHub] [spark] xkrogen commented on pull request #28874: [SPARK-32036] Replace references to blacklist/whitelist language with more appropriate terminology, excluding the blacklisting feature.

2020-07-13 Thread GitBox
xkrogen commented on pull request #28874: URL: https://github.com/apache/spark/pull/28874#issuecomment-657669096 Thanks a lot for the new eyes @srowen and @tgravescs ! I've just pushed up a resolution to the conflict. This i

[GitHub] [spark] cloud-fan commented on a change in pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-13 Thread GitBox
cloud-fan commented on a change in pull request #28996: URL: https://github.com/apache/spark/pull/28996#discussion_r453777434 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2048,19 +2088,34 @@ class Dataset[T] private[sql]( // Builds a proj

[GitHub] [spark] c21 commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-07-13 Thread GitBox
c21 commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r453775008 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala ## @@ -0,0 +1,132 @@ +/* + * Licensed to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-657637938 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] sarutak commented on a change in pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
sarutak commented on a change in pull request #29002: URL: https://github.com/apache/spark/pull/29002#discussion_r453749208 ## File path: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala ## @@ -402,6 +403,77 @@ class ExecutorSuite extends SparkFunSuite ass

[GitHub] [spark] sarutak commented on a change in pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
sarutak commented on a change in pull request #29002: URL: https://github.com/apache/spark/pull/29002#discussion_r453748409 ## File path: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala ## @@ -402,6 +403,77 @@ class ExecutorSuite extends SparkFunSuite ass

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-657637938 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-657480292 **[Test build #125768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125768/testReport)** for PR 29085 at commit [`dfcec3c`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-13 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-657636953 **[Test build #125768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125768/testReport)** for PR 29085 at commit [`dfcec3c`](https://github.co

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #28996: URL: https://github.com/apache/spark/pull/28996#discussion_r453744272 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2048,19 +2088,34 @@ class Dataset[T] private[sql]( // Builds a

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #28996: URL: https://github.com/apache/spark/pull/28996#discussion_r453744272 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2048,19 +2088,34 @@ class Dataset[T] private[sql]( // Builds a

[GitHub] [spark] viirya commented on a change in pull request #29061: [SPARK-32258][SQL] NormalizeFloatingNumbers directly normalizes IF/CaseWhen/Coalesce child expressions

2020-07-13 Thread GitBox
viirya commented on a change in pull request #29061: URL: https://github.com/apache/spark/pull/29061#discussion_r453744846 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala ## @@ -116,6 +116,15 @@ object NormalizeF

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657634504 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r453744110 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -911,13 +913,33 @@ private[spark] class TaskSchedulerImp

[GitHub] [spark] viirya commented on a change in pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-13 Thread GitBox
viirya commented on a change in pull request #28996: URL: https://github.com/apache/spark/pull/28996#discussion_r453744066 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2048,19 +2088,34 @@ class Dataset[T] private[sql]( // Builds a project

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #28996: URL: https://github.com/apache/spark/pull/28996#discussion_r453744272 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2048,19 +2088,34 @@ class Dataset[T] private[sql]( // Builds a

[GitHub] [spark] AmplabJenkins commented on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657634504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
SparkQA commented on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657633896 **[Test build #125779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125779/testReport)** for PR 29078 at commit [`77fb2be`](https://github.com

[GitHub] [spark] sarutak commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-13 Thread GitBox
sarutak commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-657633060 @Ngone51 Thanks for the feedback. I'll fix them. This is an automated message from the Apache Git Service. To re

[GitHub] [spark] HyukjinKwon commented on pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
HyukjinKwon commented on pull request #29086: URL: https://github.com/apache/spark/pull/29086#issuecomment-657631863 Thank you @dongjoon-hyun! This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657347836 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r453738154 ## File path: core/src/main/scala/org/apache/spark/scheduler/ExecutorLossReason.scala ## @@ -54,10 +54,13 @@ private [spark] object LossReasonPendi

[GitHub] [spark] dongjoon-hyun commented on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

2020-07-13 Thread GitBox
dongjoon-hyun commented on pull request #29078: URL: https://github.com/apache/spark/pull/29078#issuecomment-657630980 Retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-13 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657629870 **[Test build #125778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125778/testReport)** for PR 28939 at commit [`21720ac`](https://github.com

[GitHub] [spark] dongjoon-hyun closed pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
dongjoon-hyun closed pull request #29086: URL: https://github.com/apache/spark/pull/29086 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r453736088 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] = "

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r453735521 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] = "

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r453735521 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] = "

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r453732802 ## File path: .github/workflows/master.yml ## @@ -29,7 +29,7 @@ jobs: modules: - |- core, unsafe, kvstore, avro, -

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r453732802 ## File path: .github/workflows/master.yml ## @@ -29,7 +29,7 @@ jobs: modules: - |- core, unsafe, kvstore, avro, -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657626614 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28942: [SPARK-32125][UI] Support get taskList by status in Web UI and SHS Rest API

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28942: URL: https://github.com/apache/spark/pull/28942#issuecomment-657626558 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657622318 This is an automated message from the Apache Git Service. To respond to the message, please log on

<    1   2   3   4   5   6   7   >