AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459189586
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala
##
@@ -1063,6 +1063,9 @@ private[hive] trait HiveInspectors {
maropu commented on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-662794540
Looks almost okay now, so could you split this PR into pieces? I think its
somewhat big fro reviews. For example;
1. More refactoring PR for `HiveScriptTransformationExec`
maropu commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459188140
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala
##
@@ -1063,6 +1063,9 @@ private[hive] trait HiveInspectors {
maropu commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459188225
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
##
@@ -87,17 +181,72 @@ trait
Ngone51 commented on a change in pull request #29166:
URL: https://github.com/apache/spark/pull/29166#discussion_r459187090
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1237,20 +1250,79 @@ class Analyzer(
if
maropu commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459186587
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
##
@@ -87,17 +181,72 @@ trait
viirya commented on a change in pull request #29166:
URL: https://github.com/apache/spark/pull/29166#discussion_r459186345
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1237,20 +1250,79 @@ class Analyzer(
if
AmplabJenkins removed a comment on pull request #29166:
URL: https://github.com/apache/spark/pull/29166#issuecomment-662791663
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662791661
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29166:
URL: https://github.com/apache/spark/pull/29166#issuecomment-662791663
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662791661
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29166:
URL: https://github.com/apache/spark/pull/29166#issuecomment-662791379
**[Test build #126375 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126375/testReport)**
for PR 29166 at commit
SparkQA commented on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662791349
**[Test build #126374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126374/testReport)**
for PR 29192 at commit
Ngone51 commented on a change in pull request #29166:
URL: https://github.com/apache/spark/pull/29166#discussion_r459185548
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1237,20 +1250,79 @@ class Analyzer(
if
Ngone51 commented on a change in pull request #29166:
URL: https://github.com/apache/spark/pull/29166#discussion_r459185098
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1237,20 +1250,79 @@ class Analyzer(
if
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r459184480
##
File path: dev/requirements.txt
##
@@ -3,3 +3,4 @@ jira==1.0.3
PyGithub==1.26.0
Unidecode==0.04.19
sphinx
+pydata_sphinx_theme
Review comment:
maropu edited a comment on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662779093
`bpchar` is internally used in postgresql [1][2], but users can use it in
DDL;
- [1] https://www.postgresql.org/docs/current/datatype-character.html
- [2]
AmplabJenkins removed a comment on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662557759
Can one of the admins verify this patch?
This is an automated message from the Apache Git
holdenk commented on pull request #29032:
URL: https://github.com/apache/spark/pull/29032#issuecomment-662790280
Cool I’ll try merge this after dinner, thanks everyone for working on and
reviewing this
This is an
AmplabJenkins removed a comment on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-662790096
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662790228
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-662790096
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r459184480
##
File path: dev/requirements.txt
##
@@ -3,3 +3,4 @@ jira==1.0.3
PyGithub==1.26.0
Unidecode==0.04.19
sphinx
+pydata_sphinx_theme
Review comment:
SparkQA commented on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-662789794
**[Test build #126373 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126373/testReport)**
for PR 29085 at commit
agrawaldevesh commented on pull request #29032:
URL: https://github.com/apache/spark/pull/29032#issuecomment-662789786
@holdenk... this is ready to go in. Thanks !
This is an automated message from the Apache Git Service.
To
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662789431
> I wonder if there is some non-hacky way to organize functions into logical
groups, similarly to what ScalaDoc does.
I tried hard but looked difficult to do. I will
AmplabJenkins commented on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-662788634
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-662788634
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459182797
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##
@@ -1031,4 +1031,96 @@ class
SparkQA commented on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-662788394
**[Test build #126372 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126372/testReport)**
for PR 29085 at commit
AngersZh commented on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-662787840
All done
This is an automated message from the Apache Git Service.
To respond to the message, please log
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459182038
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationExec.scala
##
@@ -54,87 +52,110 @@ case class
AmplabJenkins removed a comment on pull request #29194:
URL: https://github.com/apache/spark/pull/29194#issuecomment-662787285
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29194:
URL: https://github.com/apache/spark/pull/29194#issuecomment-662787285
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29194:
URL: https://github.com/apache/spark/pull/29194#issuecomment-662702681
**[Test build #126361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126361/testReport)**
for PR 29194 at commit
SparkQA commented on pull request #29194:
URL: https://github.com/apache/spark/pull/29194#issuecomment-662786999
**[Test build #126361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126361/testReport)**
for PR 29194 at commit
AmplabJenkins removed a comment on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662785780
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662785780
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Ngone51 commented on a change in pull request #29166:
URL: https://github.com/apache/spark/pull/29166#discussion_r459179732
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1237,20 +1250,79 @@ class Analyzer(
if
SparkQA commented on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662785553
**[Test build #126371 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126371/testReport)**
for PR 29196 at commit
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459178460
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##
@@ -532,6 +532,21 @@ abstract class SparkStrategies
maropu edited a comment on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662784282
btw, thanks for your first contribution, @kujon !
This is an automated message from the Apache Git
maropu commented on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662784282
btw, thanks for your contribution, @kujon !
This is an automated message from the Apache Git Service.
To respond
AmplabJenkins removed a comment on pull request #29159:
URL: https://github.com/apache/spark/pull/29159#issuecomment-662782378
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29159:
URL: https://github.com/apache/spark/pull/29159#issuecomment-662782378
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29159:
URL: https://github.com/apache/spark/pull/29159#issuecomment-662767092
**[Test build #126367 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126367/testReport)**
for PR 29159 at commit
SparkQA commented on pull request #29159:
URL: https://github.com/apache/spark/pull/29159#issuecomment-662782139
**[Test build #126367 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126367/testReport)**
for PR 29159 at commit
AmplabJenkins removed a comment on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662781417
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459175410
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala
##
@@ -1063,6 +1063,9 @@ private[hive] trait HiveInspectors {
AmplabJenkins commented on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662781414
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662781211
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662780801
**[Test build #126370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126370/testReport)**
for PR 29193 at commit
AmplabJenkins removed a comment on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662781414
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662781403
**[Test build #126370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126370/testReport)**
for PR 29193 at commit
SparkQA removed a comment on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662780783
**[Test build #126369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126369/testReport)**
for PR 29196 at commit
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459175002
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkScriptTransformationSuite.scala
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to
AmplabJenkins removed a comment on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662781049
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662781036
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662781205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459174831
##
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala
##
@@ -206,75 +169,147 @@ class
SparkQA commented on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662781194
**[Test build #126369 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126369/testReport)**
for PR 29196 at commit
AmplabJenkins commented on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662781036
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459174654
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationExec.scala
##
@@ -33,14 +32,13 @@ import
AmplabJenkins commented on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662781049
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29196:
URL: https://github.com/apache/spark/pull/29196#issuecomment-662780783
**[Test build #126369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126369/testReport)**
for PR 29196 at commit
SparkQA commented on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662780801
**[Test build #126370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126370/testReport)**
for PR 29193 at commit
srowen commented on a change in pull request #29196:
URL: https://github.com/apache/spark/pull/29196#discussion_r459174022
##
File path:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
##
@@ -309,14 +311,18 @@ class HistoryServerSuite extends
wypoon commented on pull request #29193:
URL: https://github.com/apache/spark/pull/29193#issuecomment-662780377
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
srowen opened a new pull request #29196:
URL: https://github.com/apache/spark/pull/29196
### What changes were proposed in this pull request?
Updates to scalatest 3.2.0. Though it looks large, it is 99% changes to the
new location of scalatest classes.
### Why are the changes
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459173720
##
File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql
##
@@ -0,0 +1,146 @@
+-- Test data.
+CREATE OR REPLACE TEMPORARY VIEW t AS
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459173424
##
File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql
##
@@ -0,0 +1,146 @@
+-- Test data.
+CREATE OR REPLACE TEMPORARY VIEW t AS
maropu commented on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662779093
`bpchar` is internally used in postgresql
(https://www.postgresql.org/docs/current/typeconv-query.html), but users can
use it in DDL;
```
postgres=# create table t (v
AngersZh commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r459172282
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##
@@ -744,8 +744,29 @@ class AstBuilder(conf:
AmplabJenkins removed a comment on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-662778384
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-662778384
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on pull request #29192:
URL: https://github.com/apache/spark/pull/29192#issuecomment-662778415
Could you add tests in `PostgresIntegrationSuite` then check if the test can
pass on your local env? (Note: our testing framework, Jenkins, does not run it).
SparkQA removed a comment on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-662677438
**[Test build #126359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126359/testReport)**
for PR 29067 at commit
SparkQA commented on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-662778108
**[Test build #126359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126359/testReport)**
for PR 29067 at commit
maropu commented on a change in pull request #29191:
URL: https://github.com/apache/spark/pull/29191#discussion_r459169944
##
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##
@@ -288,7 +288,7 @@ final class DataFrameWriter[T] private[sql](ds:
maropu closed pull request #29189:
URL: https://github.com/apache/spark/pull/29189
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
maropu commented on pull request #29189:
URL: https://github.com/apache/spark/pull/29189#issuecomment-662773741
Thanks! Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
maropu commented on a change in pull request #29189:
URL: https://github.com/apache/spark/pull/29189#discussion_r459166990
##
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##
@@ -218,9 +218,7 @@
SparkQA commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662772347
**[Test build #126368 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126368/testReport)**
for PR 29056 at commit
AmplabJenkins commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662772419
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662772419
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662770223
**[Test build #126368 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126368/testReport)**
for PR 29056 at commit
AmplabJenkins commented on pull request #29168:
URL: https://github.com/apache/spark/pull/29168#issuecomment-662771853
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29168:
URL: https://github.com/apache/spark/pull/29168#issuecomment-662771853
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29168:
URL: https://github.com/apache/spark/pull/29168#issuecomment-662662506
**[Test build #126356 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126356/testReport)**
for PR 29168 at commit
SparkQA commented on pull request #29168:
URL: https://github.com/apache/spark/pull/29168#issuecomment-662771464
**[Test build #126356 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126356/testReport)**
for PR 29168 at commit
SparkQA commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662770223
**[Test build #126368 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126368/testReport)**
for PR 29056 at commit
dongjoon-hyun commented on pull request #29062:
URL: https://github.com/apache/spark/pull/29062#issuecomment-662769652
cc @peter-toth , too.
This is an automated message from the Apache Git Service.
To respond to the
maropu commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662769125
Note: If nobody has comments, this is just a doc improvement, so I will
merge in a few days.
This is an
AmplabJenkins removed a comment on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662768893
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662768893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-656144859
Can one of the admins verify this patch?
This is an automated message from the Apache Git
maropu commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-662768621
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on pull request #29152:
URL: https://github.com/apache/spark/pull/29152#issuecomment-662767785
Looks okay to me, but (this is trivial though) we might need to choose
either action?;
- jira type: `improvement` -> `bug`, then backport this to
`branch-3.0`/`branch-2.4`,
AmplabJenkins removed a comment on pull request #29159:
URL: https://github.com/apache/spark/pull/29159#issuecomment-662767378
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29159:
URL: https://github.com/apache/spark/pull/29159#issuecomment-662767378
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
101 - 200 of 1009 matches
Mail list logo
