[GitHub] [spark] AmplabJenkins removed a comment on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662767143 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662767143 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662767092 **[Test build #126367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126367/testReport)** for PR 29159 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662721182 **[Test build #126363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126363/testReport)** for PR 29032 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662766767 The demo website looks nice although I didn't generate manually this PR~ This is an automated message

[GitHub] [spark] huaxingao commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
huaxingao commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662766916 Jenkins, please make pip packaging tests pass! retest this please This is an automated message from the

[GitHub] [spark] viirya edited a comment on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-22 Thread GitBox
viirya edited a comment on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-662766465 > I'd treat it as not-working if it ONLY works with in-memory catalog. In production no one use it. The official release of Spark always include the hive dependencies.

[GitHub] [spark] SparkQA commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
SparkQA commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662766764 **[Test build #126363 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126363/testReport)** for PR 29032 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29188: URL: https://github.com/apache/spark/pull/29188#discussion_r459159755 ## File path: dev/requirements.txt ## @@ -3,3 +3,4 @@ jira==1.0.3 PyGithub==1.26.0 Unidecode==0.04.19 sphinx +pydata_sphinx_theme Review

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29188: URL: https://github.com/apache/spark/pull/29188#discussion_r459159613 ## File path: dev/requirements.txt ## @@ -3,3 +3,4 @@ jira==1.0.3 PyGithub==1.26.0 Unidecode==0.04.19 sphinx +pydata_sphinx_theme Review

[GitHub] [spark] viirya commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-22 Thread GitBox
viirya commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-662766465 > I'd treat it as not-working if it ONLY works with in-memory catalog. In production no one use it. The official release of Spark always include the hive dependencies. Oh

[GitHub] [spark] dongjoon-hyun commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662764624 Hi, @cloud-fan and @HyukjinKwon . Sorry, but could you review this follow-up, please? This is an

[GitHub] [spark] github-actions[bot] closed pull request #28183: [SPARK-29791][CORE][SCHEDULER]add an implemention for issue SPARK-29791.

2020-07-22 Thread GitBox
github-actions[bot] closed pull request #28183: URL: https://github.com/apache/spark/pull/28183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] github-actions[bot] commented on pull request #28133: [SPARK-31156][SQL] DataFrameStatFunctions API to be consistent with respect to Column type

2020-07-22 Thread GitBox
github-actions[bot] commented on pull request #28133: URL: https://github.com/apache/spark/pull/28133#issuecomment-662764249 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] ulysses-you commented on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-22 Thread GitBox
ulysses-you commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-662763147 @cloud-fan Thanks for merge ! Thanks all ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] zsxwing commented on a change in pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

2020-07-22 Thread GitBox
zsxwing commented on a change in pull request #29187: URL: https://github.com/apache/spark/pull/29187#discussion_r459155483 ## File path: core/src/test/scala/org/apache/spark/util/UninterruptibleThreadRunnerSuite.scala ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [spark] ulysses-you commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-22 Thread GitBox
ulysses-you commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-662762754 How about give user a config that `convertNullAsString`, then we convert `null` as `StringType` if the config is enable ? In my practice, most time `select null as c`

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662761539 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662761539 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662761176 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662761168 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662629194 **[Test build #126355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126355/testReport)** for PR 29107 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662761168 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662747548 **[Test build #126366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126366/testReport)** for PR 29159 at commit

[GitHub] [spark] SparkQA commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
SparkQA commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662761103 **[Test build #126355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126355/testReport)** for PR 29107 at commit

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662760895 **[Test build #126366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126366/testReport)** for PR 29159 at commit

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r459136940 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -744,8 +744,29 @@ class AstBuilder(conf: SQLConf)

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r458936940 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ## @@ -288,7 +288,7 @@ final class DataFrameWriter[T]

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662755299 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662755299 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
SparkQA commented on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662754876 **[Test build #126360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126360/testReport)** for PR 29190 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662692182 **[Test build #126360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126360/testReport)** for PR 29190 at commit

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662747548 **[Test build #126366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126366/testReport)** for PR 29159 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662745749 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662745749 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662744889 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662744884 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] viirya commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
viirya commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662745390 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662729224 **[Test build #126365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126365/testReport)** for PR 29159 at commit

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662744610 **[Test build #126365 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126365/testReport)** for PR 29159 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662744884 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HeartSaVioR commented on a change in pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

2020-07-22 Thread GitBox
HeartSaVioR commented on a change in pull request #29187: URL: https://github.com/apache/spark/pull/29187#discussion_r459128784 ## File path: core/src/main/scala/org/apache/spark/util/UninterruptibleThreadRunner.scala ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-662740082 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-662740082 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-662666209 **[Test build #126358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126358/testReport)** for PR 29014 at commit

[GitHub] [spark] SparkQA commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-22 Thread GitBox
SparkQA commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-662739581 **[Test build #126358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126358/testReport)** for PR 29014 at commit

[GitHub] [spark] TJX2014 closed pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

2020-07-22 Thread GitBox
TJX2014 closed pull request #29156: URL: https://github.com/apache/spark/pull/29156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662735794 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662726695 **[Test build #126364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126364/testReport)** for PR 29195 at commit

[GitHub] [spark] SparkQA commented on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
SparkQA commented on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662735688 **[Test build #126364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126364/testReport)** for PR 29195 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662735794 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] TJX2014 commented on a change in pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

2020-07-22 Thread GitBox
TJX2014 commented on a change in pull request #29156: URL: https://github.com/apache/spark/pull/29156#discussion_r459126932 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala ## @@ -165,6 +165,24 @@ object ResolveHints {

[GitHub] [spark] huaxingao commented on a change in pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
huaxingao commented on a change in pull request #29159: URL: https://github.com/apache/spark/pull/29159#discussion_r459120300 ## File path: python/pyspark/ml/tuning.py ## @@ -545,6 +551,10 @@ class _TrainValidationSplitParams(_ValidatorParams): trainRatio =

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662729695 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662729695 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662729035 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662729224 **[Test build #126365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126365/testReport)** for PR 29159 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662729028 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662729028 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662706241 **[Test build #126362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126362/testReport)** for PR 29159 at commit

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662728711 **[Test build #126362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126362/testReport)** for PR 29159 at commit

[GitHub] [spark] viirya commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
viirya commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662728840 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] viirya commented on a change in pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
viirya commented on a change in pull request #29159: URL: https://github.com/apache/spark/pull/29159#discussion_r459118660 ## File path: python/pyspark/ml/tuning.py ## @@ -545,6 +551,10 @@ class _TrainValidationSplitParams(_ValidatorParams): trainRatio =

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662727124 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662727124 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
SparkQA commented on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662726695 **[Test build #126364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126364/testReport)** for PR 29195 at commit

[GitHub] [spark] ueshin commented on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
ueshin commented on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662725027 Also cc @nvander1 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662724848 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] ueshin opened a new pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
ueshin opened a new pull request #29195: URL: https://github.com/apache/spark/pull/29195 ### What changes were proposed in this pull request? This is a follow-up of #29138 which added overload `slice` function to accept `Column` for `start` and `length` in Scala. This PR is

[GitHub] [spark] AmplabJenkins commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662724848 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662565267 **[Test build #126350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126350/testReport)** for PR 29191 at commit

[GitHub] [spark] SparkQA commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
SparkQA commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662724223 **[Test build #126350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126350/testReport)** for PR 29191 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662721626 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662721626 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
SparkQA commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662721182 **[Test build #126363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126363/testReport)** for PR 29032 at commit

[GitHub] [spark] huaxingao commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
huaxingao commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662720777 Looks really nice! It's more organized this way. This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-662720624 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] agrawaldevesh commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
agrawaldevesh commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662720666 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-662720624 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662720080 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-662548365 **[Test build #126347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126347/testReport)** for PR 29067 at commit

[GitHub] [spark] jkleckner commented on pull request #28423: [SPARK-24266][k8s] Restart the watcher when we receive a version changed from k8s

2020-07-22 Thread GitBox
jkleckner commented on pull request #28423: URL: https://github.com/apache/spark/pull/28423#issuecomment-662720174 I took the commits from master and made a partial attempt to rebase this onto branch-2.4 [1]. However, the k8s api has evolved from 2.4 quite a bit so the watchOrStop

[GitHub] [spark] AmplabJenkins commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662720080 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662557134 **[Test build #126348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126348/testReport)** for PR 29107 at commit

[GitHub] [spark] SparkQA commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
SparkQA commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662719424 **[Test build #126348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126348/testReport)** for PR 29107 at commit

[GitHub] [spark] SparkQA commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-22 Thread GitBox
SparkQA commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-662719849 **[Test build #126347 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126347/testReport)** for PR 29067 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29193: [SPARK-32003][CORE][3.0] When external shuffle service is used, unregister outputs for executor on fetch failure after executor

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29193: URL: https://github.com/apache/spark/pull/29193#issuecomment-662713218 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29193: [SPARK-32003][CORE][3.0] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29193: URL: https://github.com/apache/spark/pull/29193#issuecomment-662713210 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29193: [SPARK-32003][CORE][3.0] When external shuffle service is used, unregister outputs for executor on fetch failure after executor

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29193: URL: https://github.com/apache/spark/pull/29193#issuecomment-662713210 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29193: [SPARK-32003][CORE][3.0] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lo

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29193: URL: https://github.com/apache/spark/pull/29193#issuecomment-662629128 **[Test build #126354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126354/testReport)** for PR 29193 at commit

[GitHub] [spark] SparkQA commented on pull request #29193: [SPARK-32003][CORE][3.0] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
SparkQA commented on pull request #29193: URL: https://github.com/apache/spark/pull/29193#issuecomment-662712498 **[Test build #126354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126354/testReport)** for PR 29193 at commit

[GitHub] [spark] sap1ens commented on pull request #29194: [SPARK-30616][SQL][FOLLOW-UP] Use only config key name in the config doc.

2020-07-22 Thread GitBox
sap1ens commented on pull request #29194: URL: https://github.com/apache/spark/pull/29194#issuecomment-662709126 Ah, thanks so much for fixing this  This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662708442 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662708442 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662531198 **[Test build #126345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126345/testReport)** for PR 29085 at commit

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662707640 **[Test build #126345 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126345/testReport)** for PR 29085 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662706845 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662706845 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662706241 **[Test build #126362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126362/testReport)** for PR 29159 at commit

[GitHub] [spark] c21 commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-22 Thread GitBox
c21 commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-662704525 @bart-samwel - just to bring us in the same page. Current spark scala/java implementation for hash join (broadcast hash join and shuffled hash join) has following

<    1   2   3   4   5   6   7   8   9   10   >