SparkQA commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669718763
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/31749/
cloud-fan closed pull request #29357:
URL: https://github.com/apache/spark/pull/29357
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #29357:
URL: https://github.com/apache/spark/pull/29357#issuecomment-669718683
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503
I will update failure list to JIRA later
This is an automated message from the Apache Git Service.
To
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503
I will update failure list to JIRA after this pr later
This is an automated message from the Apache
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503
I will update failure list to JIRA later after this pr
This is an automated message from the Apache
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401
cc @srowen from the numbers alone, this pr fixed about 70% failed cases of
`sql/catalyst` module, do we accept partial fixed and fix the remaining cases
in other
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401
cc @srowen from the numbers alone, this pr fixed about 70% failed cases of
`sql/catalyst` module, do we accept partial fixed?
cloud-fan commented on a change in pull request #29357:
URL: https://github.com/apache/spark/pull/29357#discussion_r466159423
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala
##
@@ -165,7 +165,7 @@
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401
cc @srowen from the numbers alone, this pr fixed about 70% failed cases of
`sql/catalyst` module now, do we accept partial fixed?
maropu commented on pull request #29355:
URL: https://github.com/apache/spark/pull/29355#issuecomment-669714210
> Here is the link for HIVE Built-in Table-Generating Functions (UDTF).
Should we also include json_tuple and parse_url?
yea, I think we should.
maropu commented on a change in pull request #29355:
URL: https://github.com/apache/spark/pull/29355#discussion_r466158424
##
File path: docs/sql-ref-syntax-qry-select-tvf.md
##
@@ -21,25 +21,7 @@ license: |
### Description
-A table-valued function (TVF) is a function
cloud-fan closed pull request #29332:
URL: https://github.com/apache/spark/pull/29332
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-669713324
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan commented on pull request #29125:
URL: https://github.com/apache/spark/pull/29125#issuecomment-669712680
I don't agree to revert the UnsafeRow bug fix. As I said, `UnsafeRow` is
very fundamental and we can't tolerant any bugs.
I agree that the sum decimal bug becomes more
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240
> Thanks. You don't need to fix everything in one shot. Please group the
failures and fix the one you think this is related to many others. You can
proceed by suite
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240
> Thanks. You don't need to fix everything in one shot. Please group the
failures and fix the one you think this is related to many others. You can
proceed by suite
maropu commented on a change in pull request #28185:
URL: https://github.com/apache/spark/pull/28185#discussion_r466155817
##
File path: docs/sql-ref-syntax-qry-select-tvf.md
##
@@ -0,0 +1,131 @@
+---
+layout: global
+title: Table-valued Functions (TVF)
+displayTitle:
maropu commented on a change in pull request #28185:
URL: https://github.com/apache/spark/pull/28185#discussion_r466155817
##
File path: docs/sql-ref-syntax-qry-select-tvf.md
##
@@ -0,0 +1,131 @@
+---
+layout: global
+title: Table-valued Functions (TVF)
+displayTitle:
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240
> Thanks. You don't need to fix everything in one shot. Please group the
failures and fix the one you think this is related to many others. You can
proceed by suite by
maropu commented on a change in pull request #29349:
URL: https://github.com/apache/spark/pull/29349#discussion_r466151698
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala
##
@@ -418,8 +418,11 @@ package object dsl {
def
SparkQA removed a comment on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669697121
**[Test build #127127 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127127/testReport)**
for PR 29368 at commit
AmplabJenkins removed a comment on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669700817
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669700817
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669700347
**[Test build #127127 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127127/testReport)**
for PR 29368 at commit
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669699584
Can one of the admins verify this patch?
This is an automated message from the Apache Git
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669699869
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669699584
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #29369:
URL: https://github.com/apache/spark/pull/29369#issuecomment-669698899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #29369:
URL: https://github.com/apache/spark/pull/29369#issuecomment-669672653
**[Test build #127125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127125/testReport)**
for PR 29369 at commit
LuciferYang opened a new pull request #29370:
URL: https://github.com/apache/spark/pull/29370
### What changes were proposed in this pull request?
The purpose of this pr is to partial resolve
[SPARK-32526](https://issues.apache.org/jira/browse/SPARK-32526), fix
AmplabJenkins removed a comment on pull request #29369:
URL: https://github.com/apache/spark/pull/29369#issuecomment-669698894
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29369:
URL: https://github.com/apache/spark/pull/29369#issuecomment-669698894
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29369:
URL: https://github.com/apache/spark/pull/29369#issuecomment-669698778
**[Test build #127125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127125/testReport)**
for PR 29369 at commit
SparkQA commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669697121
**[Test build #127127 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127127/testReport)**
for PR 29368 at commit
maropu commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669695780
> Personally I'd drop the "getting" and I'd drop "External Shuffle Service"
(I think non-expiremental dynamic resource allocation with or without external
shuffle is good
AmplabJenkins removed a comment on pull request #29364:
URL: https://github.com/apache/spark/pull/29364#issuecomment-669694473
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gengliangwang commented on a change in pull request #29357:
URL: https://github.com/apache/spark/pull/29357#discussion_r466147119
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala
##
@@ -165,7 +165,7 @@
AmplabJenkins commented on pull request #29364:
URL: https://github.com/apache/spark/pull/29364#issuecomment-669694473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29364:
URL: https://github.com/apache/spark/pull/29364#issuecomment-669620206
**[Test build #127115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127115/testReport)**
for PR 29364 at commit
SparkQA commented on pull request #29364:
URL: https://github.com/apache/spark/pull/29364#issuecomment-669693710
**[Test build #127115 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127115/testReport)**
for PR 29364 at commit
cloud-fan commented on pull request #29363:
URL: https://github.com/apache/spark/pull/29363#issuecomment-669692126
The fix LGTM. This PR is kind of an improvement to skip the unnecessary
table conversion, but also fixes the serde class loading issues. Agree with
@dongjoon-hyun and let's
msamirkhan commented on a change in pull request #29353:
URL: https://github.com/apache/spark/pull/29353#discussion_r466144939
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala
##
@@ -73,135 +75,157 @@ class
maropu commented on a change in pull request #29356:
URL: https://github.com/apache/spark/pull/29356#discussion_r466143036
##
File path: core/src/test/scala/org/apache/spark/SparkFunSuite.scala
##
@@ -65,6 +65,12 @@ abstract class SparkFunSuite
with Logging {
//
viirya commented on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-669673556
@dbtsai @dongjoon-hyun @cloud-fan @HyukjinKwon @maropu Please take another
look if you have some time. Thanks.
viirya commented on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-669673235
Oh, right, hive-1.2 is only testable under hadoop2.7. Now hive-2.3 and
hive-1.2 all passed Jenkins tests.
This
maropu commented on pull request #29034:
URL: https://github.com/apache/spark/pull/29034#issuecomment-669673286
I'm okay to support it and no more comment. Anyone could check this? also
cc: @cloud-fan
This is an automated
AmplabJenkins removed a comment on pull request #29369:
URL: https://github.com/apache/spark/pull/29369#issuecomment-669671116
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on a change in pull request #29034:
URL: https://github.com/apache/spark/pull/29034#discussion_r466135375
##
File path: sql/core/src/test/resources/sql-tests/results/show-tables.sql.out
##
@@ -117,6 +117,63 @@ show_t2
show_t3
+-- !query
+CACHE TABLE
SparkQA commented on pull request #29369:
URL: https://github.com/apache/spark/pull/29369#issuecomment-669672653
**[Test build #127125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127125/testReport)**
for PR 29369 at commit
SparkQA commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669672688
**[Test build #127126 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127126/testReport)**
for PR 29360 at commit
AmplabJenkins removed a comment on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669671155
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-669671147
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669671155
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29369:
URL: https://github.com/apache/spark/pull/29369#issuecomment-669671116
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-669671147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-669605286
**[Test build #127110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127110/testReport)**
for PR 28761 at commit
SparkQA commented on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-669670634
**[Test build #127110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127110/testReport)**
for PR 28761 at commit
beliefer opened a new pull request #29369:
URL: https://github.com/apache/spark/pull/29369
### What changes were proposed in this pull request?
Spark SQL supported filter clause in aggregate, for example:
`select sum(distinct id) filter (where sex = 'man') from student;`
But
AmplabJenkins removed a comment on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669669262
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669668870
**[Test build #127124 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127124/testReport)**
for PR 29360 at commit
AmplabJenkins commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669669258
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669669158
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669669247
**[Test build #127124 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127124/testReport)**
for PR 29360 at commit
AmplabJenkins commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669669158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669668870
**[Test build #127124 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127124/testReport)**
for PR 29360 at commit
Karl-WangSK commented on a change in pull request #29360:
URL: https://github.com/apache/spark/pull/29360#discussion_r466129980
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -2690,6 +2690,19 @@ object SQLConf {
.booleanConf
AmplabJenkins removed a comment on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669667436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669667382
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669667063
**[Test build #127123 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127123/testReport)**
for PR 29360 at commit
AmplabJenkins removed a comment on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669667398
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669667430
**[Test build #127123 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127123/testReport)**
for PR 29360 at commit
AmplabJenkins commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669667382
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669667434
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669667398
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669667049
**[Test build #127122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127122/testReport)**
for PR 29367 at commit
SparkQA commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-669667063
**[Test build #127123 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127123/testReport)**
for PR 29360 at commit
agrawaldevesh commented on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669666584
> Ah yeah, if you click expand you can see it's just all squished down
together into one commit and the full commit text covers everything. When it
gets merged the
AmplabJenkins commented on pull request #29328:
URL: https://github.com/apache/spark/pull/29328#issuecomment-669665464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29328:
URL: https://github.com/apache/spark/pull/29328#issuecomment-669665464
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29328:
URL: https://github.com/apache/spark/pull/29328#issuecomment-669665184
**[Test build #127121 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127121/testReport)**
for PR 29328 at commit
holdenk commented on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669665636
> @holdenk, I am a bit confused by the commit message of the only commit in
this PR: "Shutdown executor once we are done decommissioning". Isn't this the
recently merged PR
AmplabJenkins removed a comment on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669663852
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669663852
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
imback82 commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r466125984
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##
@@ -826,27 +826,6 @@ class FileBasedDataSourceSuite
AmplabJenkins removed a comment on pull request #29365:
URL: https://github.com/apache/spark/pull/29365#issuecomment-669663352
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669616282
**[Test build #127113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127113/testReport)**
for PR 29367 at commit
SparkQA removed a comment on pull request #29365:
URL: https://github.com/apache/spark/pull/29365#issuecomment-669657403
**[Test build #127119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127119/testReport)**
for PR 29365 at commit
AmplabJenkins commented on pull request #29365:
URL: https://github.com/apache/spark/pull/29365#issuecomment-669663352
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29367:
URL: https://github.com/apache/spark/pull/29367#issuecomment-669663464
**[Test build #127113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127113/testReport)**
for PR 29367 at commit
SparkQA commented on pull request #29365:
URL: https://github.com/apache/spark/pull/29365#issuecomment-669663146
**[Test build #127119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127119/testReport)**
for PR 29365 at commit
AmplabJenkins removed a comment on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669662882
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669662867
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/31738/
AmplabJenkins commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669662882
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
imback82 commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r466122116
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
##
@@ -224,17 +224,6 @@ class
AmplabJenkins removed a comment on pull request #29328:
URL: https://github.com/apache/spark/pull/29328#issuecomment-669661660
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29328:
URL: https://github.com/apache/spark/pull/29328#issuecomment-669661660
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29328:
URL: https://github.com/apache/spark/pull/29328#issuecomment-669661384
**[Test build #127120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127120/testReport)**
for PR 29328 at commit
holdenk commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669659227
Personally I'd drop the "getting" and I'd drop "External Shuffle Service" (I
think non-expiremental dynamic resource allocation with or without external
shuffle is good
SparkQA commented on pull request #29368:
URL: https://github.com/apache/spark/pull/29368#issuecomment-669658081
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/31738/
1 - 100 of 594 matches
Mail list logo