[GitHub] [spark] SparkQA commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
SparkQA commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669718763 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/31749/

[GitHub] [spark] cloud-fan closed pull request #29357: [SPARK-32539][INFRA] Disallow `FileSystem.get(Configuration conf)` in style check by default

2020-08-05 Thread GitBox
cloud-fan closed pull request #29357: URL: https://github.com/apache/spark/pull/29357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #29357: [SPARK-32539][INFRA] Disallow `FileSystem.get(Configuration conf)` in style check by default

2020-08-05 Thread GitBox
cloud-fan commented on pull request #29357: URL: https://github.com/apache/spark/pull/29357#issuecomment-669718683 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503 I will update failure list to JIRA later This is an automated message from the Apache Git Service. To

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503 I will update failure list to JIRA after this pr later This is an automated message from the Apache

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503 I will update failure list to JIRA later after this pr This is an automated message from the Apache

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401 cc @srowen from the numbers alone, this pr fixed about 70% failed cases of `sql/catalyst` module, do we accept partial fixed and fix the remaining cases in other

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401 cc @srowen from the numbers alone, this pr fixed about 70% failed cases of `sql/catalyst` module, do we accept partial fixed?

[GitHub] [spark] cloud-fan commented on a change in pull request #29357: [SPARK-32539][INFRA] Disallow `FileSystem.get(Configuration conf)` in style check by default

2020-08-05 Thread GitBox
cloud-fan commented on a change in pull request #29357: URL: https://github.com/apache/spark/pull/29357#discussion_r466159423 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala ## @@ -165,7 +165,7 @@

[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401 cc @srowen from the numbers alone, this pr fixed about 70% failed cases of `sql/catalyst` module now, do we accept partial fixed?

[GitHub] [spark] maropu commented on pull request #29355: [SPARK-32552][SQL][DOCS]Complete the documentation for Table-valued Function

2020-08-05 Thread GitBox
maropu commented on pull request #29355: URL: https://github.com/apache/spark/pull/29355#issuecomment-669714210 > Here is the link for HIVE Built-in Table-Generating Functions (UDTF). Should we also include json_tuple and parse_url? yea, I think we should.

[GitHub] [spark] maropu commented on a change in pull request #29355: [SPARK-32552][SQL][DOCS]Complete the documentation for Table-valued Function

2020-08-05 Thread GitBox
maropu commented on a change in pull request #29355: URL: https://github.com/apache/spark/pull/29355#discussion_r466158424 ## File path: docs/sql-ref-syntax-qry-select-tvf.md ## @@ -21,25 +21,7 @@ license: | ### Description -A table-valued function (TVF) is a function

[GitHub] [spark] cloud-fan closed pull request #29332: [SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-05 Thread GitBox
cloud-fan closed pull request #29332: URL: https://github.com/apache/spark/pull/29332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #29332: [SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-05 Thread GitBox
cloud-fan commented on pull request #29332: URL: https://github.com/apache/spark/pull/29332#issuecomment-669713324 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #29125: [SPARK-32018][SQL][3.0] UnsafeRow.setDecimal should set null with overflowed value

2020-08-05 Thread GitBox
cloud-fan commented on pull request #29125: URL: https://github.com/apache/spark/pull/29125#issuecomment-669712680 I don't agree to revert the UnsafeRow bug fix. As I said, `UnsafeRow` is very fundamental and we can't tolerant any bugs. I agree that the sum decimal bug becomes more

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240 > Thanks. You don't need to fix everything in one shot. Please group the failures and fix the one you think this is related to many others. You can proceed by suite

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240 > Thanks. You don't need to fix everything in one shot. Please group the failures and fix the one you think this is related to many others. You can proceed by suite

[GitHub] [spark] maropu commented on a change in pull request #28185: [SPARK-31419][SQL][DOCS] Document Table-valued Function and Inline Table

2020-08-05 Thread GitBox
maropu commented on a change in pull request #28185: URL: https://github.com/apache/spark/pull/28185#discussion_r466155817 ## File path: docs/sql-ref-syntax-qry-select-tvf.md ## @@ -0,0 +1,131 @@ +--- +layout: global +title: Table-valued Functions (TVF) +displayTitle:

[GitHub] [spark] maropu commented on a change in pull request #28185: [SPARK-31419][SQL][DOCS] Document Table-valued Function and Inline Table

2020-08-05 Thread GitBox
maropu commented on a change in pull request #28185: URL: https://github.com/apache/spark/pull/28185#discussion_r466155817 ## File path: docs/sql-ref-syntax-qry-select-tvf.md ## @@ -0,0 +1,131 @@ +--- +layout: global +title: Table-valued Functions (TVF) +displayTitle:

[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240 > Thanks. You don't need to fix everything in one shot. Please group the failures and fix the one you think this is related to many others. You can proceed by suite by

[GitHub] [spark] maropu commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-05 Thread GitBox
maropu commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466151698 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ## @@ -418,8 +418,11 @@ package object dsl { def

[GitHub] [spark] SparkQA removed a comment on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
SparkQA removed a comment on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669697121 **[Test build #127127 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127127/testReport)** for PR 29368 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669700817 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669700817 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
SparkQA commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669700347 **[Test build #127127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127127/testReport)** for PR 29368 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite in scala 2.13

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669699584 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite in scala 2.13

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669699869 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite in scala 2.13

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669699584 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-669698899 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
SparkQA removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-669672653 **[Test build #127125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127125/testReport)** for PR 29369 at commit

[GitHub] [spark] LuciferYang opened a new pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite in scala 2.13

2020-08-05 Thread GitBox
LuciferYang opened a new pull request #29370: URL: https://github.com/apache/spark/pull/29370 ### What changes were proposed in this pull request? The purpose of this pr is to partial resolve [SPARK-32526](https://issues.apache.org/jira/browse/SPARK-32526), fix

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-669698894 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-669698894 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
SparkQA commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-669698778 **[Test build #127125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127125/testReport)** for PR 29369 at commit

[GitHub] [spark] SparkQA commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
SparkQA commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669697121 **[Test build #127127 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127127/testReport)** for PR 29368 at commit

[GitHub] [spark] maropu commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
maropu commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669695780 > Personally I'd drop the "getting" and I'd drop "External Shuffle Service" (I think non-expiremental dynamic resource allocation with or without external shuffle is good

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29364: [SPARK-32548][SQL] - Add Application attemptId support to SQL Rest API

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29364: URL: https://github.com/apache/spark/pull/29364#issuecomment-669694473 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] gengliangwang commented on a change in pull request #29357: [SPARK-32539][INFRA] Disallow `FileSystem.get(Configuration conf)` in style check by default

2020-08-05 Thread GitBox
gengliangwang commented on a change in pull request #29357: URL: https://github.com/apache/spark/pull/29357#discussion_r466147119 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala ## @@ -165,7 +165,7 @@

[GitHub] [spark] AmplabJenkins commented on pull request #29364: [SPARK-32548][SQL] - Add Application attemptId support to SQL Rest API

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29364: URL: https://github.com/apache/spark/pull/29364#issuecomment-669694473 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29364: [SPARK-32548][SQL] - Add Application attemptId support to SQL Rest API

2020-08-05 Thread GitBox
SparkQA removed a comment on pull request #29364: URL: https://github.com/apache/spark/pull/29364#issuecomment-669620206 **[Test build #127115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127115/testReport)** for PR 29364 at commit

[GitHub] [spark] SparkQA commented on pull request #29364: [SPARK-32548][SQL] - Add Application attemptId support to SQL Rest API

2020-08-05 Thread GitBox
SparkQA commented on pull request #29364: URL: https://github.com/apache/spark/pull/29364#issuecomment-669693710 **[Test build #127115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127115/testReport)** for PR 29364 at commit

[GitHub] [spark] cloud-fan commented on pull request #29363: [SPARK-32546][SQL] Get table names directly from Hive tables

2020-08-05 Thread GitBox
cloud-fan commented on pull request #29363: URL: https://github.com/apache/spark/pull/29363#issuecomment-669692126 The fix LGTM. This PR is kind of an improvement to skip the unnecessary table conversion, but also fixes the serde class loading issues. Agree with @dongjoon-hyun and let's

[GitHub] [spark] msamirkhan commented on a change in pull request #29353: [SPARK-32532][SQL] Improve ORC read/write performance on nested structs and array of structs

2020-08-05 Thread GitBox
msamirkhan commented on a change in pull request #29353: URL: https://github.com/apache/spark/pull/29353#discussion_r466144939 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala ## @@ -73,135 +75,157 @@ class

[GitHub] [spark] maropu commented on a change in pull request #29356: [SPARK-32538][CORE][TEST] Use local time zone for the timestamp logged in unit-tests.log

2020-08-05 Thread GitBox
maropu commented on a change in pull request #29356: URL: https://github.com/apache/spark/pull/29356#discussion_r466143036 ## File path: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ## @@ -65,6 +65,12 @@ abstract class SparkFunSuite with Logging { //

[GitHub] [spark] viirya commented on pull request #28761: [SPARK-25557][SQL][test-hadoop2.7][test-hive1.2] Nested column predicate pushdown for ORC

2020-08-05 Thread GitBox
viirya commented on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-669673556 @dbtsai @dongjoon-hyun @cloud-fan @HyukjinKwon @maropu Please take another look if you have some time. Thanks.

[GitHub] [spark] viirya commented on pull request #28761: [SPARK-25557][SQL][test-hadoop2.7][test-hive1.2] Nested column predicate pushdown for ORC

2020-08-05 Thread GitBox
viirya commented on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-669673235 Oh, right, hive-1.2 is only testable under hadoop2.7. Now hive-2.3 and hive-1.2 all passed Jenkins tests. This

[GitHub] [spark] maropu commented on pull request #29034: [SPARK-32219][SQL] Add SHOW CACHED TABLES Command

2020-08-05 Thread GitBox
maropu commented on pull request #29034: URL: https://github.com/apache/spark/pull/29034#issuecomment-669673286 I'm okay to support it and no more comment. Anyone could check this? also cc: @cloud-fan This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-669671116 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #29034: [SPARK-32219][SQL] Add SHOW CACHED TABLES Command

2020-08-05 Thread GitBox
maropu commented on a change in pull request #29034: URL: https://github.com/apache/spark/pull/29034#discussion_r466135375 ## File path: sql/core/src/test/resources/sql-tests/results/show-tables.sql.out ## @@ -117,6 +117,63 @@ show_t2 show_t3 +-- !query +CACHE TABLE

[GitHub] [spark] SparkQA commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
SparkQA commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-669672653 **[Test build #127125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127125/testReport)** for PR 29369 at commit

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669672688 **[Test build #127126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127126/testReport)** for PR 29360 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669671155 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28761: [SPARK-25557][SQL][test-hadoop2.7][test-hive1.2] Nested column predicate pushdown for ORC

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-669671147 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669671155 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-669671116 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28761: [SPARK-25557][SQL][test-hadoop2.7][test-hive1.2] Nested column predicate pushdown for ORC

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-669671147 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28761: [SPARK-25557][SQL][test-hadoop2.7][test-hive1.2] Nested column predicate pushdown for ORC

2020-08-05 Thread GitBox
SparkQA removed a comment on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-669605286 **[Test build #127110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127110/testReport)** for PR 28761 at commit

[GitHub] [spark] SparkQA commented on pull request #28761: [SPARK-25557][SQL][test-hadoop2.7][test-hive1.2] Nested column predicate pushdown for ORC

2020-08-05 Thread GitBox
SparkQA commented on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-669670634 **[Test build #127110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127110/testReport)** for PR 28761 at commit

[GitHub] [spark] beliefer opened a new pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-05 Thread GitBox
beliefer opened a new pull request #29369: URL: https://github.com/apache/spark/pull/29369 ### What changes were proposed in this pull request? Spark SQL supported filter clause in aggregate, for example: `select sum(distinct id) filter (where sex = 'man') from student;` But

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669669262 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
SparkQA removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669668870 **[Test build #127124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127124/testReport)** for PR 29360 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669669258 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669669158 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669669247 **[Test build #127124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127124/testReport)** for PR 29360 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669669158 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669668870 **[Test build #127124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127124/testReport)** for PR 29360 at commit

[GitHub] [spark] Karl-WangSK commented on a change in pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
Karl-WangSK commented on a change in pull request #29360: URL: https://github.com/apache/spark/pull/29360#discussion_r466129980 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2690,6 +2690,19 @@ object SQLConf { .booleanConf

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669667436 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669667382 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
SparkQA removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669667063 **[Test build #127123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127123/testReport)** for PR 29360 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669667398 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669667430 **[Test build #127123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127123/testReport)** for PR 29360 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669667382 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669667434 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669667398 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
SparkQA commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669667049 **[Test build #127122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127122/testReport)** for PR 29367 at commit

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL]Add a batch for optimizing logicalPlan

2020-08-05 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-669667063 **[Test build #127123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127123/testReport)** for PR 29360 at commit

[GitHub] [spark] agrawaldevesh commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
agrawaldevesh commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669666584 > Ah yeah, if you click expand you can see it's just all squished down together into one commit and the full commit text covers everything. When it gets merged the

[GitHub] [spark] AmplabJenkins commented on pull request #29328: [WIP][SPARK-32516][SQL] 'path' option should be treated consistently when loading dataframes for different APIs

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29328: URL: https://github.com/apache/spark/pull/29328#issuecomment-669665464 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29328: [WIP][SPARK-32516][SQL] 'path' option should be treated consistently when loading dataframes for different APIs

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29328: URL: https://github.com/apache/spark/pull/29328#issuecomment-669665464 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29328: [WIP][SPARK-32516][SQL] 'path' option should be treated consistently when loading dataframes for different APIs

2020-08-05 Thread GitBox
SparkQA commented on pull request #29328: URL: https://github.com/apache/spark/pull/29328#issuecomment-669665184 **[Test build #127121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127121/testReport)** for PR 29328 at commit

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669665636 > @holdenk, I am a bit confused by the commit message of the only commit in this PR: "Shutdown executor once we are done decommissioning". Isn't this the recently merged PR

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669663852 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669663852 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] imback82 commented on a change in pull request #29328: [WIP][SPARK-32516][SQL] 'path' option should be treated consistently when loading dataframes for different APIs

2020-08-05 Thread GitBox
imback82 commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466125984 ## File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ## @@ -826,27 +826,6 @@ class FileBasedDataSourceSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29365: [WIP][SPARK-32549][PYSPARK] Add column name in _infer_schema error message

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29365: URL: https://github.com/apache/spark/pull/29365#issuecomment-669663352 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
SparkQA removed a comment on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669616282 **[Test build #127113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127113/testReport)** for PR 29367 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29365: [WIP][SPARK-32549][PYSPARK] Add column name in _infer_schema error message

2020-08-05 Thread GitBox
SparkQA removed a comment on pull request #29365: URL: https://github.com/apache/spark/pull/29365#issuecomment-669657403 **[Test build #127119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127119/testReport)** for PR 29365 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29365: [WIP][SPARK-32549][PYSPARK] Add column name in _infer_schema error message

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29365: URL: https://github.com/apache/spark/pull/29365#issuecomment-669663352 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-05 Thread GitBox
SparkQA commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669663464 **[Test build #127113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127113/testReport)** for PR 29367 at commit

[GitHub] [spark] SparkQA commented on pull request #29365: [WIP][SPARK-32549][PYSPARK] Add column name in _infer_schema error message

2020-08-05 Thread GitBox
SparkQA commented on pull request #29365: URL: https://github.com/apache/spark/pull/29365#issuecomment-669663146 **[Test build #127119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127119/testReport)** for PR 29365 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669662882 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
SparkQA commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669662867 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/31738/

[GitHub] [spark] AmplabJenkins commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669662882 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] imback82 commented on a change in pull request #29328: [WIP][SPARK-32516][SQL] 'path' option should be treated consistently when loading dataframes for different APIs

2020-08-05 Thread GitBox
imback82 commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466122116 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala ## @@ -224,17 +224,6 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29328: [WIP][SPARK-32516][SQL] 'path' option should be treated consistently when loading dataframes for different APIs

2020-08-05 Thread GitBox
AmplabJenkins removed a comment on pull request #29328: URL: https://github.com/apache/spark/pull/29328#issuecomment-669661660 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29328: [WIP][SPARK-32516][SQL] 'path' option should be treated consistently when loading dataframes for different APIs

2020-08-05 Thread GitBox
AmplabJenkins commented on pull request #29328: URL: https://github.com/apache/spark/pull/29328#issuecomment-669661660 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29328: [WIP][SPARK-32516][SQL] 'path' option should be treated consistently when loading dataframes for different APIs

2020-08-05 Thread GitBox
SparkQA commented on pull request #29328: URL: https://github.com/apache/spark/pull/29328#issuecomment-669661384 **[Test build #127120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127120/testReport)** for PR 29328 at commit

[GitHub] [spark] holdenk commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
holdenk commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669659227 Personally I'd drop the "getting" and I'd drop "External Shuffle Service" (I think non-expiremental dynamic resource allocation with or without external shuffle is good

[GitHub] [spark] SparkQA commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-05 Thread GitBox
SparkQA commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-669658081 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/31738/

  1   2   3   4   5   6   >