[GitHub] [spark] AmplabJenkins commented on pull request #29422: [CORE][SPARK-32613] Fix regressions in DecommissionWorkerSuite

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673796082 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [CORE][SPARK-32613] Fix regressions in DecommissionWorkerSuite

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673796082 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29422: [CORE][SPARK-32613] Fix regressions in DecommissionWorkerSuite

2020-08-13 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673793268 **[Test build #127422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127422/testReport)** for PR 29422 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29422: [CORE][SPARK-32613] Fix regressions in DecommissionWorkerSuite

2020-08-13 Thread GitBox
SparkQA removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673749927 **[Test build #127422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127422/testReport)** for PR 29422 at commit

[GitHub] [spark] agrawaldevesh commented on pull request #29422: [CORE][SPARK-32613] Fix regressions in DecommissionWorkerSuite

2020-08-13 Thread GitBox
agrawaldevesh commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673779207 cc: @attilapiros @holdenk @HyukjinKwon This is an automated message from the Apache Git Service. To

[GitHub] [spark] github-actions[bot] closed pull request #28197: [SPARK-31431][SQL] Add CalendarInterval encoder support

2020-08-13 Thread GitBox
github-actions[bot] closed pull request #28197: URL: https://github.com/apache/spark/pull/28197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673774426 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673774426 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
SparkQA removed a comment on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673733876 **[Test build #127421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127421/testReport)** for PR 29342 at commit

[GitHub] [spark] SparkQA commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
SparkQA commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673773892 **[Test build #127421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127421/testReport)** for PR 29342 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [CORE][SPARK-32613] Fix regressions in DecommissionWorkerSuite

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673773824 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [CORE][SPARK-32613] Fix regressions in DecommissionWorkerSuite

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673773824 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #28804: [SPARK-31973][SQL] Skip partial aggregates if grouping keys have high cardinality

2020-08-13 Thread GitBox
maropu commented on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-673773652 > @maropu The stats(specifically number of records from aggregation map after a threshold) that we are looking for is available only at the operator level at runtime. I

[GitHub] [spark] SparkQA commented on pull request #29422: [CORE][SPARK-32613] Fix regressions in DecommissionWorkerSuite

2020-08-13 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673773346 **[Test build #127428 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127428/testReport)** for PR 29422 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673770514 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673770509 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673770509 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673770501 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32046/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29423: URL: https://github.com/apache/spark/pull/29423#issuecomment-673767918 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29423: URL: https://github.com/apache/spark/pull/29423#issuecomment-673767918 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
SparkQA commented on pull request #29423: URL: https://github.com/apache/spark/pull/29423#issuecomment-673767434 **[Test build #127427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127427/testReport)** for PR 29423 at commit

[GitHub] [spark] maropu commented on a change in pull request #29414: [SPARK-32106][SQL] Implement script transform in sql/core

2020-08-13 Thread GitBox
maropu commented on a change in pull request #29414: URL: https://github.com/apache/spark/pull/29414#discussion_r470300313 ## File path: sql/core/src/test/resources/sql-tests/results/transform.sql.out ## @@ -0,0 +1,224 @@ +-- Automatically generated by SQLQueryTestSuite +--

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29427: [SPARK-25557][SQL][TEST][Followup] Add case-sensitivity test for ORC predicate pushdown

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29427: URL: https://github.com/apache/spark/pull/29427#issuecomment-673765512 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29427: [SPARK-25557][SQL][TEST][Followup] Add case-sensitivity test for ORC predicate pushdown

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29427: URL: https://github.com/apache/spark/pull/29427#issuecomment-673765512 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29427: [SPARK-25557][SQL][TEST][Followup] Add case-sensitivity test for ORC predicate pushdown

2020-08-13 Thread GitBox
SparkQA removed a comment on pull request #29427: URL: https://github.com/apache/spark/pull/29427#issuecomment-673673773 **[Test build #127419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127419/testReport)** for PR 29427 at commit

[GitHub] [spark] SparkQA commented on pull request #29427: [SPARK-25557][SQL][TEST][Followup] Add case-sensitivity test for ORC predicate pushdown

2020-08-13 Thread GitBox
SparkQA commented on pull request #29427: URL: https://github.com/apache/spark/pull/29427#issuecomment-673765011 **[Test build #127419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127419/testReport)** for PR 29427 at commit

[GitHub] [spark] maropu commented on a change in pull request #29270: [SPARK-32466][TEST][SQL] Add PlanStabilitySuite to detect SparkPlan regression

2020-08-13 Thread GitBox
maropu commented on a change in pull request #29270: URL: https://github.com/apache/spark/pull/29270#discussion_r470303778 ## File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala ## @@ -0,0 +1,335 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673763467 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32046/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673756572 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
SparkQA removed a comment on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673756078 **[Test build #127426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127426/testReport)** for PR 29424 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673756569 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673756454 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
SparkQA commented on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673756557 **[Test build #127426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127426/testReport)** for PR 29424 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673756454 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #29414: [SPARK-32106][SQL] Implement script transform in sql/core

2020-08-13 Thread GitBox
maropu commented on a change in pull request #29414: URL: https://github.com/apache/spark/pull/29414#discussion_r470300313 ## File path: sql/core/src/test/resources/sql-tests/results/transform.sql.out ## @@ -0,0 +1,224 @@ +-- Automatically generated by SQLQueryTestSuite +--

[GitHub] [spark] SparkQA commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
SparkQA commented on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673756078 **[Test build #127426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127426/testReport)** for PR 29424 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673497518 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] maropu commented on pull request #29424: [MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
maropu commented on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673755561 Looks okay. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #29424: [MINOR] Fixed approx_count_distinct rsd param description

2020-08-13 Thread GitBox
maropu commented on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673755517 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak commented on a change in pull request #29082: [SPARK-32288][UI] Add exception summary for failed tasks in stage page

2020-08-13 Thread GitBox
sarutak commented on a change in pull request #29082: URL: https://github.com/apache/spark/pull/29082#discussion_r470298801 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala ## @@ -421,6 +420,51 @@ private[spark] class AppStatusStore(

[GitHub] [spark] sarutak commented on a change in pull request #29082: [SPARK-32288][UI] Add exception summary for failed tasks in stage page

2020-08-13 Thread GitBox
sarutak commented on a change in pull request #29082: URL: https://github.com/apache/spark/pull/29082#discussion_r470297451 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala ## @@ -421,6 +420,51 @@ private[spark] class AppStatusStore(

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673754055 **[Test build #127425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127425/testReport)** for PR 28939 at commit

[GitHub] [spark] maropu edited a comment on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-13 Thread GitBox
maropu edited a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-673753587 > But shuffle is happened during Aggregate here, right? By splitting, the total amount of shuffled data is not changed, but split into several ones. Does it really result

[GitHub] [spark] maropu commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-13 Thread GitBox
maropu commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-673753587 > But shuffle is happened during Aggregate here, right? By splitting, the total amount of shuffled data is not changed, but split into several ones. Does it really result

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [wip][testing][dnr] Decom fixes

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673752394 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29426: [SPARK-32610][DOCS] Fix the link to metrics.dropwizard.io in monitoring.md to refer the proper version

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29426: URL: https://github.com/apache/spark/pull/29426#issuecomment-673752312 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [wip][testing][dnr] Decom fixes

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673752394 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29426: [SPARK-32610][DOCS] Fix the link to metrics.dropwizard.io in monitoring.md to refer the proper version

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29426: URL: https://github.com/apache/spark/pull/29426#issuecomment-673752312 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
sarutak commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673751979 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #29422: [wip][testing][dnr] Decom fixes

2020-08-13 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673751916 **[Test build #127424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127424/testReport)** for PR 29422 at commit

[GitHub] [spark] SparkQA commented on pull request #29426: [SPARK-32610][DOCS] Fix the link to metrics.dropwizard.io in monitoring.md to refer the proper version

2020-08-13 Thread GitBox
SparkQA commented on pull request #29426: URL: https://github.com/apache/spark/pull/29426#issuecomment-673751893 **[Test build #127423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127423/testReport)** for PR 29426 at commit

[GitHub] [spark] sarutak commented on pull request #29426: [SPARK-32610][DOCS] Fix the link to metrics.dropwizard.io in monitoring.md to refer the proper version

2020-08-13 Thread GitBox
sarutak commented on pull request #29426: URL: https://github.com/apache/spark/pull/29426#issuecomment-673751359 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [wip][testing][dnr] Decom fixes

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673750292 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [wip][testing][dnr] Decom fixes

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673750292 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29422: [wip][testing][dnr] Decom fixes

2020-08-13 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-673749927 **[Test build #127422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127422/testReport)** for PR 29422 at commit

[GitHub] [spark] msamirkhan commented on pull request #29352: [SPARK-32531][SQL][TEST] Add benchmarks for nested structs and arrays for different file formats

2020-08-13 Thread GitBox
msamirkhan commented on pull request #29352: URL: https://github.com/apache/spark/pull/29352#issuecomment-673749654 > Could you split the PR into two because your `ReadSchemaTest` test coverage addition is worth to have an independent JIRA ID? Yes, will do that.

[GitHub] [spark] msamirkhan commented on a change in pull request #29366: [SPARK-32550][SQL] Make SpecificInternalRow constructors faster by using while loops instead of maps

2020-08-13 Thread GitBox
msamirkhan commented on a change in pull request #29366: URL: https://github.com/apache/spark/pull/29366#discussion_r470292718 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificInternalRow.scala ## @@ -192,24 +192,41 @@ final class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673737392 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673737392 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
SparkQA removed a comment on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673679974 **[Test build #127420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127420/testReport)** for PR 29342 at commit

[GitHub] [spark] SparkQA commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
SparkQA commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673736717 **[Test build #127420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127420/testReport)** for PR 29342 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673734439 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673734439 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
SparkQA commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673733876 **[Test build #127421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127421/testReport)** for PR 29342 at commit

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470271904 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -314,7 +338,9 @@ private[joins] object

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470263293 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator()

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470251281 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470248197 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator()

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470240912 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29415: [SPARK-32590][SQL] Remove fullOutput from RowDataSourceScanExec

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29415: URL: https://github.com/apache/spark/pull/29415#issuecomment-673703659 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470240912 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] AmplabJenkins commented on pull request #29415: [SPARK-32590][SQL] Remove fullOutput from RowDataSourceScanExec

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29415: URL: https://github.com/apache/spark/pull/29415#issuecomment-673703659 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29415: [SPARK-32590][SQL] Remove fullOutput from RowDataSourceScanExec

2020-08-13 Thread GitBox
SparkQA removed a comment on pull request #29415: URL: https://github.com/apache/spark/pull/29415#issuecomment-673576724 **[Test build #127416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127416/testReport)** for PR 29415 at commit

[GitHub] [spark] SparkQA commented on pull request #29415: [SPARK-32590][SQL] Remove fullOutput from RowDataSourceScanExec

2020-08-13 Thread GitBox
SparkQA commented on pull request #29415: URL: https://github.com/apache/spark/pull/29415#issuecomment-673702803 **[Test build #127416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127416/testReport)** for PR 29415 at commit

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470237884 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,64 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470236922 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470229887 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,210 @@ case class

[GitHub] [spark] c21 commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673693967 cc @cloud-fan - all new comments are addressed. Thanks. This is an automated message from the Apache Git Service.

[GitHub] [spark] ral51 commented on pull request #19410: [SPARK-22184][CORE][GRAPHX] GraphX fails in case of insufficient memory and checkpoints enabled

2020-08-13 Thread GitBox
ral51 commented on pull request #19410: URL: https://github.com/apache/spark/pull/19410#issuecomment-673692899 @szhem Your PR looks like keeping checkpoints around so that's good. Thank you Reading your comments above, just setting `spark.cleaner.referenceTracking.cleanCheckpoints` to

[GitHub] [spark] srowen commented on pull request #27369: [SPARK-30654] Bootstrap4 docs upgrade

2020-08-13 Thread GitBox
srowen commented on pull request #27369: URL: https://github.com/apache/spark/pull/27369#issuecomment-673691875 The minified version is indeed smaller (good, we should have done that already). The line count is misleading though as the minified version also omits almost all line breaks.

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470224648 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470169165 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470214602 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,210 @@ case class

[GitHub] [spark] c21 commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673681660 > I am also curious if you can share the Perf benchmark you are using as a Gist (ideally linked in the PR description) in addition to please also reporting the aggregate CPU time ?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673681135 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673681135 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470211909 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] AmplabJenkins commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673680631 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673680631 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
SparkQA removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673602120 **[Test build #127417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127417/testReport)** for PR 28939 at commit

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-13 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673680155 **[Test build #127417 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127417/testReport)** for PR 28939 at commit

[GitHub] [spark] SparkQA commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
SparkQA commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673679974 **[Test build #127420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127420/testReport)** for PR 29342 at commit

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470201781 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] viirya closed pull request #29412: [SPARK-25557][SQL][Followup] Remove CaseInsensitiveMap in OrcFiltersBase

2020-08-13 Thread GitBox
viirya closed pull request #29412: URL: https://github.com/apache/spark/pull/29412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] viirya commented on a change in pull request #29427: [SPARK-25557][SQL][Followup] Add case-sensitivity test for ORC predicate pushdown

2020-08-13 Thread GitBox
viirya commented on a change in pull request #29427: URL: https://github.com/apache/spark/pull/29427#discussion_r470206291 ## File path: sql/core/v1.2/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala ## @@ -513,5 +513,98 @@ class

[GitHub] [spark] viirya commented on a change in pull request #29412: [SPARK-25557][SQL][Followup] Remove CaseInsensitiveMap in OrcFiltersBase

2020-08-13 Thread GitBox
viirya commented on a change in pull request #29412: URL: https://github.com/apache/spark/pull/29412#discussion_r470205227 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -67,18 +65,12 @@ trait OrcFiltersBase {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29427: [SPARK-25557][SQL][Followup] Add case-sensitivity test for ORC predicate pushdown

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29427: URL: https://github.com/apache/spark/pull/29427#issuecomment-673674357 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29427: [SPARK-25557][SQL][Followup] Add case-sensitivity test for ORC predicate pushdown

2020-08-13 Thread GitBox
AmplabJenkins commented on pull request #29427: URL: https://github.com/apache/spark/pull/29427#issuecomment-673674357 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29427: [SPARK-25557][SQL][Followup] Add case-sensitivity test for ORC predicate pushdown

2020-08-13 Thread GitBox
SparkQA commented on pull request #29427: URL: https://github.com/apache/spark/pull/29427#issuecomment-673673773 **[Test build #127419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127419/testReport)** for PR 29427 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29426: [SPARK-32610][DOCS] Fix the link to metrics.dropwizard.io in monitoring.md to refer the proper version

2020-08-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29426: URL: https://github.com/apache/spark/pull/29426#issuecomment-673672942 Test FAILed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   >