[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28490: [SPARK-31670][SQL] Trim unnecessary Struct field alias in Aggregate/GroupingSets

2020-11-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r518477448 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1425,11 +1450,49 @@ class Analyzer(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722757596 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722757585 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35288/

[GitHub] [spark] AmplabJenkins commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722757596 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] wangyum commented on pull request #30222: [SPARK-33315][SQL] Simplify CaseWhen with EqualTo

2020-11-05 Thread GitBox
wangyum commented on pull request #30222: URL: https://github.com/apache/spark/pull/30222#issuecomment-722751973 It seems it is caused by **deterministic**. cc @viirya ``` == Analyzed Logical Plan == label: double, features: vector, fold: int Filter (UDF(fold#14) AND NOT

[GitHub] [spark] dongjoon-hyun closed pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
dongjoon-hyun closed pull request #30268: URL: https://github.com/apache/spark/pull/30268 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AngersZhuuuu commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

2020-11-05 Thread GitBox
AngersZh commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-722749469 > The default concurrent connections between the peer are 1. So the total connection number of a single server should depend on the number of executors, right? If there

[GitHub] [spark] AngersZhuuuu commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

2020-11-05 Thread GitBox
AngersZh commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-722748841 > I actually thought about this and looked into the logic, but we have a case where we remove the stream from streams "without disconnecting channel", which looks like we

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL] Trim unnecessary Struct field alias in Aggregate/GroupingSets

2020-11-05 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r518469886 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1425,11 +1450,49 @@ class Analyzer(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722745061 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722745581 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35288/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722745049 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
SparkQA removed a comment on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722683919 **[Test build #130673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130673/testReport)** for PR 30211 at commit

[GitHub] [spark] SparkQA commented on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
SparkQA commented on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722744768 **[Test build #130673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130673/testReport)** for PR 30211 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722745049 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30189: [SPARK-33291][SQL] Improve DataFrame.show for nulls in arrays and structs

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30189: URL: https://github.com/apache/spark/pull/30189#issuecomment-722744093 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30189: [SPARK-33291][SQL] Improve DataFrame.show for nulls in arrays and structs

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30189: URL: https://github.com/apache/spark/pull/30189#issuecomment-722744086 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30189: [SPARK-33291][SQL] Improve DataFrame.show for nulls in arrays and structs

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30189: URL: https://github.com/apache/spark/pull/30189#issuecomment-722744086 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722744051 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722744051 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
SparkQA commented on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722744026 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35287/

[GitHub] [spark] SparkQA removed a comment on pull request #30189: [SPARK-33291][SQL] Improve DataFrame.show for nulls in arrays and structs

2020-11-05 Thread GitBox
SparkQA removed a comment on pull request #30189: URL: https://github.com/apache/spark/pull/30189#issuecomment-722647065 **[Test build #130667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130667/testReport)** for PR 30189 at commit

[GitHub] [spark] SparkQA commented on pull request #30189: [SPARK-33291][SQL] Improve DataFrame.show for nulls in arrays and structs

2020-11-05 Thread GitBox
SparkQA commented on pull request #30189: URL: https://github.com/apache/spark/pull/30189#issuecomment-722743474 **[Test build #130667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130667/testReport)** for PR 30189 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30269: URL: https://github.com/apache/spark/pull/30269#issuecomment-722740629 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
SparkQA commented on pull request #30269: URL: https://github.com/apache/spark/pull/30269#issuecomment-722740612 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35286/

[GitHub] [spark] AmplabJenkins commented on pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30269: URL: https://github.com/apache/spark/pull/30269#issuecomment-722740629 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer diale

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722736357 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer dialect)

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722736357 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722735706 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
SparkQA removed a comment on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722717831 **[Test build #130676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130676/testReport)** for PR 30263 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer dialect)

2020-11-05 Thread GitBox
SparkQA removed a comment on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722674810 **[Test build #130671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130671/testReport)** for PR 30038 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722735706 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
SparkQA commented on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722735404 **[Test build #130676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130676/testReport)** for PR 30263 at commit

[GitHub] [spark] SparkQA commented on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer dialect)

2020-11-05 Thread GitBox
SparkQA commented on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722735529 **[Test build #130671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130671/testReport)** for PR 30038 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30267: [SPARK-33364][SQL] Introduce the "purge" option in TableCatalog.dropTable for v2 catalog.

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30267: URL: https://github.com/apache/spark/pull/30267#issuecomment-722734985 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
SparkQA commented on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722735097 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35287/

[GitHub] [spark] AmplabJenkins commented on pull request #30267: [SPARK-33364][SQL] Introduce the "purge" option in TableCatalog.dropTable for v2 catalog.

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30267: URL: https://github.com/apache/spark/pull/30267#issuecomment-722734985 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30267: [SPARK-33364][SQL] Introduce the "purge" option in TableCatalog.dropTable for v2 catalog.

2020-11-05 Thread GitBox
SparkQA removed a comment on pull request #30267: URL: https://github.com/apache/spark/pull/30267#issuecomment-722613041 **[Test build #130664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130664/testReport)** for PR 30267 at commit

[GitHub] [spark] SparkQA commented on pull request #30267: [SPARK-33364][SQL] Introduce the "purge" option in TableCatalog.dropTable for v2 catalog.

2020-11-05 Thread GitBox
SparkQA commented on pull request #30267: URL: https://github.com/apache/spark/pull/30267#issuecomment-722734093 **[Test build #130664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130664/testReport)** for PR 30267 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30268: URL: https://github.com/apache/spark/pull/30268#issuecomment-722734030 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30268: URL: https://github.com/apache/spark/pull/30268#issuecomment-722734030 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
SparkQA removed a comment on pull request #30268: URL: https://github.com/apache/spark/pull/30268#issuecomment-722677810 **[Test build #130672 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130672/testReport)** for PR 30268 at commit

[GitHub] [spark] SparkQA commented on pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
SparkQA commented on pull request #30268: URL: https://github.com/apache/spark/pull/30268#issuecomment-722733194 **[Test build #130672 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130672/testReport)** for PR 30268 at commit

[GitHub] [spark] SparkQA commented on pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
SparkQA commented on pull request #30269: URL: https://github.com/apache/spark/pull/30269#issuecomment-722732115 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35286/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-722730633 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-722730633 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
SparkQA removed a comment on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-722674775 **[Test build #130670 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130670/testReport)** for PR 30154 at commit

[GitHub] [spark] SparkQA commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
SparkQA commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-722729791 **[Test build #130670 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130670/testReport)** for PR 30154 at commit

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722729495 **[Test build #130677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130677/testReport)** for PR 30242 at commit

[GitHub] [spark] github-actions[bot] closed pull request #29197: [WIP][SPARK-32395][CORE][SQL] Commit output files after task attempt succeed in dynamic partition datawriter

2020-11-05 Thread GitBox
github-actions[bot] closed pull request #29197: URL: https://github.com/apache/spark/pull/29197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722720052 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722720032 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35285/

[GitHub] [spark] AmplabJenkins commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722720043 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722720043 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
SparkQA commented on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722717831 **[Test build #130676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130676/testReport)** for PR 30263 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722285154 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on pull request #30263: [SPARK-33358][SQL] Return code when command process failed

2020-11-05 Thread GitBox
dongjoon-hyun commented on pull request #30263: URL: https://github.com/apache/spark/pull/30263#issuecomment-722715792 ok to test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
SparkQA commented on pull request #30269: URL: https://github.com/apache/spark/pull/30269#issuecomment-722714747 **[Test build #130675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130675/testReport)** for PR 30269 at commit

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
dongjoon-hyun edited a comment on pull request #30269: URL: https://github.com/apache/spark/pull/30269#issuecomment-722713776 I made this as a MINOR PR because it's too late to make a follow-up (The original PR was merged early September). If you guys want, we can make this as a

[GitHub] [spark] dongjoon-hyun commented on pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
dongjoon-hyun commented on pull request #30269: URL: https://github.com/apache/spark/pull/30269#issuecomment-722713776 I made this as a MINOR PR because it's too late to make a follow-up (The original PR was merged early September).

[GitHub] [spark] dongjoon-hyun commented on pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
dongjoon-hyun commented on pull request #30269: URL: https://github.com/apache/spark/pull/30269#issuecomment-722713559 cc @AngersZh and @cloud-fan This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28490: [SPARK-31670][SQL] Trim unnecessary Struct field alias in Aggregate/GroupingSets

2020-11-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r518442446 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1425,11 +1450,49 @@ class Analyzer(

[GitHub] [spark] dongjoon-hyun opened a new pull request #30269: [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer

2020-11-05 Thread GitBox
dongjoon-hyun opened a new pull request #30269: URL: https://github.com/apache/spark/pull/30269 ### What changes were proposed in this pull request? This PR fixes incorrect JIRA ids in `Analyzer.scala`. ```scala - // SPARK-31607: Resolve Struct field in

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722709816 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35285/

[GitHub] [spark] dongjoon-hyun closed pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
dongjoon-hyun closed pull request #30264: URL: https://github.com/apache/spark/pull/30264 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #30264: URL: https://github.com/apache/spark/pull/30264#discussion_r518435128 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala ## @@ -248,6 +248,68 @@ abstract

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #30264: URL: https://github.com/apache/spark/pull/30264#discussion_r518435128 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala ## @@ -248,6 +248,68 @@ abstract

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722705631 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722705631 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
SparkQA commented on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722705612 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35284/

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #30264: URL: https://github.com/apache/spark/pull/30264#discussion_r518434104 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala ## @@ -248,6 +248,68 @@ abstract

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30268: URL: https://github.com/apache/spark/pull/30268#issuecomment-722704530 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
SparkQA commented on pull request #30268: URL: https://github.com/apache/spark/pull/30268#issuecomment-722704523 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35283/

[GitHub] [spark] AmplabJenkins commented on pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30268: URL: https://github.com/apache/spark/pull/30268#issuecomment-722704530 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer diale

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722702745 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer dialect)

2020-11-05 Thread GitBox
SparkQA commented on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722702723 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35282/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer diale

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722702738 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer dialect)

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722702738 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-722701451 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-722701451 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
SparkQA commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-722701428 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35281/

[GitHub] [spark] SparkQA commented on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
SparkQA commented on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722698602 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35284/

[GitHub] [spark] SparkQA commented on pull request #30268: [SPARK-33365][BUILD] Update SBT to 1.4.2

2020-11-05 Thread GitBox
SparkQA commented on pull request #30268: URL: https://github.com/apache/spark/pull/30268#issuecomment-722697150 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35283/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30264: URL: https://github.com/apache/spark/pull/30264#issuecomment-722696516 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30264: URL: https://github.com/apache/spark/pull/30264#issuecomment-722696513 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
AmplabJenkins commented on pull request #30264: URL: https://github.com/apache/spark/pull/30264#issuecomment-722696513 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
SparkQA commented on pull request #30264: URL: https://github.com/apache/spark/pull/30264#issuecomment-722696497 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35280/

[GitHub] [spark] SparkQA commented on pull request #30038: [SPARK-33130][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MsSqlServer dialect)

2020-11-05 Thread GitBox
SparkQA commented on pull request #30038: URL: https://github.com/apache/spark/pull/30038#issuecomment-722694410 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35282/

[GitHub] [spark] otterc commented on pull request #30062: [SPARK-32916][SHUFFLE] Implementation of shuffle service that leverages push-based shuffle in YARN deployment mode

2020-11-05 Thread GitBox
otterc commented on pull request #30062: URL: https://github.com/apache/spark/pull/30062#issuecomment-722694164 The tests failures are not related to this change. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722692048 **[Test build #130674 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130674/testReport)** for PR 30242 at commit

[GitHub] [spark] viirya commented on a change in pull request #30245: [SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-05 Thread GitBox
viirya commented on a change in pull request #30245: URL: https://github.com/apache/spark/pull/30245#discussion_r518419317 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -96,8 +131,21 @@ class

[GitHub] [spark] SparkQA commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
SparkQA commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-722691122 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35281/

[GitHub] [spark] viirya commented on a change in pull request #30189: [SPARK-33291][SQL] Improve DataFrame.show for nulls in arrays and structs

2020-11-05 Thread GitBox
viirya commented on a change in pull request #30189: URL: https://github.com/apache/spark/pull/30189#discussion_r518418496 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -982,7 +985,7 @@ abstract class CastBase extends

[GitHub] [spark] viirya commented on pull request #30245: [SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-05 Thread GitBox
viirya commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-722687545 > Also, could you add a negative test case having the expression cannot be eliminated from conditional expressions? I mixed positive and negative test cases. I think I can

[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

2020-11-05 Thread GitBox
SparkQA commented on pull request #30264: URL: https://github.com/apache/spark/pull/30264#issuecomment-722685550 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35280/

[GitHub] [spark] SparkQA commented on pull request #30211: [WIP][SPARK-33305][SQL] DSv2: DROP TABLE command should also invalidate cache

2020-11-05 Thread GitBox
SparkQA commented on pull request #30211: URL: https://github.com/apache/spark/pull/30211#issuecomment-722683919 **[Test build #130673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130673/testReport)** for PR 30211 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722682949 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30245: [SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #30245: URL: https://github.com/apache/spark/pull/30245#discussion_r518409583 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -96,8 +131,21 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722682936 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

2020-11-05 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-722682915 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35279/

<    1   2   3   4   5   6   7   8   >