[GitHub] [spark] zhengruifeng commented on a change in pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

zhengruifeng commented on a change in pull request #31160: URL: https://github.com/apache/spark/pull/31160#discussion_r556326055 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/UnivariateFeatureSelector.scala ## @@ -0,0 +1,511 @@ +/* + * Licensed to the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #31128: [SPARK-28123][SQL] String Functions: support btrim

SparkQA removed a comment on pull request #31128: URL: https://github.com/apache/spark/pull/31128#issuecomment-759182771 **[Test build #133991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133991/testReport)** for PR 31128 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA removed a comment on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759241023 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759274997 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38588/

[GitHub] [spark] SparkQA commented on pull request #31128: [SPARK-28123][SQL] String Functions: support btrim

SparkQA commented on pull request #31128: URL: https://github.com/apache/spark/pull/31128#issuecomment-759273809 **[Test build #133991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133991/testReport)** for PR 31128 at commit

[GitHub] [spark] SparkQA commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759273096 **[Test build #134000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134000/testReport)** for PR 31160 at commit

[GitHub] [spark] LantaoJin commented on a change in pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin commented on a change in pull request #31119: URL: https://github.com/apache/spark/pull/31119#discussion_r556323159 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala ## @@ -74,7 +74,9 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759271872 **[Test build #133999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133999/testReport)** for PR 31160 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31136: [SPARK-34076][SQL] SQLContext.dropTempTable fails if cache is non-empty

cloud-fan commented on a change in pull request #31136: URL: https://github.com/apache/spark/pull/31136#discussion_r556321750 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ## @@ -412,8 +417,13 @@ class CatalogImpl(sparkSession:

[GitHub] [spark] SparkQA commented on pull request #31166: [SPARK-32850][TEST][FOLLOWUP] Fix flaky test due to timeout

SparkQA commented on pull request #31166: URL: https://github.com/apache/spark/pull/31166#issuecomment-759268153 **[Test build #134001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134001/testReport)** for PR 31166 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

cloud-fan commented on a change in pull request #31119: URL: https://github.com/apache/spark/pull/31119#discussion_r556317573 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala ## @@ -74,7 +74,9 @@ case class

[GitHub] [spark] viirya commented on pull request #31034: [SPARK-33989][SQL] Strip auto-generated cast when using Cast.sql

viirya commented on pull request #31034: URL: https://github.com/apache/spark/pull/31034#issuecomment-759265166 > I like this idea to exclude auto-added cast in the auto-generated alias. This should be a safe change as the auto-generated alias is mostly for display purposes. Let's get

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

AmplabJenkins removed a comment on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759263920 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38584/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

AmplabJenkins removed a comment on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-759263924 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133989/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31130: [SPARK-34070][CORE][SQL] Replaces find and emptiness check with exists

AmplabJenkins removed a comment on pull request #31130: URL: https://github.com/apache/spark/pull/31130#issuecomment-759263923 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38586/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000

AmplabJenkins removed a comment on pull request #31164: URL: https://github.com/apache/spark/pull/31164#issuecomment-759263922 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133994/

[GitHub] [spark] AmplabJenkins commented on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

AmplabJenkins commented on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759263920 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38584/

[GitHub] [spark] AmplabJenkins commented on pull request #31130: [SPARK-34070][CORE][SQL] Replaces find and emptiness check with exists

AmplabJenkins commented on pull request #31130: URL: https://github.com/apache/spark/pull/31130#issuecomment-759263923 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38586/

[GitHub] [spark] AmplabJenkins commented on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

AmplabJenkins commented on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-759263924 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133989/

[GitHub] [spark] AmplabJenkins commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000

AmplabJenkins commented on pull request #31164: URL: https://github.com/apache/spark/pull/31164#issuecomment-759263922 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133994/

[GitHub] [spark] viirya commented on a change in pull request #31034: [SPARK-33989][SQL] Strip auto-generated cast when using Cast.sql

viirya commented on a change in pull request #31034: URL: https://github.com/apache/spark/pull/31034#discussion_r556313146 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala ## @@ -136,6 +136,8 @@ package object util extends Logging {

[GitHub] [spark] viirya commented on a change in pull request #31034: [SPARK-33989][SQL] Strip auto-generated cast when using Cast.sql

viirya commented on a change in pull request #31034: URL: https://github.com/apache/spark/pull/31034#discussion_r556312488 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala ## @@ -136,6 +136,8 @@ package object util extends Logging {

[GitHub] [spark] SparkQA commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759261890 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38588/

[GitHub] [spark] MaxGekk commented on pull request #31114: [SPARK-34062][SQL] Call `updateTableStats()` from `AlterTableAddPartitionCommand`

MaxGekk commented on pull request #31114: URL: https://github.com/apache/spark/pull/31114#issuecomment-759261851 I am closing this because https://github.com/apache/spark/pull/31149 invokes `updateTableStats()` already.

[GitHub] [spark] MaxGekk closed pull request #31114: [SPARK-34062][SQL] Call `updateTableStats()` from `AlterTableAddPartitionCommand`

MaxGekk closed pull request #31114: URL: https://github.com/apache/spark/pull/31114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] ulysses-you commented on a change in pull request #31166: [SPARK-32850][TEST][FOLLOWUP] Fix flaky test due to timeout

ulysses-you commented on a change in pull request #31166: URL: https://github.com/apache/spark/pull/31166#discussion_r556311209 ## File path: core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala ## @@ -49,7 +49,7 @@ class

[GitHub] [spark] Ngone51 commented on a change in pull request #31166: [SPARK-32850][TEST][FOLLOWUP] Fix flaky test due to timeout

Ngone51 commented on a change in pull request #31166: URL: https://github.com/apache/spark/pull/31166#discussion_r556309641 ## File path: core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala ## @@ -49,7 +49,7 @@ class

[GitHub] [spark] Ngone51 commented on a change in pull request #31166: [SPARK-32850][TEST][FOLLOWUP] Fix flaky test due to timeout

Ngone51 commented on a change in pull request #31166: URL: https://github.com/apache/spark/pull/31166#discussion_r556309641 ## File path: core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala ## @@ -49,7 +49,7 @@ class

[GitHub] [spark] ulysses-you commented on pull request #31166: [SPARK-32850][TEST][FOLLOWUP] Fix flaky test due to timeout

ulysses-you commented on pull request #31166: URL: https://github.com/apache/spark/pull/31166#issuecomment-759257830 cc @HyukjinKwon @dongjoon-hyun @Ngone51 This is an automated message from the Apache Git Service. To

[GitHub] [spark] ulysses-you opened a new pull request #31166: [SPARK-32850][TEST][FOLLOWUP] Fix flaky test due to timeout

ulysses-you opened a new pull request #31166: URL: https://github.com/apache/spark/pull/31166 ### What changes were proposed in this pull request? Increase test timeout. ### Why are the changes needed? It's more reasonable to use 60s instead 6s since many code

[GitHub] [spark] zhengruifeng commented on a change in pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

zhengruifeng commented on a change in pull request #31160: URL: https://github.com/apache/spark/pull/31160#discussion_r556295900 ## File path: docs/ml-features.md ## @@ -1793,13 +1793,16 @@ for more details on the API. -## ANOVASelector - -`ANOVASelector` operates on

[GitHub] [spark] LantaoJin edited a comment on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin edited a comment on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759253291 @cloud-fan I tested manually and broadcast inside a subquery could be cancelled with this patch (I also tested the same query without patch, and it cannot be

[GitHub] [spark] LantaoJin commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759253291 @cloud-fan I tested manually and broadcast inside a subquery could be cancelled with this patch (I also tested the same query without patch, and it cannot be cancelled).

[GitHub] [spark] SparkQA removed a comment on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

SparkQA removed a comment on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-759163840 **[Test build #133989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133989/testReport)** for PR 31148 at commit

[GitHub] [spark] SparkQA commented on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

SparkQA commented on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-759252435 **[Test build #133989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133989/testReport)** for PR 31148 at commit

[GitHub] [spark] SparkQA commented on pull request #31130: [SPARK-34070][CORE][SQL] Replaces find and emptiness check with exists

SparkQA commented on pull request #31130: URL: https://github.com/apache/spark/pull/31130#issuecomment-759249641 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38586/

[GitHub] [spark] SparkQA removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000

SparkQA removed a comment on pull request #31164: URL: https://github.com/apache/spark/pull/31164#issuecomment-759201329 **[Test build #133994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133994/testReport)** for PR 31164 at commit

[GitHub] [spark] SparkQA commented on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

SparkQA commented on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759248874 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38584/

[GitHub] [spark] ulysses-you commented on pull request #31034: [SPARK-33989][SQL] Strip auto-generated cast when using Cast.sql

ulysses-you commented on pull request #31034: URL: https://github.com/apache/spark/pull/31034#issuecomment-759248721 How about add a config like `extended` or `simple` to decide whether show the `Cast` or not ? That sounds more like a debug config which maybe can help user. But after

[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000

SparkQA commented on pull request #31164: URL: https://github.com/apache/spark/pull/31164#issuecomment-759247779 **[Test build #133994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133994/testReport)** for PR 31164 at commit

[GitHub] [spark] SparkQA commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759242962 **[Test build #134000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134000/testReport)** for PR 31160 at commit

[GitHub] [spark] SparkQA commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759241023 **[Test build #133999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133999/testReport)** for PR 31160 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31034: [SPARK-33989][SQL] Strip auto-generated cast when using Cast.sql

AmplabJenkins removed a comment on pull request #31034: URL: https://github.com/apache/spark/pull/31034#issuecomment-759238822 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133987/

[GitHub] [spark] AmplabJenkins commented on pull request #31034: [SPARK-33989][SQL] Strip auto-generated cast when using Cast.sql

AmplabJenkins commented on pull request #31034: URL: https://github.com/apache/spark/pull/31034#issuecomment-759238822 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133987/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

AmplabJenkins removed a comment on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759238314 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31163: [SPARK-34093][ML] param maxDepth should check upper bound

AmplabJenkins removed a comment on pull request #31163: URL: https://github.com/apache/spark/pull/31163#issuecomment-759238311 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

AmplabJenkins removed a comment on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759238309 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38581/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000

AmplabJenkins removed a comment on pull request #31164: URL: https://github.com/apache/spark/pull/31164#issuecomment-759238313 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38582/

[GitHub] [spark] AmplabJenkins commented on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

AmplabJenkins commented on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759238309 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38581/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31132: [SPARK-34072][SQL] Fix empty array failed in functions.lit()

AmplabJenkins removed a comment on pull request #31132: URL: https://github.com/apache/spark/pull/31132#issuecomment-759238315 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133986/

[GitHub] [spark] AmplabJenkins commented on pull request #31163: [SPARK-34093][ML] param maxDepth should check upper bound

AmplabJenkins commented on pull request #31163: URL: https://github.com/apache/spark/pull/31163#issuecomment-759238311 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

AmplabJenkins commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759238314 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #31132: [SPARK-34072][SQL] Fix empty array failed in functions.lit()

AmplabJenkins commented on pull request #31132: URL: https://github.com/apache/spark/pull/31132#issuecomment-759238315 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133986/

[GitHub] [spark] AmplabJenkins commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000

AmplabJenkins commented on pull request #31164: URL: https://github.com/apache/spark/pull/31164#issuecomment-759238313 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38582/

[GitHub] [spark] SparkQA removed a comment on pull request #31034: [SPARK-33989][SQL] Strip auto-generated cast when using Cast.sql

SparkQA removed a comment on pull request #31034: URL: https://github.com/apache/spark/pull/31034#issuecomment-759147672 **[Test build #133987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133987/testReport)** for PR 31034 at commit

[GitHub] [spark] SparkQA commented on pull request #31034: [SPARK-33989][SQL] Strip auto-generated cast when using Cast.sql

SparkQA commented on pull request #31034: URL: https://github.com/apache/spark/pull/31034#issuecomment-759237259 **[Test build #133987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133987/testReport)** for PR 31034 at commit

[GitHub] [spark] SparkQA commented on pull request #31130: [SPARK-34070][CORE][SQL] Replaces find and emptiness check with exists

SparkQA commented on pull request #31130: URL: https://github.com/apache/spark/pull/31130#issuecomment-759236685 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38586/

[GitHub] [spark] SparkQA commented on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

SparkQA commented on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759235483 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38584/

[GitHub] [spark] SparkQA removed a comment on pull request #31132: [SPARK-34072][SQL] Fix empty array failed in functions.lit()

SparkQA removed a comment on pull request #31132: URL: https://github.com/apache/spark/pull/31132#issuecomment-759147734 **[Test build #133986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133986/testReport)** for PR 31132 at commit

[GitHub] [spark] SparkQA commented on pull request #31132: [SPARK-34072][SQL] Fix empty array failed in functions.lit()

SparkQA commented on pull request #31132: URL: https://github.com/apache/spark/pull/31132#issuecomment-759231340 **[Test build #133986 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133986/testReport)** for PR 31132 at commit

[GitHub] [spark] LantaoJin commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759225970 > Could we move this change to BroadcastExchangeExec.scala#L49? Better don't. BroadcastExchangeExec.scala#L49 is a `def`, we don't want to add any `val` in `trait

[GitHub] [spark] LantaoJin commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759223704 Another reason I think is the generation of `executionId` is too late, it generated only we invoke `sc.sql()`. But statementId needed in thrift server-client protocol part

[GitHub] [spark] SparkQA removed a comment on pull request #31163: [SPARK-34093][ML] param maxDepth should check upper bound

SparkQA removed a comment on pull request #31163: URL: https://github.com/apache/spark/pull/31163#issuecomment-759201617 **[Test build #133995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133995/testReport)** for PR 31163 at commit

[GitHub] [spark] SparkQA commented on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

SparkQA commented on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759222615 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38581/

[GitHub] [spark] SparkQA commented on pull request #31163: [SPARK-34093][ML] param maxDepth should check upper bound

SparkQA commented on pull request #31163: URL: https://github.com/apache/spark/pull/31163#issuecomment-759222373 **[Test build #133995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133995/testReport)** for PR 31163 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA removed a comment on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759218340 **[Test build #133996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133996/testReport)** for PR 31160 at commit

[GitHub] [spark] SparkQA commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759221753 **[Test build #133996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133996/testReport)** for PR 31160 at commit

[GitHub] [spark] wangyum commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

wangyum commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759221671 The `statementId` was introduced by https://github.com/apache/spark/pull/3946/files#diff-84cb625cf9fbadddac3b710431009437e63de5211d3d43742dae49cbac95d1e4R207 to support

[GitHub] [spark] SparkQA commented on pull request #31163: [SPARK-34093][ML] param maxDepth should check upper bound

SparkQA commented on pull request #31163: URL: https://github.com/apache/spark/pull/31163#issuecomment-759220772 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38583/

[GitHub] [spark] SparkQA commented on pull request #31130: [SPARK-34070][CORE][SQL] Replaces find and emptiness check with exists

SparkQA commented on pull request #31130: URL: https://github.com/apache/spark/pull/31130#issuecomment-759219926 **[Test build #133998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133998/testReport)** for PR 31130 at commit

[GitHub] [spark] LantaoJin edited a comment on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin edited a comment on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759218273 > BTW why doesn't STS use SQL execution ID to cancel the jobs for a SQL query? A `statementId` bound in `SparkOperation` can be accessed in two threads

[GitHub] [spark] LantaoJin edited a comment on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin edited a comment on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759218273 > BTW why doesn't STS use SQL execution ID to cancel the jobs for a SQL query? A `statementId` bound in `SparkOperation` can be accessed in two threads

[GitHub] [spark] SparkQA commented on pull request #31160: [SPARK-34080][ML][PySpark] Add UnivariateFeatureSelector

SparkQA commented on pull request #31160: URL: https://github.com/apache/spark/pull/31160#issuecomment-759218340 **[Test build #133996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133996/testReport)** for PR 31160 at commit

[GitHub] [spark] LantaoJin commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759218273 > BTW why doesn't STS use SQL execution ID to cancel the jobs for a SQL query? A `statementId` bound in `SparkOperation` can be accessed in two threads

[GitHub] [spark] LantaoJin edited a comment on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin edited a comment on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759218273 > BTW why doesn't STS use SQL execution ID to cancel the jobs for a SQL query? A `statementId` bound in `SparkOperation` can be accessed in two threads

[GitHub] [spark] SparkQA commented on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

SparkQA commented on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759217758 **[Test build #133997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133997/testReport)** for PR 31165 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

AmplabJenkins removed a comment on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759216349 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133993/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31090: [SPARK-34047][ML] save decisiontree model in single partition

AmplabJenkins removed a comment on pull request #31090: URL: https://github.com/apache/spark/pull/31090#issuecomment-759216351 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31128: [SPARK-28123][SQL] String Functions: support btrim

AmplabJenkins removed a comment on pull request #31128: URL: https://github.com/apache/spark/pull/31128#issuecomment-759216347 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38579/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31150: [SPARK-34086][SQL] RaiseError generates too much code and may fails codegen in length check for char varchar

AmplabJenkins removed a comment on pull request #31150: URL: https://github.com/apache/spark/pull/31150#issuecomment-759216353 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38578/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31144: [SPARK-33690][SQL][FOLLOWUP] Escape further meta-characters in showString

AmplabJenkins removed a comment on pull request #31144: URL: https://github.com/apache/spark/pull/31144#issuecomment-759216350 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133985/

[GitHub] [spark] AmplabJenkins commented on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

AmplabJenkins commented on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759216349 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133993/

[GitHub] [spark] AmplabJenkins commented on pull request #31090: [SPARK-34047][ML] save decisiontree model in single partition

AmplabJenkins commented on pull request #31090: URL: https://github.com/apache/spark/pull/31090#issuecomment-759216351 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #31144: [SPARK-33690][SQL][FOLLOWUP] Escape further meta-characters in showString

AmplabJenkins commented on pull request #31144: URL: https://github.com/apache/spark/pull/31144#issuecomment-759216350 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133985/

[GitHub] [spark] AmplabJenkins commented on pull request #31150: [SPARK-34086][SQL] RaiseError generates too much code and may fails codegen in length check for char varchar

AmplabJenkins commented on pull request #31150: URL: https://github.com/apache/spark/pull/31150#issuecomment-759216353 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38578/

[GitHub] [spark] AmplabJenkins commented on pull request #31128: [SPARK-28123][SQL] String Functions: support btrim

AmplabJenkins commented on pull request #31128: URL: https://github.com/apache/spark/pull/31128#issuecomment-759216347 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38579/

[GitHub] [spark] cloud-fan commented on a change in pull request #31128: [SPARK-28123][SQL] String Functions: support btrim

cloud-fan commented on a change in pull request #31128: URL: https://github.com/apache/spark/pull/31128#discussion_r556270715 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -872,31 +872,21 @@ object StringTrim

[GitHub] [spark] cloud-fan commented on a change in pull request #31128: [SPARK-28123][SQL] String Functions: support btrim

cloud-fan commented on a change in pull request #31128: URL: https://github.com/apache/spark/pull/31128#discussion_r556270557 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -872,31 +872,21 @@ object StringTrim

[GitHub] [spark] LuciferYang commented on a change in pull request #31130: [SPARK-34070][CORE][SQL] Replaces find and emptiness check with exists

LuciferYang commented on a change in pull request #31130: URL: https://github.com/apache/spark/pull/31130#discussion_r556270570 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala ## @@ -272,7 +272,7 @@ private[storage] class

[GitHub] [spark] LantaoJin commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

LantaoJin commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-759213710 > @LantaoJin can you do a bit more manual test with broadcast inside a subquery? Sure, let me have a try.

[GitHub] [spark] SparkQA removed a comment on pull request #31144: [SPARK-33690][SQL][FOLLOWUP] Escape further meta-characters in showString

SparkQA removed a comment on pull request #31144: URL: https://github.com/apache/spark/pull/31144#issuecomment-759126974 **[Test build #133985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133985/testReport)** for PR 31144 at commit

[GitHub] [spark] SparkQA commented on pull request #31144: [SPARK-33690][SQL][FOLLOWUP] Escape further meta-characters in showString

SparkQA commented on pull request #31144: URL: https://github.com/apache/spark/pull/31144#issuecomment-759213534 **[Test build #133985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133985/testReport)** for PR 31144 at commit

[GitHub] [spark] cloud-fan closed pull request #31158: [SPARK-34084][SQL][3.0] Fix auto updating of table stats in `ALTER TABLE .. ADD PARTITION`

cloud-fan closed pull request #31158: URL: https://github.com/apache/spark/pull/31158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31158: [SPARK-34084][SQL][3.0] Fix auto updating of table stats in `ALTER TABLE .. ADD PARTITION`

cloud-fan commented on pull request #31158: URL: https://github.com/apache/spark/pull/31158#issuecomment-759213055 thanks, merging to 3.0! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #31165: [SPARK-34092][SQL] Support Stage level restful api filter task details by task status

SparkQA commented on pull request #31165: URL: https://github.com/apache/spark/pull/31165#issuecomment-759213077 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38581/

[GitHub] [spark] cloud-fan closed pull request #31157: [SPARK-34084][SQL][3.1] Fix auto updating of table stats in `ALTER TABLE .. ADD PARTITION`

cloud-fan closed pull request #31157: URL: https://github.com/apache/spark/pull/31157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31157: [SPARK-34084][SQL][3.1] Fix auto updating of table stats in `ALTER TABLE .. ADD PARTITION`

cloud-fan commented on pull request #31157: URL: https://github.com/apache/spark/pull/31157#issuecomment-759212858 thanks, merging to 3.1! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #31163: [SPARK-34093][ML] param maxDepth should check upper bound

SparkQA commented on pull request #31163: URL: https://github.com/apache/spark/pull/31163#issuecomment-759212331 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38583/

[GitHub] [spark] yaooqinn commented on a change in pull request #30643: [SPARK-33705][SQL][TEST] Fix HiveThriftHttpServerSuite flakiness

yaooqinn commented on a change in pull request #30643: URL: https://github.com/apache/spark/pull/30643#discussion_r556266811 ## File path: project/SparkBuild.scala ## @@ -758,6 +774,15 @@ object Hive { ) } +object YARN { + lazy val settings = Seq( +

[GitHub] [spark] SparkQA commented on pull request #31090: [SPARK-34047][ML] save decisiontree model in single partition

SparkQA commented on pull request #31090: URL: https://github.com/apache/spark/pull/31090#issuecomment-759207765 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38580/

  1   2   3   4   5   6   7   >