[GitHub] [spark] cloud-fan commented on a change in pull request #31329: [SPARK-34229][SQL] Avro should read decimal values with the file schema

cloud-fan commented on a change in pull request #31329: URL: https://github.com/apache/spark/pull/31329#discussion_r564309401 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala ## @@ -169,16 +169,16 @@ private[sql] class

[GitHub] [spark] SparkQA removed a comment on pull request #31335: [SPARK-34232][CORE] Redact SparkListenerEnvironmentUpdate event in log

SparkQA removed a comment on pull request #31335: URL: https://github.com/apache/spark/pull/31335#issuecomment-767305393 **[Test build #134481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134481/testReport)** for PR 31335 at commit

[GitHub] [spark] SparkQA commented on pull request #31335: [SPARK-34232][CORE] Redact SparkListenerEnvironmentUpdate event in log

SparkQA commented on pull request #31335: URL: https://github.com/apache/spark/pull/31335#issuecomment-767369408 **[Test build #134481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134481/testReport)** for PR 31335 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #31319: [SPARK-34212][SQL] Fix incorrect decimal reading from Parquet files

dongjoon-hyun commented on pull request #31319: URL: https://github.com/apache/spark/pull/31319#issuecomment-767368069 For Avro PR, here is the link. - https://github.com/apache/spark/pull/31329#discussion_r564305342 - https://github.com/apache/spark/pull/31329#discussion_r564307326

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31329: [SPARK-34229][SQL] Avro should read decimal values with the file schema

dongjoon-hyun commented on a change in pull request #31329: URL: https://github.com/apache/spark/pull/31329#discussion_r564307326 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala ## @@ -169,16 +169,16 @@ private[sql] class

[GitHub] [spark] SparkQA commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade Parquet to 1.11.1

SparkQA commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-767367295 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39073/

[GitHub] [spark] SparkQA commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

SparkQA commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-767367307 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39071/

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31329: [SPARK-34229][SQL] Avro should read decimal values with the file schema

dongjoon-hyun commented on a change in pull request #31329: URL: https://github.com/apache/spark/pull/31329#discussion_r564305342 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala ## @@ -169,16 +169,16 @@ private[sql] class

[GitHub] [spark] SparkQA commented on pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

SparkQA commented on pull request #31323: URL: https://github.com/apache/spark/pull/31323#issuecomment-767365549 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39069/

[GitHub] [spark] SparkQA removed a comment on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

SparkQA removed a comment on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-767287953 **[Test build #134477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134477/testReport)** for PR 31336 at commit

[GitHub] [spark] SparkQA commented on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

SparkQA commented on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-767364154 **[Test build #134477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134477/testReport)** for PR 31336 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

SparkQA removed a comment on pull request #31323: URL: https://github.com/apache/spark/pull/31323#issuecomment-767287966 **[Test build #134478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134478/testReport)** for PR 31323 at commit

[GitHub] [spark] SparkQA commented on pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

SparkQA commented on pull request #31323: URL: https://github.com/apache/spark/pull/31323#issuecomment-767362642 **[Test build #134478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134478/testReport)** for PR 31323 at commit

[GitHub] [spark] Ngone51 commented on pull request #31298: [SPARK-34193][CORE] TorrentBroadcast block manager decommissioning race fix

Ngone51 commented on pull request #31298: URL: https://github.com/apache/spark/pull/31298#issuecomment-767362213 Thanks for the explanation @holdenk . +1 to address @attilapiros 's suggestion, otherwise LGTM. This is an

[GitHub] [spark] SparkQA commented on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

SparkQA commented on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-767361826 **[Test build #134490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134490/testReport)** for PR 31336 at commit

[GitHub] [spark] SparkQA commented on pull request #31340: [SPARK-34237][SQL] Add more metrics (fallback, spill) to object hash aggregate

SparkQA commented on pull request #31340: URL: https://github.com/apache/spark/pull/31340#issuecomment-767361848 **[Test build #134488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134488/testReport)** for PR 31340 at commit

[GitHub] [spark] SparkQA commented on pull request #31339: [SPARK-34236][SQL] Fix v2 Overwrite w/ null static partition raise Cannot translate expression to source filter: null

SparkQA commented on pull request #31339: URL: https://github.com/apache/spark/pull/31339#issuecomment-767361801 **[Test build #134489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134489/testReport)** for PR 31339 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31335: [SPARK-34232][CORE] Redact SparkListenerEnvironmentUpdate event in log

AmplabJenkins removed a comment on pull request #31335: URL: https://github.com/apache/spark/pull/31335#issuecomment-767356206 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

AmplabJenkins removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767356211 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

AmplabJenkins removed a comment on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-767356216 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134470/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

AmplabJenkins removed a comment on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-767356209 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134476/

[GitHub] [spark] SparkQA commented on pull request #31321: [SPARK-34235][SS] Make spark.sql.hive as a private package

SparkQA commented on pull request #31321: URL: https://github.com/apache/spark/pull/31321#issuecomment-767356490 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39070/

[GitHub] [spark] AmplabJenkins commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

AmplabJenkins commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767356211 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

AmplabJenkins commented on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-767356209 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134476/

[GitHub] [spark] AmplabJenkins commented on pull request #31335: [SPARK-34232][CORE] Redact SparkListenerEnvironmentUpdate event in log

AmplabJenkins commented on pull request #31335: URL: https://github.com/apache/spark/pull/31335#issuecomment-767356217 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

AmplabJenkins commented on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-767356216 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134470/

[GitHub] [spark] SparkQA commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade Parquet to 1.11.1

SparkQA commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-767355969 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39073/

[GitHub] [spark] SparkQA commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

SparkQA commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-767353859 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39071/

[GitHub] [spark] SparkQA removed a comment on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

SparkQA removed a comment on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-767290410 **[Test build #134476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134476/testReport)** for PR 31337 at commit

[GitHub] [spark] SparkQA commented on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

SparkQA commented on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-767353077 **[Test build #134476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134476/testReport)** for PR 31337 at commit

[GitHub] [spark] SparkQA commented on pull request #31335: [SPARK-34232][CORE] Redact SparkListenerEnvironmentUpdate event in log

SparkQA commented on pull request #31335: URL: https://github.com/apache/spark/pull/31335#issuecomment-767348873 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39068/

[GitHub] [spark] yaooqinn commented on a change in pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

yaooqinn commented on a change in pull request #31336: URL: https://github.com/apache/spark/pull/31336#discussion_r564286245 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3957,13 +3957,16 @@ object ApplyCharTypePadding

[GitHub] [spark] SparkQA removed a comment on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

SparkQA removed a comment on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-767242349 **[Test build #134470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134470/testReport)** for PR 31272 at commit

[GitHub] [spark] SparkQA commented on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

SparkQA commented on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-767343780 **[Test build #134470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134470/testReport)** for PR 31272 at commit

[GitHub] [spark] yaooqinn commented on a change in pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

yaooqinn commented on a change in pull request #31336: URL: https://github.com/apache/spark/pull/31336#discussion_r564283274 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3957,13 +3957,16 @@ object ApplyCharTypePadding

[GitHub] [spark] c21 commented on pull request #31340: [SPARK-34237][SQL] Add more metrics (fallback, spill) to object hash aggregate

c21 commented on pull request #31340: URL: https://github.com/apache/spark/pull/31340#issuecomment-767341828 cc @cloud-fan and @sameeragarwal could you help to take a look when you have time? Thanks. This is an automated

[GitHub] [spark] c21 commented on a change in pull request #31340: [SPARK-34237][SQL] Add more metrics (fallback, spill) to object hash aggregate

c21 commented on a change in pull request #31340: URL: https://github.com/apache/spark/pull/31340#discussion_r564282423 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala ## @@ -76,6 +82,11 @@ class

[GitHub] [spark] c21 commented on a change in pull request #31340: [SPARK-34237][SQL] Add more metrics (fallback, spill) to object hash aggregate

c21 commented on a change in pull request #31340: URL: https://github.com/apache/spark/pull/31340#discussion_r564282252 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala ## @@ -57,6 +59,10 @@ class

[GitHub] [spark] c21 commented on a change in pull request #31340: [SPARK-34237][SQL] Add more metrics (fallback, spill) to object hash aggregate

c21 commented on a change in pull request #31340: URL: https://github.com/apache/spark/pull/31340#discussion_r564281952 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala ## @@ -25,7 +25,8 @@ import

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564281472 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala ## @@ -36,8 +37,9 @@ case class

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564281472 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala ## @@ -36,8 +37,9 @@ case class

[GitHub] [spark] yaooqinn commented on a change in pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

yaooqinn commented on a change in pull request #31336: URL: https://github.com/apache/spark/pull/31336#discussion_r564281275 ## File path: sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala ## @@ -146,6 +146,22 @@ trait CharVarcharTestSuite extends

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767339967 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39067/

[GitHub] [spark] c21 opened a new pull request #31340: [SPARK-34237][SQL] Add more metrics (fallback, spill) to object hash aggregate

c21 opened a new pull request #31340: URL: https://github.com/apache/spark/pull/31340 ### What changes were proposed in this pull request? This PR is to add two more metrics for `ObjectHashAggregateExec`, i.e. the spill size, and number of fallback to sort-based aggregation.

[GitHub] [spark] yaooqinn commented on pull request #31339: [SPARK-34236][SQL] Fix v2 Overwrite w/ null static partition raise Cannot translate expression to source filter: null

yaooqinn commented on pull request #31339: URL: https://github.com/apache/spark/pull/31339#issuecomment-767339178 cc @cloud-fan @dongjoon-hyun @HyukjinKwon @maropu thanks for reviewing This is an automated message from the

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31319: [SPARK-34212][SQL] Fix incorrect decimal reading from Parquet files

dongjoon-hyun edited a comment on pull request #31319: URL: https://github.com/apache/spark/pull/31319#issuecomment-767337183 Thanks, @cloud-fan . 1. For vectorized code path, (if we do), we need **adjust** during building columnar vectors. It will cause performance regression like

[GitHub] [spark] yaooqinn opened a new pull request #31339: [SPARK-34236][SQL] Fix v2 Overwrite w/ null static partition raise Cannot translate expression to source filter: null

yaooqinn opened a new pull request #31339: URL: https://github.com/apache/spark/pull/31339 ### What changes were proposed in this pull request? For v2 static partitions overwriting, we use `EqualTo ` to generate the `deleteExpr` This is not right for null partition

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31319: [SPARK-34212][SQL] Fix incorrect decimal reading from Parquet files

dongjoon-hyun edited a comment on pull request #31319: URL: https://github.com/apache/spark/pull/31319#issuecomment-767337183 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #31335: [SPARK-34232][CORE] Redact SparkListenerEnvironmentUpdate event in log

SparkQA commented on pull request #31335: URL: https://github.com/apache/spark/pull/31335#issuecomment-767336039 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39068/

[GitHub] [spark] SparkQA commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

SparkQA commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-767336024 **[Test build #134485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134485/testReport)** for PR 31245 at commit

[GitHub] [spark] SparkQA commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade Parquet to 1.11.1

SparkQA commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-767335521 **[Test build #134487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134487/testReport)** for PR 26804 at commit

[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

SparkQA commented on pull request #31012: URL: https://github.com/apache/spark/pull/31012#issuecomment-767334644 **[Test build #134486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134486/testReport)** for PR 31012 at commit

[GitHub] [spark] SparkQA commented on pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

SparkQA commented on pull request #31323: URL: https://github.com/apache/spark/pull/31323#issuecomment-767334487 **[Test build #134483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134483/testReport)** for PR 31323 at commit

[GitHub] [spark] SparkQA commented on pull request #31321: [SPARK-34235][SS] Make spark.sql.hive as a private package

SparkQA commented on pull request #31321: URL: https://github.com/apache/spark/pull/31321#issuecomment-767334445 **[Test build #134484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134484/testReport)** for PR 31321 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

HyukjinKwon commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564273754 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala ## @@ -36,8 +37,9 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31335: [SPARK-34232][CORE] Redact SparkListenerEnvironmentUpdate event in log

SparkQA commented on pull request #31335: URL: https://github.com/apache/spark/pull/31335#issuecomment-767325478 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39066/

[GitHub] [spark] linhongliu-db edited a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

linhongliu-db edited a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767319118 cc @cloud-fan, this PR is ready for review This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

AmplabJenkins removed a comment on pull request #31323: URL: https://github.com/apache/spark/pull/31323#issuecomment-767324706 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39064/

[GitHub] [spark] AmplabJenkins commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

AmplabJenkins commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767324704 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134473/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

AmplabJenkins removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767324704 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134473/

[GitHub] [spark] AmplabJenkins commented on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

AmplabJenkins commented on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-767324707 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

AmplabJenkins removed a comment on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-767324707 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

AmplabJenkins removed a comment on pull request #31316: URL: https://github.com/apache/spark/pull/31316#issuecomment-767324709 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39065/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

AmplabJenkins removed a comment on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-767324705 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39062/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31317: [SPARK-32852][SQL][FOLLOW_UP] Add notice about keep hive version consistence when config hive jars location

AmplabJenkins removed a comment on pull request #31317: URL: https://github.com/apache/spark/pull/31317#issuecomment-767291305 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #31317: [SPARK-32852][SQL][FOLLOW_UP] Add notice about keep hive version consistence when config hive jars location

AmplabJenkins commented on pull request #31317: URL: https://github.com/apache/spark/pull/31317#issuecomment-767324703 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134472/

[GitHub] [spark] AmplabJenkins commented on pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

AmplabJenkins commented on pull request #31323: URL: https://github.com/apache/spark/pull/31323#issuecomment-767324706 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39064/

[GitHub] [spark] AmplabJenkins commented on pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

AmplabJenkins commented on pull request #31316: URL: https://github.com/apache/spark/pull/31316#issuecomment-767324709 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39065/

[GitHub] [spark] AmplabJenkins commented on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

AmplabJenkins commented on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-767324705 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39062/

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31319: [SPARK-34212][SQL] Fix incorrect decimal reading from Parquet files

dongjoon-hyun commented on a change in pull request #31319: URL: https://github.com/apache/spark/pull/31319#discussion_r564267501 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3868,6 +3868,43 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] imback82 commented on a change in pull request #31325: [SPARK-34227][SQL] WindowFunctionFrame should clear its states during preparation

imback82 commented on a change in pull request #31325: URL: https://github.com/apache/spark/pull/31325#discussion_r564265521 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -299,13 +309,10 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31319: [SPARK-34212][SQL] Fix incorrect decimal reading from Parquet files

dongjoon-hyun commented on a change in pull request #31319: URL: https://github.com/apache/spark/pull/31319#discussion_r564264345 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala ## @@ -268,18 +268,27 @@

[GitHub] [spark] SparkQA removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

SparkQA removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767273696 **[Test build #134473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134473/testReport)** for PR 31286 at commit

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767321168 **[Test build #134473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134473/testReport)** for PR 31286 at commit

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767320955 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39067/

[GitHub] [spark] dongjoon-hyun commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot

dongjoon-hyun commented on pull request #31338: URL: https://github.com/apache/spark/pull/31338#issuecomment-767319952 Thank you so much! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] attilapiros commented on a change in pull request #31298: [SPARK-34193][CORE] TorrentBroadcast block manager decommissioning race fix

attilapiros commented on a change in pull request #31298: URL: https://github.com/apache/spark/pull/31298#discussion_r564250920 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -258,6 +258,17 @@ private[spark] class BlockManager( @inline

[GitHub] [spark] dongjoon-hyun commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot

dongjoon-hyun commented on pull request #31338: URL: https://github.com/apache/spark/pull/31338#issuecomment-767319860 Could you review this, @HyukjinKwon ? I missed this typo in the previous PR. This is an automated message

[GitHub] [spark] HyukjinKwon closed pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot

HyukjinKwon closed pull request #31338: URL: https://github.com/apache/spark/pull/31338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot

HyukjinKwon commented on pull request #31338: URL: https://github.com/apache/spark/pull/31338#issuecomment-767319769 Merged to master. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun opened a new pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot

dongjoon-hyun opened a new pull request #31338: URL: https://github.com/apache/spark/pull/31338 ### What changes were proposed in this pull request? This is a follow-up of #31311 and fixes a typo in Scala 2.13 profile section in `publish-snapshot` command. ### Why are the

[GitHub] [spark] linhongliu-db commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

linhongliu-db commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-767319118 cc @cloud-fan, this PR is ready to review This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

SparkQA commented on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-767318747 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39063/

[GitHub] [spark] cloud-fan commented on pull request #31325: [SPARK-34227][SQL] WindowFunctionFrame should clear its states during preparation

cloud-fan commented on pull request #31325: URL: https://github.com/apache/spark/pull/31325#issuecomment-767314962 @viirya yea it's a master-only bug. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] cloud-fan commented on a change in pull request #31325: [SPARK-34227][SQL] WindowFunctionFrame should clear its states during preparation

cloud-fan commented on a change in pull request #31325: URL: https://github.com/apache/spark/pull/31325#discussion_r564239911 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -299,13 +309,10 @@ class

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564233512 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala ## @@ -36,8 +37,9 @@ case class

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564236924 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala ## @@ -242,8 +242,9 @@ object PROCESS_TABLES

[GitHub] [spark] SparkQA removed a comment on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

SparkQA removed a comment on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-767276616 **[Test build #134475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134475/testReport)** for PR 31336 at commit

[GitHub] [spark] cloud-fan commented on pull request #31319: [SPARK-34212][SQL] Fix incorrect decimal reading from Parquet files

cloud-fan commented on pull request #31319: URL: https://github.com/apache/spark/pull/31319#issuecomment-767313508 I took a quick and it seems hard to fix this in the vectorized reader, so +1 to fail first. My major concern is how do we resolve the schema mismatch between decimal values

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564236924 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala ## @@ -242,8 +242,9 @@ object PROCESS_TABLES

[GitHub] [spark] SparkQA commented on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

SparkQA commented on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-767313317 **[Test build #134475 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134475/testReport)** for PR 31336 at commit

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564233512 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala ## @@ -36,8 +37,9 @@ case class

[GitHub] [spark] xuanyuanking commented on pull request #31321: [SPARK-34235][SS] Make spark.sql.hive as a private package

xuanyuanking commented on pull request #31321: URL: https://github.com/apache/spark/pull/31321#issuecomment-767313161 @HyukjinKwon Oh yeah, sorry for the missing. I filled Jira SPARK-34235 for this. Thanks! This is an

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564235162 ## File path: examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala ## @@ -46,9 +47,7 @@ object DFSReadWriteTest { private val

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564234628 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala ## @@ -243,12 +243,14 @@ object

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564233512 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala ## @@ -36,8 +37,9 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

SparkQA commented on pull request #31337: URL: https://github.com/apache/spark/pull/31337#issuecomment-767312130 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39062/

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564232360 ## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala ## @@ -167,29 +167,31 @@ class

[GitHub] [spark] LuciferYang commented on a change in pull request #31323: [SPARK-34224][CORE][SQL][SS][DSTREAM][YARN][TEST][EXAMPLES] Ensure all resource opened by `Source.fromXXX` are closed

LuciferYang commented on a change in pull request #31323: URL: https://github.com/apache/spark/pull/31323#discussion_r564230679 ## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala ## @@ -167,29 +167,31 @@ class

[GitHub] [spark] SparkQA commented on pull request #31335: [SPARK-34232][CORE] Redact SparkListenerEnvironmentUpdate event in log

SparkQA commented on pull request #31335: URL: https://github.com/apache/spark/pull/31335#issuecomment-767310854 **[Test build #134482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134482/testReport)** for PR 31335 at commit

  1   2   3   4   5   6   7   8   9   10   >