[GitHub] [spark] AmplabJenkins commented on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811665311 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41375/ --

[GitHub] [spark] SparkQA commented on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-03-31 Thread GitBox
SparkQA commented on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811665284 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41375/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
SparkQA commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811665027 **[Test build #136797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136797/testReport)** for PR 32019 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
HyukjinKwon commented on a change in pull request #32019: URL: https://github.com/apache/spark/pull/32019#discussion_r605393073 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryCast.scala ## @@ -30,10 +30,12 @@ import

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
HyukjinKwon commented on a change in pull request #32019: URL: https://github.com/apache/spark/pull/32019#discussion_r605392992 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryCast.scala ## @@ -30,10 +30,12 @@ import

[GitHub] [spark] SparkQA commented on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
SparkQA commented on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811662206 **[Test build #136796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136796/testReport)** for PR 32017 at commit

[GitHub] [spark] viirya commented on a change in pull request #31451: [SPARK-34338][SQL] Report metrics from Datasource v2 scan

2021-03-31 Thread GitBox
viirya commented on a change in pull request #31451: URL: https://github.com/apache/spark/pull/31451#discussion_r605392105 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/PartitionReader.java ## @@ -51,7 +51,8 @@ T get(); /** - * Returns

[GitHub] [spark] gengliangwang commented on a change in pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
gengliangwang commented on a change in pull request #32019: URL: https://github.com/apache/spark/pull/32019#discussion_r605391951 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryCast.scala ## @@ -30,10 +30,12 @@ import

[GitHub] [spark] karenfeng closed pull request #31975: [WIP][SPARK-34527][SQL] Resolve duplicated common columns from USING/NATURAL JOIN

2021-03-31 Thread GitBox
karenfeng closed pull request #31975: URL: https://github.com/apache/spark/pull/31975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811660012 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41376/

[GitHub] [spark] AmplabJenkins commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811660012 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41376/ --

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811659972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-03-31 Thread GitBox
SparkQA commented on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811659949 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41375/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811659269 **[Test build #136795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136795/testReport)** for PR 31179 at commit

[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-03-31 Thread GitBox
SparkQA commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811658915 **[Test build #136794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136794/testReport)** for PR 32010 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811658544 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136788/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811658545 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41374/

[GitHub] [spark] AmplabJenkins commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811658545 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41374/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811658544 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136788/ -- This

[GitHub] [spark] yaooqinn commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-03-31 Thread GitBox
yaooqinn commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811657957 > The tests LGTM. To completely support the char feature, we may need to truly support it in the type system. For example, `upper(char_col)` should also return char type, not

[GitHub] [spark] SparkQA commented on pull request #32019: [WIP][SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
SparkQA commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811652998 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41374/ --

[GitHub] [spark] LuciferYang commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-03-31 Thread GitBox
LuciferYang commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-811642573 Thanks ~ @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] yaooqinn commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions

2021-03-31 Thread GitBox
yaooqinn commented on a change in pull request #32010: URL: https://github.com/apache/spark/pull/32010#discussion_r605378485 ## File path: sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out ## @@ -663,6 +663,478 @@ Location [not included in

[GitHub] [spark] SparkQA removed a comment on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
SparkQA removed a comment on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811598016 **[Test build #136788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136788/testReport)** for PR 32009 at commit

[GitHub] [spark] SparkQA commented on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
SparkQA commented on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811641059 **[Test build #136788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136788/testReport)** for PR 32009 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31451: [SPARK-34338][SQL] Report metrics from Datasource v2 scan

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #31451: URL: https://github.com/apache/spark/pull/31451#discussion_r605374302 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/PartitionReader.java ## @@ -51,7 +51,8 @@ T get(); /** - *

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811635011 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41373/

[GitHub] [spark] SparkQA commented on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-03-31 Thread GitBox
SparkQA commented on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811635030 **[Test build #136793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136793/testReport)** for PR 31989 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811635011 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41373/ --

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811634996 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41373/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32019: [WIP][SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
SparkQA commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811634985 **[Test build #136792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136792/testReport)** for PR 32019 at commit

[GitHub] [spark] cloud-fan commented on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
cloud-fan commented on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811634868 The new behavior makes more sense to me. cc @rdblue @brkyvz @viirya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #32017: URL: https://github.com/apache/spark/pull/32017#discussion_r605372596 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -466,6 +488,8 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811634186 **[Test build #136791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136791/testReport)** for PR 31179 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811633809 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41372/

[GitHub] [spark] AmplabJenkins commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811633809 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41372/ --

[GitHub] [spark] cloud-fan commented on a change in pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #32017: URL: https://github.com/apache/spark/pull/32017#discussion_r605371960 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -270,6 +279,8 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #32017: URL: https://github.com/apache/spark/pull/32017#discussion_r605371792 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -187,6 +193,8 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811633429 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41373/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on a change in pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #32017: URL: https://github.com/apache/spark/pull/32017#discussion_r605371720 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -270,6 +279,8 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #32017: URL: https://github.com/apache/spark/pull/32017#discussion_r605371343 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -107,6 +109,8 @@ case class

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
AngersZh commented on a change in pull request #31179: URL: https://github.com/apache/spark/pull/31179#discussion_r605371258 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala ## @@ -251,7 +252,18 @@ class

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
AngersZh commented on a change in pull request #31179: URL: https://github.com/apache/spark/pull/31179#discussion_r605370937 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala ## @@ -51,6 +51,119 @@ class

[GitHub] [spark] cloud-fan commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions

2021-03-31 Thread GitBox
cloud-fan commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811632116 The tests LGTM. To completely support the char feature, we may need to truly support it in the type system. For example, `upper(char_col)` should also return char type, not

[GitHub] [spark] SparkQA commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
SparkQA commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811631196 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41372/ --

[GitHub] [spark] cloud-fan commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #32010: URL: https://github.com/apache/spark/pull/32010#discussion_r605368101 ## File path: sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out ## @@ -663,6 +663,478 @@ Location [not included in

[GitHub] [spark] cloud-fan commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #32010: URL: https://github.com/apache/spark/pull/32010#discussion_r605367754 ## File path: sql/core/src/test/resources/sql-tests/inputs/charvarchar.sql ## @@ -61,7 +61,57 @@ desc formatted char_part; MSCK REPAIR TABLE

[GitHub] [spark] cloud-fan commented on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-03-31 Thread GitBox
cloud-fan commented on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811627745 The change LGTM. Can we re-generate the golden files to fix conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon opened a new pull request #32019: [WIP][SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-03-31 Thread GitBox
HyukjinKwon opened a new pull request #32019: URL: https://github.com/apache/spark/pull/32019 ### What changes were proposed in this pull request? This PR fixes JDK 11 compilation failed: ```

[GitHub] [spark] HeartSaVioR commented on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-03-31 Thread GitBox
HeartSaVioR commented on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811622439 retest this, please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811619794 **[Test build #136790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136790/testReport)** for PR 31179 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-03-31 Thread GitBox
HyukjinKwon commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-811619057 SPARK-34930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] HyukjinKwon commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-03-31 Thread GitBox
HyukjinKwon commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-811618571 I think we should install pandas / pyarrow in jenkins machines: ``` Skipped tests in pyspark.sql.tests.test_arrow with pypy3:

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-03-31 Thread GitBox
AngersZh commented on a change in pull request #31179: URL: https://github.com/apache/spark/pull/31179#discussion_r605358714 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala ## @@ -51,6 +51,119 @@ class

[GitHub] [spark] HyukjinKwon commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-03-31 Thread GitBox
HyukjinKwon commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-811617873 Just for a bit of more contexts, ever since Jenkins were upgraded, we didn't install pandas, etc so we don't run the pandas in Jenkins. The pandas related tests only run on

[GitHub] [spark] HyukjinKwon edited a comment on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-03-31 Thread GitBox
HyukjinKwon edited a comment on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-811617659 I think the last trigger didn't pass in this PR: ![Screen Shot 2021-04-01 at 12 49 52

[GitHub] [spark] Ngone51 edited a comment on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-03-31 Thread GitBox
Ngone51 edited a comment on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-811617535 Is the failure from the latest run? I tested the same failed test locally yesterday and passed, and so I retriggered the GA. -- This is an automated message from the

[GitHub] [spark] HyukjinKwon commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-03-31 Thread GitBox
HyukjinKwon commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-811617659 I think the last trigger didn't pass in this PR: ![Uploading Screen Shot 2021-04-01 at 12.49.52 PM.png…]() -- This is an automated message from the Apache Git

[GitHub] [spark] Ngone51 commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-03-31 Thread GitBox
Ngone51 commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-811617535 Is the failure from the latest run? I tested it locally yesterday and passed, and so I retriggered the GA. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
SparkQA commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811617005 **[Test build #136789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136789/testReport)** for PR 32015 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-03-31 Thread GitBox
HyukjinKwon commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-811616745 It seems it broke PySpark tests ... https://github.com/apache/spark/runs/2240195852 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811616047 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41370/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811616050 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41371/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811616048 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136784/

[GitHub] [spark] AmplabJenkins commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811616047 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41370/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811616050 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41371/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811616048 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136784/ -- This

[GitHub] [spark] SparkQA commented on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
SparkQA commented on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811612908 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41371/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
SparkQA commented on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811611447 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41371/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-03-31 Thread GitBox
SparkQA commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811610688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] HyukjinKwon edited a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
HyukjinKwon edited a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811064987 Note that I tested subset of benchmarks, verified that it works, and now I am waiting for the final results of running all benchmarks: - [Run benchmarks: * (JDK

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605349110 ## File path: core/src/test/scala/org/apache/spark/benchmark/Benchmarks.scala ## @@ -30,44 +31,64 @@ import com.google.common.reflect.ClassPath *

[GitHub] [spark] HyukjinKwon edited a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
HyukjinKwon edited a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811064987 Note that I tested subset of benchmarks, verified that it works, and now I am waiting for the final results of running all benchmarks: - [Run benchmarks: * (JDK

[GitHub] [spark] wangyum commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
wangyum commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605346227 ## File path: .github/workflows/benchmark.yml ## @@ -0,0 +1,68 @@ +name: Run benchmarks + +on: + workflow_dispatch: +inputs: + class: +

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605345844 ## File path: .github/workflows/benchmark.yml ## @@ -0,0 +1,68 @@ +name: Run benchmarks + +on: + workflow_dispatch: +inputs: + class: +

[GitHub] [spark] SparkQA removed a comment on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
SparkQA removed a comment on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811514173 **[Test build #136784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136784/testReport)** for PR 32017 at commit

[GitHub] [spark] SparkQA commented on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-03-31 Thread GitBox
SparkQA commented on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811602003 **[Test build #136784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136784/testReport)** for PR 32017 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605344146 ## File path: .github/workflows/benchmark.yml ## @@ -0,0 +1,68 @@ +name: Run benchmarks + +on: + workflow_dispatch: +inputs: + class: +

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605343992 ## File path: core/src/test/scala/org/apache/spark/benchmark/Benchmarks.scala ## @@ -78,8 +99,12 @@ object Benchmarks { // Maven build

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605343862 ## File path: core/src/test/scala/org/apache/spark/benchmark/Benchmarks.scala ## @@ -78,8 +99,12 @@ object Benchmarks { // Maven build

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605343535 ## File path: core/src/test/scala/org/apache/spark/benchmark/Benchmarks.scala ## @@ -30,44 +31,64 @@ import com.google.common.reflect.ClassPath *

[GitHub] [spark] AngersZhuuuu commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-03-31 Thread GitBox
AngersZh commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811600763 ping @MaxGekk Since your pr make partition value support value as `null`, here I think we need to handle null value and I meet this in

[GitHub] [spark] SparkQA commented on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
SparkQA commented on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811598016 **[Test build #136788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136788/testReport)** for PR 32009 at commit

[GitHub] [spark] SparkQA commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-03-31 Thread GitBox
SparkQA commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811597991 **[Test build #136787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136787/testReport)** for PR 32018 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #24559: URL: https://github.com/apache/spark/pull/24559#issuecomment-811596875 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136783/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811596876 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41369/

[GitHub] [spark] AmplabJenkins commented on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811596876 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41369/ --

[GitHub] [spark] AmplabJenkins commented on pull request #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #24559: URL: https://github.com/apache/spark/pull/24559#issuecomment-811596875 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136783/ -- This

[GitHub] [spark] yaooqinn commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions

2021-03-31 Thread GitBox
yaooqinn commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811596632 cc @cloud-fan @HyukjinKwon thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AngersZhuuuu opened a new pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-03-31 Thread GitBox
AngersZh opened a new pull request #32018: URL: https://github.com/apache/spark/pull/32018 ### What changes were proposed in this pull request? ExternalCatalogUtils.escapePathName should support null ### Why are the changes needed? ExternalCatalogUtils.escapePathName

[GitHub] [spark] wangyum commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-03-31 Thread GitBox
wangyum commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605336056 ## File path: .github/workflows/benchmark.yml ## @@ -0,0 +1,68 @@ +name: Run benchmarks + +on: + workflow_dispatch: +inputs: + class: +

[GitHub] [spark] ulysses-you commented on pull request #32009: [SPARK-34914][CORE] Local scheduler backend support update token

2021-03-31 Thread GitBox
ulysses-you commented on pull request #32009: URL: https://github.com/apache/spark/pull/32009#issuecomment-811591207 > NOte that if we decide to support this we should document exactly what is and what is not supported: http://spark.apache.org/docs/latest/security.html#kerberos

[GitHub] [spark] SparkQA commented on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-03-31 Thread GitBox
SparkQA commented on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811591016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2021-03-31 Thread GitBox
SparkQA removed a comment on pull request #24559: URL: https://github.com/apache/spark/pull/24559#issuecomment-811487701 **[Test build #136783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136783/testReport)** for PR 24559 at commit

[GitHub] [spark] SparkQA commented on pull request #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2021-03-31 Thread GitBox
SparkQA commented on pull request #24559: URL: https://github.com/apache/spark/pull/24559#issuecomment-811585210 **[Test build #136783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136783/testReport)** for PR 24559 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31666: [SPARK-34527][SQL] Resolve duplicated common columns from USING/NATURAL JOIN

2021-03-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31666: URL: https://github.com/apache/spark/pull/31666#issuecomment-811579868 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136785/

[GitHub] [spark] AmplabJenkins commented on pull request #31666: [SPARK-34527][SQL] Resolve duplicated common columns from USING/NATURAL JOIN

2021-03-31 Thread GitBox
AmplabJenkins commented on pull request #31666: URL: https://github.com/apache/spark/pull/31666#issuecomment-811579868 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136785/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #31666: [SPARK-34527][SQL] Resolve duplicated common columns from USING/NATURAL JOIN

2021-03-31 Thread GitBox
SparkQA removed a comment on pull request #31666: URL: https://github.com/apache/spark/pull/31666#issuecomment-811535839 **[Test build #136785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136785/testReport)** for PR 31666 at commit

[GitHub] [spark] SparkQA commented on pull request #31666: [SPARK-34527][SQL] Resolve duplicated common columns from USING/NATURAL JOIN

2021-03-31 Thread GitBox
SparkQA commented on pull request #31666: URL: https://github.com/apache/spark/pull/31666#issuecomment-811579710 **[Test build #136785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136785/testReport)** for PR 31666 at commit

[GitHub] [spark] SparkQA commented on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-03-31 Thread GitBox
SparkQA commented on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811578298 **[Test build #136786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136786/testReport)** for PR 32012 at commit

  1   2   3   4   5   6   >