[GitHub] [spark] HyukjinKwon commented on a change in pull request #32161: [SPARK-35025][SQL][PYTHON][DOCS] Move Parquet data source options from Python and Scala into a single page.

2021-05-19 Thread GitBox
HyukjinKwon commented on a change in pull request #32161: URL: https://github.com/apache/spark/pull/32161#discussion_r635788033 ## File path: docs/sql-data-sources-parquet.md ## @@ -260,6 +260,12 @@ Data source options of Parquet can be set via: Property

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844699781 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138722/

[GitHub] [spark] AmplabJenkins commented on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844724760 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844699823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] ulysses-you opened a new pull request #32602: [SPARK-35455][SQL] Enhance EliminateUnnecessaryJoin

2021-05-19 Thread GitBox
ulysses-you opened a new pull request #32602: URL: https://github.com/apache/spark/pull/32602 ### What changes were proposed in this pull request? - Add semi / anti elimination check if left side is empty. - Add outer join elimination check if left

[GitHub] [spark] SparkQA commented on pull request #32600: [SPARK-35456][CORE] Print the invalid value in config validation error message

2021-05-19 Thread GitBox
SparkQA commented on pull request #32600: URL: https://github.com/apache/spark/pull/32600#issuecomment-844723643 **[Test build #138729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138729/testReport)** for PR 32600 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32601: [SPARK-35130][SQL] Add make_duration function to construct DayTimeIntervalType value

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32601: URL: https://github.com/apache/spark/pull/32601#issuecomment-844721318 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844721237 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138726/ -- This

[GitHub] [spark] HyukjinKwon commented on pull request #30404: [SPARK-33475][BUILD] Bump ANTLR runtime version to 4.8-1

2021-05-19 Thread GitBox
HyukjinKwon commented on pull request #30404: URL: https://github.com/apache/spark/pull/30404#issuecomment-844716174 Maybe let's just use the 4.8 that's matched with the official releases there ... Thanks for pointing this out, @bozhang2820. Mind making a quick followup to match

[GitHub] [spark] HyukjinKwon commented on pull request #30404: [SPARK-33475][BUILD] Bump ANTLR runtime version to 4.8-1

2021-05-19 Thread GitBox
HyukjinKwon commented on pull request #30404: URL: https://github.com/apache/spark/pull/30404#issuecomment-844713306 Just quick question: Do you guys know the diff between 4.8-1 vs 4.8? The official release seems to be 4.8 https://www.antlr.org/download/index.html - I checked the

[GitHub] [spark] dongjoon-hyun commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
dongjoon-hyun commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844713151 +1, LGTM. Thanks, @ueshin and @HyukjinKwon . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] allisonwang-db commented on a change in pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-19 Thread GitBox
allisonwang-db commented on a change in pull request #32478: URL: https://github.com/apache/spark/pull/32478#discussion_r635773423 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala ## @@ -1451,4 +1454,146 @@ private[spark]

[GitHub] [spark] xuanyuanking commented on pull request #32136: [SPARK-35022][CORE] Task Scheduling Plugin in Spark

2021-05-19 Thread GitBox
xuanyuanking commented on pull request #32136: URL: https://github.com/apache/spark/pull/32136#issuecomment-844712368 After reviewing the SPIP doc and the WIP implementation, I think it's a reasonable requirement and scenario for SS. Since the API will be added to Spark Core, we might

[GitHub] [spark] linhongliu-db commented on a change in pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-19 Thread GitBox
linhongliu-db commented on a change in pull request #32587: URL: https://github.com/apache/spark/pull/32587#discussion_r635776715 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java ## @@ -144,6 +155,11 @@ public

[GitHub] [spark] copperybean opened a new pull request #32601: [SPARK-35130][SQL] Add make_duration function to construct DayTimeIntervalType value

2021-05-19 Thread GitBox
copperybean opened a new pull request #32601: URL: https://github.com/apache/spark/pull/32601 ### What changes were proposed in this pull request? Providing a new function make_duration to construct DayTimeIntervalType value ### Why are the changes needed? As the JIRA

[GitHub] [spark] SparkQA removed a comment on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA removed a comment on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844644163 **[Test build #138726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138726/testReport)** for PR 32516 at commit

[GitHub] [spark] yaooqinn opened a new pull request #32600: [SPARK-35456][CORE] Print the invalid value in config validation error message

2021-05-19 Thread GitBox
yaooqinn opened a new pull request #32600: URL: https://github.com/apache/spark/pull/32600 ### What changes were proposed in this pull request? Print the invalid value in config validation error message for `checkValue` just like `checkValues` ### Why are the changes needed?

[GitHub] [spark] viirya commented on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
viirya commented on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844705907 cc @maropu @cloud-fan too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] SparkQA commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844705593 **[Test build #138726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138726/testReport)** for PR 32516 at commit

[GitHub] [spark] wangyum commented on a change in pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-19 Thread GitBox
wangyum commented on a change in pull request #32563: URL: https://github.com/apache/spark/pull/32563#discussion_r635773394 ## File path: sql/core/src/test/resources/sql-tests/results/show-tables.sql.out ## @@ -120,19 +120,9 @@ show_t3 -- !query SHOW TABLE EXTENDED LIKE

[GitHub] [spark] wangyum commented on a change in pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-19 Thread GitBox
wangyum commented on a change in pull request #32563: URL: https://github.com/apache/spark/pull/32563#discussion_r635771768 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -314,21 +315,27 @@ case class

[GitHub] [spark] Ngone51 commented on pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-19 Thread GitBox
Ngone51 commented on pull request #32287: URL: https://github.com/apache/spark/pull/32287#issuecomment-844702300 Thank you, everyone!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844699823 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43250/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844699781 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138722/ -- This

[GitHub] [spark] SparkQA commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844699807 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43250/ -- This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-19 Thread GitBox
dongjoon-hyun commented on pull request #32287: URL: https://github.com/apache/spark/pull/32287#issuecomment-844699111 Sorry for missing ping here. +1, late LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] SparkQA removed a comment on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
SparkQA removed a comment on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844598185 **[Test build #138722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138722/testReport)** for PR 32595 at commit

[GitHub] [spark] SparkQA commented on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
SparkQA commented on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844698658 **[Test build #138722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138722/testReport)** for PR 32595 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844691139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] viirya commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-19 Thread GitBox
viirya commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-844693655 Thanks @HeartSaVioR. I will take another look with #32582 tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844691139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] cloud-fan commented on a change in pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-19 Thread GitBox
cloud-fan commented on a change in pull request #32563: URL: https://github.com/apache/spark/pull/32563#discussion_r635761625 ## File path: sql/core/src/test/resources/sql-tests/results/show-tables.sql.out ## @@ -120,19 +120,9 @@ show_t3 -- !query SHOW TABLE EXTENDED LIKE

[GitHub] [spark] cloud-fan commented on a change in pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-19 Thread GitBox
cloud-fan commented on a change in pull request #32563: URL: https://github.com/apache/spark/pull/32563#discussion_r635760696 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -314,21 +315,27 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #32590: [SPARK-35445][SQL] Reduce the execution time of DeduplicateRelations

2021-05-19 Thread GitBox
maropu commented on a change in pull request #32590: URL: https://github.com/apache/spark/pull/32590#discussion_r635670349 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeduplicateRelations.scala ## @@ -67,61 +81,78 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-19 Thread GitBox
cloud-fan commented on a change in pull request #32563: URL: https://github.com/apache/spark/pull/32563#discussion_r635760348 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -314,21 +315,27 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #32590: [SPARK-35445][SQL] Reduce the execution time of DeduplicateRelations

2021-05-19 Thread GitBox
cloud-fan commented on a change in pull request #32590: URL: https://github.com/apache/spark/pull/32590#discussion_r635759716 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeduplicateRelations.scala ## @@ -67,61 +81,78 @@ object

[GitHub] [spark] SparkQA commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844681278 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43250/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-19 Thread GitBox
cloud-fan commented on pull request #32287: URL: https://github.com/apache/spark/pull/32287#issuecomment-844676584 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] dongjoon-hyun commented on pull request #32588: [SPARK-35443][K8S] Mark K8s ConfigMaps and Secrets created by Spark as immutable

2021-05-19 Thread GitBox
dongjoon-hyun commented on pull request #32588: URL: https://github.com/apache/spark/pull/32588#issuecomment-844676646 Thank you for your first contribution. I added you to the Apache Spark contributor group and assigned SPARK-35443 to you. Welcome! @ashrayjain -- This is an

[GitHub] [spark] cloud-fan closed pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-19 Thread GitBox
cloud-fan closed pull request #32287: URL: https://github.com/apache/spark/pull/32287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] dongjoon-hyun closed pull request #32588: [SPARK-35443][K8S] Mark K8s ConfigMaps and Secrets created by Spark as immutable

2021-05-19 Thread GitBox
dongjoon-hyun closed pull request #32588: URL: https://github.com/apache/spark/pull/32588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] SparkQA removed a comment on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA removed a comment on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844666931 **[Test build #138728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138728/testReport)** for PR 32516 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #32588: [SPARK-35443][K8S] Mark K8s ConfigMaps and Secrets created by Spark as immutable

2021-05-19 Thread GitBox
dongjoon-hyun commented on pull request #32588: URL: https://github.com/apache/spark/pull/32588#issuecomment-844674916 Thank you for making a contribution, @ashrayjain . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] dongjoon-hyun commented on pull request #32588: [SPARK-35443][K8S] Mark K8s ConfigMaps and Secrets created by Spark as immutable

2021-05-19 Thread GitBox
dongjoon-hyun commented on pull request #32588: URL: https://github.com/apache/spark/pull/32588#issuecomment-844674819 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844674783 **[Test build #138728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138728/testReport)** for PR 32516 at commit

[GitHub] [spark] SparkQA commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844672135 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43248/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32513: [SPARK-35378][SQL] Eagerly execute Command so that query command with CTE

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32513: URL: https://github.com/apache/spark/pull/32513#issuecomment-844670814 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43249/

[GitHub] [spark] AmplabJenkins commented on pull request #32513: [SPARK-35378][SQL] Eagerly execute Command so that query command with CTE

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32513: URL: https://github.com/apache/spark/pull/32513#issuecomment-844670814 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43249/ --

[GitHub] [spark] SparkQA commented on pull request #32513: [SPARK-35378][SQL] Eagerly execute Command so that query command with CTE

2021-05-19 Thread GitBox
SparkQA commented on pull request #32513: URL: https://github.com/apache/spark/pull/32513#issuecomment-844670801 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43249/ -- This is an automated message from the

[GitHub] [spark] cfmcgrady commented on a change in pull request #32488: [SPARK-35316][SQL] UnwrapCastInBinaryComparison support In predicate

2021-05-19 Thread GitBox
cfmcgrady commented on a change in pull request #32488: URL: https://github.com/apache/spark/pull/32488#discussion_r635736572 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -89,10 +89,11 @@ import

[GitHub] [spark] SparkQA removed a comment on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA removed a comment on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844603936 **[Test build #138725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138725/testReport)** for PR 32597 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844665541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844665543 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138721/

[GitHub] [spark] SparkQA commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844666931 **[Test build #138728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138728/testReport)** for PR 32516 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-84485 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138725/ -- This

[GitHub] [spark] SparkQA commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844666111 **[Test build #138725 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138725/testReport)** for PR 32597 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844665543 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138721/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844665542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA removed a comment on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844602397 **[Test build #138723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138723/testReport)** for PR 32597 at commit

[GitHub] [spark] SparkQA commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844663190 **[Test build #138723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138723/testReport)** for PR 32597 at commit

[GitHub] [spark] SparkQA commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844661572 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43248/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32513: [SPARK-35378][SQL] Eagerly execute Command so that query command with CTE

2021-05-19 Thread GitBox
SparkQA commented on pull request #32513: URL: https://github.com/apache/spark/pull/32513#issuecomment-844660785 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43249/ -- This is an automated message from the Apache

[GitHub] [spark] YuzhouSun commented on pull request #32530: [SPARK-35106][Core][SQL] Avoid failing rename caused by destination directory not exist

2021-05-19 Thread GitBox
YuzhouSun commented on pull request #32530: URL: https://github.com/apache/spark/pull/32530#issuecomment-844660497 > @YuzhouSun can you leave a comment in the JIRA ticket so that I can assign it to you? Thank you. Done. -- This is an automated message from the Apache Git Service.

[GitHub] [spark] HeartSaVioR commented on a change in pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-19 Thread GitBox
HeartSaVioR commented on a change in pull request #32272: URL: https://github.com/apache/spark/pull/32272#discussion_r635722361 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed

[GitHub] [spark] SparkQA removed a comment on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA removed a comment on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844598119 **[Test build #138720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138720/testReport)** for PR 32597 at commit

[GitHub] [spark] SparkQA commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844652948 **[Test build #138720 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138720/testReport)** for PR 32597 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
SparkQA removed a comment on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844598150 **[Test build #138721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138721/testReport)** for PR 32596 at commit

[GitHub] [spark] SparkQA commented on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
SparkQA commented on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844652391 **[Test build #138721 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138721/testReport)** for PR 32596 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844621608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844643740 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43244/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844643742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
SparkQA commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844644163 **[Test build #138726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138726/testReport)** for PR 32516 at commit

[GitHub] [spark] SparkQA commented on pull request #32513: [SPARK-35378][SQL] Eagerly execute Command so that query command with CTE

2021-05-19 Thread GitBox
SparkQA commented on pull request #32513: URL: https://github.com/apache/spark/pull/32513#issuecomment-844644199 **[Test build #138727 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138727/testReport)** for PR 32513 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844643743 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43245/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844643740 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43244/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844643744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] ueshin closed pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
ueshin closed pull request #32596: URL: https://github.com/apache/spark/pull/32596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] cloud-fan commented on a change in pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-19 Thread GitBox
cloud-fan commented on a change in pull request #32587: URL: https://github.com/apache/spark/pull/32587#discussion_r635709224 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java ## @@ -144,6 +155,11 @@ public ExpressionInfo(

[GitHub] [spark] ueshin commented on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
ueshin commented on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844641911 Thanks! merging to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] ueshin commented on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
ueshin commented on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844641598 I also confirmed the `lint-python` passes with the latest master branch merged. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] itholic commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
itholic commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844637725 Thanks for the review, @ueshin , @xinrong-databricks ! > What about `koalas` accessor? Maybe in the following PR? Yeah, I just created new JIRA for this :

[GitHub] [spark] itholic edited a comment on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
itholic edited a comment on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-844637725 Thanks for the review, @ueshin , @xinrong-databricks ! > What about `koalas` accessor? Maybe in the following PR? Yeah, I just created new JIRA for this :

[GitHub] [spark] beliefer commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-19 Thread GitBox
beliefer commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-844636986 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844636592 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43246/ -- This is an automated message from the

[GitHub] [spark] itholic commented on a change in pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-19 Thread GitBox
itholic commented on a change in pull request #32516: URL: https://github.com/apache/spark/pull/32516#discussion_r635704467 ## File path: python/pyspark/pandas/tests/test_dataframe_conversion.py ## @@ -101,69 +101,69 @@ def test_to_excel(self): koalas_location =

[GitHub] [spark] SparkQA commented on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
SparkQA commented on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844634213 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43245/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844629172 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43243/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
SparkQA commented on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844629074 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43244/ -- This is an automated message from the

[GitHub] [spark] linhongliu-db commented on pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-19 Thread GitBox
linhongliu-db commented on pull request #32587: URL: https://github.com/apache/spark/pull/32587#issuecomment-844613482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] Ngone51 commented on pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-19 Thread GitBox
Ngone51 commented on pull request #32287: URL: https://github.com/apache/spark/pull/32287#issuecomment-844624889 @mridulm I already rebased against that PR :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] SparkQA commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844622897 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43246/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #32598: [SPARK-35408][PYTHON][FOLLOW-UP] Avoid unnecessary f-string format

2021-05-19 Thread GitBox
SparkQA removed a comment on pull request #32598: URL: https://github.com/apache/spark/pull/32598#issuecomment-844603941 **[Test build #138724 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138724/testReport)** for PR 32598 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844620229 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43242/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32598: [SPARK-35408][PYTHON][FOLLOW-UP] Avoid unnecessary f-string format

2021-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32598: URL: https://github.com/apache/spark/pull/32598#issuecomment-844620225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32597: [SPARK-35450][INFRA] Follow checkout-merge way to use the latest commit for linter, or other workflows.

2021-05-19 Thread GitBox
SparkQA commented on pull request #32597: URL: https://github.com/apache/spark/pull/32597#issuecomment-844615958 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43243/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #32595: [SPARK-35449][SQL] Only extract common expressions from CaseWhen values if elseValue is set

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32595: URL: https://github.com/apache/spark/pull/32595#issuecomment-844621608 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] SparkQA commented on pull request #32598: [SPARK-35408][PYTHON][FOLLOW-UP] Avoid unnecessary f-string format

2021-05-19 Thread GitBox
SparkQA commented on pull request #32598: URL: https://github.com/apache/spark/pull/32598#issuecomment-844614658 **[Test build #138724 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138724/testReport)** for PR 32598 at commit

[GitHub] [spark] SparkQA commented on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
SparkQA commented on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844615375 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43244/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #32598: [SPARK-35408][PYTHON][FOLLOW-UP] Avoid unnecessary f-string format

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32598: URL: https://github.com/apache/spark/pull/32598#issuecomment-844620226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins commented on pull request #32596: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-19 Thread GitBox
AmplabJenkins commented on pull request #32596: URL: https://github.com/apache/spark/pull/32596#issuecomment-844620229 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43242/ --

  1   2   3   4   5   >