[GitHub] [spark] AmplabJenkins removed a comment on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871508305 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44955/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871508306 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140439/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871508305 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44955/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871508306 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140439/ -- This

[GitHub] [spark] viirya commented on a change in pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
viirya commented on a change in pull request #33142: URL: https://github.com/apache/spark/pull/33142#discussion_r661590120 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -135,33 +125,47 @@ class EquivalentE

[GitHub] [spark] Shockang commented on a change in pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-06-30 Thread GitBox
Shockang commented on a change in pull request #33101: URL: https://github.com/apache/spark/pull/33101#discussion_r661587935 ## File path: core/src/main/scala/org/apache/spark/util/Utils.scala ## @@ -310,15 +306,17 @@ private[spark] object Utils extends Logging { while (di

[GitHub] [spark] viirya commented on a change in pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
viirya commented on a change in pull request #33142: URL: https://github.com/apache/spark/pull/33142#discussion_r661588066 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -93,25 +72,36 @@ class EquivalentExp

[GitHub] [spark] SparkQA commented on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871505039 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44960/ -- This is an automated message from the Apache

[GitHub] [spark] xkrogen commented on a change in pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-06-30 Thread GitBox
xkrogen commented on a change in pull request #33101: URL: https://github.com/apache/spark/pull/33101#discussion_r661581188 ## File path: core/src/main/scala/org/apache/spark/util/Utils.scala ## @@ -310,15 +306,17 @@ private[spark] object Utils extends Logging { while (dir

[GitHub] [spark] SparkQA commented on pull request #32933: [SPARK-35785][SS] Cleanup support for RocksDB instance

2021-06-30 Thread GitBox
SparkQA commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871501503 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44958/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
SparkQA commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871500313 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44959/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33156: [SPARK-35953][SQL] Support extracting date fields from timestamp without time zone

2021-06-30 Thread GitBox
SparkQA commented on pull request #33156: URL: https://github.com/apache/spark/pull/33156#issuecomment-871498937 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44954/ -- This is an automated message from the Apache

[GitHub] [spark] Shockang commented on a change in pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-06-30 Thread GitBox
Shockang commented on a change in pull request #33101: URL: https://github.com/apache/spark/pull/33101#discussion_r661579528 ## File path: core/src/main/scala/org/apache/spark/util/Utils.scala ## @@ -285,13 +285,10 @@ private[spark] object Utils extends Logging { */ def

[GitHub] [spark] SparkQA commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871497534 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44955/ -- This

[GitHub] [spark] holdenk commented on pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

2021-06-30 Thread GitBox
holdenk commented on pull request #33155: URL: https://github.com/apache/spark/pull/33155#issuecomment-871496903 Jenkins ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661576649 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala ## @@ -1243,6 +1244,214 @@ class FlatMapGroupsWithSta

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661575428 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala ## @@ -1243,6 +1244,214 @@ class FlatMapGroupsWithSta

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661576112 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala ## @@ -1243,6 +1244,214 @@ class FlatMapGroupsWithSta

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661575428 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala ## @@ -1243,6 +1244,214 @@ class FlatMapGroupsWithSta

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661575111 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala ## @@ -1243,6 +1244,214 @@ class FlatMapGroupsWithSta

[GitHub] [spark] Kimahriman commented on a change in pull request #32987: [SPARK-35564][SQL] Support subexpression elimination for conditionally evaluated expressions

2021-06-30 Thread GitBox
Kimahriman commented on a change in pull request #32987: URL: https://github.com/apache/spark/pull/32987#discussion_r661573860 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -134,24 +154,18 @@ class Equival

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661573794 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala ## @@ -1243,6 +1244,214 @@ class FlatMapGroupsWithSta

[GitHub] [spark] gengliangwang edited a comment on pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

2021-06-30 Thread GitBox
gengliangwang edited a comment on pull request #33155: URL: https://github.com/apache/spark/pull/33155#issuecomment-871492807 @pingsutw Thanks for the fix. cc @holdenk @dongjoon-hyun @BryanCutler -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [spark] gengliangwang commented on pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

2021-06-30 Thread GitBox
gengliangwang commented on pull request #33155: URL: https://github.com/apache/spark/pull/33155#issuecomment-871492807 Thanks for the fix. cc @holdenk @dongjoon-hyun @BryanCutler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [spark] Kimahriman commented on a change in pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
Kimahriman commented on a change in pull request #33142: URL: https://github.com/apache/spark/pull/33142#discussion_r661573328 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -135,33 +125,47 @@ class Equival

[GitHub] [spark] venkata91 commented on a change in pull request #33034: WIP: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle

2021-06-30 Thread GitBox
venkata91 commented on a change in pull request #33034: URL: https://github.com/apache/spark/pull/33034#discussion_r661572858 ## File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java ## @@ -222,7 +223,7 @@ public void sendMergedBlo

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661571317 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -250,6 +370,63 @@ case class FlatMapGr

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661569762 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -178,6 +257,47 @@ case class FlatMapGr

[GitHub] [spark] gengliangwang commented on a change in pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

2021-06-30 Thread GitBox
gengliangwang commented on a change in pull request #33155: URL: https://github.com/apache/spark/pull/33155#discussion_r661568732 ## File path: core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html ## @@ -128,7 +128,7 @@ Executors Shuffl

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661566959 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -250,6 +370,63 @@ case class FlatMapGr

[GitHub] [spark] SparkQA removed a comment on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871288343 **[Test build #140439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140439/testReport)** for PR 32883 at commit [`7666145`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
SparkQA commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871486875 **[Test build #140439 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140439/testReport)** for PR 32883 at commit [`7666145`](https://github.co

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661565073 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -178,6 +257,47 @@ case class FlatMapGr

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661565251 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -178,6 +257,47 @@ case class FlatMapGr

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661565073 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -178,6 +257,47 @@ case class FlatMapGr

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661564195 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -178,6 +257,47 @@ case class FlatMapGr

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661562142 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -178,6 +257,47 @@ case class FlatMapGr

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661561469 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -178,6 +257,47 @@ case class FlatMapGr

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661559629 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -101,51 +172,48 @@ case class FlatMapG

[GitHub] [spark] SparkQA removed a comment on pull request #32934: [WIP][SPARK-35788][SS] Metrics support for RocksDB instance

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #32934: URL: https://github.com/apache/spark/pull/32934#issuecomment-871467798 **[Test build #140447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140447/testReport)** for PR 32934 at commit [`1dfe279`](https://gi

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661556881 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -101,51 +172,48 @@ case class FlatMapG

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661555856 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -39,45 +42,63 @@ import org.apache.spa

[GitHub] [spark] SparkQA commented on pull request #32934: [WIP][SPARK-35788][SS] Metrics support for RocksDB instance

2021-06-30 Thread GitBox
SparkQA commented on pull request #32934: URL: https://github.com/apache/spark/pull/32934#issuecomment-871471055 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44961/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32934: [WIP][SPARK-35788][SS] Metrics support for RocksDB instance

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #32934: URL: https://github.com/apache/spark/pull/32934#issuecomment-871471087 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44961/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32934: [WIP][SPARK-35788][SS] Metrics support for RocksDB instance

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #32934: URL: https://github.com/apache/spark/pull/32934#issuecomment-871469501 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140447/ -- This

[GitHub] [spark] SparkQA commented on pull request #32934: [WIP][SPARK-35788][SS] Metrics support for RocksDB instance

2021-06-30 Thread GitBox
SparkQA commented on pull request #32934: URL: https://github.com/apache/spark/pull/32934#issuecomment-871469443 **[Test build #140447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140447/testReport)** for PR 32934 at commit [`1dfe279`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871469027 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140446/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871469027 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140446/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871467449 **[Test build #140446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140446/testReport)** for PR 33140 at commit [`2ecb6fb`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871468990 **[Test build #140446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140446/testReport)** for PR 33140 at commit [`2ecb6fb`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32934: [WIP][SPARK-35788][SS] Metrics support for RocksDB instance

2021-06-30 Thread GitBox
SparkQA commented on pull request #32934: URL: https://github.com/apache/spark/pull/32934#issuecomment-871467798 **[Test build #140447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140447/testReport)** for PR 32934 at commit [`1dfe279`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871467449 **[Test build #140446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140446/testReport)** for PR 33140 at commit [`2ecb6fb`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871461610 **[Test build #140445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140445/testReport)** for PR 32883 at commit [`8e706ae`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871465933 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140441/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871466331 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140445/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871466331 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140445/ -- This

[GitHub] [spark] SparkQA commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
SparkQA commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871466275 **[Test build #140445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140445/testReport)** for PR 32883 at commit [`8e706ae`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871465933 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140441/ -- This

[GitHub] [spark] SparkQA commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871465886 **[Test build #140441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140441/testReport)** for PR 33142 at commit [`f925cc9`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871461249 **[Test build #140441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140441/testReport)** for PR 33142 at commit [`f925cc9`](https://gi

[GitHub] [spark] cloud-fan commented on a change in pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33142: URL: https://github.com/apache/spark/pull/33142#discussion_r660900471 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -135,33 +125,47 @@ class Equivale

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661541692 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ## @@ -39,45 +42,63 @@ import org.apache.spa

[GitHub] [spark] cloud-fan commented on a change in pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33142: URL: https://github.com/apache/spark/pull/33142#discussion_r661540443 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -135,33 +125,47 @@ class Equivale

[GitHub] [spark] SparkQA removed a comment on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871461317 **[Test build #140442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140442/testReport)** for PR 33140 at commit [`9e98649`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871462660 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140442/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871462660 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140442/ -- This

[GitHub] [spark] SparkQA commented on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871462639 **[Test build #140442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140442/testReport)** for PR 33140 at commit [`9e98649`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #33156: [SPARK-35953][SQL] Support extracting date fields from timestamp without time zone

2021-06-30 Thread GitBox
SparkQA commented on pull request #33156: URL: https://github.com/apache/spark/pull/33156#issuecomment-871461759 **[Test build #140440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140440/testReport)** for PR 33156 at commit [`afa6903`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
SparkQA commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871461610 **[Test build #140445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140445/testReport)** for PR 32883 at commit [`8e706ae`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32933: [SPARK-35785][SS] Cleanup support for RocksDB instance

2021-06-30 Thread GitBox
SparkQA commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871461502 **[Test build #140444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140444/testReport)** for PR 32933 at commit [`368ae75`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32972: [SPARK-35756][SQL] unionByName supports struct having same col names but different sequence

2021-06-30 Thread GitBox
SparkQA commented on pull request #32972: URL: https://github.com/apache/spark/pull/32972#issuecomment-871461540 **[Test build #140443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140443/testReport)** for PR 32972 at commit [`a29df92`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33140: URL: https://github.com/apache/spark/pull/33140#issuecomment-871461317 **[Test build #140442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140442/testReport)** for PR 33140 at commit [`9e98649`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871461249 **[Test build #140441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140441/testReport)** for PR 33142 at commit [`f925cc9`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871459891 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140437/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32972: [SPARK-35756][SQL] unionByName supports struct having same col names but different sequence

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #32972: URL: https://github.com/apache/spark/pull/32972#issuecomment-864380521 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [spark] cloud-fan commented on pull request #32972: [SPARK-35756][SQL] unionByName supports struct having same col names but different sequence

2021-06-30 Thread GitBox
cloud-fan commented on pull request #32972: URL: https://github.com/apache/spark/pull/32972#issuecomment-871459830 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871459891 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140437/ -- This

[GitHub] [spark] cloud-fan commented on a change in pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33142: URL: https://github.com/apache/spark/pull/33142#discussion_r660902531 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala ## @@ -159,35 +156,34 @@ class

[GitHub] [spark] xuanyuanking commented on a change in pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
xuanyuanking commented on a change in pull request #33038: URL: https://github.com/apache/spark/pull/33038#discussion_r661517930 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreMap.scala ## @@ -0,0 +1,172 @@ +/* + * Lice

[GitHub] [spark] tdas commented on a change in pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r661532840 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala ## @@ -449,10 +451,48 @@ object FlatMapGroupsWithState {

[GitHub] [spark] SaurabhChawla100 commented on pull request #32972: [SPARK-35756][SQL] unionByName supports struct having same col names but different sequence

2021-06-30 Thread GitBox
SaurabhChawla100 commented on pull request #32972: URL: https://github.com/apache/spark/pull/32972#issuecomment-871451958 @cloud-fan - Shall we trigger the test build for this PR, seems like its not triggered -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] gengliangwang commented on a change in pull request #33156: [SPARK-35953][SQL] Support extracting date fields from timestamp without time zone

2021-06-30 Thread GitBox
gengliangwang commented on a change in pull request #33156: URL: https://github.com/apache/spark/pull/33156#discussion_r661522097 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -961,8 +961,8 @@ object TypeCoercion exte

[GitHub] [spark] gengliangwang opened a new pull request #33156: [SPARK-35953][SQL] Support extracting date fields from timestamp without time zone

2021-06-30 Thread GitBox
gengliangwang opened a new pull request #33156: URL: https://github.com/apache/spark/pull/33156 ### What changes were proposed in this pull request? Support extracting date fields from timestamp without time zone, which includes: - year - month - day - year of wee

[GitHub] [spark] xuanyuanking commented on pull request #32933: [SPARK-35785][SS] Cleanup support for RocksDB instance

2021-06-30 Thread GitBox
xuanyuanking commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871436858 Rebased and addressed all the comments. Thanks for your heads-up! cc @viirya @HeartSaVioR -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

2021-06-30 Thread GitBox
xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661506525 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala ## @@ -304,3 +498,25 @@ class RocksDBSuite e

[GitHub] [spark] SparkQA removed a comment on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871247964 **[Test build #140437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140437/testReport)** for PR 33136 at commit [`c206f2a`](https://gi

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

2021-06-30 Thread GitBox
xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661505905 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala ## @@ -102,6 +102,72 @@ class RocksDBSuite e

[GitHub] [spark] ulysses-you commented on a change in pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
ulysses-you commented on a change in pull request #32883: URL: https://github.com/apache/spark/pull/32883#discussion_r661505310 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -1820,4 +1821,45 @@ class AdaptiveQu

[GitHub] [spark] SparkQA commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

2021-06-30 Thread GitBox
SparkQA commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871432877 **[Test build #140437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140437/testReport)** for PR 33136 at commit [`c206f2a`](https://github.co

[GitHub] [spark] ulysses-you commented on a change in pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

2021-06-30 Thread GitBox
ulysses-you commented on a change in pull request #32883: URL: https://github.com/apache/spark/pull/32883#discussion_r661504807 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -1806,7 +1806,8 @@ class AdaptiveQue

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

2021-06-30 Thread GitBox
xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661497530 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -295,6 +385,16 @@ class RocksDBF

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

2021-06-30 Thread GitBox
xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661495630 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -153,6 +156,139 @@ class RocksDB

[GitHub] [spark] cloud-fan commented on a change in pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33142: URL: https://github.com/apache/spark/pull/33142#discussion_r661495179 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -93,25 +72,36 @@ class Equivalent

[GitHub] [spark] Kimahriman commented on a change in pull request #32987: [SPARK-35564][SQL] Support subexpression elimination for conditionally evaluated expressions

2021-06-30 Thread GitBox
Kimahriman commented on a change in pull request #32987: URL: https://github.com/apache/spark/pull/32987#discussion_r661488150 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -134,24 +154,18 @@ class Equival

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28032: [SPARK-31264][SQL] Repartition before writing data source tables/directories

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-871409397 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140435/ -

[GitHub] [spark] AmplabJenkins commented on pull request #28032: [SPARK-31264][SQL] Repartition before writing data source tables/directories

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-871409397 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140435/ -- This

[GitHub] [spark] cloud-fan commented on a change in pull request #32987: [SPARK-35564][SQL] Support subexpression elimination for conditionally evaluated expressions

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #32987: URL: https://github.com/apache/spark/pull/32987#discussion_r661476268 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -134,24 +154,18 @@ class Equivale

[GitHub] [spark] gengliangwang commented on a change in pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

2021-06-30 Thread GitBox
gengliangwang commented on a change in pull request #33136: URL: https://github.com/apache/spark/pull/33136#discussion_r661475310 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -961,13 +961,15 @@ object TypeCoercion ex

[GitHub] [spark] Kimahriman commented on a change in pull request #30245: [SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2021-06-30 Thread GitBox
Kimahriman commented on a change in pull request #30245: URL: https://github.com/apache/spark/pull/30245#discussion_r661470618 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -65,11 +65,82 @@ class Equivalen

[GitHub] [spark] cloud-fan commented on a change in pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33136: URL: https://github.com/apache/spark/pull/33136#discussion_r661468789 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -961,13 +961,15 @@ object TypeCoercion extend

<    1   2   3   4   5   6   7   8   >