[GitHub] [spark] cloud-fan commented on a change in pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

cloud-fan commented on a change in pull request #32883: URL: https://github.com/apache/spark/pull/32883#discussion_r661466362 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -1820,4 +1821,45 @@ class AdaptiveQuer

[GitHub] [spark] cloud-fan commented on a change in pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

cloud-fan commented on a change in pull request #32883: URL: https://github.com/apache/spark/pull/32883#discussion_r661466362 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -1820,4 +1821,45 @@ class AdaptiveQuer

[GitHub] [spark] cloud-fan commented on a change in pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

cloud-fan commented on a change in pull request #32883: URL: https://github.com/apache/spark/pull/32883#discussion_r661464988 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -1806,7 +1806,8 @@ class AdaptiveQuery

[GitHub] [spark] SparkQA removed a comment on pull request #28032: [SPARK-31264][SQL] Repartition before writing data source tables/directories

SparkQA removed a comment on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-871210456 **[Test build #140435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140435/testReport)** for PR 28032 at commit [`f2d4d3a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28032: [SPARK-31264][SQL] Repartition before writing data source tables/directories

SparkQA commented on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-871395313 **[Test build #140435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140435/testReport)** for PR 28032 at commit [`f2d4d3a`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

cloud-fan commented on a change in pull request #33146: URL: https://github.com/apache/spark/pull/33146#discussion_r661458691 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -406,19 +406,21 @@ abstract class CastBase extends

[GitHub] [spark] MaxGekk closed pull request #32943: [SPARK-35735][SQL] Take into account day-time interval fields in cast

MaxGekk closed pull request #32943: URL: https://github.com/apache/spark/pull/32943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubs

[GitHub] [spark] MaxGekk commented on pull request #32943: [SPARK-35735][SQL] Take into account day-time interval fields in cast

MaxGekk commented on pull request #32943: URL: https://github.com/apache/spark/pull/32943#issuecomment-871386191 +1, LGTM. Merging to master. Thank you, @AngersZh and @sarutak for review. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cfmcgrady commented on pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

cfmcgrady commented on pull request #33146: URL: https://github.com/apache/spark/pull/33146#issuecomment-871373025 cc @cloud-fan @viirya @maropu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] cfmcgrady commented on pull request #33146: [WIP][SPARK-35912][SQL] Fix cast struct contains null value to string

cfmcgrady commented on pull request #33146: URL: https://github.com/apache/spark/pull/33146#issuecomment-871370894 > how is the cache issue related to the cast? HI, @HyukjinKwon The root cause is cast struct to other types, updated the pr description. -- This is an automate

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

AmplabJenkins removed a comment on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871363702 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44953/

[GitHub] [spark] AmplabJenkins commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

AmplabJenkins commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871363702 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44953/ -- T

[GitHub] [spark] SparkQA commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

SparkQA commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871345888 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44953/ -- This is an automated message from the A

[GitHub] [spark] SparkQA removed a comment on pull request #33152: [SPARK-35935][SQL][3.1][3.0] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

SparkQA removed a comment on pull request #33152: URL: https://github.com/apache/spark/pull/33152#issuecomment-871168652 **[Test build #140433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140433/testReport)** for PR 33152 at commit [`6f9ff9e`](https://gi

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871334995 There are some busy cases today, we'll try to fix the ignored case tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] AmplabJenkins commented on pull request #33152: [SPARK-35935][SQL][3.1][3.0] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

AmplabJenkins commented on pull request #33152: URL: https://github.com/apache/spark/pull/33152#issuecomment-871334578 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140433/ -- This

[GitHub] [spark] SparkQA commented on pull request #33152: [SPARK-35935][SQL][3.1][3.0] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

SparkQA commented on pull request #33152: URL: https://github.com/apache/spark/pull/33152#issuecomment-871333192 **[Test build #140433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140433/testReport)** for PR 33152 at commit [`6f9ff9e`](https://github.co

[GitHub] [spark] Kimahriman commented on a change in pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

Kimahriman commented on a change in pull request #33142: URL: https://github.com/apache/spark/pull/33142#discussion_r661384470 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala ## @@ -93,25 +72,36 @@ class Equivalen

[GitHub] [spark] gengliangwang closed pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

gengliangwang closed pull request #33136: URL: https://github.com/apache/spark/pull/33136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-

[GitHub] [spark] gengliangwang commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

gengliangwang commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871326922 Merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

AmplabJenkins removed a comment on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871325621 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44951/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

AmplabJenkins removed a comment on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871325623 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140436/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

AmplabJenkins commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871325623 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140436/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

AmplabJenkins commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871325621 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44951/ -- T

[GitHub] [spark] SparkQA commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

SparkQA commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871324607 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44953/ -- This is an automated message from the Apache

[GitHub] [spark] SaurabhChawla100 commented on a change in pull request #32972: [SPARK-35756][SQL] unionByName supports struct having same col names but different sequence

SaurabhChawla100 commented on a change in pull request #32972: URL: https://github.com/apache/spark/pull/32972#discussion_r661364187 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -922,12 +922,67 @@ class DataFrameSetOperatio

[GitHub] [spark] SparkQA commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

SparkQA commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871309025 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44951/ -- This is an automated message from the A

[GitHub] [spark] SparkQA removed a comment on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

SparkQA removed a comment on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871214481 **[Test build #140436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140436/testReport)** for PR 33114 at commit [`c85ab7a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

SparkQA commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871307375 **[Test build #140436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140436/testReport)** for PR 33114 at commit [`c85ab7a`](https://github.co

[GitHub] [spark] HyukjinKwon commented on pull request #33153: [SPARK-35951][DOCS] Add since versions for Avro options in Documentation

HyukjinKwon commented on pull request #33153: URL: https://github.com/apache/spark/pull/33153#issuecomment-871292218 lgtm2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

AmplabJenkins removed a comment on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871289752 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44950/

[GitHub] [spark] AmplabJenkins commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

AmplabJenkins commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871289752 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44950/ -- T

[GitHub] [spark] SparkQA commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

SparkQA commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871289731 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44950/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

SparkQA commented on pull request #32883: URL: https://github.com/apache/spark/pull/32883#issuecomment-871288343 **[Test build #140439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140439/testReport)** for PR 32883 at commit [`7666145`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

AmplabJenkins commented on pull request #33155: URL: https://github.com/apache/spark/pull/33155#issuecomment-871287756 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28032: [SPARK-31264][SQL] Repartition before writing data source tables/directories

AmplabJenkins removed a comment on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-871287526 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44949/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33137: [SPARK-35935][SQL] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

AmplabJenkins removed a comment on pull request #33137: URL: https://github.com/apache/spark/pull/33137#issuecomment-871287525 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140428/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33105: [SPARK-35908][SQL] Remove repartition if the child maximum number of rows less than or equal to 1

AmplabJenkins removed a comment on pull request #33105: URL: https://github.com/apache/spark/pull/33105#issuecomment-871287529 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140429/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

AmplabJenkins removed a comment on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871257197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

AmplabJenkins removed a comment on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871287528 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140434/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33137: [SPARK-35935][SQL] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

AmplabJenkins commented on pull request #33137: URL: https://github.com/apache/spark/pull/33137#issuecomment-871287525 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140428/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

AmplabJenkins commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871287528 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140434/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #28032: [SPARK-31264][SQL] Repartition before writing data source tables/directories

AmplabJenkins commented on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-871287526 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44949/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #33105: [SPARK-35908][SQL] Remove repartition if the child maximum number of rows less than or equal to 1

AmplabJenkins commented on pull request #33105: URL: https://github.com/apache/spark/pull/33105#issuecomment-871287529 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140429/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

AmplabJenkins commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871287527 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44952/ -- T

[GitHub] [spark] SparkQA commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

SparkQA commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871286647 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44951/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #28032: [SPARK-31264][SQL] Repartition before writing data source tables/directories

SparkQA commented on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-871276080 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44949/ -- This is an automated message from the A

[GitHub] [spark] SparkQA removed a comment on pull request #33137: [SPARK-35935][SQL] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

SparkQA removed a comment on pull request #33137: URL: https://github.com/apache/spark/pull/33137#issuecomment-871110470 **[Test build #140428 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140428/testReport)** for PR 33137 at commit [`85954ae`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33137: [SPARK-35935][SQL] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

SparkQA commented on pull request #33137: URL: https://github.com/apache/spark/pull/33137#issuecomment-871274106 **[Test build #140428 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140428/testReport)** for PR 33137 at commit [`85954ae`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #33105: [SPARK-35908][SQL] Remove repartition if the child maximum number of rows less than or equal to 1

SparkQA removed a comment on pull request #33105: URL: https://github.com/apache/spark/pull/33105#issuecomment-871110491 **[Test build #140429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140429/testReport)** for PR 33105 at commit [`ae4531b`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33105: [SPARK-35908][SQL] Remove repartition if the child maximum number of rows less than or equal to 1

SparkQA commented on pull request #33105: URL: https://github.com/apache/spark/pull/33105#issuecomment-871266713 **[Test build #140429 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140429/testReport)** for PR 33105 at commit [`ae4531b`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

SparkQA removed a comment on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871250829 **[Test build #140438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140438/testReport)** for PR 32933 at commit [`56439b9`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

SparkQA removed a comment on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871178742 **[Test build #140434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140434/testReport)** for PR 29326 at commit [`74d5fbd`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

SparkQA commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871262610 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44950/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

SparkQA commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871262105 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44952/ -- This

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661308771 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -153,6 +156,139 @@ class RocksDB

[GitHub] [spark] pingsutw opened a new pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

pingsutw opened a new pull request #33155: URL: https://github.com/apache/spark/pull/33155 ### What changes were proposed in this pull request? Update the executor's page, so it can successfully hide the "Exec Loss Reason" column. ### Why are the changes needed?

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661306958 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -153,6 +156,139 @@ class RocksDB

[GitHub] [spark] SparkQA commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

SparkQA commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871258990 **[Test build #140434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140434/testReport)** for PR 29326 at commit [`74d5fbd`](https://github.co

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661306386 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -199,6 +199,96 @@ class RocksDBF

[GitHub] [spark] AmplabJenkins commented on pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

AmplabJenkins commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871257197 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140438/ -- This

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661304791 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -153,6 +156,139 @@ class RocksDB

[GitHub] [spark] SparkQA commented on pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

SparkQA commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871257148 **[Test build #140438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140438/testReport)** for PR 32933 at commit [`56439b9`](https://github.co

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661304079 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -199,6 +199,96 @@ class RocksDBF

[GitHub] [spark] xuanyuanking commented on a change in pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

xuanyuanking commented on a change in pull request #32933: URL: https://github.com/apache/spark/pull/32933#discussion_r661303956 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -153,6 +156,139 @@ class RocksDB

[GitHub] [spark] SparkQA commented on pull request #32933: [WIP][SPARK-35785][SS] Cleanup support for RocksDB instance

SparkQA commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871250829 **[Test build #140438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140438/testReport)** for PR 32933 at commit [`56439b9`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28032: [SPARK-31264][SQL] Repartition before writing data source tables/directories

SparkQA commented on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-871249974 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44949/ -- This is an automated message from the Apache

[GitHub] [spark] gengliangwang commented on a change in pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

gengliangwang commented on a change in pull request #33136: URL: https://github.com/apache/spark/pull/33136#discussion_r661294955 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -639,8 +639,8 @@ abstract class TypeCoerc

[GitHub] [spark] SparkQA commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

SparkQA commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871247964 **[Test build #140437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140437/testReport)** for PR 33136 at commit [`c206f2a`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #33154: [SPARK-35949][CORE]Fixes bug for sparkContext stopped on client mode

AmplabJenkins commented on pull request #33154: URL: https://github.com/apache/spark/pull/33154#issuecomment-871247704 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

AmplabJenkins removed a comment on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871246952 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140426/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33152: [SPARK-35935][SQL][3.1][3.0] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

AmplabJenkins removed a comment on pull request #33152: URL: https://github.com/apache/spark/pull/33152#issuecomment-871246954 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44947/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33149: [SPARK-35947][INFRA] Increase JVM stack size in release-build.sh

AmplabJenkins removed a comment on pull request #33149: URL: https://github.com/apache/spark/pull/33149#issuecomment-871246950 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140431/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33150: [SPARK-35948][INFRA] Simplify release scripts by removing Spark 2.4/Java7 parts

AmplabJenkins removed a comment on pull request #33150: URL: https://github.com/apache/spark/pull/33150#issuecomment-871246951 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140432/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

AmplabJenkins removed a comment on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871138114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

AmplabJenkins commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871246956 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44948/ -- T

[GitHub] [spark] gengliangwang commented on a change in pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

gengliangwang commented on a change in pull request #33136: URL: https://github.com/apache/spark/pull/33136#discussion_r661293657 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala ## @@ -189,6 +189,7 @@ object AnsiTypeCoerc

[GitHub] [spark] AmplabJenkins commented on pull request #33150: [SPARK-35948][INFRA] Simplify release scripts by removing Spark 2.4/Java7 parts

AmplabJenkins commented on pull request #33150: URL: https://github.com/apache/spark/pull/33150#issuecomment-871246951 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140432/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33152: [SPARK-35935][SQL][3.1][3.0] Prevent failure of `MSCK REPAIR TABLE` on table refreshing

AmplabJenkins commented on pull request #33152: URL: https://github.com/apache/spark/pull/33152#issuecomment-871246954 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44947/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #33149: [SPARK-35947][INFRA] Increase JVM stack size in release-build.sh

AmplabJenkins commented on pull request #33149: URL: https://github.com/apache/spark/pull/33149#issuecomment-871246950 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140431/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

AmplabJenkins commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871246952 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140426/ -- This

[GitHub] [spark] wangyum closed pull request #32013: [WIP][SPARK-34920][SQL] Add SQLSTATE and ERRORCODE to SQL exception

wangyum closed pull request #32013: URL: https://github.com/apache/spark/pull/32013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubs

[GitHub] [spark] gengliangwang closed pull request #33153: [SPARK-35951][DOCS] Add since versions for Avro options in Documentation

gengliangwang closed pull request #33153: URL: https://github.com/apache/spark/pull/33153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-

[GitHub] [spark] SparkQA commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

SparkQA commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871242105 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44948/ -- This

[GitHub] [spark] gengliangwang commented on pull request #33153: [SPARK-35951][DOCS] Add since versions for Avro options in Documentation

gengliangwang commented on pull request #33153: URL: https://github.com/apache/spark/pull/33153#issuecomment-871239716 Merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] cloud-fan closed pull request #32850: [SPARK-34920][CORE][SQL] Add error classes with SQLSTATE

cloud-fan closed pull request #32850: URL: https://github.com/apache/spark/pull/32850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsu

[GitHub] [spark] cloud-fan commented on pull request #32850: [SPARK-34920][CORE][SQL] Add error classes with SQLSTATE

cloud-fan commented on pull request #32850: URL: https://github.com/apache/spark/pull/32850#issuecomment-871238577 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] wangyum commented on a change in pull request #32883: [SPARK-35725][SQL] Support optimize skewed partitions in RebalancePartitions

wangyum commented on a change in pull request #32883: URL: https://github.com/apache/spark/pull/32883#discussion_r661284044 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedPartitions.scala ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [spark] sunpe closed pull request #33154: [SPARK-35949][CORE]Fixes bug for sparkContext stopped on client mode

sunpe closed pull request #33154: URL: https://github.com/apache/spark/pull/33154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr

[GitHub] [spark] sunpe opened a new pull request #33154: [SPARK-35949][CORE]Fixes bug for sparkContext stopped on client mode

sunpe opened a new pull request #33154: URL: https://github.com/apache/spark/pull/33154 What changes were proposed in this pull request? Fixes a bug that the spark context was stopped while application is started on client mode. Why are the changes needed? Due to pr c625eb4#di

[GitHub] [spark] SparkQA removed a comment on pull request #33150: [SPARK-35948][INFRA] Simplify release scripts by removing Spark 2.4/Java7 parts

SparkQA removed a comment on pull request #33150: URL: https://github.com/apache/spark/pull/33150#issuecomment-871143765 **[Test build #140432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140432/testReport)** for PR 33150 at commit [`538c86a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33150: [SPARK-35948][INFRA] Simplify release scripts by removing Spark 2.4/Java7 parts

SparkQA commented on pull request #33150: URL: https://github.com/apache/spark/pull/33150#issuecomment-871235068 **[Test build #140432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140432/testReport)** for PR 33150 at commit [`538c86a`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #33149: [SPARK-35947][INFRA] Increase JVM stack size in release-build.sh

SparkQA removed a comment on pull request #33149: URL: https://github.com/apache/spark/pull/33149#issuecomment-871136536 **[Test build #140431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140431/testReport)** for PR 33149 at commit [`f1fa0e2`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33149: [SPARK-35947][INFRA] Increase JVM stack size in release-build.sh

SparkQA commented on pull request #33149: URL: https://github.com/apache/spark/pull/33149#issuecomment-871227343 **[Test build #140431 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140431/testReport)** for PR 33149 at commit [`f1fa0e2`](https://github.co

[GitHub] [spark] sunpe closed pull request #33151: [SPARK-35949][CORE]Fixes bug for sparkContext stopped on client mode

sunpe closed pull request #33151: URL: https://github.com/apache/spark/pull/33151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr

[GitHub] [spark] gengliangwang commented on pull request #33153: [SPARK-35951][DOCS] Add since versions for Avro options in Documentation

gengliangwang commented on pull request #33153: URL: https://github.com/apache/spark/pull/33153#issuecomment-871225983 @MaxGekk Screenshot uploaded, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] SparkQA removed a comment on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

SparkQA removed a comment on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871088160 **[Test build #140426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140426/testReport)** for PR 33136 at commit [`0596534`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

SparkQA commented on pull request #33136: URL: https://github.com/apache/spark/pull/33136#issuecomment-871225436 **[Test build #140426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140426/testReport)** for PR 33136 at commit [`0596534`](https://github.co

[GitHub] [spark] cloud-fan commented on pull request #32850: [SPARK-34920][CORE][SQL] Add error classes with SQLSTATE

cloud-fan commented on pull request #32850: URL: https://github.com/apache/spark/pull/32850#issuecomment-871222996 > How do other common modules use these errors? For example: spark-unsafe, spark-network-common. Similar problems appear in the config framework as well. spark-unsafe,

[GitHub] [spark] MaxGekk commented on pull request #33153: [SPARK-35951][DOCS] Add since versions for Avro options in Documentation

MaxGekk commented on pull request #33153: URL: https://github.com/apache/spark/pull/33153#issuecomment-87176 > Manual preview on local setup. Can you put a screenshot in PR's description. Otherwise LGTM. -- This is an automated message from the Apache Git Service. To respond to

<    2   3   4   5   6   7   8   >