[GitHub] [spark] SparkQA removed a comment on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
SparkQA removed a comment on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879558541 **[Test build #140993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140993/testReport)** for PR 3 at commit

[GitHub] [spark] SparkQA commented on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
SparkQA commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879614152 **[Test build #140993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140993/testReport)** for PR 3 at commit

[GitHub] [spark] sarutak edited a comment on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
sarutak edited a comment on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879613028 Yeah, I'll do it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] sunchao commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
sunchao commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669311658 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ## @@ -358,7 +386,14 @@ public

[GitHub] [spark] viirya commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
viirya commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669311526 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetColumnIndexSuite.scala ## @@ -31,24 +31,25 @@ class

[GitHub] [spark] sarutak commented on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
sarutak commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879613028 Yeah, I'll do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] dongjoon-hyun commented on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
dongjoon-hyun commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879612808 BTW, for the other old branches, we might need to revisit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
dongjoon-hyun commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879612523 @gengliangwang I landed this to branch-3.2 since this is related to some CVEs. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun closed pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
dongjoon-hyun closed pull request #3: URL: https://github.com/apache/spark/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] viirya commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
viirya commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669310575 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ## @@ -358,7 +386,14 @@ public

[GitHub] [spark] SparkQA commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
SparkQA commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879611464 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45509/ -- This is an automated message from the

[GitHub] [spark] sunchao commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
sunchao commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669309831 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ## @@ -358,7 +386,14 @@ public

[GitHub] [spark] dongjoon-hyun commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
dongjoon-hyun commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879611200 I reviewed and merged https://github.com/apache/spark/pull/4 . Please rebase this PR to the master. -- This is an automated message from the Apache Git Service.

[GitHub] [spark] dongjoon-hyun closed pull request #33334: [SPARK-36131][SQL][TEST] Refactor ParquetColumnIndexSuite

2021-07-13 Thread GitBox
dongjoon-hyun closed pull request #4: URL: https://github.com/apache/spark/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] sunchao commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
sunchao commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669309298 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ## @@ -255,6 +253,36 @@ private

[GitHub] [spark] viirya commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
viirya commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669309094 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ## @@ -358,7 +386,14 @@ public

[GitHub] [spark] dongjoon-hyun commented on pull request #33334: [SPARK-36131][SQL][TEST] Refactor ParquetColumnIndexSuite

2021-07-13 Thread GitBox
dongjoon-hyun commented on pull request #4: URL: https://github.com/apache/spark/pull/4#issuecomment-879610496 Merged to master/3.2. cc @gengliangwang . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] sunchao commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
sunchao commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669308991 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetColumnIndexSuite.scala ## @@ -31,24 +31,25 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33334: [SPARK-36131][SQL][TEST] Refactor ParquetColumnIndexSuite

2021-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #4: URL: https://github.com/apache/spark/pull/4#discussion_r669308630 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetColumnIndexSuite.scala ## @@ -31,96 +40,56 @@

[GitHub] [spark] viirya commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
viirya commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669308507 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ## @@ -255,6 +253,36 @@ private

[GitHub] [spark] viirya commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
viirya commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669308360 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ## @@ -255,6 +253,36 @@ private

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33323: URL: https://github.com/apache/spark/pull/33323#issuecomment-879608970 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45508/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33077: [SPARK-34892][SS] Introduce MergingSortWithSessionWindowStateIterator sorting input rows and rows in state efficiently

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33077: URL: https://github.com/apache/spark/pull/33077#issuecomment-879608822 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140989/

[GitHub] [spark] AmplabJenkins commented on pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #33323: URL: https://github.com/apache/spark/pull/33323#issuecomment-879608970 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45508/ --

[GitHub] [spark] SparkQA commented on pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
SparkQA commented on pull request #33323: URL: https://github.com/apache/spark/pull/33323#issuecomment-879608954 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45508/ -- This is an automated message from the

[GitHub] [spark] zhouyejoe commented on a change in pull request #33078: [SPARK-35546][Shuffle] Enable push-based shuffle when multiple app attempts are enabled and manage concurrent access to the sta

2021-07-13 Thread GitBox
zhouyejoe commented on a change in pull request #33078: URL: https://github.com/apache/spark/pull/33078#discussion_r669306705 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java ## @@ -567,7 +598,8 @@ public void

[GitHub] [spark] AmplabJenkins commented on pull request #33077: [SPARK-34892][SS] Introduce MergingSortWithSessionWindowStateIterator sorting input rows and rows in state efficiently

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #33077: URL: https://github.com/apache/spark/pull/33077#issuecomment-879608822 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140989/ -- This

[GitHub] [spark] cfmcgrady commented on pull request #33335: [SPARK-36130][SQL] UnwrapCastInBinaryComparison should skip In expression when in.list contains an expression that is not literal

2021-07-13 Thread GitBox
cfmcgrady commented on pull request #5: URL: https://github.com/apache/spark/pull/5#issuecomment-879608835 cc @allisonwang-db @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] SparkQA removed a comment on pull request #33077: [SPARK-34892][SS] Introduce MergingSortWithSessionWindowStateIterator sorting input rows and rows in state efficiently

2021-07-13 Thread GitBox
SparkQA removed a comment on pull request #33077: URL: https://github.com/apache/spark/pull/33077#issuecomment-879512560 **[Test build #140989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140989/testReport)** for PR 33077 at commit

[GitHub] [spark] zhouyejoe commented on a change in pull request #33078: [SPARK-35546][Shuffle] Enable push-based shuffle when multiple app attempts are enabled and manage concurrent access to the sta

2021-07-13 Thread GitBox
zhouyejoe commented on a change in pull request #33078: URL: https://github.com/apache/spark/pull/33078#discussion_r669306864 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java ## @@ -403,38 +394,78 @@ public

[GitHub] [spark] SparkQA commented on pull request #33077: [SPARK-34892][SS] Introduce MergingSortWithSessionWindowStateIterator sorting input rows and rows in state efficiently

2021-07-13 Thread GitBox
SparkQA commented on pull request #33077: URL: https://github.com/apache/spark/pull/33077#issuecomment-879607967 **[Test build #140989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140989/testReport)** for PR 33077 at commit

[GitHub] [spark] zhouyejoe commented on a change in pull request #33078: [SPARK-35546][Shuffle] Enable push-based shuffle when multiple app attempts are enabled and manage concurrent access to the sta

2021-07-13 Thread GitBox
zhouyejoe commented on a change in pull request #33078: URL: https://github.com/apache/spark/pull/33078#discussion_r669306705 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java ## @@ -567,7 +598,8 @@ public void

[GitHub] [spark] viirya commented on a change in pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
viirya commented on a change in pull request #0: URL: https://github.com/apache/spark/pull/0#discussion_r669306577 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetColumnIndexSuite.scala ## @@ -31,24 +31,25 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33334: [SPARK-36131][SQL][TEST] Refactor ParquetColumnIndexSuite

2021-07-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #4: URL: https://github.com/apache/spark/pull/4#discussion_r669305829 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetColumnIndexSuite.scala ## @@ -31,96 +40,56 @@

[GitHub] [spark] AmplabJenkins commented on pull request #33335: [SPARK-36130][SQL] Fix UnwrapCastInBinaryComparison bug.

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #5: URL: https://github.com/apache/spark/pull/5#issuecomment-879606997 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] cfmcgrady opened a new pull request #33335: [SPARK-36130][SQL] Fix UnwrapCastInBinaryComparison bug.

2021-07-13 Thread GitBox
cfmcgrady opened a new pull request #5: URL: https://github.com/apache/spark/pull/5 ### What changes were proposed in this pull request? This PR fix rule `UnwrapCastInBinaryComparison` bug. Rule UnwrapCastInBinaryComparison should skip In expression when in.list

[GitHub] [spark] dongjoon-hyun commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
dongjoon-hyun commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879605733 Thank you, @sunchao . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] SparkQA commented on pull request #32401: [SPARK-35276][CORE] Calculate checksum for shuffle data and write as checksum file

2021-07-13 Thread GitBox
SparkQA commented on pull request #32401: URL: https://github.com/apache/spark/pull/32401#issuecomment-879603860 **[Test build #141000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141000/testReport)** for PR 32401 at commit

[GitHub] [spark] SparkQA commented on pull request #33081: [SPARK-34893][SS] Support session window natively

2021-07-13 Thread GitBox
SparkQA commented on pull request #33081: URL: https://github.com/apache/spark/pull/33081#issuecomment-879603643 **[Test build #140999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140999/testReport)** for PR 33081 at commit

[GitHub] [spark] SparkQA commented on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
SparkQA commented on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879603580 **[Test build #140998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140998/testReport)** for PR 33258 at commit

[GitHub] [spark] SparkQA commented on pull request #33334: [SPARK-36131][SQL][TEST] Refactor ParquetColumnIndexSuite

2021-07-13 Thread GitBox
SparkQA commented on pull request #4: URL: https://github.com/apache/spark/pull/4#issuecomment-879603443 **[Test build #140996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140996/testReport)** for PR 4 at commit

[GitHub] [spark] SparkQA commented on pull request #33324: [SPARK-36093][SQL] RemoveRedundantAliases should not change Command's parameter's expression's name

2021-07-13 Thread GitBox
SparkQA commented on pull request #33324: URL: https://github.com/apache/spark/pull/33324#issuecomment-879603497 **[Test build #140997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140997/testReport)** for PR 33324 at commit

[GitHub] [spark] SparkQA commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
SparkQA commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879598200 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45509/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
SparkQA commented on pull request #33323: URL: https://github.com/apache/spark/pull/33323#issuecomment-879596706 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45508/ -- This is an automated message from the Apache

[GitHub] [spark] HeartSaVioR commented on a change in pull request #32401: [SPARK-35276][CORE] Calculate checksum for shuffle data and write as checksum file

2021-07-13 Thread GitBox
HeartSaVioR commented on a change in pull request #32401: URL: https://github.com/apache/spark/pull/32401#discussion_r669288375 ## File path: core/src/main/java/org/apache/spark/shuffle/checksum/ShuffleChecksumHelper.java ## @@ -0,0 +1,83 @@ +package

[GitHub] [spark] beliefer commented on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
beliefer commented on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879587025 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r669284266 ## File path: core/src/test/resources/HistoryServerExpectations/running_app_list_json_expectation.json ## @@ -1 +1 @@ -[ ] +[ ] Review comment:

[GitHub] [spark] Ngone51 commented on a change in pull request #32401: [SPARK-35276][CORE] Calculate checksum for shuffle data and write as checksum file

2021-07-13 Thread GitBox
Ngone51 commented on a change in pull request #32401: URL: https://github.com/apache/spark/pull/32401#discussion_r669282673 ## File path: core/src/main/java/org/apache/spark/shuffle/checksum/ShuffleChecksumHelper.java ## @@ -0,0 +1,83 @@ +package

[GitHub] [spark] sunchao commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
sunchao commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879583404 thanks @gengliangwang - I opened #4 for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] sunchao opened a new pull request #33334: [SPARK-35743][SQL][TEST] Refactor ParquetColumnIndexSuite

2021-07-13 Thread GitBox
sunchao opened a new pull request #4: URL: https://github.com/apache/spark/pull/4 ### What changes were proposed in this pull request? Refactor `ParquetColumnIndexSuite` and allow better code reuse. ### Why are the changes needed? A few methods

[GitHub] [spark] cloud-fan commented on a change in pull request #32872: [SPARK-35639][SQL] Make hasCoalescedPartition return true if something was actually coalesced

2021-07-13 Thread GitBox
cloud-fan commented on a change in pull request #32872: URL: https://github.com/apache/spark/pull/32872#discussion_r669277698 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala ## @@ -87,8 +87,15 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879580591 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140995/

[GitHub] [spark] SparkQA commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
SparkQA commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879580580 **[Test build #140995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140995/testReport)** for PR 33253 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
SparkQA removed a comment on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879580409 **[Test build #140995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140995/testReport)** for PR 33253 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879580591 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140995/ -- This

[GitHub] [spark] SparkQA commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
SparkQA commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879580409 **[Test build #140995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140995/testReport)** for PR 33253 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33174: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33174: URL: https://github.com/apache/spark/pull/33174#issuecomment-879578133 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140991/

[GitHub] [spark] venkata91 commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
venkata91 commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879579744 > @venkata91 Could you fix the style issue first? > > ``` > [error]

[GitHub] [spark] AmplabJenkins commented on pull request #33174: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #33174: URL: https://github.com/apache/spark/pull/33174#issuecomment-879578133 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140991/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33323: URL: https://github.com/apache/spark/pull/33323#issuecomment-879136851 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] SparkQA removed a comment on pull request #33174: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-07-13 Thread GitBox
SparkQA removed a comment on pull request #33174: URL: https://github.com/apache/spark/pull/33174#issuecomment-879537921 **[Test build #140991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140991/testReport)** for PR 33174 at commit

[GitHub] [spark] SparkQA commented on pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
SparkQA commented on pull request #33323: URL: https://github.com/apache/spark/pull/33323#issuecomment-879577688 **[Test build #140994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140994/testReport)** for PR 33323 at commit

[GitHub] [spark] SparkQA commented on pull request #33174: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-07-13 Thread GitBox
SparkQA commented on pull request #33174: URL: https://github.com/apache/spark/pull/33174#issuecomment-879577612 **[Test build #140991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140991/testReport)** for PR 33174 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33077: [SPARK-34892][SS] Introduce MergingSortWithSessionWindowStateIterator sorting input rows and rows in state efficiently

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33077: URL: https://github.com/apache/spark/pull/33077#issuecomment-879577172 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140987/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879577174 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140986/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32401: [SPARK-35276][CORE] Calculate checksum for shuffle data and write as checksum file

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32401: URL: https://github.com/apache/spark/pull/32401#issuecomment-879577176 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45506/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879577173 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140990/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879577171 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45507/

[GitHub] [spark] AmplabJenkins commented on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879577171 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45507/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879577173 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140990/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33077: [SPARK-34892][SS] Introduce MergingSortWithSessionWindowStateIterator sorting input rows and rows in state efficiently

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #33077: URL: https://github.com/apache/spark/pull/33077#issuecomment-879577172 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140987/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879577174 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140986/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32401: [SPARK-35276][CORE] Calculate checksum for shuffle data and write as checksum file

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #32401: URL: https://github.com/apache/spark/pull/32401#issuecomment-879577176 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45506/ --

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33332: [SQL] Warn if less files visible after stats write

2021-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #2: URL: https://github.com/apache/spark/pull/2#discussion_r669267871 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -166,7 +166,7 @@ class

[GitHub] [spark] SparkQA commented on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
SparkQA commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879572572 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45507/ --

[GitHub] [spark] SparkQA removed a comment on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
SparkQA removed a comment on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879537873 **[Test build #140990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140990/testReport)** for PR 33258 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #33332: [SQL] Warn if less files visible after stats write

2021-07-13 Thread GitBox
HyukjinKwon commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-879571129 @tooptoop4 please refer to https://spark.apache.org/contributing.html and make the PR description and title properly with a jira. -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
SparkQA commented on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879571046 **[Test build #140990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140990/testReport)** for PR 33258 at commit

[GitHub] [spark] HyukjinKwon edited a comment on pull request #33329: [WIP][SPARK-35917][SHUFFLE][CORE][3.2] Disable push-based shuffle feature to prevent it from being used

2021-07-13 Thread GitBox
HyukjinKwon edited a comment on pull request #33329: URL: https://github.com/apache/spark/pull/33329#issuecomment-879569468 Yeah, I think we won't necessarily have to make it failed when it's enabled. I believe it's fine to explicitly document that this feature is unstable, and either

[GitHub] [spark] HyukjinKwon commented on pull request #33329: [WIP][SPARK-35917][SHUFFLE][CORE][3.2] Disable push-based shuffle feature to prevent it from being used

2021-07-13 Thread GitBox
HyukjinKwon commented on pull request #33329: URL: https://github.com/apache/spark/pull/33329#issuecomment-879569468 Yeah, I think we won't necessarily have to make it failed when it's enabled. I believe it's fine to explicitly document that this feature is unstable, and either

[GitHub] [spark] gengliangwang commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
gengliangwang commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879568535 @sunchao Thanks for the work. I think it's OK to have a PR for test refactoring. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on pull request #33325: [SPARK-36076][SQL][3.0] ArrayIndexOutOfBounds in Cast string to timestamp

2021-07-13 Thread GitBox
HyukjinKwon commented on pull request #33325: URL: https://github.com/apache/spark/pull/33325#issuecomment-879567089 the sparkr test failure should be ignorable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] ekoifman commented on a change in pull request #32872: [SPARK-35639][SQL] Make hasCoalescedPartition return true if something was actually coalesced

2021-07-13 Thread GitBox
ekoifman commented on a change in pull request #32872: URL: https://github.com/apache/spark/pull/32872#discussion_r669262650 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala ## @@ -87,8 +87,15 @@ case class

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33324: [SPARK-36093][SQL] RemoveRedundantAliases should not change Command's parameter's expression's name

2021-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #33324: URL: https://github.com/apache/spark/pull/33324#discussion_r669262443 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -4058,6 +4058,44 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] HyukjinKwon commented on pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
HyukjinKwon commented on pull request #33323: URL: https://github.com/apache/spark/pull/33323#issuecomment-879566146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #33323: URL: https://github.com/apache/spark/pull/33323#discussion_r669261877 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -981,6 +1006,58 @@ class Dataset[T] private[sql]( join(right,

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #33323: URL: https://github.com/apache/spark/pull/33323#discussion_r669261712 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -956,6 +956,31 @@ class Dataset[T] private[sql]( join(right,

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33323: [SPARK-35739][SQL] Add Java-compatible Dataset.join overloads

2021-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #33323: URL: https://github.com/apache/spark/pull/33323#discussion_r669261605 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -956,6 +956,31 @@ class Dataset[T] private[sql]( join(right,

[GitHub] [spark] SparkQA commented on pull request #32401: [SPARK-35276][CORE] Calculate checksum for shuffle data and write as checksum file

2021-07-13 Thread GitBox
SparkQA commented on pull request #32401: URL: https://github.com/apache/spark/pull/32401#issuecomment-879565484 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45506/ -- This is an automated message from the

[GitHub] [spark] SparkQA removed a comment on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
SparkQA removed a comment on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879470999 **[Test build #140986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140986/testReport)** for PR 0 at commit

[GitHub] [spark] SparkQA commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
SparkQA commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879564742 **[Test build #140986 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140986/testReport)** for PR 0 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #33077: [SPARK-34892][SS] Introduce MergingSortWithSessionWindowStateIterator sorting input rows and rows in state efficiently

2021-07-13 Thread GitBox
SparkQA removed a comment on pull request #33077: URL: https://github.com/apache/spark/pull/33077#issuecomment-879471127 **[Test build #140987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140987/testReport)** for PR 33077 at commit

[GitHub] [spark] SparkQA commented on pull request #33077: [SPARK-34892][SS] Introduce MergingSortWithSessionWindowStateIterator sorting input rows and rows in state efficiently

2021-07-13 Thread GitBox
SparkQA commented on pull request #33077: URL: https://github.com/apache/spark/pull/33077#issuecomment-879564143 **[Test build #140987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140987/testReport)** for PR 33077 at commit

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-13 Thread GitBox
sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879563645 @venkata91 Could you fix the style issue first? ``` [error]

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879562230 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45504/

[GitHub] [spark] SparkQA commented on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
SparkQA commented on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879562217 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45504/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #33258: [SPARK-36037][SQL] Support ANSI SQL LOCALTIMESTAMP datetime value function

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #33258: URL: https://github.com/apache/spark/pull/33258#issuecomment-879562230 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45504/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-879558620 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140985/

[GitHub] [spark] AmplabJenkins commented on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-13 Thread GitBox
AmplabJenkins commented on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-879558620 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140985/ -- This

[GitHub] [spark] SparkQA commented on pull request #33333: [SPARK-36129][BUILD] Upgrade commons-compress to 1.21 to deal with CVEs

2021-07-13 Thread GitBox
SparkQA commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-879558541 **[Test build #140993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140993/testReport)** for PR 3 at commit

  1   2   3   4   5   6   7   >