gengliangwang commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926422744
@mridulm Yes.
At first the benchmark of job start:
```
listener.onJobStart(SparkListenerJobStart(4, time, stages, null))
```
Later on, I change the
SparkQA commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926419740
**[Test build #143587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143587/testReport)**
for PR 34092 at commit
SparkQA commented on pull request #34089:
URL: https://github.com/apache/spark/pull/34089#issuecomment-926416340
**[Test build #143588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143588/testReport)**
for PR 34089 at commit
Peng-Lei commented on pull request #34093:
URL: https://github.com/apache/spark/pull/34093#issuecomment-926416101
@karenfeng @HyukjinKwon Could you take a look ? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins commented on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926414847
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48102/
--
SparkQA commented on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926414804
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48102/
--
This is an automated message from the
Peng-Lei commented on a change in pull request #34093:
URL: https://github.com/apache/spark/pull/34093#discussion_r715386251
##
File path: core/src/main/resources/error/error-classes.json
##
@@ -134,13 +181,28 @@
"message" : [ "The second argument of '%s' function needs
Peng-Lei commented on a change in pull request #34093:
URL: https://github.com/apache/spark/pull/34093#discussion_r715386015
##
File path: core/src/main/resources/error/error-classes.json
##
@@ -134,13 +181,28 @@
"message" : [ "The second argument of '%s' function needs
Peng-Lei commented on a change in pull request #34093:
URL: https://github.com/apache/spark/pull/34093#discussion_r715385928
##
File path: core/src/main/resources/error/error-classes.json
##
@@ -134,13 +181,28 @@
"message" : [ "The second argument of '%s' function needs
Peng-Lei commented on a change in pull request #34093:
URL: https://github.com/apache/spark/pull/34093#discussion_r715385719
##
File path: core/src/main/resources/error/error-classes.json
##
@@ -110,6 +153,10 @@
"message" : [ "Unknown static partition column: %s" ],
Peng-Lei commented on a change in pull request #34093:
URL: https://github.com/apache/spark/pull/34093#discussion_r715385403
##
File path: core/src/main/resources/error/error-classes.json
##
@@ -39,9 +57,31 @@
"message" : [ "Found duplicate keys '%s'" ],
"sqlState" :
mridulm commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926413763
Btw, can you share the details of the regression ?
What I had seen earlier was:
```
Before changes:
InMemoryStore: 2.8s
LevelDB: 68.9s
After changes:
gengliangwang commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926412080
> One option is to batch all the deletes together, instead of doing it one
by one - which should make level db updates also faster ?
Then the same optimization can
mridulm edited a comment on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926406914
I am guessing the minor perf difference for level db would be the sort being
done after pulling all data vs pushing the sort to the store.
One option is to batch all
SparkQA commented on pull request #34070:
URL: https://github.com/apache/spark/pull/34070#issuecomment-926408733
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48103/
--
This is an automated message from the Apache
mridulm commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926406914
I am guessing the minor perf difference for level db would be the sort being
done after pulling all data vs pushing the sort to the store.
One option is to batch all the
AmplabJenkins commented on pull request #34093:
URL: https://github.com/apache/spark/pull/34093#issuecomment-926403952
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Peng-Lei opened a new pull request #34093:
URL: https://github.com/apache/spark/pull/34093
### What changes were proposed in this pull request?
Refactor fifth set of 20 query execution errors to use error classes. as
follows:
`
createStreamingSourceNotSpecifySchemaError
AmplabJenkins removed a comment on pull request #34009:
URL: https://github.com/apache/spark/pull/34009#issuecomment-926403057
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48101/
AmplabJenkins commented on pull request #34009:
URL: https://github.com/apache/spark/pull/34009#issuecomment-926403057
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48101/
--
SparkQA commented on pull request #34009:
URL: https://github.com/apache/spark/pull/34009#issuecomment-926403030
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48101/
--
This is an automated message from the
AmplabJenkins removed a comment on pull request #34038:
URL: https://github.com/apache/spark/pull/34038#issuecomment-926399922
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48100/
AmplabJenkins commented on pull request #34038:
URL: https://github.com/apache/spark/pull/34038#issuecomment-926399922
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48100/
--
SparkQA commented on pull request #34038:
URL: https://github.com/apache/spark/pull/34038#issuecomment-926399893
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48100/
--
This is an automated message from the
AmplabJenkins removed a comment on pull request #34089:
URL: https://github.com/apache/spark/pull/34089#issuecomment-926399792
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48099/
AmplabJenkins commented on pull request #34089:
URL: https://github.com/apache/spark/pull/34089#issuecomment-926399792
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48099/
--
SparkQA commented on pull request #34089:
URL: https://github.com/apache/spark/pull/34089#issuecomment-926399770
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48099/
--
This is an automated message from the
SparkQA commented on pull request #34058:
URL: https://github.com/apache/spark/pull/34058#issuecomment-926398174
**[Test build #143594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143594/testReport)**
for PR 34058 at commit
AmplabJenkins removed a comment on pull request #34058:
URL: https://github.com/apache/spark/pull/34058#issuecomment-926398197
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143594/
AmplabJenkins commented on pull request #34058:
URL: https://github.com/apache/spark/pull/34058#issuecomment-926398197
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143594/
--
This
SparkQA removed a comment on pull request #34058:
URL: https://github.com/apache/spark/pull/34058#issuecomment-926397312
**[Test build #143594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143594/testReport)**
for PR 34058 at commit
AmplabJenkins removed a comment on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926396364
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143584/
AmplabJenkins removed a comment on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926396888
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48098/
SparkQA commented on pull request #34070:
URL: https://github.com/apache/spark/pull/34070#issuecomment-926397273
**[Test build #143593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143593/testReport)**
for PR 34070 at commit
SparkQA commented on pull request #34058:
URL: https://github.com/apache/spark/pull/34058#issuecomment-926397312
**[Test build #143594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143594/testReport)**
for PR 34058 at commit
SparkQA commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926397098
**[Test build #143592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143592/testReport)**
for PR 34092 at commit
SparkQA commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926396839
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48098/
--
This is an automated message from the
AmplabJenkins commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926396888
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48098/
--
AmplabJenkins commented on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926396364
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143584/
--
This
MaxGekk closed pull request #34057:
URL: https://github.com/apache/spark/pull/34057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
SparkQA commented on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926390902
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48102/
--
This is an automated message from the Apache
MaxGekk commented on pull request #34057:
URL: https://github.com/apache/spark/pull/34057#issuecomment-926390400
Merging to master. Thank you, @sarutak @sunchao and @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dgd-contributor commented on pull request #33805:
URL: https://github.com/apache/spark/pull/33805#issuecomment-926389935
CC @karenfeng. Could you take another look when you have time ? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gengliangwang commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926385613
@mridulm Thanks for the review. This one is ready now.
As I observe regression after applying the changes when using LevelDB, this
PR is to optimize InMemoryStore only.
SparkQA removed a comment on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926326364
**[Test build #143584 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143584/testReport)**
for PR 34091 at commit
SparkQA commented on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926384784
**[Test build #143584 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143584/testReport)**
for PR 34091 at commit
SparkQA commented on pull request #34009:
URL: https://github.com/apache/spark/pull/34009#issuecomment-926380423
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48101/
--
This is an automated message from the Apache
AmplabJenkins removed a comment on pull request #34069:
URL: https://github.com/apache/spark/pull/34069#issuecomment-926377057
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48095/
AmplabJenkins commented on pull request #34069:
URL: https://github.com/apache/spark/pull/34069#issuecomment-926377057
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48095/
--
SparkQA commented on pull request #34069:
URL: https://github.com/apache/spark/pull/34069#issuecomment-926377045
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48095/
--
This is an automated message from the
SparkQA commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926375480
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48098/
--
This is an automated message from the Apache
AmplabJenkins removed a comment on pull request #34069:
URL: https://github.com/apache/spark/pull/34069#issuecomment-926373023
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48096/
SparkQA commented on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926373020
**[Test build #143591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143591/testReport)**
for PR 34091 at commit
AmplabJenkins commented on pull request #34069:
URL: https://github.com/apache/spark/pull/34069#issuecomment-926373023
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48096/
--
SparkQA commented on pull request #34069:
URL: https://github.com/apache/spark/pull/34069#issuecomment-926372976
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48096/
--
This is an automated message from the
AmplabJenkins removed a comment on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926372336
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48094/
AmplabJenkins commented on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926372336
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48094/
--
SparkQA commented on pull request #34091:
URL: https://github.com/apache/spark/pull/34091#issuecomment-926372263
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48094/
--
This is an automated message from the
AmplabJenkins removed a comment on pull request #34077:
URL: https://github.com/apache/spark/pull/34077#issuecomment-926370365
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48097/
SparkQA commented on pull request #34038:
URL: https://github.com/apache/spark/pull/34038#issuecomment-926371144
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48100/
--
This is an automated message from the Apache
gengliangwang commented on a change in pull request #34092:
URL: https://github.com/apache/spark/pull/34092#discussion_r715321250
##
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##
@@ -1253,44 +1254,46 @@ private[spark] class
SparkQA commented on pull request #34089:
URL: https://github.com/apache/spark/pull/34089#issuecomment-926370883
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48099/
--
This is an automated message from the Apache
AmplabJenkins commented on pull request #34077:
URL: https://github.com/apache/spark/pull/34077#issuecomment-926370365
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48097/
--
SparkQA commented on pull request #34077:
URL: https://github.com/apache/spark/pull/34077#issuecomment-926370348
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48097/
--
This is an automated message from the
attilapiros commented on a change in pull request #33936:
URL: https://github.com/apache/spark/pull/33936#discussion_r715326783
##
File path: repl/src/main/scala-2.12/org/apache/spark/repl/SparkILoop.scala
##
@@ -105,6 +108,13 @@ class SparkILoop(in0: Option[BufferedReader],
gengliangwang commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926368948
@mridulm there is something wrong with the benchmark. I rerun the updated
benchmark and find that after changes the LevelDB is slower.
I am considering making the code
mridulm commented on pull request #34092:
URL: https://github.com/apache/spark/pull/34092#issuecomment-926367597
Did not notice the change was still WIP !
But the fix looks good to me - though I am not sure if it is sufficient to
fix the issue
--
This is an automated message from the
401 - 467 of 467 matches
Mail list logo