[GitHub] [spark] SparkQA removed a comment on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
SparkQA removed a comment on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983450419 **[Test build #145810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145810/testReport)** for PR 34741 at commit

[GitHub] [spark] SparkQA commented on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
SparkQA commented on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983713248 **[Test build #145810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145810/testReport)** for PR 34741 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

2021-12-01 Thread GitBox
SparkQA removed a comment on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-983695873 **[Test build #145816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145816/testReport)** for PR 34599 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-983709929 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145816/

[GitHub] [spark] AmplabJenkins commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-983709929 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145816/ -- This

[GitHub] [spark] SparkQA commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

2021-12-01 Thread GitBox
SparkQA commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-983709555 **[Test build #145816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145816/testReport)** for PR 34599 at commit

[GitHub] [spark] SparkQA commented on pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

2021-12-01 Thread GitBox
SparkQA commented on pull request #34738: URL: https://github.com/apache/spark/pull/34738#issuecomment-983706656 **[Test build #145817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145817/testReport)** for PR 34738 at commit

[GitHub] [spark] SparkQA commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

2021-12-01 Thread GitBox
SparkQA commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-983695873 **[Test build #145816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145816/testReport)** for PR 34599 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34769: URL: https://github.com/apache/spark/pull/34769#issuecomment-983693572 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50289/

[GitHub] [spark] AmplabJenkins commented on pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34769: URL: https://github.com/apache/spark/pull/34769#issuecomment-983693572 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50289/ --

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r760228758 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2489,10 +2693,6 @@ abstract class CSVSuite

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r760225314 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -1012,6 +1012,196 @@ abstract class CSVSuite

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

2021-12-01 Thread GitBox
Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-983685340 > In theory, this feature looks unsafe because there is a chance to leak the pre-populated resources because they have no owner yet. Yes, that's a good point, and the

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r760223753 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -66,10 +68,23 @@ sealed trait

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r760222777 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -66,10 +68,23 @@ sealed trait

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r760221751 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -66,10 +68,23 @@ sealed trait

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r760221164 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -442,17 +442,22 @@ object DateTimeUtils {

[GitHub] [spark] SparkQA commented on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
SparkQA commented on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983680629 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50290/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r760219127 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala ## @@ -164,6 +164,10 @@ class CSVOptions(

[GitHub] [spark] cloud-fan closed pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
cloud-fan closed pull request #34758: URL: https://github.com/apache/spark/pull/34758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] cloud-fan commented on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
cloud-fan commented on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983672127 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan edited a comment on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
cloud-fan edited a comment on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983660633 @bersprockets After reading more ORC code, I feel the timestamp implementation is quite messy in ORC. Not only the reader side, but also the writer side shifts the

[GitHub] [spark] cloud-fan edited a comment on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
cloud-fan edited a comment on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983660633 @bersprockets After reading more ORC code, I feel the timestamp implementation is quite messy in ORC. Not only the reader side, but also the writer side shifts the

[GitHub] [spark] zero323 commented on a change in pull request #34363: [SPARK-37083][PYTHON] Inline type hints for python/pyspark/accumulators.py

2021-12-01 Thread GitBox
zero323 commented on a change in pull request #34363: URL: https://github.com/apache/spark/pull/34363#discussion_r760208707 ## File path: python/pyspark/accumulators.py ## @@ -176,44 +193,44 @@ class AccumulatorParam(object): [7.0, 8.0, 9.0] """ -def zero(self,

[GitHub] [spark] SparkQA commented on pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
SparkQA commented on pull request #34769: URL: https://github.com/apache/spark/pull/34769#issuecomment-983665823 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50289/ -- This is an automated message from the

[GitHub] [spark] cloud-fan edited a comment on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
cloud-fan edited a comment on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983660633 @bersprockets After reading more ORC code, I feel the timestamp implementation is quite messy in ORC. Not only the reader side, but also the writer side shifts the

[GitHub] [spark] cloud-fan commented on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
cloud-fan commented on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983660633 @bersprockets After reading more ORC code, I feel the timestamp implementation is quite messy in ORC. Not only the reader side, but also the writer side shifts the timestamp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983655989 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50288/

[GitHub] [spark] AmplabJenkins commented on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983655989 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50288/ --

[GitHub] [spark] SparkQA commented on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
SparkQA commented on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983655923 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50288/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983652224 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145804/

[GitHub] [spark] AmplabJenkins commented on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983652224 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145804/ -- This

[GitHub] [spark] SparkQA commented on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
SparkQA commented on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983650601 **[Test build #145804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145804/testReport)** for PR 34758 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
SparkQA removed a comment on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983403373 **[Test build #145804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145804/testReport)** for PR 34758 at commit

[GitHub] [spark] kevincmchen commented on pull request #34742: [SPARK-37486][SQL][HIVE] set the ContextClassLoader before using the `addJars` in `HiveClient`

2021-12-01 Thread GitBox
kevincmchen commented on pull request #34742: URL: https://github.com/apache/spark/pull/34742#issuecomment-983650416 @HyukjinKwon Could you please review the code and merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] kevincmchen commented on pull request #34742: [SPARK-37486][SQL][HIVE] set the ContextClassLoader before using the `addJars` in `HiveClient`

2021-12-01 Thread GitBox
kevincmchen commented on pull request #34742: URL: https://github.com/apache/spark/pull/34742#issuecomment-983645625 > Thank you for your explanation. If you are sure it will not affect the old case, I think this change is OK ok, thx -- This is an automated message from the

[GitHub] [spark] zero323 commented on a change in pull request #34363: [SPARK-37083][PYTHON] Inline type hints for python/pyspark/accumulators.py

2021-12-01 Thread GitBox
zero323 commented on a change in pull request #34363: URL: https://github.com/apache/spark/pull/34363#discussion_r760186335 ## File path: python/pyspark/_typing.pyi ## @@ -21,11 +21,14 @@ from typing_extensions import Protocol F = TypeVar("F", bound=Callable) T_co =

[GitHub] [spark] zero323 commented on a change in pull request #34363: [SPARK-37083][PYTHON] Inline type hints for python/pyspark/accumulators.py

2021-12-01 Thread GitBox
zero323 commented on a change in pull request #34363: URL: https://github.com/apache/spark/pull/34363#discussion_r760182927 ## File path: python/pyspark/_typing.pyi ## @@ -21,11 +21,14 @@ from typing_extensions import Protocol F = TypeVar("F", bound=Callable) T =

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-983639467 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145806/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983639466 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50287/

[GitHub] [spark] AmplabJenkins commented on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-983639467 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145806/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983639466 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50287/ --

[GitHub] [spark] tanelk commented on a change in pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted

2021-12-01 Thread GitBox
tanelk commented on a change in pull request #34702: URL: https://github.com/apache/spark/pull/34702#discussion_r760180464 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ReplaceHashWithSortAgg.scala ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] [spark] zero323 commented on a change in pull request #34363: [SPARK-37083][PYTHON] Inline type hints for python/pyspark/accumulators.py

2021-12-01 Thread GitBox
zero323 commented on a change in pull request #34363: URL: https://github.com/apache/spark/pull/34363#discussion_r760175944 ## File path: python/pyspark/accumulators.py ## @@ -176,44 +193,44 @@ class AccumulatorParam(object): [7.0, 8.0, 9.0] """ -def zero(self,

[GitHub] [spark] beliefer commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

2021-12-01 Thread GitBox
beliefer commented on a change in pull request #34738: URL: https://github.com/apache/spark/pull/34738#discussion_r760174691 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -370,6 +370,8 @@ abstract class JdbcDialect extends

[GitHub] [spark] SparkQA removed a comment on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-01 Thread GitBox
SparkQA removed a comment on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-983403563 **[Test build #145806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145806/testReport)** for PR 34673 at commit

[GitHub] [spark] SparkQA commented on pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
SparkQA commented on pull request #34769: URL: https://github.com/apache/spark/pull/34769#issuecomment-983629826 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50289/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-01 Thread GitBox
SparkQA commented on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-983629803 **[Test build #145806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145806/testReport)** for PR 34673 at commit

[GitHub] [spark] SparkQA commented on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
SparkQA commented on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983626546 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50287/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
SparkQA commented on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983605763 **[Test build #145815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145815/testReport)** for PR 34741 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34738: URL: https://github.com/apache/spark/pull/34738#discussion_r760148616 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownTopN.java ## @@ -0,0 +1,37 @@ +/* + * Licensed to the

[GitHub] [spark] SparkQA commented on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
SparkQA commented on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983602523 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50288/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34738: URL: https://github.com/apache/spark/pull/34738#discussion_r760145878 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -370,6 +370,8 @@ abstract class JdbcDialect extends

[GitHub] [spark] cloud-fan commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34738: URL: https://github.com/apache/spark/pull/34738#discussion_r760144783 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -255,7 +256,20 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34738: URL: https://github.com/apache/spark/pull/34738#discussion_r760144434 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -249,13 +248,25 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-983599243 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145801/

[GitHub] [spark] AmplabJenkins commented on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-983599243 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145801/ -- This

[GitHub] [spark] cloud-fan commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34738: URL: https://github.com/apache/spark/pull/34738#discussion_r760142801 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushedDownOperators.scala ## @@ -25,4 +26,5 @@ import

[GitHub] [spark] SparkQA removed a comment on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-01 Thread GitBox
SparkQA removed a comment on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-983363812 **[Test build #145801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145801/testReport)** for PR 34673 at commit

[GitHub] [spark] SparkQA commented on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-01 Thread GitBox
SparkQA commented on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-983597809 **[Test build #145801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145801/testReport)** for PR 34673 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983594755 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145802/

[GitHub] [spark] cloud-fan commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34738: URL: https://github.com/apache/spark/pull/34738#discussion_r760139088 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ## @@ -149,6 +149,7 @@ case class RowDataSourceScanExec(

[GitHub] [spark] AmplabJenkins commented on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983594755 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145802/ -- This

[GitHub] [spark] SparkQA commented on pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
SparkQA commented on pull request #34769: URL: https://github.com/apache/spark/pull/34769#issuecomment-983594523 **[Test build #145814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145814/testReport)** for PR 34769 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
SparkQA removed a comment on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983370498 **[Test build #145802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145802/testReport)** for PR 34758 at commit

[GitHub] [spark] SparkQA commented on pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

2021-12-01 Thread GitBox
SparkQA commented on pull request #34758: URL: https://github.com/apache/spark/pull/34758#issuecomment-983593261 **[Test build #145802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145802/testReport)** for PR 34758 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #34768: [SPARK-11150][SQL][FOLLOWUP] We should drop all tables after testing dynamic partition pruning.

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34768: URL: https://github.com/apache/spark/pull/34768#issuecomment-983592651 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34718: URL: https://github.com/apache/spark/pull/34718#issuecomment-983592141 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50285/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34753: [SPARK-37494][SQL] Unify v1 and v2 options output of `SHOW CREATE TABLE` command

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34753: URL: https://github.com/apache/spark/pull/34753#issuecomment-983592144 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50283/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983592142 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50284/

[GitHub] [spark] AmplabJenkins commented on pull request #34753: [SPARK-37494][SQL] Unify v1 and v2 options output of `SHOW CREATE TABLE` command

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34753: URL: https://github.com/apache/spark/pull/34753#issuecomment-983592144 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50283/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34718: URL: https://github.com/apache/spark/pull/34718#issuecomment-983592141 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50285/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983592142 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50284/ --

[GitHub] [spark] cloud-fan commented on a change in pull request #34667: [SPARK-36902][SQL] Migrate CreateTableAsSelectStatement to v2 command

2021-12-01 Thread GitBox
cloud-fan commented on a change in pull request #34667: URL: https://github.com/apache/spark/pull/34667#discussion_r760132755 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ## @@ -323,18 +323,25 @@ final class DataFrameWriter[T]

[GitHub] [spark] beliefer edited a comment on pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
beliefer edited a comment on pull request #34769: URL: https://github.com/apache/spark/pull/34769#issuecomment-983586891 Because my mistake rebase not correctly, I create this PR to replace https://github.com/apache/spark/pull/34712 ping @cloud-fan @bersprockets This PR can fix all

[GitHub] [spark] beliefer edited a comment on pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
beliefer edited a comment on pull request #34769: URL: https://github.com/apache/spark/pull/34769#issuecomment-983586891 Because my mistake rebase not correctly, I create this PR to replace https://github.com/apache/spark/pull/34712 ping @cloud-fan @bersprockets -- This is an

[GitHub] [spark] beliefer commented on pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
beliefer commented on pull request #34769: URL: https://github.com/apache/spark/pull/34769#issuecomment-983586891 Because my mistake rebase not correctly, I create this PR to replace https://github.com/apache/spark/pull/34712 -- This is an automated message from the Apache Git Service.

[GitHub] [spark] SparkQA commented on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
SparkQA commented on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983585767 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50287/ -- This is an automated message from the Apache

[GitHub] [spark] beliefer opened a new pull request #34769: [SPARK-37463][SQL] Read/Write Timestamp ntz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
beliefer opened a new pull request #34769: URL: https://github.com/apache/spark/pull/34769 ### What changes were proposed in this pull request? This PR used to fix the issue https://github.com/apache/spark/pull/33588#issuecomment-978719988 The root cause is Orc write/read

[GitHub] [spark] cloud-fan closed pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION

2021-12-01 Thread GitBox
cloud-fan closed pull request #34718: URL: https://github.com/apache/spark/pull/34718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] cloud-fan edited a comment on pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION

2021-12-01 Thread GitBox
cloud-fan edited a comment on pull request #34718: URL: https://github.com/apache/spark/pull/34718#issuecomment-983583155 thanks, merging to master/3.2! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] cloud-fan commented on pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION

2021-12-01 Thread GitBox
cloud-fan commented on pull request #34718: URL: https://github.com/apache/spark/pull/34718#issuecomment-983583155 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] weixiuli opened a new pull request #34768: [SPARK-11150][SQL][FOLLOWUP] We should drop all tables after testing dynamic partition pruning.

2021-12-01 Thread GitBox
weixiuli opened a new pull request #34768: URL: https://github.com/apache/spark/pull/34768 ### What changes were proposed in this pull request? Drop all tables after testing dynamic partition pruning. ### Why are the changes needed? We should drop all

[GitHub] [spark] SparkQA commented on pull request #34741: [SPARK-37463][SQL] Read/Write Timestamp ntz from/to Orc uses UTC time zone

2021-12-01 Thread GitBox
SparkQA commented on pull request #34741: URL: https://github.com/apache/spark/pull/34741#issuecomment-983580955 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50284/ -- This is an automated message from the

[GitHub] [spark] zero323 commented on a change in pull request #34728: [WIP][SPARK-37474][R][DOCS] Migrate SparkR docs to pkgdown

2021-12-01 Thread GitBox
zero323 commented on a change in pull request #34728: URL: https://github.com/apache/spark/pull/34728#discussion_r760125119 ## File path: R/pkg/_pkgdown.yml ## @@ -0,0 +1,293 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [spark] SparkQA commented on pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION

2021-12-01 Thread GitBox
SparkQA commented on pull request #34718: URL: https://github.com/apache/spark/pull/34718#issuecomment-983572753 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50285/ -- This is an automated message from the

[GitHub] [spark] beliefer closed pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
beliefer closed pull request #34712: URL: https://github.com/apache/spark/pull/34712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] SparkQA commented on pull request #34753: [SPARK-37494][SQL] Unify v1 and v2 options output of `SHOW CREATE TABLE` command

2021-12-01 Thread GitBox
SparkQA commented on pull request #34753: URL: https://github.com/apache/spark/pull/34753#issuecomment-983562325 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50283/ -- This is an automated message from the

[GitHub] [spark] SparkQA removed a comment on pull request #34753: [SPARK-37494][SQL] Unify v1 and v2 options output of `SHOW CREATE TABLE` command

2021-12-01 Thread GitBox
SparkQA removed a comment on pull request #34753: URL: https://github.com/apache/spark/pull/34753#issuecomment-983450312 **[Test build #145809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145809/testReport)** for PR 34753 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34753: [SPARK-37494][SQL] Unify v1 and v2 options output of `SHOW CREATE TABLE` command

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34753: URL: https://github.com/apache/spark/pull/34753#issuecomment-983559882 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145809/

[GitHub] [spark] AmplabJenkins commented on pull request #34753: [SPARK-37494][SQL] Unify v1 and v2 options output of `SHOW CREATE TABLE` command

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34753: URL: https://github.com/apache/spark/pull/34753#issuecomment-983559882 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145809/ -- This

[GitHub] [spark] SparkQA commented on pull request #34753: [SPARK-37494][SQL] Unify v1 and v2 options output of `SHOW CREATE TABLE` command

2021-12-01 Thread GitBox
SparkQA commented on pull request #34753: URL: https://github.com/apache/spark/pull/34753#issuecomment-983559573 **[Test build #145809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145809/testReport)** for PR 34753 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34764: [SPARK-37330][SQL] Migrate ReplaceTableStatement to v2 command

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34764: URL: https://github.com/apache/spark/pull/34764#issuecomment-983553655 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145795/

[GitHub] [spark] AmplabJenkins commented on pull request #34764: [SPARK-37330][SQL] Migrate ReplaceTableStatement to v2 command

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34764: URL: https://github.com/apache/spark/pull/34764#issuecomment-983553655 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145795/ -- This

[GitHub] [spark] SparkQA commented on pull request #34767: [SPARK-37461][YARN][FOLLOWUP] Refactor YARN Client code to avoid add unnecessary parameter of `appId`

2021-12-01 Thread GitBox
SparkQA commented on pull request #34767: URL: https://github.com/apache/spark/pull/34767#issuecomment-983552304 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50282/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #34767: [SPARK-37461][YARN][FOLLOWUP] Refactor YARN Client code to avoid add unnecessary parameter of `appId`

2021-12-01 Thread GitBox
AmplabJenkins commented on pull request #34767: URL: https://github.com/apache/spark/pull/34767#issuecomment-983552351 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50282/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34767: [SPARK-37461][YARN][FOLLOWUP] Refactor YARN Client code to avoid add unnecessary parameter of `appId`

2021-12-01 Thread GitBox
AmplabJenkins removed a comment on pull request #34767: URL: https://github.com/apache/spark/pull/34767#issuecomment-983552351 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50282/

[GitHub] [spark] SparkQA removed a comment on pull request #34764: [SPARK-37330][SQL] Migrate ReplaceTableStatement to v2 command

2021-12-01 Thread GitBox
SparkQA removed a comment on pull request #34764: URL: https://github.com/apache/spark/pull/34764#issuecomment-983329462 **[Test build #145795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145795/testReport)** for PR 34764 at commit

[GitHub] [spark] SparkQA commented on pull request #34764: [SPARK-37330][SQL] Migrate ReplaceTableStatement to v2 command

2021-12-01 Thread GitBox
SparkQA commented on pull request #34764: URL: https://github.com/apache/spark/pull/34764#issuecomment-983551560 **[Test build #145795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145795/testReport)** for PR 34764 at commit

[GitHub] [spark] SparkQA commented on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp

2021-12-01 Thread GitBox
SparkQA commented on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-983548980 **[Test build #145813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145813/testReport)** for PR 34712 at commit

<    1   2   3   4   5   6   7   >