[GitHub] [spark] dongjoon-hyun closed pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones URL: https://github.com/apache/spark/pull/43065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43065: URL: https://github.com/apache/spark/pull/43065#issuecomment-1732206610 I'll merge this because this PR doesn't touch any code. These are purely generated files as the snapshot. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43065: URL: https://github.com/apache/spark/pull/43065#issuecomment-1732206126 Thank you for thorough reviews. Ya, we should catch up them one by one after having this. This helps us be in the same page and monitor this. -- This is an automated message from

[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
LuciferYang commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334916319 ## sql/core/benchmarks/SortBenchmark-results.txt: ## @@ -2,15 +2,15 @@ radix sort

[GitHub] [spark] dongjoon-hyun commented on pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43069: URL: https://github.com/apache/spark/pull/43069#issuecomment-1732200379 Merged to master for Apache Spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun closed pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support URL: https://github.com/apache/spark/pull/43069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43069: URL: https://github.com/apache/spark/pull/43069#issuecomment-1732200263 Thank you so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] yaooqinn commented on pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork

2023-09-22 Thread via GitHub
yaooqinn commented on PR #43053: URL: https://github.com/apache/spark/pull/43053#issuecomment-1732198539 Thank you all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] dongjoon-hyun commented on pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43069: URL: https://github.com/apache/spark/pull/43069#issuecomment-1732194064 Could you review this doc-only PR, @LuciferYang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] dongjoon-hyun commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732193985 Thank you, @LuciferYang ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43065: URL: https://github.com/apache/spark/pull/43065#issuecomment-1732193905 Thank you, @LuciferYang . Now, the PR is ready by adding AnsiIntervalSortBenchmark (Java17/21). -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334911535 ## sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt: ## @@ -1,10 +1,10 @@ -OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334911491 ## core/benchmarks/ZStandardBenchmark-results.txt: ## @@ -2,26 +2,26 @@ Benchmark ZStandardCompressionCodec

[GitHub] [spark] LuciferYang commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

2023-09-22 Thread via GitHub
LuciferYang commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732193237 Merged into master for Apache Spark 4.0, thanks @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] LuciferYang closed pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

2023-09-22 Thread via GitHub
LuciferYang closed pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt` URL: https://github.com/apache/spark/pull/43066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] dongjoon-hyun opened a new pull request, #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

2023-09-22 Thread via GitHub
dongjoon-hyun opened a new pull request, #43069: URL: https://github.com/apache/spark/pull/43069 ### What changes were proposed in this pull request? This PR aims to update K8s doc to recommend K8s 1.26+ for Apache Spark 4.0.0. ### Why are the changes needed? **1.

[GitHub] [spark] LuciferYang commented on pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

2023-09-22 Thread via GitHub
LuciferYang commented on PR #43060: URL: https://github.com/apache/spark/pull/43060#issuecomment-1732191906 > Thank you. I checked now. Spark doc is updated with Java 17. So, we don't need to mention here. It seems that we need to fix it from `Java 17` to `Java17/21`. I'll handle it

[GitHub] [spark] LuciferYang commented on pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

2023-09-22 Thread via GitHub
LuciferYang commented on PR #43060: URL: https://github.com/apache/spark/pull/43060#issuecomment-1732191440 late LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
LuciferYang commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334909906 ## sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt: ## @@ -1,10 +1,10 @@ -OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure -Intel(R)

[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
LuciferYang commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334909865 ## sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt: ## @@ -1,10 +1,10 @@ -OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure -Intel(R)

[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

2023-09-22 Thread via GitHub
LuciferYang commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334908931 ## core/benchmarks/ZStandardBenchmark-results.txt: ## @@ -2,26 +2,26 @@ Benchmark ZStandardCompressionCodec

[GitHub] [spark] dongjoon-hyun commented on pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43053: URL: https://github.com/apache/spark/pull/43053#issuecomment-1732185291 Merged to master for Apache Spark 4.0.0. Thank you, @yaooqinn and all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun closed pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork URL: https://github.com/apache/spark/pull/43053 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] mridulm commented on pull request #42685: [WIP][SPARK-44937][CORE] Add SSL/TLS support for RPC and Shuffle communications

2023-09-22 Thread via GitHub
mridulm commented on PR #42685: URL: https://github.com/apache/spark/pull/42685#issuecomment-1732173622 Thanks for working on this @hasnain-db , this is a very nice adding to spark ! Given the size of the PR, can we split this up to make it easier to review ? -- This is an automated

[GitHub] [spark] dongjoon-hyun commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732154701 This PR is irrelevant from CI result. So, please note that I stopped the runnjng pipelines on this PR manually to unblock my other PRs. -- This is an automated message from the

[GitHub] [spark] mridulm commented on pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork

2023-09-22 Thread via GitHub
mridulm commented on PR #43053: URL: https://github.com/apache/spark/pull/43053#issuecomment-1732154429 Nice job @yaooqinn ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] mridulm commented on a diff in pull request #42950: [SPARK-45182][CORE] Ignore task completion from old stage after retrying indeterminate stages

2023-09-22 Thread via GitHub
mridulm commented on code in PR #42950: URL: https://github.com/apache/spark/pull/42950#discussion_r1334896106 ## core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala: ## @@ -1903,13 +1903,20 @@ private[spark] class DAGScheduler( case smt:

[GitHub] [spark] mridulm commented on a diff in pull request #42950: [SPARK-45182][CORE] Ignore task completion from old stage after retrying indeterminate stages

2023-09-22 Thread via GitHub
mridulm commented on code in PR #42950: URL: https://github.com/apache/spark/pull/42950#discussion_r1334896106 ## core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala: ## @@ -1903,13 +1903,20 @@ private[spark] class DAGScheduler( case smt:

[GitHub] [spark] Hisoka-X commented on pull request #40963: [SPARK-43288][SQL] DataSourceV2: CREATE TABLE LIKE

2023-09-22 Thread via GitHub
Hisoka-X commented on PR #40963: URL: https://github.com/apache/spark/pull/40963#issuecomment-1732151326 @atronchi Hi, since this PR not updated... So I created one for create table like too, please check https://github.com/apache/spark/pull/42586 -- This is an automated message from the

[GitHub] [spark] chenyu-opensource commented on pull request #43028: [SPARK-45248][CORE]Set the timeout for spark ui server

2023-09-22 Thread via GitHub
chenyu-opensource commented on PR #43028: URL: https://github.com/apache/spark/pull/43028#issuecomment-1732148383 > OK, please put a comment in the code about why this is set lower than usual. Thank you for your suggestion and i had follow it. -- This is an automated message from

[GitHub] [spark] jchen5 opened a new pull request, #43068: [SPARK-44550][SQL] Enable correctness fixes for `null IN (empty list)` under ANSI

2023-09-22 Thread via GitHub
jchen5 opened a new pull request, #43068: URL: https://github.com/apache/spark/pull/43068 ### What changes were proposed in this pull request? Enables the correctness fixes for `null IN (empty list)` expressions `null IN (empty list)` incorrectly evaluates to null, when it should

[GitHub] [spark] github-actions[bot] commented on pull request #40503: [SPARK-42830] [UI] Link skipped stages on Spark UI

2023-09-22 Thread via GitHub
github-actions[bot] commented on PR #40503: URL: https://github.com/apache/spark/pull/40503#issuecomment-1732142967 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

[GitHub] [spark] github-actions[bot] commented on pull request #40529: [SPARK-42890] [UI] add repeat identifier on SQL UI

2023-09-22 Thread via GitHub
github-actions[bot] commented on PR #40529: URL: https://github.com/apache/spark/pull/40529#issuecomment-1732142946 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

[GitHub] [spark] github-actions[bot] closed pull request #40821: [SPARK-43152][spark-structured-streaming] Parametrisable output metadata path (_spark_metadata)

2023-09-22 Thread via GitHub
github-actions[bot] closed pull request #40821: [SPARK-43152][spark-structured-streaming] Parametrisable output metadata path (_spark_metadata) URL: https://github.com/apache/spark/pull/40821 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] github-actions[bot] commented on pull request #40782: [SPARK-42669][CONNECT] Short circuit local relation RPCs

2023-09-22 Thread via GitHub
github-actions[bot] commented on PR #40782: URL: https://github.com/apache/spark/pull/40782#issuecomment-1732142935 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

[GitHub] [spark] dongjoon-hyun commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732140942 Could you review this PR, @attilapiros ? After we switching to Java 17+, there are several clean-up PRs like this. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #43064: [SPARK-45265][SQL][WIP] Supporting Hive 4.0 metastore

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43064: URL: https://github.com/apache/spark/pull/43064#issuecomment-1732140284 Thank you. And, if you are fine with Apache Spark 4.0, that's great! I was worried.  -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] warrenzhu25 opened a new pull request, #43067: [SPARK-45057][CORE] Avoid acquire read lock when keepReadLock is false

2023-09-22 Thread via GitHub
warrenzhu25 opened a new pull request, #43067: URL: https://github.com/apache/spark/pull/43067 ### What changes were proposed in this pull request? Add `keepReadLock` parameter in `lockNewBlockForWriting()`. When `keepReadLock` is `false`, skip `lockForReading()` to avoid block on read

[GitHub] [spark] attilapiros commented on pull request #43064: [SPARK-45265][SQL][WIP] Supporting Hive 4.0 metastore

2023-09-22 Thread via GitHub
attilapiros commented on PR #43064: URL: https://github.com/apache/spark/pull/43064#issuecomment-1732139192 @dongjoon-hyun Thanks! > Are you using the current beta-1? Yes. > Is there a timeline for Hive 4.0 GA? I will ask around but as I know they still

[GitHub] [spark] dongjoon-hyun closed pull request #43062: [SPARK-45285][CORE][TESTS] Remove deprecated `Runtime.getRuntime.exec(String)` API usage

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43062: [SPARK-45285][CORE][TESTS] Remove deprecated `Runtime.getRuntime.exec(String)` API usage URL: https://github.com/apache/spark/pull/43062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] dongjoon-hyun commented on pull request #43062: [SPARK-45285][CORE][TESTS] Remove deprecated `Runtime.getRuntime.exec(String)` API usage

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43062: URL: https://github.com/apache/spark/pull/43062#issuecomment-1732134994 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] viirya commented on pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

2023-09-22 Thread via GitHub
viirya commented on PR #43060: URL: https://github.com/apache/spark/pull/43060#issuecomment-1732134464 Sounds good. Thanks @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] dongjoon-hyun closed pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17 URL: https://github.com/apache/spark/pull/43060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] dongjoon-hyun commented on pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43060: URL: https://github.com/apache/spark/pull/43060#issuecomment-1732133925 Thank you. I checked now. Spark doc is updated with Java 17. It seems that we need to fix it from `Java 17` to `Java17/21`. I'll handle it independently because it's Java 21 stuff.

[GitHub] [spark] viirya commented on pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

2023-09-22 Thread via GitHub
viirya commented on PR #43060: URL: https://github.com/apache/spark/pull/43060#issuecomment-1732132107 Do we have necessary change in Spark documents? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732130048 I tried to clean-up this in my regeneration PR, but it makes the commit log weird because Git thinks is renaming. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732129270 cc @LuciferYang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] dongjoon-hyun opened a new pull request, #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

2023-09-22 Thread via GitHub
dongjoon-hyun opened a new pull request, #43066: URL: https://github.com/apache/spark/pull/43066 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43065: URL: https://github.com/apache/spark/pull/43065#issuecomment-1732121987 cc @LuciferYang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] dongjoon-hyun opened a new pull request, #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result

2023-09-22 Thread via GitHub
dongjoon-hyun opened a new pull request, #43065: URL: https://github.com/apache/spark/pull/43065 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] xiongbo-sjtu commented on pull request #43021: [SPARK-45227][CORE] Fix a subtle thread-safety issue with CoarseGrainedExecutorBackend

2023-09-22 Thread via GitHub
xiongbo-sjtu commented on PR #43021: URL: https://github.com/apache/spark/pull/43021#issuecomment-1732099260 @jiangxb1987 @mridulm Eventually got all tests passed in Github Actions. Any concern on merging this pull request? As a side note, I've discovered [another minor

[GitHub] [spark] attilapiros opened a new pull request, #43064: [SPARK-45265][SQL][WIP] Supporting Hive 4.0 metastore

2023-09-22 Thread via GitHub
attilapiros opened a new pull request, #43064: URL: https://github.com/apache/spark/pull/43064 ### What changes were proposed in this pull request? Supporting Hive 4.0 metastore where partition filters even for CHAR and a VARCHAR types can be pushed down. **Hive 4.0 is

[GitHub] [spark] atronchi commented on pull request #40963: [SPARK-43288][SQL] DataSourceV2: CREATE TABLE LIKE

2023-09-22 Thread via GitHub
atronchi commented on PR #40963: URL: https://github.com/apache/spark/pull/40963#issuecomment-1732002000 Would it be possible to re-open this PR? The `CREATE TABLE LIKE` functionality still does not exist for DataSourceV2... -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] bjornjorgensen commented on pull request #37234: [SPARK-39822][PYTHON][PS] Provide a good feedback to users

2023-09-22 Thread via GitHub
bjornjorgensen commented on PR #37234: URL: https://github.com/apache/spark/pull/37234#issuecomment-1731983498 @bzhaoopenstack will you reopen this? If not, can I open a new PR with yours code and add you as co-writer? -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43060: URL: https://github.com/apache/spark/pull/43060#issuecomment-1731960708 Could you review this, @LuciferYang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] dongjoon-hyun commented on pull request #40390: [SPARK-42768][SQL] Enable cached plan apply AQE by default

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #40390: URL: https://github.com/apache/spark/pull/40390#issuecomment-1731959966 Thanks. Ya, I also was tracking that, @LuciferYang . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] srowen opened a new pull request, #43063: [SPARK-45286][DOCS] Add back Matomo analytics

2023-09-22 Thread via GitHub
srowen opened a new pull request, #43063: URL: https://github.com/apache/spark/pull/43063 ### What changes were proposed in this pull request? Add analytics to doc pages using the ASF's Matomo service ### Why are the changes needed? We had previously removed Google

[GitHub] [spark] ion-elgreco commented on pull request #38624: [SPARK-40559][PYTHON] Add applyInArrow to groupBy and cogroup

2023-09-22 Thread via GitHub
ion-elgreco commented on PR #38624: URL: https://github.com/apache/spark/pull/38624#issuecomment-1731949210 @HyukjinKwon since @igorghi has shown with his tests it's not possible to use repartition().mapInArrow to mimic groupbyApply, would it now make sense to add groupbyApplyInArrow? --

[GitHub] [spark] dongjoon-hyun opened a new pull request, #43062: [SPARK-45285][CORE][TESTS] Remove deprecated `Runtime.getRuntime.exec(String)` API usage

2023-09-22 Thread via GitHub
dongjoon-hyun opened a new pull request, #43062: URL: https://github.com/apache/spark/pull/43062 ### What changes were proposed in this pull request? This PR aims to remove the deprecated `Runtime.exec` methods with a single string command line. ### Why are the changes needed?

[GitHub] [spark] agubichev opened a new pull request, #43061: tests for correlated exists/IN with ORDER BY/LIMIT

2023-09-22 Thread via GitHub
agubichev opened a new pull request, #43061: URL: https://github.com/apache/spark/pull/43061 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

[GitHub] [spark] LuciferYang commented on pull request #40390: [SPARK-42768][SQL] Enable cached plan apply AQE by default

2023-09-22 Thread via GitHub
LuciferYang commented on PR #40390: URL: https://github.com/apache/spark/pull/40390#issuecomment-1731860178 @ulysses-you I found that after this PR is merged, `InMemoryColumnarBenchmark` will fail to execute. ``` build/sbt "sql/Test/runMain

[GitHub] [spark] dongjoon-hyun opened a new pull request, #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

2023-09-22 Thread via GitHub
dongjoon-hyun opened a new pull request, #43060: URL: https://github.com/apache/spark/pull/43060 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] yaooqinn closed pull request #43016: [SPARK-45077][UI][FOLLOWUP] Update comment to link the forked repo yaooqinn/dagre-d3

2023-09-22 Thread via GitHub
yaooqinn closed pull request #43016: [SPARK-45077][UI][FOLLOWUP] Update comment to link the forked repo yaooqinn/dagre-d3 URL: https://github.com/apache/spark/pull/43016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] dongjoon-hyun commented on pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43059: URL: https://github.com/apache/spark/pull/43059#issuecomment-1731767573 Merged to master for Apache Spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun closed pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version URL: https://github.com/apache/spark/pull/43059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] dongjoon-hyun commented on pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43059: URL: https://github.com/apache/spark/pull/43059#issuecomment-1731766295 Thank you so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] dongjoon-hyun commented on pull request #43056: [SPARK-45277][BUILD][INFRA] Install Java 17 to support SparkR testing on Windows

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43056: URL: https://github.com/apache/spark/pull/43056#issuecomment-1731765149 Merged to master~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] dongjoon-hyun closed pull request #43056: [SPARK-45277][BUILD][INFRA] Install Java 17 to support SparkR testing on Windows

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43056: [SPARK-45277][BUILD][INFRA] Install Java 17 to support SparkR testing on Windows URL: https://github.com/apache/spark/pull/43056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334634163 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles:

[GitHub] [spark] viirya commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
viirya commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334632685 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles: Boolean =

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334632610 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles:

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334631707 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles:

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334629527 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles:

[GitHub] [spark] viirya commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
viirya commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334628023 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles: Boolean =

[GitHub] [spark] viirya commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
viirya commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334628023 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles: Boolean =

[GitHub] [spark] dongjoon-hyun commented on pull request #42943: [SPARK-45175][K8S] download krb5.conf from remote storage in spark-submit on k8s

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #42943: URL: https://github.com/apache/spark/pull/42943#issuecomment-1731745429 Thank you for your decision, @dcoliversun . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] LuciferYang commented on pull request #43056: [SPARK-45277][BUILD][INFRA] Install Java 17 to support SparkR testing on Windows

2023-09-22 Thread via GitHub
LuciferYang commented on PR #43056: URL: https://github.com/apache/spark/pull/43056#issuecomment-1731734955 https://github.com/apache/spark/assets/1475305/2df78203-3cfd-4e5e-b162-d0bd38b3615d;> Passed -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun opened a new pull request, #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun opened a new pull request, #43059: URL: https://github.com/apache/spark/pull/43059 … ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[GitHub] [spark] dongjoon-hyun commented on pull request #43035: [SPARK-45256][SQL] DurationWriter fails when writing more values than initial capacity

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43035: URL: https://github.com/apache/spark/pull/43035#issuecomment-1731694203 Merged to master for Apache Spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun closed pull request #43035: [SPARK-45256][SQL] DurationWriter fails when writing more values than initial capacity

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43035: [SPARK-45256][SQL] DurationWriter fails when writing more values than initial capacity URL: https://github.com/apache/spark/pull/43035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] dongjoon-hyun closed pull request #43057: [SPARK-45280][INFRA] Change Maven daily test use Java 17 for testing

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43057: [SPARK-45280][INFRA] Change Maven daily test use Java 17 for testing URL: https://github.com/apache/spark/pull/43057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] gengliangwang commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-22 Thread via GitHub
gengliangwang commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1334552910 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala: ## @@ -61,68 +62,92 @@ case class PrintToStderr(child: Expression) extends

[GitHub] [spark] gengliangwang commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-22 Thread via GitHub
gengliangwang commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1334552099 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala: ## @@ -61,68 +62,92 @@ case class PrintToStderr(child: Expression) extends

[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-22 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1334513626 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4432,6 +4432,17 @@ object SQLConf { .booleanConf

[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-22 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1334513626 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4432,6 +4432,17 @@ object SQLConf { .booleanConf

[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-22 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1334511376 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala: ## @@ -61,68 +62,97 @@ case class PrintToStderr(child: Expression) extends

[GitHub] [spark] ishnagy commented on pull request #33550: [SPARK-36321][K8S] Do not fail application in kubernetes if name is too long

2023-09-22 Thread via GitHub
ishnagy commented on PR #33550: URL: https://github.com/apache/spark/pull/33550#issuecomment-1731539550 Hi @ulysses-you , @attilapiros I'd like to work on this issue and tie up all the loose ends left. If you're ok with it, I'd like to open a new PR from my private repo

[GitHub] [spark] yaooqinn commented on pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork

2023-09-22 Thread via GitHub
yaooqinn commented on PR #43053: URL: https://github.com/apache/spark/pull/43053#issuecomment-1731521203 cc @sarutak @cloud-fan @dongjoon-hyun @HyukjinKwon @mridulm, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] LuciferYang opened a new pull request, #43058: Test new ammonite

2023-09-22 Thread via GitHub
LuciferYang opened a new pull request, #43058: URL: https://github.com/apache/spark/pull/43058 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] LuciferYang commented on a diff in pull request #43005: [SPARK-44112][BUILD][INFRA][DOCS] Drop support for Java 8 and Java 11

2023-09-22 Thread via GitHub
LuciferYang commented on code in PR #43005: URL: https://github.com/apache/spark/pull/43005#discussion_r1334415482 ## dev/infra/Dockerfile: ## @@ -30,7 +30,7 @@ RUN apt-get update && apt-get install -y \ pkg-config \ curl \ wget \ -openjdk-8-jdk \ +

[GitHub] [spark] LuciferYang opened a new pull request, #43057: [SPARK-45280] Change Maven daily test use Java 17 for testing.

2023-09-22 Thread via GitHub
LuciferYang opened a new pull request, #43057: URL: https://github.com/apache/spark/pull/43057 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] Yikun commented on a diff in pull request #43005: [SPARK-44112][BUILD][INFRA][DOCS] Drop support for Java 8 and Java 11

2023-09-22 Thread via GitHub
Yikun commented on code in PR #43005: URL: https://github.com/apache/spark/pull/43005#discussion_r1334402022 ## dev/infra/Dockerfile: ## @@ -30,7 +30,7 @@ RUN apt-get update && apt-get install -y \ pkg-config \ curl \ wget \ -openjdk-8-jdk \ +

[GitHub] [spark] LuciferYang commented on pull request #43032: [SPARK-45252][CORE] Escape the greater/less than symbols in the comments to make `sbt doc` execute successfully

2023-09-22 Thread via GitHub
LuciferYang commented on PR #43032: URL: https://github.com/apache/spark/pull/43032#issuecomment-1731439172 Thanks @dongjoon-hyun and @mridulm ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] srowen commented on pull request #43028: [SPARK-45248][CORE]Set the timeout for spark ui server

2023-09-22 Thread via GitHub
srowen commented on PR #43028: URL: https://github.com/apache/spark/pull/43028#issuecomment-1731429696 OK, please put a comment in the code about why this is set lower than usual. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] LuciferYang closed pull request #43054: Test Appveyor use pre-installed java 17

2023-09-22 Thread via GitHub
LuciferYang closed pull request #43054: Test Appveyor use pre-installed java 17 URL: https://github.com/apache/spark/pull/43054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] LuciferYang opened a new pull request, #43056: [SPARK-45277][INFRA] Install Java 17 for Windows SparkR test

2023-09-22 Thread via GitHub
LuciferYang opened a new pull request, #43056: URL: https://github.com/apache/spark/pull/43056 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] LuciferYang commented on pull request #43005: [SPARK-44112][BUILD][INFRA][DOCS] Drop support for Java 8 and Java 11

2023-09-22 Thread via GitHub
LuciferYang commented on PR #43005: URL: https://github.com/apache/spark/pull/43005#issuecomment-1731366636 Thanks @dongjoon-hyun @HyukjinKwon @bjornjorgensen and @cfmcgrady ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] sander-goos commented on pull request #43035: [SPARK-45256][SQL] DurationWriter fails when writing more values than initial capacity

2023-09-22 Thread via GitHub
sander-goos commented on PR #43035: URL: https://github.com/apache/spark/pull/43035#issuecomment-1731360942 > +1, this PR looks reasonable (Pending CIs). There is no perf regression for the case which fits the limit, right, @sander-goos ? There shouldn't be a perf regression; the

[GitHub] [spark] dongjoon-hyun commented on pull request #43025: [SPARK-45247][BUILD][PYTHON][PS] Upgrade Pandas to 2.1.1

2023-09-22 Thread via GitHub
dongjoon-hyun commented on PR #43025: URL: https://github.com/apache/spark/pull/43025#issuecomment-1731345459 Merged to master for Apache Spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun closed pull request #43025: [SPARK-45247][BUILD][PYTHON][PS] Upgrade Pandas to 2.1.1

2023-09-22 Thread via GitHub
dongjoon-hyun closed pull request #43025: [SPARK-45247][BUILD][PYTHON][PS] Upgrade Pandas to 2.1.1 URL: https://github.com/apache/spark/pull/43025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   >