stefanbuk-db commented on code in PR #45407:
URL: https://github.com/apache/spark/pull/45407#discussion_r1519220632
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkIntervalUtils.scala:
##
@@ -229,13 +237,21 @@ trait SparkIntervalUtils {
try {
yaooqinn opened a new pull request, #45456:
URL: https://github.com/apache/spark/pull/45456
### What changes were proposed in this pull request?
This PR upgrades the DB2 Docker image version to 11.5.8.0 used by
docker-integration tests
https://hub.docker.com/r/ibmco
stefanbuk-db commented on code in PR #45407:
URL: https://github.com/apache/spark/pull/45407#discussion_r1519209532
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -2060,6 +2085,74 @@
},
"sqlState" : "42000"
},
+ "INVALID_INTERVAL_FORMAT" : {
+
stefanbuk-db commented on code in PR #45407:
URL: https://github.com/apache/spark/pull/45407#discussion_r1519208459
##
sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala:
##
@@ -283,10 +283,10 @@ case class StructType(fields: Array[StructField]) extends
DataType
stefanbuk-db commented on code in PR #45407:
URL: https://github.com/apache/spark/pull/45407#discussion_r1519208319
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -1823,6 +1830,24 @@
},
"sqlState" : "HY109"
},
+ "INVALID_DATETIME_PATTERN" : {
+
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519192303
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519192303
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
anishshri-db commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519187563
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519185494
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
richardc-db opened a new pull request, #45455:
URL: https://github.com/apache/spark/pull/45455
### What changes were proposed in this pull request?
Adds the Variant singleton
### Why are the changes needed?
Dependent projects (i.e. Delta kernel) require access to
anishshri-db commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519178347
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (
cloud-fan commented on code in PR #45440:
URL: https://github.com/apache/spark/pull/45440#discussion_r1519158838
##
sql/core/src/main/scala/org/apache/spark/sql/internal/SparkAnalyzer.scala:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
cloud-fan commented on code in PR #45436:
URL: https://github.com/apache/spark/pull/45436#discussion_r1519141471
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -138,11 +138,13 @@ public Collation(
collationTable[2] = new Colla
cloud-fan commented on code in PR #45438:
URL: https://github.com/apache/spark/pull/45438#discussion_r1519136321
##
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala:
##
@@ -540,10 +540,11 @@ object QueryExecution {
}
/**
- * Converts asserts,
zwangsheng commented on PR #45454:
URL: https://github.com/apache/spark/pull/45454#issuecomment-1987590065
Hi @holdenk, could you please take a review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zwangsheng opened a new pull request, #45454:
URL: https://github.com/apache/spark/pull/45454
### What changes were proposed in this pull request?
Log a warning when shuffle tracking is enabled along side another DA
supported mechanism
### Why are the changes needed?
panbingkun commented on code in PR #44665:
URL: https://github.com/apache/spark/pull/44665#discussion_r1519100897
##
python/pyspark/sql/functions/builtin.py:
##
@@ -15534,19 +15532,7 @@ def to_csv(col: "ColumnOrName", options:
Optional[Dict[str, str]] = None) -> Col
|
zhengruifeng commented on PR #45450:
URL: https://github.com/apache/spark/pull/45450#issuecomment-1987526057
thanks @HyukjinKwon for reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
HeartSaVioR commented on code in PR #45341:
URL: https://github.com/apache/spark/pull/45341#discussion_r1519035053
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MapStateImpl.scala:
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
yaooqinn commented on PR #45443:
URL: https://github.com/apache/spark/pull/45443#issuecomment-1987507628
Late +1 & LGTM. Thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
LuciferYang commented on code in PR #44665:
URL: https://github.com/apache/spark/pull/44665#discussion_r1519047021
##
python/pyspark/sql/functions/builtin.py:
##
@@ -15534,19 +15532,7 @@ def to_csv(col: "ColumnOrName", options:
Optional[Dict[str, str]] = None) -> Col
|
HyukjinKwon closed pull request #45435: [SPARK-47324][SQL] Add missing
timestamp conversion for JDBC nested types
URL: https://github.com/apache/spark/pull/45435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
HyukjinKwon commented on PR #45435:
URL: https://github.com/apache/spark/pull/45435#issuecomment-1987437571
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HeartSaVioR closed pull request #45447: [SS][SPARK-47331] Serialization using
case classes/primitives/POJO based on SQL encoder for Arbitrary State API v2.
URL: https://github.com/apache/spark/pull/45447
--
This is an automated message from the Apache Git Service.
To respond to the message, p
HyukjinKwon closed pull request #45437: [MINOR][DOCS][SQL] Fix doc comment for
coalescePartitions.parallelismFirst
URL: https://github.com/apache/spark/pull/45437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
HeartSaVioR commented on PR #45447:
URL: https://github.com/apache/spark/pull/45447#issuecomment-1987429917
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
HeartSaVioR commented on PR #45447:
URL: https://github.com/apache/spark/pull/45447#issuecomment-1987429802
GA failure happened only in Pyspark connect, and these failed suites do not
have relationship with this change.
--
This is an automated message from the Apache Git Service.
To respo
HyukjinKwon commented on PR #45437:
URL: https://github.com/apache/spark/pull/45437#issuecomment-1987426378
Merged to master, branch-3.5 and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
HyukjinKwon commented on PR #45441:
URL: https://github.com/apache/spark/pull/45441#issuecomment-1987424381
Mind filing a JIRA at https://issues.apache.org/jira/projects/SPARK? See
also https://spark.apache.org/contributing.html
--
This is an automated message from the Apache Git Service.
HyukjinKwon closed pull request #45444: [SPARK-47035][SS][CONNECT][FOLLOWUP]
Additional protobuf change to client side listener
URL: https://github.com/apache/spark/pull/45444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
HyukjinKwon commented on PR #45444:
URL: https://github.com/apache/spark/pull/45444#issuecomment-1987423411
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HyukjinKwon commented on PR #45448:
URL: https://github.com/apache/spark/pull/45448#issuecomment-1987423181
Pending CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
HyukjinKwon closed pull request #45450: [SPARK-47334][SQL] Make
`withColumnRenamed` reuse the implementation of `withColumnsRenamed`
URL: https://github.com/apache/spark/pull/45450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HyukjinKwon commented on PR #45450:
URL: https://github.com/apache/spark/pull/45450#issuecomment-1987422732
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HyukjinKwon closed pull request #45433: [SPARK-47325][INFRA] Use the latest
`buf-setup-action` in github workflow
URL: https://github.com/apache/spark/pull/45433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
HyukjinKwon commented on PR #45433:
URL: https://github.com/apache/spark/pull/45433#issuecomment-1987417581
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HeartSaVioR commented on PR #45449:
URL: https://github.com/apache/spark/pull/45449#issuecomment-1987415681
(Btw, I missed the JIRA ticket is reused - best practice for this case is
adding `[FOLLOWUP]` explicitly in the title. Just FYI.)
--
This is an automated message from the Apache Git
HeartSaVioR closed pull request #45449: [SPARK-47200][SS] Make Foreach batch
sink user function error handling backward compatible
URL: https://github.com/apache/spark/pull/45449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
HeartSaVioR commented on PR #45449:
URL: https://github.com/apache/spark/pull/45449#issuecomment-1987415009
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
HeartSaVioR commented on PR #45449:
URL: https://github.com/apache/spark/pull/45449#issuecomment-1987414965
GA failure only happened in Spark connect, which is not related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
HyukjinKwon commented on PR #45379:
URL: https://github.com/apache/spark/pull/45379#issuecomment-1987414093
(let's file a new JIRA next time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
HyukjinKwon closed pull request #45379: [SPARK-47218] [SQL] XML: Changed
SchemaOfXml to fail on DROPMALFORMED mode
URL: https://github.com/apache/spark/pull/45379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
HyukjinKwon commented on PR #45379:
URL: https://github.com/apache/spark/pull/45379#issuecomment-1987413908
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519006106
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519009915
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519006106
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519006106
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1519006106
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
GideonPotok opened a new pull request, #45453:
URL: https://github.com/apache/spark/pull/45453
### What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-46840
[Collation Support in
Spark.docx](https://github.com/apache/spark/
neilramaswamy commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1518995350
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation
MaxGekk closed pull request #45439: [MINOR][SQL][TEST] Moving tests to related
suites
URL: https://github.com/apache/spark/pull/45439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
MaxGekk commented on PR #45439:
URL: https://github.com/apache/spark/pull/45439#issuecomment-1987338068
+1, LGTM. Merging to master.
Thank you, @mihailom-db and @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
MaxGekk commented on code in PR #44665:
URL: https://github.com/apache/spark/pull/44665#discussion_r1518964720
##
python/pyspark/sql/functions/builtin.py:
##
@@ -15534,19 +15532,7 @@ def to_csv(col: "ColumnOrName", options:
Optional[Dict[str, str]] = None) -> Col
| 2,
panbingkun commented on code in PR #45451:
URL: https://github.com/apache/spark/pull/45451#discussion_r1518848989
##
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java:
##
@@ -114,7 +114,7 @@ public boolean isFinal() {
*
* @since 1.6.0
*/
- public
panbingkun opened a new pull request, #45452:
URL: https://github.com/apache/spark/pull/45452
### What changes were proposed in this pull request?
The pr aims to upgrade `mvn-scalafmt` from `1.1.1640084764.9f463a9` to
`1.1.1684076452.9f83818`.
### Why are the changes needed?
panbingkun opened a new pull request, #45451:
URL: https://github.com/apache/spark/pull/45451
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
MaxGekk commented on PR #45167:
URL: https://github.com/apache/spark/pull/45167#issuecomment-1987157200
> If you have time, can you help me review this PR
https://github.com/apache/spark/pull/44665 first?
I will look at it soon. Thanks.
--
This is an automated message from the Apac
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1518795524
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1518795524
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1518795524
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1518795524
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1518795524
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
HeartSaVioR commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1518795524
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (A
63 matches
Mail list logo
