[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

2018-12-03 Thread CarolinePeng
Github user CarolinePeng commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238523807 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -377,41 +377,42 @@ abstract class DDLSuite extends

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

2018-12-01 Thread CarolinePeng
Github user CarolinePeng commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238063442 --- Diff: core/src/main/scala/org/apache/spark/memory/ExecutionMemoryPool.scala --- @@ -37,7 +37,7 @@ import org.apache.spark.internal.Logging

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

2018-12-01 Thread CarolinePeng
GitHub user CarolinePeng opened a pull request: https://github.com/apache/spark/pull/23194 [MINOR][SQL] Combine the same codes in test cases ## What changes were proposed in this pull request? In the DDLSuit, there are four test cases have the same codes , writing

[GitHub] spark pull request #22694: [SQL][CATALYST] update comment about RewriteDisti...

2018-10-11 Thread CarolinePeng
GitHub user CarolinePeng opened a pull request: https://github.com/apache/spark/pull/22694 [SQL][CATALYST] update comment about RewriteDistinctAggregates ## What changes were proposed in this pull request? this PR correct a comment from "as low a possible"