Github user JasmineGeorge commented on the issue:
https://github.com/apache/spark/pull/7842
removed all blank lines except the one in the import statements between
different groups. Tests have passed. Are we ready to merge
Github user JasmineGeorge commented on a diff in the pull request:
https://github.com/apache/spark/pull/7842#discussion_r146416252
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/pmml/export/PMMLTreeModelUtils.scala
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-212650221
ready for merge.
Which is the new mllib code base ?? mllib-local ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-154395939
@yinxusen does everything look good now ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/9057#issuecomment-152181045
Sorry I can't get to it until next Wednesday.. Can someone else take over
---
If your project is set up for it, you can reply to this email and have your
reply
Github user JasmineGeorge commented on a diff in the pull request:
https://github.com/apache/spark/pull/7842#discussion_r43259689
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/pmml/export/PMMLTreeModelUtils.scala
---
@@ -0,0 +1,282 @@
+/*
+ * Licensed
Github user JasmineGeorge commented on a diff in the pull request:
https://github.com/apache/spark/pull/7842#discussion_r43259992
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/pmml/export/PMMLTreeModelUtils.scala
---
@@ -0,0 +1,282 @@
+/*
+ * Licensed
Github user JasmineGeorge commented on a diff in the pull request:
https://github.com/apache/spark/pull/9057#discussion_r43117338
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/pmml/export/NaiveBayesPMMLModelExport.scala
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-151464879
Sure @mengxr I can review @yinxusen PR #9057
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user JasmineGeorge commented on a diff in the pull request:
https://github.com/apache/spark/pull/9057#discussion_r43131125
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/pmml/export/NaiveBayesPMMLModelExportSuite.scala
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-150469784
@coderxiang I was just wondering what would be the next step ?
Haven't heard from anyone for 3 weeks.
---
If your project is set up for it, you can reply
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-147580075
@mengxr whats the next step ??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-144599967
Thanks a lot @selvinsource.
@mengxr is there anything we should be adding/changing ? Please let me know.
Once these changes are merged I will start
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-142015391
Changes Done
- renamed TreeModelUtils to PMMLTreeModelUtils
- added target field for the regression model
- for the classification model, now
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-139230019
When I ran the evaluator I realized the evaluator expects that the root
node predicate should always have predicate True.
And every node has the predicate
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-139248295
There are changes in the spark-pmml-exporter-validator. the pmml for
decision-tree classification and also the tree evaluator method
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-138843989
found issues when ran the evaluator. Wait for new changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-136638167
Had one question regarding returning the fields in normal order. By normal
order you mean sorted lexicographically or by the double value of the fields
e.g
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-136586349
Probably missed one point, that is returning the miningfields and
datafields in normal order. Will do that tonight and checkin.
---
If your project is set up
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-136585584
Made the changes. Now the FieldName is instantiated once and reused by
DataField, MiningField and Predicates. Added default True predicate for leaf
nodes
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-134108436
l will make the changes and get back. Thanks for all the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-132294464
formatted those files as well. Sorry I missed them last time.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-132269214
I got the scala import formatter plugin to work finally. This time the
imports should be formatted correctly.
---
If your project is set up for it, you can reply
Github user JasmineGeorge commented on a diff in the pull request:
https://github.com/apache/spark/pull/7842#discussion_r36671219
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/pmml/export/TreeModelUtils.scala ---
@@ -0,0 +1,274 @@
+/*
+ * Licensed to the Apache
Github user JasmineGeorge commented on a diff in the pull request:
https://github.com/apache/spark/pull/7842#discussion_r36670784
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/pmml/export/DecisionTreePMMLModelExport.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed
Github user JasmineGeorge commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-129650266
changes requested are done !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user JasmineGeorge commented on a diff in the pull request:
https://github.com/apache/spark/pull/7842#discussion_r36670729
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/pmml/export/TreeModelUtils.scala ---
@@ -0,0 +1,274 @@
+/*
+ * Licensed to the Apache
GitHub user JasmineGeorge opened a pull request:
https://github.com/apache/spark/pull/7842
[SPARK-8542][MLlib]PMML export for Decision Trees
Added support for PMML export for Decision Trees
You can merge this pull request into a Git repository by running:
$ git pull https
28 matches
Mail list logo
