[GitHub] spark issue #23269: [SPARK-26316] Currently the wrong implementation in the ...

Github user JkSelf commented on the issue: https://github.com/apache/spark/pull/23269 @viirya ok I will update. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join"

Github user JkSelf commented on the issue: https://github.com/apache/spark/pull/23204 @cloud-fan the new ticket is in [here](https://github.com/apache/spark/pull/23269 ). I will close this ticket

[GitHub] spark pull request #23269: partial revert 21052 because of the performance d...

GitHub user JkSelf opened a pull request: https://github.com/apache/spark/pull/23269 partial revert 21052 because of the performance degradation in TPC-DS ## What changes were proposed in this pull request? We tested TPC-DS in spark2.3 with and without [L486](https

[GitHub] spark issue #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join"

Github user JkSelf commented on the issue: https://github.com/apache/spark/pull/23204 @cloud-fan @dongjoon-hyun update the patch, please help review if you have time. Thanks. --- - To unsubscribe, e-mail: reviews

[GitHub] spark issue #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join"

Github user JkSelf commented on the issue: https://github.com/apache/spark/pull/23204 @cloud-fan ok, i will revert as your comments later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join"

Github user JkSelf commented on the issue: https://github.com/apache/spark/pull/23204 The result of all queries in tpcds with 1TB data scale is in [tpcds result](https://docs.google.com/spreadsheets/d/18a5BdOlmm8euTaRodyeWum9yu92mbWWu6JbhGXtr7yE/edit#gid=0

[GitHub] spark issue #23214: [SPARK-26155] Optimizing the performance of LongToUnsafe...

Github user JkSelf commented on the issue: https://github.com/apache/spark/pull/23214 @LuciferYang the patch is fine in my test environment. @adrian-wang I will run all the tpcds queries in spark2.3 and spark2.3 with this patch later

[GitHub] spark issue #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join"

Github user JkSelf commented on the issue: https://github.com/apache/spark/pull/23204 **Cluster info:**   | Master Node | Worker Nodes -- | -- | -- Node | 1x | 4x Processor | Intel(R) Xeon(R) Platinum 8170 CPU @ 2.10GHz | Intel(R) Xeon(R) Platinum 8180 CPU

[GitHub] spark pull request #23204: Revert "[SPARK-21052][SQL] Add hash map metrics t...

GitHub user JkSelf opened a pull request: https://github.com/apache/spark/pull/23204 Revert "[SPARK-21052][SQL] Add hash map metrics to join" Because of the performance degradation discussion in [SPARK-26155](https://issues.apache.org/jira/browse/SPARK-26155), currently