[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-19 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r145845879 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request #19527: [SPARK-13030][ML] Create OneHotEncoderEstimator f...

2017-10-18 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19527#discussion_r145531800 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoderEstimator.scala --- @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-18 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r145501280 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-18 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r145499084 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-12 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144365856 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-12 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144363062 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-11 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144128955 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-11 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r144127767 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r143853274 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r143799505 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r143794449 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r143799083 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r143798662 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark issue #18896: [SPARK-21681][ML] fix bug of MLOR do not work correctly ...

2017-08-15 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/18896 @jkbradley please take a look when you get a chance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #18896: [SPARK-21681][ML] fix bug of MLOR do not work cor...

2017-08-15 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/18896#discussion_r133301688 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -1392,6 +1415,61 @@ class LogisticRegressionSuite

[GitHub] spark pull request #18888: [Spark-17025][ML][Python] Persistence for Pipelin...

2017-08-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r132575143 --- Diff: python/pyspark/ml/pipeline.py --- @@ -242,3 +327,65 @@ def _to_java(self): JavaParams._new_java_obj

[GitHub] spark pull request #18888: [Spark-17025][ML][Python] Persistence for Pipelin...

2017-08-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r132561786 --- Diff: python/pyspark/ml/pipeline.py --- @@ -242,3 +327,65 @@ def _to_java(self): JavaParams._new_java_obj

[GitHub] spark pull request #18888: [Spark-17025][ML][Python] Persistence for Pipelin...

2017-08-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r132531424 --- Diff: python/pyspark/ml/pipeline.py --- @@ -16,14 +16,15 @@ # import sys +import os if sys.version >

[GitHub] spark pull request #18888: [Spark-17025][ML][Python] Persistence for Pipelin...

2017-08-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r132560721 --- Diff: python/pyspark/ml/pipeline.py --- @@ -130,13 +131,20 @@ def copy(self, extra=None): @since("2.0.0") def

[GitHub] spark pull request #18888: [Spark-17025][ML][Python] Persistence for Pipelin...

2017-08-10 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r132562392 --- Diff: python/pyspark/ml/tests.py --- @@ -1142,6 +1142,35 @@ def test_nested_pipeline_persistence(self): except OSError

[GitHub] spark issue #17373: [SPARK-12664] Expose probability in mlp model

2017-08-08 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/17373 Thanks for the changes @WeichenXu123. I don't have any other comments @jkbradley do you want to have a look? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-01 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r130746928 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -463,7 +479,7 @@ private[ml] class FeedForwardModel private( private var

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-01 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r130747030 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -363,7 +363,7 @@ private[ann] trait TopologyModel extends Serializable

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-01 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r130746665 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -463,7 +479,7 @@ private[ml] class FeedForwardModel private( private var

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-01 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r130747996 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala --- @@ -82,6 +83,23 @@ class

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] Avoid passing float to ndar...

2017-05-24 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/18081 @viirya I was running python tests for pyspark-ml and pyspark-mllib and this was the only place where the python3/numpy interaction caused a test failure. There might be other places where floor int

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] Avoid passing float to ndar...

2017-05-24 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/18081 @srowen floor divide has been in python since 2.2, https://www.python.org/download/releases/2.2/. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #18081: [SPARK-20862] BugFix - avoid passing float to nda...

2017-05-23 Thread MrBago
GitHub user MrBago opened a pull request: https://github.com/apache/spark/pull/18081 [SPARK-20862] BugFix - avoid passing float to ndarray.reshape in LogisticRegressionModel ## What changes were proposed in this pull request? Fixed TypeError with python3 and numpy 1.12.1

[GitHub] spark issue #18077: Delegate looping over paramMaps to estimators

2017-05-23 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/18077 @jkbradley can you take a look at this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18077: Delegate looping over paramMaps to estimators

2017-05-23 Thread MrBago
GitHub user MrBago opened a pull request: https://github.com/apache/spark/pull/18077 Delegate looping over paramMaps to estimators Changes: pyspark.ml Estimators can take either a list of param maps or a dict of params. This change allows the CrossValidator

[GitHub] spark pull request #17421: [SPARK-20040][ML][python] pyspark wrapper for Chi...

2017-03-27 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17421#discussion_r108299791 --- Diff: dev/sparktestsupport/modules.py --- @@ -431,6 +431,7 @@ def __hash__(self): "pyspark.ml.linalg.__i

[GitHub] spark pull request #17421: [SPARK-20040][ML][python] pyspark wrapper for Chi...

2017-03-27 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17421#discussion_r108286662 --- Diff: dev/sparktestsupport/modules.py --- @@ -431,6 +431,7 @@ def __hash__(self): "pyspark.ml.linalg.__i

[GitHub] spark pull request #17421: [SPARK-20040][ML][python] pyspark wrapper for Chi...

2017-03-24 Thread MrBago
GitHub user MrBago opened a pull request: https://github.com/apache/spark/pull/17421 [SPARK-20040][ML][python] pyspark wrapper for ChiSquareTest ## What changes were proposed in this pull request? A pyspark wrapper for spark.ml.stat.ChiSquareTest ## How

<    1   2