Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-209673821
@dilipbiswal Thanks for working on this. I think it looks pretty good
overall. The existing API for show partitions is a little too tied to Hive so I
suggested an
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636620
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +133,103 @@ class HiveCommandSuite extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636516
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +133,103 @@ class HiveCommandSuite extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636373
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636244
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635926
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635881
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635840
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635781
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635435
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59634825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -409,6 +409,25 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59633351
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -404,6 +404,28 @@ private[hive] class HiveClientImpl
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59631726
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12356#issuecomment-209642363
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12362#issuecomment-209641967
@viirya we just merged a patch that implements `CREATE TABLE`. It would be
good if you can rebase. Some of the changes in that patch may be relevant here.
---
If
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59622663
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -55,6 +55,7 @@ statement
rowFormat
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59622384
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -203,6 +204,32 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59622497
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -203,6 +204,32 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59621980
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59621802
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59621625
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59621513
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59621219
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -55,6 +55,7 @@ statement
rowFormat
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12362#discussion_r59621133
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -55,6 +55,7 @@ statement
rowFormat
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209600458
@gatorsmile that's a good point. I think a better goal of the issue is to
make the tests consistent and make sure the functionality of the test suites
are cl
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12314#discussion_r59606712
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala
---
@@ -17,36 +17,21 @@
package
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12314#discussion_r59606692
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala
---
@@ -17,36 +17,21 @@
package
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12327#issuecomment-209595775
@cloud-fan Can you add a test to `ClosureCleanerSuite2`? Otherwise this
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12327#discussion_r59605684
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -233,16 +217,22 @@ private[spark] object ClosureCleaner extends Logging
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12327#discussion_r59605580
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -233,16 +217,22 @@ private[spark] object ClosureCleaner extends Logging
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12327#discussion_r59605473
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -233,16 +217,22 @@ private[spark] object ClosureCleaner extends Logging
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12363#issuecomment-209574950
OK, let's close this PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12363#issuecomment-209536036
OK, I cherry-picked your changes and updated the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-209536129
OK, I cherry-picked your changes and updated the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59580227
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -675,34 +680,38 @@ private[hive] class HiveClientImpl
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-209172015
I've ignored some tests in `HiveCompatibilitySuite` for now. I'll have a
look at them shortly. I just wanted to see if the rest of the tests will pass.
-
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12314#discussion_r59459447
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -29,6 +29,7 @@ import
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12314#discussion_r59459425
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala
---
@@ -17,36 +17,21 @@
package
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12314#issuecomment-209115133
There's a lot more to this issue than just changing this hierarchy. In the
parsers we still throw `AnalysisException` sometimes but `ParseException`
others. I
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-209091270
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59426592
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,82 +136,117 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-209031556
Thanks for the reviews. Latest commit should pass tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59423143
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -121,84 +123,114 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/961#issuecomment-209024020
@ouyangshourui this is not at all the same issue. Please file a JIRA with
your stack trace and mark the affected version as 2.0
---
If your project is set up for it
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-208665982
I'll have a look at the failing tests in a couple of hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12220#discussion_r59308833
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -367,9 +367,27 @@ private[hive] class HiveClientImpl
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12220#issuecomment-208654664
@gatorsmile that would be great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12311#issuecomment-208622959
Looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12311#discussion_r59300812
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
---
@@ -55,6 +55,12 @@ private[ui] class AllExecutionsPage
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59300573
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59300596
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,82 +136,117 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12285#issuecomment-208594142
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12301#issuecomment-208594045
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12303#issuecomment-208593831
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12303#discussion_r59293221
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -23,9 +23,8 @@ import org.apache.spark.sql.catalyst.planning
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59280363
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -218,14 +219,35 @@ case class CatalogTable
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59280215
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -218,14 +219,35 @@ case class CatalogTable
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59137856
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,82 +136,117 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59137836
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -397,11 +429,28 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59137814
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,82 +136,117 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207932122
Merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12236#issuecomment-207931911
OK, merging into master, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12275#issuecomment-207931542
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12275#discussion_r59128181
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -659,9 +659,18 @@ private[hive] class HiveClientImpl
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12275#issuecomment-207931468
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59123872
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -665,9 +672,17 @@ private[hive] class HiveClientImpl
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59123869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -218,14 +219,35 @@ case class CatalogTable
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59111501
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -271,8 +271,7 @@ createFileFormat
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59111479
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -320,8 +320,6 @@ class DDLSuite extends QueryTest with
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59111469
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -176,29 +176,6 @@ case class DescribeDatabase
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/12271
[SPARK-14388][SQL][WIP] Implement CREATE TABLE
## What changes were proposed in this pull request?
This patch implements the `CREATE TABLE` command using the
`SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12255#discussion_r59099032
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -206,7 +203,7 @@ class SparkSqlAstBuilder extends AstBuilder
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12220#issuecomment-207618996
OK, let's do that in a separate patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12220#issuecomment-207598920
Looks like #12169 already added the check in the parser so we don't have to
add it ourselves. The last commit just removes the bad comment and adds two
test
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207565240
Fixed. retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207540334
Oh never mind, looks like Jenkins is broken at the moment:
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-maven-hadoop-2.3
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207538976
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r59065155
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -321,7 +321,7 @@ private[spark] class Executor(
logInfo(s
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207536042
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r59063855
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -321,7 +321,7 @@ private[spark] class Executor(
logInfo(s
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12244#issuecomment-207152329
Thanks, merged into master, 1.6, 1.5 and 1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r58967525
--- Diff: core/src/test/scala/org/apache/spark/util/CausedBySuite.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r58967540
--- Diff: core/src/main/scala/org/apache/spark/util/CausedBy.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207150584
Looks great. Representing it in `unapply` is quite elegant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207150346
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12249#issuecomment-207149949
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12244#issuecomment-207122922
@JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/12244
[SPARK-14468] Always enable OutputCommitCoordinator
## What changes were proposed in this pull request?
`OutputCommitCoordinator` was introduced to deal with concurrent task
attempts
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12236#issuecomment-207069952
@tdas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12220#issuecomment-206624499
@yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12211#issuecomment-206616463
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12197#discussion_r58796667
--- Diff: docs/building-spark.md ---
@@ -190,13 +190,6 @@ or
Java 8 tests are automatically enabled when a Java 8 JDK is detected.
If you have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12221#issuecomment-206609632
style checks already passed, merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12197#issuecomment-206608380
LGTM merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12218#issuecomment-206602404
@dragos @tnachen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12154#issuecomment-206601300
Merged into master thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12221#issuecomment-206601901
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12218#issuecomment-206602300
@elmalto please add `[Docs][Minor]` to the title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12210#issuecomment-206600432
`LauncherServerSuite` already passed. I'm merging this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appe
801 - 900 of 10529 matches
Mail list logo
