GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/12220
[SPARK-14132][SPARK-14133][SQL] Alter table partition DDLs
## What changes were proposed in this pull request?
This implements a few alter table partition commands using the
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12203#issuecomment-206514469
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12203#discussion_r58762547
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -519,8 +528,7 @@ private[spark] class Client(
).foreach { case
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58762264
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
---
@@ -0,0 +1,233 @@
+/*
+ * Licensed
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12154#issuecomment-206513739
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58762163
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
---
@@ -100,12 +115,13 @@ private[streaming
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-206499791
ping @yhuai do we need to create a directory for the database?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12156#issuecomment-206498803
Merged into master. Good catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12206#issuecomment-206493611
I'll fix those myself on merge actually. Merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12206#issuecomment-206491670
LGTM, just a few style nits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12206#discussion_r58752400
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
---
@@ -52,4 +52,26 @@ object StringUtils {
def
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12206#discussion_r58752254
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
---
@@ -52,4 +52,26 @@ object StringUtils {
def
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12199#issuecomment-206488388
Merging into master thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12199#issuecomment-206141117
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12198#issuecomment-206140681
@yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12183#issuecomment-206136314
@rekhajoshm I've opened #12198 to illustrate what I mean. I don't think the
changes in this patch are correct so I would recommend that we close this PR
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/12198
[SPARK-14410][SQL] Push functions existence check into catalog
## What changes were proposed in this pull request?
This is a followup to #12117 and addresses some of the TODOs
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12193#issuecomment-206127119
LGTM merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12169#issuecomment-206126467
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12188#issuecomment-206126096
Mergd into amster
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12188#issuecomment-206069989
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58634134
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -47,18 +48,40 @@ case class AnalyzeTable(tableName: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58634059
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -47,18 +48,40 @@ case class AnalyzeTable(tableName: String
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12188#issuecomment-206039892
retest this please, it should be fixed by now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58632900
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -113,7 +113,10 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58632748
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -47,18 +47,38 @@ case class AnalyzeTable(tableName: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12169#discussion_r58632645
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -215,11 +215,20 @@ class HiveSqlAstBuilder extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12169#issuecomment-206037824
LGTM we just need to make tests pass now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12169#issuecomment-206037592
Build is broken I think. retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12182#issuecomment-206037026
@infynyxx I think this one is on the borderline. I would just create one so
everyone is happy.
---
If your project is set up for it, you can reply to this email
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12188#issuecomment-206036235
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12188#discussion_r58632211
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -39,9 +39,12 @@ private[spark] abstract class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12188#issuecomment-206036081
Thanks, I love this patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12188#discussion_r58632162
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -43,24 +44,30 @@ class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12186#issuecomment-206035348
what... retest this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12183#issuecomment-206033483
@rekhajoshm I think there is some misunderstanding on what the issue is.
The JIRA is saying all the create/drop methods in `SessionCatalog` should take
in a flag
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12183#discussion_r58631403
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -474,15 +479,8 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12183#discussion_r58631042
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -84,15 +84,21 @@ class SessionCatalog
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12186#issuecomment-206030664
Build is broken. retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-206030529
This looks OK. @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r58630441
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -52,7 +52,10 @@ abstract class NativeDDLCommand(val sql: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r58630394
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -116,8 +116,9 @@ class SessionCatalog
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11996#issuecomment-206019800
For scheduler changes let's ping @kayousterhout and @markhamstra
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/12186
[SPARK-14128][SQL] Alter table DDL followup
## What changes were proposed in this pull request?
This is just a followup to #12121, which implemented the alter table DDLs
using the
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12186#issuecomment-206017959
@yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58624011
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -410,116 +407,41 @@ class SparkSqlAstBuilder extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58622715
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -292,11 +357,53 @@ case class AlterTableSetFileFormat
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12150#issuecomment-205960129
@jeanlyn can you close this PR now that it's merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12150#issuecomment-205959893
Merging into 1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12169#issuecomment-205959612
Looks pretty good, just a minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12169#discussion_r58600702
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -553,9 +553,13 @@ class SparkSqlAstBuilder extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205957877
Thanks @yhuai @viirya I'm merging this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58600078
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -85,24 +91,23 @@ case class DropFunction(
extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12154#issuecomment-205699344
@tdas Looks great. I think you could add more comments in the code but the
rest is pretty good.
---
If your project is set up for it, you can reply to this email
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58497305
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
@@ -234,6 +236,16 @@ class ReceiverTracker(ssc
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58497208
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobScheduler.scala
---
@@ -93,6 +103,10 @@ class JobScheduler(val ssc
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58496898
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58496601
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58496446
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58496298
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58496003
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58495835
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205560436
Thanks @yhuai. This looks pretty good. I left a few suggestions on how the
documentation, code readability and placement of functionality can be improved,
but these
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58467158
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466759
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -21,19 +21,19 @@ import scala.collection.JavaConverters
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466595
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -17,27 +17,39 @@
package org.apache.spark.sql.hive
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466640
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -112,4 +124,129 @@ class HiveSessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466523
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466440
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58465870
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58465597
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58465188
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -396,18 +400,16 @@ case class ShowFunctions(db: Option
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58465066
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -396,18 +400,16 @@ case class ShowFunctions(db: Option
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456861
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -208,6 +208,22 @@ class SQLContext private[sql
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456814
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -208,6 +208,22 @@ class SQLContext private[sql
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456761
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -208,6 +208,22 @@ class SQLContext private[sql
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -146,6 +146,7 @@ abstract class ExternalCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456466
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -524,7 +537,39 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456181
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -524,7 +537,39 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58455582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58455116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58455071
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58455003
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58454975
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58454910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58454950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58454715
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58454405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -146,6 +146,7 @@ abstract class ExternalCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58454099
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -159,6 +160,7 @@ abstract class ExternalCatalog
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58447880
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -341,9 +343,14 @@ object FunctionRegistry
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58447748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -52,6 +52,8 @@ trait FunctionRegistry
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58447785
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -49,7 +49,6 @@ object SimpleAnalyzer
class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12154#issuecomment-205493533
12133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58445982
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -410,116 +407,41 @@ class SparkSqlAstBuilder extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12132#issuecomment-205481834
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12101#issuecomment-205481087
can you close this PR now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12101#issuecomment-205480408
Merged into 1.6 thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58442629
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -534,17 +579,11 @@ class SessionCatalog
901 - 1000 of 10529 matches
Mail list logo
