[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-10-27 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/9297 [SPARK-11206] Support SQL UI on the history server On the live web UI, there is a SQL tab which provides valuable information for the SQL query. But once the workload is finished, we won'

[GitHub] spark pull request: [SPARK-11047] Internal accumulators miss the i...

2015-10-12 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/9061#issuecomment-147563864 /CC @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Internal accumulators miss the internal flag w...

2015-10-10 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/9061 Internal accumulators miss the internal flag when replaying events in the history server Internal accumulators don't write the internal flag to event log. So on the history server Web UI

[GitHub] spark pull request: [SPARK-9426][WebUI]Job page DAG visualization ...

2015-08-11 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/8104#issuecomment-129885976 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9426][WebUI]Job page DAG visualization ...

2015-08-11 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/8104 [SPARK-9426][WebUI]Job page DAG visualization is not shown To reproduce the issue, go to the stage page and click DAG Visualization once, then go to the job page to show the job DAG

[GitHub] spark pull request: [SPARK-9809]Task crashes because the internal ...

2015-08-11 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/8090#issuecomment-129776041 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9809]Task crashes because the internal ...

2015-08-10 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/8090#issuecomment-129724889 @squito , here are some further information about the issue. I was running an iterative graph-parallel algorithm which uses RDD cache for iterative computations. In

[GitHub] spark pull request: [SPARK-9809]Task crashes because the internal ...

2015-08-10 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/8090#issuecomment-129684834 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9809]Task crashes because the internal ...

2015-08-10 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/8090 [SPARK-9809]Task crashes because the internal accumulators are not properly initialized When a stage failed and another stage was resubmitted with only part of partitions to compute, all the

[GitHub] spark pull request: [SPARK-9731] Standalone scheduling incorrect c...

2015-08-07 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/8017#issuecomment-128889371 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9731] Standalone scheduling incorrect c...

2015-08-07 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/8017#discussion_r36573857 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -591,9 +591,15 @@ private[deploy] class Master( true

[GitHub] spark pull request: [SPARK-9731] Standalone scheduling incorrect c...

2015-08-06 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/8017#issuecomment-128606109 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9731] Standalone scheduling incorrect c...

2015-08-06 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/8017#issuecomment-128566324 @andrewor14 , would you mind taking a look at this? This is related to recently changes in #7274 and #7668 --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-9731] Standalone scheduling incorrect c...

2015-08-06 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/8017 [SPARK-9731] Standalone scheduling incorrect cores if spark.executor.cores is not set The issue only happens if `spark.executor.cores` is not set and executor memory is set to a high value

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-08-03 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-127455197 Thanks @sarutak . The style issues are fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-28 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125860669 Screenshots attached. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125466146 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125397558 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/7692 [SPARK-2016][WebUI]RDD partition table pagination for the RDD Page Add pagination for the RDD page to avoid unresponsive UI when the number of the RDD partitions is large. You can merge this

[GitHub] spark pull request: [SPARK-8405][Doc] Add how to view logs on Web ...

2015-07-25 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7463#issuecomment-124843304 Sorry for the delay. Updated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-8405][Doc] Add how to view logs on Web ...

2015-07-21 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7463#issuecomment-123576915 Sounds great, @tgravescs . The text was updated as you suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-9187][WebUI] Timeline view may show neg...

2015-07-20 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7526#issuecomment-122791974 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9187][WebUI] Timeline view may show neg...

2015-07-19 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/7526 [SPARK-9187][WebUI] Timeline view may show negative value for running tasks For running tasks, the executorRunTime metrics is 0 which causes negative executorComputingTime in the timeline. It

[GitHub] spark pull request: [SPARK-8405][Doc] Add how to view logs on Web ...

2015-07-17 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/7463 [SPARK-8405][Doc] Add how to view logs on Web UI when yarn log aggregation is enabled Some users may not be aware that the logs are available on Web UI even if Yarn log aggregation is enabled

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-17 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7399#issuecomment-122202978 @zsxwing , I just left some minor comments. Another problem: If a user selects to show additional metrics and sort by one metric like SchedulerDelay, the server

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-17 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34867522 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -672,164 +658,605 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-17 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34867437 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -672,164 +658,605 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-17 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34866416 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -672,164 +658,605 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-17 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34866298 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -672,164 +658,605 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-17 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34866161 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -672,164 +658,605 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-16 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34866034 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -672,164 +658,605 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-16 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34865990 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -672,164 +658,605 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-16 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34865987 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -672,164 +658,605 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-16 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7399#discussion_r34865792 --- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-4598][WebUI]Task table pagination for t...

2015-07-16 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7399#issuecomment-121886531 The REST API provides all the task information in JSON format. It seems it is easier to enable pagination on client side by consuming the JSON data. I was actually

[GitHub] spark pull request: [SPARK-8950][WebUI] Correct the calculation of...

2015-07-15 Thread carsonwang
Github user carsonwang closed the pull request at: https://github.com/apache/spark/pull/7319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8950][WebUI] Correct the calculation of...

2015-07-15 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7319#issuecomment-121792832 Sure. Thanks @kayousterhout --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-8950][WebUI] Correct the calculation of...

2015-07-12 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7319#issuecomment-120779581 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8950][WebUI] Correct the calculation of...

2015-07-09 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7319#discussion_r34321691 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -852,32 +852,29 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8950][WebUI] Correct the calculation of...

2015-07-09 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7319#discussion_r34321580 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -852,32 +852,29 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8950][WebUI] Correct the calculation of...

2015-07-09 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/7319 [SPARK-8950][WebUI] Correct the calculation of SchedulerDelay in StagePage In StagePage, the SchedulerDelay is calculated as totalExecutionTime - executorRunTime - executorOverhead

[GitHub] spark pull request: [SPARK-8405][WebUI] Show executor logs on Web ...

2015-06-29 Thread carsonwang
Github user carsonwang closed the pull request at: https://github.com/apache/spark/pull/7033 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8405][WebUI] Show executor logs on Web ...

2015-06-29 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7033#issuecomment-116905800 Thanks all. Closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8405][WebUI] Show executor logs on Web ...

2015-06-29 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7033#issuecomment-116643570 After configuring yarn.log.server.url in yarn-site.xml, the log url will be redirected to MR job history server to show the spark log. This means the user has to

[GitHub] spark pull request: [SPARK-8405][WebUI] Show executor logs on Web ...

2015-06-26 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/7033 [SPARK-8405][WebUI] Show executor logs on Web UI when Yarn log aggregation is enabled https://issues.apache.org/jira/browse/SPARK-8405 When running Spark application in Yarn mode and Yarn

[GitHub] spark pull request: [Followup SPARK-8387][WEBUI] Update driver log...

2015-06-18 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/6878#issuecomment-113084512 Thanks for the reminder, @srowen ! The url in `YarnClusterSuite` is now updated. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [Followup SPARK-8387][WEBUI] Update driver log...

2015-06-18 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/6878 [Followup SPARK-8387][WEBUI] Update driver log URL to show only 4096 bytes This is to follow up #6834 , update the driver log URL as well for consistency. You can merge this pull request into a

[GitHub] spark pull request: [SPARK-8372] History server shows incorrect in...

2015-06-15 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/6827#discussion_r32487191 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -218,6 +223,18 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request: [SPARK-8372] History server shows incorrect in...

2015-06-15 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/6827#issuecomment-112260070 Thanks for reviewing this, @vanzin . The code is updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-8372] History server shows incorrect in...

2015-06-15 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/6827#issuecomment-112258599 @vanzin SPARK-8275 is a different issue. What I wanted to fix in this PR is to avoid showing an App ID like application_1432793609805_009_1.inprogress. This is not a

[GitHub] spark pull request: [SPARK-8372] History server shows incorrect in...

2015-06-15 Thread carsonwang
Github user carsonwang commented on a diff in the pull request: https://github.com/apache/spark/pull/6827#discussion_r32485127 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -218,6 +223,18 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request: [SPARK-8372] History server shows incorrect in...

2015-06-15 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/6827#issuecomment-111989257 Thanks @jerryshao . I updated the code as suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-8372] History server shows incorrect in...

2015-06-15 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/6827 [SPARK-8372] History server shows incorrect information for application not started The history server may show an incorrect App ID for an incomplete application like .inprogress. This app info

[GitHub] spark pull request: [SPARK-8098][WebUI] Show correct length of byt...

2015-06-04 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/6640 [SPARK-8098][WebUI] Show correct length of bytes on log page The log page should only show desired length of bytes. Currently it shows bytes from the startIndex to the end of the file. The "

[GitHub] spark pull request: [SPARK-7864] [Web UI] Clicking a job's DAG gra...

2015-05-26 Thread carsonwang
Github user carsonwang closed the pull request at: https://github.com/apache/spark/pull/6407 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7864] [Web UI] Clicking a job's DAG gra...

2015-05-26 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/6407#issuecomment-105730681 Thanks @andrewor14 for the quick action. I'll close this one now. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-7864] [Web UI] Clicking a job's DAG gra...

2015-05-26 Thread carsonwang
GitHub user carsonwang opened a pull request: https://github.com/apache/spark/pull/6407 [SPARK-7864] [Web UI] Clicking a job's DAG graph on Web UI kills the job as the link is broken When clicking a job's DAG graph on Web UI, the user is expected to be redirec

<    1   2