[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a executorAllocationRatio...

2018-04-23 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r183337314 --- Diff: docs/configuration.md --- @@ -1751,6 +1751,7 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a executorAllocationRatio...

2018-04-23 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r183337131 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -26,7 +26,10 @@ import scala.util.control.{ControlThrowable

[GitHub] spark issue #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationDivisor ...

2018-04-12 Thread jcuquemelle
Github user jcuquemelle commented on the issue: https://github.com/apache/spark/pull/19881 Ok, will quickly do the change thanks for the proposals --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationDivisor ...

2018-04-06 Thread jcuquemelle
Github user jcuquemelle commented on the issue: https://github.com/apache/spark/pull/19881 more aggressive must be forbidden, because the setting of 1.0 gives enough executors so that if the executor provisioning was perfect (e.g. all executors were available at the same time

[GitHub] spark issue #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationDivisor ...

2018-04-03 Thread jcuquemelle
Github user jcuquemelle commented on the issue: https://github.com/apache/spark/pull/19881 @rxin , can we merge this PR ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationD...

2018-03-27 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r177444324 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -116,9 +120,12 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationD...

2018-03-26 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r17717 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -116,9 +120,12 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationD...

2018-03-22 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r176365454 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -116,9 +120,12 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationD...

2018-03-22 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r176351053 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -145,6 +145,39 @@ class ExecutorAllocationManagerSuite

[GitHub] spark issue #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationDivisor ...

2018-03-21 Thread jcuquemelle
Github user jcuquemelle commented on the issue: https://github.com/apache/spark/pull/19881 @felixcheung: updated PR title and description --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add tasksPerExecutorSlot para...

2018-03-21 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r176036965 --- Diff: docs/configuration.md --- @@ -1795,6 +1796,19 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add tasksPerExecutorSlot para...

2018-03-20 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r175852840 --- Diff: docs/configuration.md --- @@ -1795,6 +1796,19 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add tasksPerExecutorSlot para...

2018-03-20 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r175852906 --- Diff: docs/configuration.md --- @@ -1795,6 +1796,19 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add tasksPerExecutorSlot para...

2018-03-20 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r175852881 --- Diff: docs/configuration.md --- @@ -1795,6 +1796,19 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add tasksPerExecutorSlot para...

2018-03-20 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r175831139 --- Diff: docs/configuration.md --- @@ -1795,6 +1796,19 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark issue #19881: [SPARK-22683][CORE] Add tasksPerExecutorSlot parameter

2018-03-12 Thread jcuquemelle
Github user jcuquemelle commented on the issue: https://github.com/apache/spark/pull/19881 The new semantics (throttling w.r.t max possible parallelism) is actually simpler to understand. I'm proposing another name which doesn't have any ambiguity with the existing maxExecutors param

[GitHub] spark issue #19881: [SPARK-22683][CORE] Add tasksPerExecutorSlot parameter

2018-03-06 Thread jcuquemelle
Github user jcuquemelle commented on the issue: https://github.com/apache/spark/pull/19881 Sorry, I didn't see the ping, I will have a look shortly. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add tasksPerExecutorSlot para...

2017-12-04 Thread jcuquemelle
GitHub user jcuquemelle opened a pull request: https://github.com/apache/spark/pull/19881 [SPARK-22683][CORE] Add tasksPerExecutorSlot parameter ## What changes were proposed in this pull request? let's say an executor has spark.executor.cores / spark.task.cpus taskSlots