[GitHub] spark issue #21629: Fix minor typo in docs/cloud-integration.md

2018-06-25 Thread jkleckner
Github user jkleckner commented on the issue: https://github.com/apache/spark/pull/21629 @HyukjinKwon found one more small nit. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21629: Fix minor typo in docs/cloud-integration.md

2018-06-24 Thread jkleckner
GitHub user jkleckner opened a pull request: https://github.com/apache/spark/pull/21629 Fix minor typo in docs/cloud-integration.md ## What changes were proposed in this pull request? Minor typo in docs/cloud-integration.md ## How was this patch tested

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-03-05 Thread jkleckner
Github user jkleckner closed the pull request at: https://github.com/apache/spark/pull/4780 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-03-05 Thread jkleckner
Github user jkleckner commented on the pull request: https://github.com/apache/spark/pull/4780#issuecomment-77426386 Closing this PR and hoping that the user class path first gets fixed. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-03-05 Thread jkleckner
Github user jkleckner commented on the pull request: https://github.com/apache/spark/pull/4780#issuecomment-77427477 By the way, I wanted to mention that because Spark production uses maven but some developers use sbt during development, shading HyperLogLog could produce a different

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-03-04 Thread jkleckner
Github user jkleckner commented on the pull request: https://github.com/apache/spark/pull/4780#issuecomment-77195569 Well, [sbt-assembly rename](http://stackoverflow.com/questions/24596914/sbt-assembly-rename-class-with-merge-conflicts-shade) does not perform a shade operation

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-03-02 Thread jkleckner
Github user jkleckner commented on the pull request: https://github.com/apache/spark/pull/4780#issuecomment-76831730 I wonder if we're hitting some bugs with the serializer's classloader not seeing the right classloaders. Some issues like that are fixed in 1.3.0. It may still

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-03-02 Thread jkleckner
Github user jkleckner commented on the pull request: https://github.com/apache/spark/pull/4780#issuecomment-76767297 You're definitely sure CA is in your app JAR? I ask just because you mention it was marked provided above, though also in your assembly. Worth double-checking

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-02-27 Thread jkleckner
Github user jkleckner commented on the pull request: https://github.com/apache/spark/pull/4780#issuecomment-76428126 Are you packaging CA yourself, are you marking all the Spark deps as provided? I see you're already using the ```userClassPathFirst``` settings. Cases

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-02-26 Thread jkleckner
Github user jkleckner commented on a diff in the pull request: https://github.com/apache/spark/pull/4780#discussion_r25440596 --- Diff: pom.xml --- @@ -471,13 +471,6 @@ groupIdcom.clearspring.analytics/groupId artifactIdstream/artifactId

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-02-25 Thread jkleckner
GitHub user jkleckner opened a pull request: https://github.com/apache/spark/pull/4780 [SPARK-6029] Stop excluding fastutil package Spark excludes fastutil dependencies of clearspring quantiles. This patch removes the exclusion of the dependency. You can merge this pull

[GitHub] spark pull request: [SPARK-3787] Assembly jar name is wrong when w...

2014-10-03 Thread jkleckner
Github user jkleckner commented on a diff in the pull request: https://github.com/apache/spark/pull/2647#discussion_r18423582 --- Diff: project/SparkBuild.scala --- @@ -99,6 +99,30 @@ object SparkBuild extends PomBuild { v.split((\\s+|,)).filterNot(_.isEmpty).map