[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-06-26 Thread krcz
Github user krcz commented on the issue: https://github.com/apache/spark/pull/20641 @felixcheung It fixes the same problem so in terms of implementation it is not very different. But when I created this one 21014 didn't exist. The only difference is that this PR adds an

[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-06-18 Thread krcz
Github user krcz commented on the issue: https://github.com/apache/spark/pull/20641 @felixb @skonto I've triend rebasing, but it looks that the issue has been meanwhile fixed independently in [other pull request](https://github.com/apache/spark/pull/21014) while someon

[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-06-12 Thread krcz
Github user krcz commented on the issue: https://github.com/apache/spark/pull/20641 @skonto The one directly below "At the driver side in DC/OS:" in your comment. But if it's output of ps that's ok, as `ps` wouldn't be able to discern between `command "

[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-06-12 Thread krcz
Github user krcz commented on the issue: https://github.com/apache/spark/pull/20641 @skonto The command you have pasted as "At the driver side in DC/OS:" concerns me. It doesn't seem escaped properly. Is it the command to be run by shell or is it just space-j

[GitHub] spark pull request #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler ...

2018-03-20 Thread krcz
Github user krcz commented on a diff in the pull request: https://github.com/apache/spark/pull/20641#discussion_r175863304 --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala --- @@ -199,6 +199,38 @@ class

[GitHub] spark pull request #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler ...

2018-03-12 Thread krcz
Github user krcz commented on a diff in the pull request: https://github.com/apache/spark/pull/20641#discussion_r173909575 --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala --- @@ -199,6 +199,38 @@ class

[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-03-01 Thread krcz
Github user krcz commented on the issue: https://github.com/apache/spark/pull/20641 @susanxhuynh Thanks for the example! I have added similar test, covering more cases. After you or someone else reviews it, I'll rebase the pull re

[GitHub] spark pull request #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler ...

2018-02-20 Thread krcz
GitHub user krcz opened a pull request: https://github.com/apache/spark/pull/20641 [SPARK-23464][MESOS] Fix mesos cluster scheduler options double-escaping ## What changes were proposed in this pull request? Don't enclose --conf option value with "", as t

[GitHub] spark pull request: [SPARK-7984][Graphx]Complex Operators between ...

2015-07-17 Thread krcz
Github user krcz commented on a diff in the pull request: https://github.com/apache/spark/pull/6685#discussion_r34936041 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/impl/GraphImpl.scala --- @@ -178,6 +178,39 @@ class GraphImpl[VD: ClassTag, ED: ClassTag] protected