[GitHub] spark pull request: SPARK-1627: Support external aggregation by us...

2014-06-06 Thread lamuguo
Github user lamuguo commented on a diff in the pull request: https://github.com/apache/spark/pull/867#discussion_r13477507 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala --- @@ -155,48 +155,60 @@ case class Aggregate( } } else

[GitHub] spark pull request: SPARK-1627: Support external aggregation by us...

2014-05-30 Thread lamuguo
Github user lamuguo commented on a diff in the pull request: https://github.com/apache/spark/pull/867#discussion_r13217796 --- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala --- @@ -32,7 +33,8 @@ import org.apache.spark.util.collection.{AppendOnlyMap

[GitHub] spark pull request: SPARK-1627: Support external aggregation by us...

2014-05-30 Thread lamuguo
Github user lamuguo commented on a diff in the pull request: https://github.com/apache/spark/pull/867#discussion_r13217800 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala --- @@ -155,48 +155,60 @@ case class Aggregate( } } else

[GitHub] spark pull request: SPARK-1627: Support external aggregation by us...

2014-05-30 Thread lamuguo
Github user lamuguo commented on a diff in the pull request: https://github.com/apache/spark/pull/867#discussion_r13217803 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala --- @@ -155,48 +155,60 @@ case class Aggregate( } } else