[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-06-06 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 @zsxwing Thanks for dropping by. This patch is about fixing the rate ramp up when `rowsPerSecond <= rampUpTime`, which makes the Rate Source produce no data until `rampUpTime` (See [SPARK-24

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-23 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 @holdenk as we discussed in Strata, it would be great if you could give me your opinion on the approach taken in this PR

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-03 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 pinging @zsxwing: as the original author of the `RateSourceProvider`, could you review this PR? --- - To unsubscribe, e-mail

[GitHub] spark pull request #21194: [SPARK-24046][SS] Fix rate source when rowsPerSec...

2018-05-03 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/21194#discussion_r185891712 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala --- @@ -173,55 +173,154 @@ class

[GitHub] spark issue #21188: [SPARK-24046][SS] Fix rate source rowsPerSecond <= rampU...

2018-05-02 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21188 Hi Jerry, There's an improvement from the original situation, but the initial ramp-up phase starts only when the time gets very close to `rampUpTime`. Here you have another example that shows

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-01 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 @xuanyuanking thanks for the review. I understand that the changes are broader than what the ticket might imply, but I believe the new implementation is much simpler to understand and delivers

[GitHub] spark issue #21188: [SPARK-24046][SS] Fix rate source rowsPerSecond <= rampU...

2018-04-30 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21188 Hi Jerry, I don't think the issue is solved with this patch. I plugged the new function in my notebook and it still shows a rather flat ramp-up: ![image](https://user

[GitHub] spark pull request #21194: [SPARK-24046][SS] Fix rate source when rowsPerSec...

2018-04-30 Thread maasg
GitHub user maasg opened a pull request: https://github.com/apache/spark/pull/21194 [SPARK-24046][SS] Fix rate source when rowsPerSecond <= rampUpTime ## What changes were proposed in this pull request? Fixes the ramp-up of the rate source for the case `rowsPerSec

[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

2018-01-18 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/18923 Outdated by Datasource V2 implementation. Closing. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with l...

2018-01-18 Thread maasg
Github user maasg closed the pull request at: https://github.com/apache/spark/pull/18923 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

2017-11-10 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/18923 @zsxwing sorry, lost track of this. Will do. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with l...

2017-08-11 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/18923#discussion_r132794142 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala --- @@ -49,7 +49,7 @@ class ConsoleSink(options: Map[String, String

[GitHub] spark pull request #18923: [SPARK-21710][SS] Fix OOM on ConsoleSink with lar...

2017-08-11 Thread maasg
GitHub user maasg opened a pull request: https://github.com/apache/spark/pull/18923 [SPARK-21710][SS] Fix OOM on ConsoleSink with large inputs ## What changes were proposed in this pull request? Replace a full `collect` with a `take` using the expected number of elements

[GitHub] spark pull request: [SPARK-5095][MESOS] Support capping cores and ...

2015-05-05 Thread maasg
Github user maasg commented on the pull request: https://github.com/apache/spark/pull/4027#issuecomment-99211900 @tdas Would you have an opinion on this? Are there alternatives to warranty the even spread of Streaming receivers over nodes of a Mesos cluster ? --- If your project

[GitHub] spark pull request: [SPARK-5095][MESOS] Support capping cores and ...

2015-04-14 Thread maasg
Github user maasg commented on the pull request: https://github.com/apache/spark/pull/4027#issuecomment-93029751 One of the issues this PR is solving is ensuring jobs could be forced to spread over several nodes. This is particularly important for Spark Streaming as parallelizing

[GitHub] spark pull request: [SPARK-5095] Support capping cores and launch ...

2015-01-14 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/4027#discussion_r22938076 --- Diff: docs/running-on-mesos.md --- @@ -226,6 +226,20 @@ See the [configuration page](configuration.html) for information on Spark config The final

[GitHub] spark pull request: [SPARK-5095] Support capping cores and launch ...

2015-01-14 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/4027#discussion_r22938097 --- Diff: docs/running-on-mesos.md --- @@ -226,6 +226,20 @@ See the [configuration page](configuration.html) for information on Spark config The final

[GitHub] spark pull request: [SPARK-5095] Support capping cores and launch ...

2015-01-14 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/4027#discussion_r22938137 --- Diff: docs/running-on-mesos.md --- @@ -226,6 +226,20 @@ See the [configuration page](configuration.html) for information on Spark config The final

[GitHub] spark pull request: [SPARK-4537][Streaming] Expand StreamingSource...

2014-11-26 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/3466#discussion_r20924293 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala --- @@ -70,4 +78,14 @@ private[streaming] class StreamingSource(ssc

[GitHub] spark pull request: SPARK-1818 Freshen Mesos documentation

2014-05-16 Thread maasg
Github user maasg commented on the pull request: https://github.com/apache/spark/pull/756#issuecomment-43221668 Thanks for the updates! +1 (after the facts :) ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-1818 Freshen Mesos documentation

2014-05-13 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/756#discussion_r12578665 --- Diff: docs/running-on-mesos.md --- @@ -3,19 +3,109 @@ layout: global title: Running Spark on Mesos --- -Spark can run on clusters managed

[GitHub] spark pull request: SPARK-1818 Freshen Mesos documentation

2014-05-13 Thread maasg
Github user maasg commented on the pull request: https://github.com/apache/spark/pull/756#issuecomment-42945385 Great work. I'd love to see some more background of the dynamics of Spark running on Mesos. It has been a tough learning experience to get our Spark + Spark Streaming

[GitHub] spark pull request: SPARK-1818 Freshen Mesos documentation

2014-05-13 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/756#discussion_r12578801 --- Diff: docs/running-on-mesos.md --- @@ -25,31 +115,52 @@ val conf = new SparkConf() val sc = new SparkContext(conf) {% endhighlight