[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r207104309 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -89,23 +97,42 @@ case class ReuseExchange(conf: SQLConf

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r207102873 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -52,6 +52,14 @@ case class ReusedExchangeExec(override val

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r207101662 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -52,6 +52,14 @@ case class ReusedExchangeExec(override val

[GitHub] spark issue #21752: [SPARK-24788][SQL] fixed UnresolvedException when toStri...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21752 ok, I will. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r207091637 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1449,6 +1449,15 @@ object SQLConf { .intConf

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r207090891 --- Diff: docs/sql-programming-guide.md --- @@ -1872,6 +1872,8 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r207090637 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -89,23 +97,42 @@ case class ReuseExchange(conf: SQLConf

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r207090221 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -52,6 +52,14 @@ case class ReusedExchangeExec(override val

[GitHub] spark issue #21754: [SPARK-24705][SQL] Cannot reuse an exchange operator wit...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21754 Sorry, but I forgot this pr... I'll do today. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21933: [SPARK-24917] make chunk size configurable

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21933 Can you add `[SPARK-24917][CORE]` in the title? Also, you need to describe more in the description about this issue; what does this pr solve

[GitHub] spark issue #21752: [SPARK-24788][SQL] fixed UnresolvedException when toStri...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21752 kindly ping again @c-horn --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21892: [SPARK-24945][SQL] Switching to uniVocity 2.7.2

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21892#discussion_r207083344 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala --- @@ -203,19 +203,11 @@ class UnivocityParser

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r207074028 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1449,6 +1449,15 @@ object SQLConf { .intConf

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r207071540 --- Diff: docs/sql-programming-guide.md --- @@ -1872,6 +1872,8 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r207071484 --- Diff: docs/sql-programming-guide.md --- @@ -1872,6 +1872,8 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark issue #21834: [SPARK-22814][SQL] Support Date/Timestamp in a JDBC part...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21834 Thanks for the merge! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21868: [SPARK-24906][SQL] Adaptively enlarge split / partition ...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21868 Thanks for the work, but, probably, we first need consensus to work on this because this part is pretty performance-sensitive... As @viirya described in the jira, I think we need more general

[GitHub] spark issue #21834: [SPARK-22814][SQL] Support Date/Timestamp in a JDBC part...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21834 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21834: [SPARK-22814][SQL] Support Date/Timestamp in a JDBC part...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21834 Currently, no. Is it ok that the log level is `INFO`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21834: [SPARK-22814][SQL] Support Date/Timestamp in a JD...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21834#discussion_r204960461 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -1341,6 +1352,70 @@ class JDBCSuite extends QueryTest

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204775684 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -222,6 +222,32 @@ case class Stack(children: Seq

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204773466 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -182,14 +182,16 @@ case class

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204763786 --- Diff: sql/core/src/test/resources/sql-tests/inputs/except-all.sql --- @@ -0,0 +1,146 @@ +CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204760604 --- Diff: sql/core/src/test/resources/sql-tests/inputs/except-all.sql --- @@ -0,0 +1,146 @@ +CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204760405 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -182,14 +182,16 @@ case class

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204758133 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1919,6 +1919,21 @@ class Dataset[T] private[sql]( Except

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204762822 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -222,6 +222,32 @@ case class Stack(children: Seq

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204761432 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -222,6 +222,32 @@ case class Stack(children: Seq

[GitHub] spark pull request #21857: [SPARK-21274][SQL] Implement EXCEPT ALL clause.

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21857#discussion_r204763415 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1275,6 +1276,64 @@ object ReplaceExceptWithAntiJoin

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21608 LGTM except for minor comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r204656360 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -148,6 +149,25 @@ class StatisticsSuite extends

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r204655895 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -148,6 +148,19 @@ class StatisticsSuite extends

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r204654664 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileIndex.scala --- @@ -59,14 +59,15 @@ abstract class

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r204654083 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -47,15 +48,26 @@ object CommandUtils extends Logging

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r204652437 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -47,15 +48,26 @@ object CommandUtils extends Logging

[GitHub] spark issue #21853: [SPARK-23957][SQL] Sorts in subqueries are redundant and...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21853 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21853: [SPARK-23957][SQL] Sorts in subqueries are redundant and...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21853 Also, could you add `Closes #21049` in the description? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21853: [SPARK-23957][SQL] Sorts in subqueries are redundant and...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21853 LGTM except for minor comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21853: [SPARK-23957][SQL] Sorts in subqueries are redund...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21853#discussion_r204612114 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -970,4 +973,300 @@ class SubquerySuite extends QueryTest

[GitHub] spark pull request #21853: [SPARK-23957][SQL] Sorts in subqueries are redund...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21853#discussion_r204609653 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -164,10 +164,20 @@ abstract class Optimizer

[GitHub] spark pull request #21853: [SPARK-23957][SQL] Sorts in subqueries are redund...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21853#discussion_r204609622 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -164,10 +164,20 @@ abstract class Optimizer

[GitHub] spark pull request #21853: [SPARK-23957][SQL] Sorts in subqueries are redund...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21853#discussion_r204609532 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -970,4 +973,300 @@ class SubquerySuite extends QueryTest

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r204609271 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Utils.scala --- @@ -55,4 +57,11 @@ private[sql] object

[GitHub] spark issue #21752: [SPARK-24788][SQL] fixed UnresolvedException when toStri...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21752 cc: @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21834: [SPARK-22814][SQL] Support Date/Timestamp in a JDBC part...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21834 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #17174: [SPARK-19145][SQL] Timestamp to String casting is slowin...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/17174 @tanejagagan Can you update? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #19434: [SPARK-21785][SQL]Support create table from a parquet fi...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/19434 @CrazyJacky Can you close this for now cuz it's not active for a long time? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #20854: [SPARK-23712][SQL] Interpreted UnsafeRowJoiner [WIP]

Github user maropu commented on the issue: https://github.com/apache/spark/pull/20854 @hvanhovell What's the status of this pr? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19773: [SPARK-22546][SQL] Supporting for changing column dataTy...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/19773 @xuanyuanking Any update? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #19745: [SPARK-2926][Core][Follow Up] Sort shuffle reader for Sp...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/19745 @xuanyuanking Can you close this for now because it's not active for a long time. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #15970: [SPARK-18134][SQL] Comparable MapTypes [POC]

Github user maropu commented on the issue: https://github.com/apache/spark/pull/15970 @hvanhovell We still need to keep this pr open? Either way, we need rework based on this pr. If so, can you close this for now

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/18697 @aray Can you close this for now because it's not active for a long time? (I'm not sure the current master still has this issue..., so you should check it first

[GitHub] spark issue #15334: [SPARK-10367][SQL] Support Parquet logical type INTERVAL

Github user maropu commented on the issue: https://github.com/apache/spark/pull/15334 oh, I noticed the jira ticket has already been closed as later, so can you close this? @dilipbiswal --- - To unsubscribe, e

[GitHub] spark issue #15334: [SPARK-10367][SQL] Support Parquet logical type INTERVAL

Github user maropu commented on the issue: https://github.com/apache/spark/pull/15334 IIUC we have no plan to expose Interval types now, so can we close this for now? cc: @gatorsmile --- - To unsubscribe, e-mail

[GitHub] spark issue #18954: [SPARK-17654] [SQL] Enable populating hive bucketed tabl...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/18954 @tejasapatil Can you close this for now because it's not active for a long time. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #15071: [SPARK-17517][SQL]Improve generated Code for BroadcastHa...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/15071 @yaooqinn Can you close this because it's not long time for a long time. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #21805: [SPARK-24850][SQL] fix str representation of CachedRDDBu...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21805 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21805: [SPARK-24850][SQL] fix str representation of Cach...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21805#discussion_r204379093 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -207,4 +207,7 @@ case class InMemoryRelation

[GitHub] spark pull request #21805: [SPARK-24850][SQL] fix str representation of Cach...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21805#discussion_r204378903 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala --- @@ -206,4 +206,20 @@ class DatasetCacheSuite extends QueryTest

[GitHub] spark pull request #21805: [SPARK-24850][SQL] fix str representation of Cach...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21805#discussion_r204378696 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -207,4 +207,7 @@ case class InMemoryRelation

[GitHub] spark issue #21764: [SPARK-24802][SQL] Add a new config for Optimization Rul...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21764 LGTM, too --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21830: [SPARK-24878][SQL] Fix reverse function for array...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21830#discussion_r204277225 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1244,46 +1244,50 @@ case class Reverse

[GitHub] spark pull request #21830: [SPARK-24878][SQL] Fix reverse function for array...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21830#discussion_r204275800 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1244,46 +1244,50 @@ case class Reverse

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21764 Also, can you update the title? You need to at least add `[SQL]` in the title: https://github.com/apache/spark/pull/21764#issuecomment-405832763

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r204275071 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -175,6 +191,41 @@ abstract class Optimizer

[GitHub] spark pull request #21439: [SPARK-24391][SQL] Support arrays of any types by...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21439#discussion_r204274790 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -101,6 +102,17 @@ class JacksonParser

[GitHub] spark issue #21839: [SPARK-24339][SQL] Prunes the unused columns from child ...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21839 LGTM cc: @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #21754: [SPARK-24705][SQL] Cannot reuse an exchange operator wit...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21754 @markhamstra @cloud-fan How about the current fix in this pr? Or, another approach idea to fix is: https://github.com/apache/spark/compare/master...maropu:SPARK-24705-3 In the latter idea, I

[GitHub] spark issue #21839: [SPARK-24339][SQL] Prunes the unused columns from child ...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21839 Thanks for the work! I’ll review this in hours. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21439: [SPARK-24391][SQL] Support arrays of any types by...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21439#discussion_r204233840 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -61,6 +61,7 @@ class JacksonParser( dt match

[GitHub] spark pull request #21439: [SPARK-24391][SQL] Support arrays of any types by...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21439#discussion_r204231723 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -61,6 +61,7 @@ class JacksonParser( dt match

[GitHub] spark pull request #21439: [SPARK-24391][SQL] Support arrays of any types by...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21439#discussion_r204226404 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -61,6 +61,7 @@ class JacksonParser( dt match

[GitHub] spark pull request #21805: [SPARK-24850][SQL] fix str representation of Cach...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21805#discussion_r204212287 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -50,6 +50,8 @@ case class CachedRDDBuilder

[GitHub] spark pull request #21830: [SPARK-24878][SQL] Fix reverse function for array...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21830#discussion_r204210201 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1244,46 +1244,50 @@ case class Reverse

[GitHub] spark pull request #21830: [SPARK-24878][SQL] Fix reverse function for array...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21830#discussion_r204209661 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1244,46 +1244,50 @@ case class Reverse

[GitHub] spark issue #21834: [SPARK-22814][SQL] Support Date/Timestamp in a JDBC part...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21834 @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21830: [SPARK-24878][SQL] Fix reverse function for array...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21830#discussion_r204208955 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -918,34 +918,55 @@ class DataFrameFunctionsSuite extends

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21668: [SPARK-24690][SQL] Add a new config to control plan stat...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21668 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21834: [SPARK-22814][SQL] Support Date/Timestamp in a JD...

GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21834 [SPARK-22814][SQL] Support Date/Timestamp in a JDBC partition column ## What changes were proposed in this pull request? This pr supported Date/Timestamp in a JDBC partition column (a numeric

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r204202735 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -175,6 +182,44 @@ abstract class Optimizer

[GitHub] spark issue #19999: JDBC support date/timestamp type as partitionColumn

Github user maropu commented on the issue: https://github.com/apache/spark/pull/1 ok, I will. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r204196291 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -47,15 +48,27 @@ object CommandUtils extends Logging

[GitHub] spark pull request #21805: [SPARK-24850][SQL] fix str representation of Cach...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21805#discussion_r204032968 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala --- @@ -206,4 +206,19 @@ class DatasetCacheSuite extends QueryTest

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r203972003 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -85,14 +85,20 @@ case class ReusedExchangeExec(override val

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r203966689 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -85,14 +85,20 @@ case class ReusedExchangeExec(override val

[GitHub] spark issue #21822: [SPARK-24865] Remove AnalysisBarrier - WIP

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21822 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r203953577 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -47,15 +48,27 @@ object CommandUtils extends Logging

[GitHub] spark pull request #21805: [SPARK-24850][SQL] fix str representation of Cach...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21805#discussion_r203949905 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala --- @@ -206,4 +206,19 @@ class DatasetCacheSuite extends QueryTest

[GitHub] spark issue #21777: [WIP][SPARK-24498][SQL] Add JDK compiler for runtime cod...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21777 btw, it seems this pr exceeds the current timeout...　Any way to temporarily make the timeout longer? We always need to configure timeout in the Jenkins-side like https://github.com/apache/spark

[GitHub] spark pull request #21804: [SPARK-24268][SQL] Use datatype.catalogString in ...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21804#discussion_r203585703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala --- @@ -145,7 +145,7 @@ abstract class NumericType extends

[GitHub] spark pull request #21803: [SPARK-24849][SQL] Converting a value of StructTy...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21803#discussion_r203584039 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala --- @@ -436,6 +436,14 @@ object StructType extends AbstractDataType

[GitHub] spark issue #21803: [SPARK-24849][SQL] Converting a value of StructType to a...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21803 (As I described in the jira) What's this func is used for? Is this related to the other work? --- - To unsubscribe, e-mail

[GitHub] spark issue #21777: [WIP][SPARK-24498][SQL] Add JDK compiler for runtime cod...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21777 > Except the TPC-DS queries, are we able to find some workloads that could perform faster using the bytecode generated by the JDK compiler? Since I don't have real workloads or non-TP

[GitHub] spark issue #21805: [SPARK-24850][SQL] fix str representation of CachedRDDBu...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21805 Can you add tests? cc: @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r203437795 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -85,14 +85,20 @@ case class ReusedExchangeExec(override val

[GitHub] spark issue #21803: [SPARK-24849][SQL] Converting a value of StructType to a...

Github user maropu commented on the issue: https://github.com/apache/spark/pull/21803 How about the case where a column name has special characters that should be backquoted, e.g., 'aaa:bbb'? --- - To unsubscribe

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r203278576 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -175,6 +182,44 @@ abstract class Optimizer

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r203278443 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -175,6 +182,44 @@ abstract class Optimizer

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r203277729 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -160,6 +160,13 @@ abstract class Optimizer

<    2   3   4   5   6   7   8   9   10   11   >