[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-11-05 Thread martinbrown
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154264615 @mengxr responded --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-11-05 Thread martinbrown
Github user martinbrown commented on a diff in the pull request: https://github.com/apache/spark/pull/8505#discussion_r44097390 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Binarizer.scala --- @@ -31,10 +31,12 @@ import org.apache.spark.sql.types.{DoubleType

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-09-24 Thread martinbrown
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143051613 @mengxr ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-09-23 Thread martinbrown
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142730616 Trying again in case it was a transitory download error. Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-09-21 Thread martinbrown
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142130231 @mengxr any insight on this failure? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-09-19 Thread martinbrown
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141724075 @mengxr Can you kick off another Jenkins run? It looks like the last run had a fault unrelated to the code. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-09-16 Thread martinbrown
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-140795638 Ready for another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-08-28 Thread martinbrown
GitHub user martinbrown opened a pull request: https://github.com/apache/spark/pull/8505 [SPARK-10258] [DOCUMENTATION, ML] Adding Since() Annotations to ml/feature Unsure what to do for SQLTransformer since it's in master but not in any tagged release. You can merge this