[GitHub] spark issue #17461: [SPARK-20082][ml] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 Hi @sprintcheng, This PR is stale and is not even mergeable. I haven't had any feedback from spark maintainers since more than a year. @hhbyyh suggested to wait for #18610 which is also

[GitHub] spark pull request #17461: [SPARK-20082][ml] LDA incremental model learning

Github user mdespriee commented on a diff in the pull request: https://github.com/apache/spark/pull/17461#discussion_r136519055 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -180,6 +179,29 @@ private[clustering] trait LDAParams extends Params

[GitHub] spark issue #17461: [SPARK-20082][ml] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 I updated the example following your suggestion. It's more consistent with LDAExample this way. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #17461: [SPARK-20082][ml] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 Hi @hhbyyh, @jkbradley a gentle ping on this PR. It's not WIP anymore, and ready for a review. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #17461: [SPARK-20082][ml] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 Hi @hhbyyh, This PR is ready for a review. Thanks ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17461: [SPARK-20082][ml][WIP] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 Ok, will do with a model path. I'll push an update shortly, and I'll think this PR will be ready. (in KMeans, the initialModel API is available in mllib but not at ML level, yet. Could

[GitHub] spark issue #17461: [SPARK-20082][ml][WIP] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 Hi @hhbyyh, @jkbradley a gentle ping on this PR, if you could have a look at the code, and give me your opinion regarding my question hereabove (the use of Param API to provide a previous

[GitHub] spark issue #17461: [SPARK-20082][ml][WIP] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 Putting [WIP] back, as there is a problem with serialization of param. Working on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #17461: [SPARK-20082][ml] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 I made some manual tests as well, see here : https://gist.github.com/mdespriee/8ae604036732f39f6345ee91acf777a0 This code could be added in spark-examples, just tell me. --- If your

[GitHub] spark issue #17461: [SPARK-20082][ml][WIP] LDA incremental model learning

Github user mdespriee commented on the issue: https://github.com/apache/spark/pull/17461 Yes, still active. I've been very busy lately. Regarding 1/ -> will do 2/ -> still waiting for a comment from @jkbradley actually. 3/ -> will do I'll tr

[GitHub] spark pull request #17461: [SPARK-20082][ml][WIP] LDA incremental model lear...

GitHub user mdespriee opened a pull request: https://github.com/apache/spark/pull/17461 [SPARK-20082][ml][WIP] LDA incremental model learning ## What changes were proposed in this pull request? This PR implements an initialModel parameter for LDA. (Right now, only