[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-16 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/10180#discussion_r47817475 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -103,7 +103,11 @@ class HistoryServer( // Note we

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-16 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/10180#discussion_r47817405 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -103,7 +103,11 @@ class HistoryServer( // Note we

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-15 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/10180#discussion_r47735900 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -103,7 +103,11 @@ class HistoryServer( // Note we

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-15 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/10180#discussion_r47733873 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -103,7 +103,11 @@ class HistoryServer( // Note we

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-15 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/10180#discussion_r47733082 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -103,7 +103,11 @@ class HistoryServer( // Note we

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-13 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/10180#issuecomment-164333244 Can someone review this or if it seems okay, merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-10 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/10180#issuecomment-163795104 cc - @srowen, @andrewor14 Can you please ask Jenkins to run the tests. Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-08 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/10180#issuecomment-163027364 cc - @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-07 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/spark/pull/10180 [SPARK-12186] [WEB UI] Send the complete request URI including the query string when redirecting. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] spark pull request: [DOC] [MINOR] [SQL] Fix internal link

2015-11-08 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/9544#discussion_r44228299 --- Diff: docs/sql-programming-guide.md --- @@ -2294,7 +2294,7 @@ Several caching related features are not supported yet: Spark SQL is designed to be

[GitHub] spark pull request: [DOC] [MINOR] [SQL] Fix internal link

2015-11-07 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/spark/pull/9544 [DOC] [MINOR] [SQL] Fix internal link It doesn't show up as a hyperlink currently. It will show up as a hyperlink after this change. You can merge this pull request into a Git reposito

[GitHub] spark pull request: [DOC] [SQL] Remove redundant out-of-place pyth...

2015-11-07 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/9540#issuecomment-154709554 cc - @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [DOC] [SQL] Remove redundant out-of-place pyth...

2015-11-07 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/spark/pull/9540 [DOC] [SQL] Remove redundant out-of-place python snippet This snippet seems to be mistakenly introduced at two places in #5348. You can merge this pull request into a Git repository by running

[GitHub] spark pull request: [SPARK-9924] [WEB UI] Don't schedule checkForL...

2015-08-15 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/8153#issuecomment-131394133 Can we retest this please? The failures are unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-9924] [WEB UI] Don't schedule checkForL...

2015-08-14 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/8153#discussion_r37059670 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -204,13 +204,20 @@ private[history] class FsHistoryProvider

[GitHub] spark pull request: [SPARK-9924] [WEB UI] Don't schedule checkForL...

2015-08-13 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/8153#discussion_r37002261 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -204,13 +204,21 @@ private[history] class FsHistoryProvider

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-12 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/8014#issuecomment-130489538 @vanzin, @srowen Does this look good now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9924] [WEB UI] Don't schedule checkForL...

2015-08-12 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/spark/pull/8153 [SPARK-9924] [WEB UI] Don't schedule checkForLogs while some of them are already running. You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-12 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/8014#issuecomment-130292929 Can we retest this? The test failures seem unrelated to my changes. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-9806] [WEB UI] Don't share ReplayListen...

2015-08-11 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/8088#issuecomment-130176137 Finally! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9806] [WEB UI] Don't share ReplayListen...

2015-08-11 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/8088#issuecomment-129990128 Yeah, I noticed that in my other PR as well. :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-10 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/8014#discussion_r36703520 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -251,6 +251,13 @@ private[spark] object JettyUtils extends Logging

[GitHub] spark pull request: [SPARK-9806] [WEB UI] Don't share ReplayListen...

2015-08-10 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/spark/pull/8088 [SPARK-9806] [WEB UI] Don't share ReplayListenerBus between multiple applications You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-10 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/8014#discussion_r36612982 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -251,6 +251,13 @@ private[spark] object JettyUtils extends Logging

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-09 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/8014#discussion_r36596083 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -251,6 +251,13 @@ private[spark] object JettyUtils extends Logging

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-08 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/8014#issuecomment-128943565 Can this be merged now @vanzin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-06 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/8014#discussion_r36491091 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -64,7 +64,7 @@ private[spark] class SparkUI private ( attachTab(new

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-06 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/spark/pull/8014#discussion_r36491031 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -251,6 +251,14 @@ private[spark] object JettyUtils extends Logging

[GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...

2015-08-06 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/spark/pull/8014 [SPARK-9724] [WEB UI] Avoid unnecessary redirects in the Spark Web UI. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/spark

[GitHub] spark pull request: [SPARK-4069] [YARN] When AppMaster finishes, t...

2015-03-28 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/5233#issuecomment-87185350 There wasn't - I created https://issues.apache.org/jira/browse/YARN-3415 just now. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-4069] [YARN] When AppMaster finishes, t...

2015-03-27 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/spark/pull/5233#issuecomment-87160289 Hi @sryza We faced an issue where not doing this was causing incorrect accounting of the queue's AM Resources. As you may be aware that the YARN