Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
Thank you for your kindful reviews!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user nzw0301 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19372#discussion_r142332793
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -368,11 +371,12 @@ class Word2Vec extends Serializable with Logging
Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
I updated the results of word2vec example based on this PR in the first
comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
Thank you for your reviews, @LowikC.
Like this?
```scala
val totalWordsCounts = numIterations * trainWordsCount + 1
val numWordsProcessedInPreviousIterations = (k - 1
Github user nzw0301 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19372#discussion_r141609260
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -368,9 +368,9 @@ class Word2Vec extends Serializable with Logging
Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
Thank you for your comment, @LowikC.
You are right, my PR code is incorrect.
Correct update formula is
```scala
alpha = learningRate *
(1 - numPartitions
Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
Thank you for your comment, @srowen.
I'll create an isuen on JIRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user nzw0301 opened a pull request:
https://github.com/apache/spark/pull/19372
[MLLIB] Fix update equation of learning rate in Word2Vec.scala
## What changes were proposed in this pull request?
Current equation of learning rate is incorrect when `numIterations` >
