[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2017-10-30 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @shivaram: Have you reviewed this? If the intent is to merge it, I'll gladly update the code. @gatorsmile

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2017-01-11 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 Happy New Year, folks! Any updates on this? @shivaram @falaki --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2016-12-14 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @falaki @shivaram Shall we merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2016-11-16 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @shivaram @felixcheung @falaki Any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2016-11-08 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 Folks? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2016-11-02 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @shivaram @falaki @felixcheung Any additional comments? Otherwise, are we ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2016-10-25 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @felixcheung I'm done! Thanks for your comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2016-10-25 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @felixcheung When a user types a variable name on the R shell, it triggers method showDefault() which, in turn, invokes show(). I wrote an implementation of show() for Column which, in turn

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2016-10-25 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @felixcheung @falaki Folks? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] head() and show() for Columns

2016-10-21 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @felixcheung @falaki I have addressed all your comments. Shall we merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] head() and show() for Colum...

2016-10-19 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r84150590 --- Diff: R/pkg/R/DataFrame.R --- @@ -3321,3 +3328,11 @@ setMethod("randomSplit", } sapply(sdfs,

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-14 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @felixcheung @falaki I have addressed all your comments and tests pass now. Thank you! cc @aloknsingh --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-12 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @falaki @felixcheung I have addressed all your comments. I'm getting two documentation warnings which seem to be making the build fail: 1) ``` Undocumented S4 methods

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-12 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r83057347 --- Diff: R/pkg/R/functions.R --- @@ -2836,7 +2845,11 @@ setMethod("lpad", signature(x = "Column", len = "numeric", pad

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82919122 --- Diff: R/pkg/R/DataFrame.R --- @@ -1168,12 +1179,14 @@ setMethod("take", #' Head #' -#' Return the first \code

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82918200 --- Diff: R/pkg/R/column.R --- @@ -32,35 +34,57 @@ setOldClass("jobj") #' @export #' @note Column since 1.4.0 setCla

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82911261 --- Diff: R/pkg/R/DataFrame.R --- @@ -1049,11 +1055,16 @@ setMethod("dim", #' @export #' @examples #'\dontrun{ -#' spar

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82911244 --- Diff: R/pkg/R/DataFrame.R --- @@ -1035,10 +1035,16 @@ setMethod("dim", c(count(x), ncol(x)) }) -#

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82910308 --- Diff: R/pkg/R/functions.R --- @@ -2836,7 +2845,11 @@ setMethod("lpad", signature(x = "Column", len = "numeric", pad

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-11 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @falaki Yeah but those warnings are making the build fail (see below). Is that okay? Now I see a new"Checks" section. I may be outdated with the protocols as it's been a while I did

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-11 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @falaki Thanks for your comments. Yeah, before removing collect/show, I just wanted to rebase to current upstream master. I'm getting a build error which is actually a warning, not even an R error

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-11 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @falaki Sorry, I was out of town. Let me get back to this today. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-06 Thread olarayej
Github user olarayej commented on the issue: https://github.com/apache/spark/pull/11336 @falaki Absolutely. Let me do that. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-05-06 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-217586684 I just got this branch up to date. Any comments, folks? @shivaram @falaki @felixcheung @rxin @sun-rui @mengxr --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-13436][SPARKR] Added parameter drop to ...

2016-04-27 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11318#issuecomment-215253259 @shivaram I've changed default value to drop=F as you suggested. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13436][SPARKR] Added parameter drop to ...

2016-04-27 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11318#issuecomment-215181464 @shivaram @sun-rui @felixcheung This one's ready. Shall we merge? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-26 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-214898243 @shivaram @felixcheung I have addressed all your comments. Anything else? Or shall we merge? Thanks! --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-26 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r61168496 --- Diff: R/pkg/R/DataFrame.R --- @@ -2465,6 +2465,110 @@ setMethod("drop", base::drop(x) }) +#' Thi

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-26 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-214890244 @shivaram @felixcheung Looks like the version of lint-r running on the build server is different than the one on Spark's Github. Even though lint-r passes on my local

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-25 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r61009021 --- Diff: R/pkg/R/DataFrame.R --- @@ -2469,6 +2469,110 @@ setMethod("drop", base::drop(x) }) +#' Thi

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-22 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-213528826 @felixcheung @shivaram I'm done with all your suggestions. Thanks. Shall we merge? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-21 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-213124256 @felixcheung @shivaram I have addressed all your comments. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-21 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r60651721 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,107 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-21 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r60651656 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,107 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-20 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r60452619 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,100 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-19 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-212141260 @shivaram @felixcheung I have addressed all your comments. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-19 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r60287324 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,100 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-19 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r60284165 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,100 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-19 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r60278988 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,100 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-12 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-209030552 @felixcheung @shivaram This is done. Shall we merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-04-12 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-209030229 @shivaram @falaki @felixcheung @rxin @sun-rui Any thoughts on this? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-30 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-203678252 Looks good to you @felixcheung? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13436][SPARKR] Added parameter drop to ...

2016-03-30 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11318#issuecomment-203678123 @sun-rui @shivaram Shall we merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-03-30 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-203672948 Thanks @sun-rui @rxin @shivaram for your inputs. To alleviate the confusion on which columns can/cannot be collected, I propose the following (already pushed

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-25 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-201597000 @felixcheung I just added support for Columns or characters. In my opinion, histogram() is column function and when we sort out #11336, it wouldn't have

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-24 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r57349827 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,81 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-24 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r57343915 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,81 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-24 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r57342255 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,81 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-23 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r57259854 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,81 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-23 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11569#discussion_r57252393 --- Diff: R/pkg/R/functions.R --- @@ -2638,3 +2638,81 @@ setMethod("sort_array", jc <- callJStatic("org.apache.s

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-21 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-199552264 @shivaram @sun-rui @felixcheung Yeah, that makes sense. I modified histogram() function so now it only computes the histogram statistics. There's neither rendering

[GitHub] spark pull request: [SPARK-13436][SPARKR] Added parameter drop to ...

2016-03-21 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11318#issuecomment-199464512 @sun-rui Done with the style issues. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13436][SPARKR] Added parameter drop to ...

2016-03-19 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11318#discussion_r56418618 --- Diff: R/pkg/R/DataFrame.R --- @@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i = "numericOrcharacter

[GitHub] spark pull request: [SPARK-13436][SPARKR] Added parameter drop to ...

2016-03-19 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11318#issuecomment-197566393 @felixcheung @shivaram @sun-rui I have addressed all your comments. Do we have a consensus on the default value for drop? I'd say drop=T makes sense cuz R does

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-03-10 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11220#issuecomment-195127575 Thanks, @shivaram! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-03-08 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11220#discussion_r55481841 --- Diff: R/pkg/R/DataFrame.R --- @@ -303,8 +303,28 @@ setMethod("colnames", #' @rdname columns #' @name colnames<- setMet

[GitHub] spark pull request: [SPARK-13436][SPARKR] Added parameter drop to ...

2016-03-08 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11318#issuecomment-194128322 @felixcheung @sun-rui @shivaram Can you folks please take a look at this one? Thank you! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-03-08 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11220#discussion_r55418947 --- Diff: R/pkg/R/DataFrame.R --- @@ -303,8 +303,28 @@ setMethod("colnames", #' @rdname columns #' @name colnames<- setMet

[GitHub] spark pull request: Added histogram function

2016-03-07 Thread olarayej
GitHub user olarayej opened a pull request: https://github.com/apache/spark/pull/11569 Added histogram function ## What changes were proposed in this pull request? Added method histogram() to compute the histogram of a Column **Usage:** # Create a DataFrame

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-03-04 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-192400350 @sun-rui Does that make sense to you? @shivaram @felixcheung Any comments? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-03-02 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-191399711 Also, the fact that the size of a column depends on the join seems counter-intuitive for an R user: ``` > dim(irisDF2) [1] 150 5 &g

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-03-01 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-191003387 @sun-rui Yes. In that case, c3 will be only associated to df3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-03-01 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-190867380 SparkR doesn't support operations between columns from different DataFrame objects. Yet you can do: ``` c1 <- df1$c1 c2 <- df2$c2 c3 <

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-02-29 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-190334385 Can any of you folks please take a look at the code? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-02-25 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-189053702 @felixcheung It wasn't an R issue after all. The problem was that I hadn't been able to rebuild Spark in the last couple days due to SPARK-13431, and I needed changes

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-02-24 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-188484496 Thanks, folks. Looks like all test pass now! :-) However, on my environment (R 3.2.2), two tests don't pass. We should be careful whenever upgrading the R

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-02-24 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-188138539 @sun-rui @shivaram Do you know which version of R and SparkR's dependencies are being used in Jenkins? Tests run fine in my environment (have reviewed my code and ran

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-02-23 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-188046181 @AmplabJenkins Jenkins, could you retest please? I see ERROR: Error fetching remote repo 'origin' --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-02-23 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-187996241 Jenkins, retest please. All tests pass for me after checking out this branch. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-02-23 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-187996142 Thanks @falaki! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-02-23 Thread olarayej
GitHub user olarayej opened a pull request: https://github.com/apache/spark/pull/11336 [SPARK-9325][SPARK-R] collect() head() and show() for Columns See attached design document [SparkR collect (JIRA doc).pdf](https://github.com/apache/spark/files/143656

[GitHub] spark pull request: [SPARK-13436][SPARKR]

2016-02-22 Thread olarayej
GitHub user olarayej opened a pull request: https://github.com/apache/spark/pull/11318 [SPARK-13436][SPARKR] ## What changes were proposed in this pull request? Added parameter drop to subsetting operator [. Refer to R's documentation for the behavior of parameter drop

[GitHub] spark pull request: [SPARK-13436] [Mesos] Document that spark.meso...

2016-02-22 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11311#issuecomment-187425038 @mgummelt I'm guessing you got the wrong PR number? Could you please fix this? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-02-22 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11220#discussion_r53701739 --- Diff: R/pkg/R/DataFrame.R --- @@ -303,8 +303,28 @@ setMethod("colnames", #' @rdname columns #' @name colnames<- setMet

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-02-22 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11220#issuecomment-187318737 Jenkins, retest please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-02-19 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11220#discussion_r53504008 --- Diff: R/pkg/R/DataFrame.R --- @@ -303,8 +303,28 @@ setMethod("colnames", #' @rdname columns #' @name colnames<- setMet

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-02-18 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11220#discussion_r53375517 --- Diff: R/pkg/R/DataFrame.R --- @@ -303,8 +303,28 @@ setMethod("colnames", #' @rdname columns #' @name colnames<- setMet

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-02-18 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11220#discussion_r53373470 --- Diff: R/pkg/R/DataFrame.R --- @@ -303,8 +303,28 @@ setMethod("colnames", #' @rdname columns #' @name colnames<- setMet

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-02-16 Thread olarayej
GitHub user olarayej opened a pull request: https://github.com/apache/spark/pull/11220 [SPARK-13327][SPARKR] Added parameter validations for colnames<- You can merge this pull request into a Git repository by running: $ git pull https://github.com/olarayej/spark SPARK-1331

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2016-01-15 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-172054570 Thanks, @shivaram! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2016-01-13 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-171441589 @felixcheung Done. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2016-01-12 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/9613#discussion_r49493628 --- Diff: R/pkg/R/generics.R --- @@ -581,6 +579,10 @@ setGeneric("unionAll", function(x, y) { standardGeneric("unionAll") }) #' @ex

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2016-01-12 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-171013162 Jenkins, could you retest please? The error I see is "Error fetching remote repo 'origin'" --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2016-01-12 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-171101731 @SparkQA Could you retest? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2016-01-11 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-170624621 Happy New Year, folks! Shall we merge this PR? @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-12-21 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-166544706 @shivaram I have addressed all your comments. Should we close this pull request? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-12-18 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/9613#discussion_r48079567 --- Diff: R/pkg/R/generics.R --- @@ -509,13 +520,8 @@ setGeneric("saveAsTable", function(df, tableName, source, mode, ...) { stand

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-12-18 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-165923895 @felixcheung Done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-12-17 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-165607267 @shivaram I have removed the caching logic as you indicated @felixcheung @sun-rui I have already explained why we can't use R's str() function under the covers

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-12-17 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/9613#discussion_r47984121 --- Diff: R/pkg/R/DataFrame.R --- @@ -2151,3 +2151,97 @@ setMethod("coltypes", rTypes }) + +

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-12-08 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/9613#discussion_r46995766 --- Diff: R/pkg/R/DataFrame.R --- @@ -2151,3 +2151,97 @@ setMethod("coltypes", rTypes }) + +

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-12-07 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-162725183 @felixcheung, @sun-rui As I mentioned in my previous comment, it's not only replacing data.frame for DataFrame in the header. There are also issues with the number

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-24 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-159366139 @shivaram Any further comments or clarification on the existing ones required from my end? Otherwise, should we merge this PR? Thank you! --- If your project is set

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-20 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/9613#discussion_r45537232 --- Diff: R/pkg/R/DataFrame.R --- @@ -2199,3 +2199,97 @@ setMethod("coltypes", rTypes }) + +

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-20 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/9613#discussion_r45537282 --- Diff: R/pkg/R/DataFrame.R --- @@ -2199,3 +2199,97 @@ setMethod("coltypes", rTypes }) + +

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-20 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/9613#discussion_r45537532 --- Diff: R/pkg/R/DataFrame.R --- @@ -2199,3 +2199,97 @@ setMethod("coltypes", rTypes }) + +

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-19 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-158241832 Jenkins, could you retest please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-19 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/9613#discussion_r45413626 --- Diff: R/pkg/R/generics.R --- @@ -561,6 +579,10 @@ setGeneric("unionAll", function(x, y) { standardGeneric("unionAll") }) #' @ex

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-18 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-157786743 @felixcheung @shivaram Any more comments, folks? Otherwise, can we merge this? Thank you! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-18 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-157903598 @shivaram I have updated this branch with master. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

  1   2   >