Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220244160
cc @dbtsai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/13191
[SPARK-14613][ML] Add @Since into the matrix and vector classes in
spark-mllib-local
## What changes were proposed in this pull request?
This PR add `@Since` annotations
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-218674561
@srowen Yes, please go ahead. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-216322117
Aah ok, got it thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-216320984
> OK, let's try this PR again but only with the tag changes first.
@srowen I'm little confused here, could you please elaborate a bit here?
What
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12420#issuecomment-216318404
@jkbradley I have stumbled across an issue, would really appreciate your
input. Have a look at this method:
```
def getStage[T <: PipelineSt
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215839125
@dbtsai @srowen My mistake, apparently changes in `modules.py` does not
cause build failure. And I was unable to reproduce the locally (even after
rebasing
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215822661
@srowen I undid the changes done in `dev/sparktestsupport/modules.py`, ran
the sbt test build locally with `build/sbt -Pyarn -Phadoop-2.3 -Phive
-Pkinesis-asl
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215543380
@dbtsai Is this something you had in mind? Zip file contains the patch for
modules.
[tags.patch.zip](https://github.com/apache/spark/files/241333
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12420#issuecomment-215538279
@jkbradley I'll update it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215515903
@srowen Reverted back the python module changes. Rebasing Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214720347
@dbtsai Comments addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214386251
@srowen Done rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12420#issuecomment-213742826
@jkbradley I'll update the PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60827833
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -154,11 +172,12 @@ sealed trait Matrix extends Serializable
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213668195
@dbtsai I'll update the PR soon, I have been overwhelmed by office work :(
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60448406
--- Diff: common/tags/pom.xml ---
@@ -46,5 +46,24 @@
target/scala-${scala.binary.version}/classes
target/scala
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60446515
--- Diff: common/tags/pom.xml ---
@@ -46,5 +46,24 @@
target/scala-${scala.binary.version}/classes
target/scala
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-212494660
@dbtsai @srowen Please validate the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-211858720
@dbtsai I'll update the PR accordingly. I just have one doubt before making
any further changes, do you want to make a copy of `@Since` under `common/tags
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/12420
[SPARK-14585][ML][WIP] Provide accessor methods for Pipeline stages
## What changes were proposed in this pull request?
This PR adds accessor methods for pipeline stages in `Pipeline
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r59864603
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -759,6 +769,8 @@ object SparseMatrix
Github user pravingadakh closed the pull request at:
https://github.com/apache/spark/pull/11575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/12416
[SPARK-14613][ML] Add @Since into the matrix and vector classes in
spark-mllib-local
## What changes were proposed in this pull request?
This PR adds `@since` tag into the matrix
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r59852468
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -536,13 +532,16 @@ private[clustering] object
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r59844091
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -536,13 +532,16 @@ private[clustering] object
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-207929631
@srowen Added `@return` for the method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-206119313
@jkbradley Could you please flag this PR for test build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-205918384
I could document the returned values, but frankly I have no idea what those
values are. I can see the documentation of first returned value `gammad
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r58553918
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -542,10 +539,11 @@ private[clustering] object
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r58553056
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -440,12 +440,9 @@ final class OnlineLDAOptimizer extends
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/12176
[SPARK-14370][MLLIB]removed duplicate generation of ids in
OnlineLDAOptimizer
## What changes were proposed in this pull request?
Removed duplicated generation of `ids
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11575#discussion_r55349423
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -178,6 +178,20 @@ class StringIndexerSuite
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9522#issuecomment-193683770
@thunterdb Please refer following PR.
[https://github.com/apache/spark/pull/11575](PR)
---
If your project is set up for it, you can reply to this email and have
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/11575
[SPARK-11535][ML] handling empty string in StringIndexer
## What changes were proposed in this pull request?
Replacing "" (not null) with string "EMPTY_STRING&qu
Github user pravingadakh closed the pull request at:
https://github.com/apache/spark/pull/9522
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9522#issuecomment-193663512
@thunterdb Hi, I think I messed up while merging, thus closing this pull
request creating a new one for the same.
---
If your project is set up for it, you can
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9376#issuecomment-170477328
Hi All,
Did not know there was a comment on this PR. I don't remember the reason
behind this approach as it has been long time since, so closing this PR
Github user pravingadakh closed the pull request at:
https://github.com/apache/spark/pull/9376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9522#issuecomment-157131275
@jkbradley Any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9516#issuecomment-155299748
@yinxusen I have added example on off labels at places you mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/9522
[SPARK-11535][ML] handling empty string in StringIndexer
Replacing "" (not null) with string "EMPTY_STRING" in StringIndexer.
Another approach is to use "0&qu
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/9516
[SPARK-11550][Docs] Replace example code in mllib-optimization.md using
include_example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-153339792
@mengxr @yinxusen Can we merge this, if there aren't any further issues?
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/9376
[SPARK-11408][SQL] display scientific notation correctly in DataFrame.show()
Initial implementation for displaying scientific notation in
DataFrame.show().
Advantages:
-- No type
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152176928
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152211342
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152228923
@mengxr Ran the style checks locally, passed. Also I have moved FPGrowth
example code from user guide to examples.
---
If your project is set up for it, you can
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152292812
@yinxusen Done with all import re-orderings. You can assign me
https://issues.apache.org/jira/browse/SPARK-11382 jira if no one is working on
it.
---
If your
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152090442
@yinxusen I will do the changes mentioned. I am confused about one thing
though, FPGrowth examples are already available in scala and java language, and
it's
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152118502
@yinxusen When you say use the existing example code, you mean the one in
the doc or the one which is readily available in examples directory?
---
If your project
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/9340
replaced example code using include_example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pravingadakh/spark SPARK-11380
Alternatively
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/9195
[SPARK-11037][SQL] using Option instead of Some in JdbcDialects
Using Option instead of Some in getCatalystType method.
You can merge this pull request into a Git repository by running
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9148#issuecomment-148833589
@rxin Yes, with username pravingadakh.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/9148
[SPARK-10581][Docs] Groups are not resolved in scaladoc in sql classes
Groups are not resolved properly in scaladoc in following classes:
sql/core/src/main/scala/org/apache/spark/sql
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9148#issuecomment-148686987
@srowen Yes, I have verified this in my local environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9148#issuecomment-148738200
@srowen Is there a way to see the generated docs, post a successful build?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9148#issuecomment-148761181
I have generated scaladoc locally. Attaching the screenshot.
https://cloud.githubusercontent.com/assets/13175315/10547236/d056fba4-7450-11e5-8b17
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9148#issuecomment-148763689
@srowen Fair enough. Guess I was super excited for the first commit :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
59 matches
Mail list logo
