[GitHub] spark issue #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Dialect]

2017-08-08 Thread radford1
Github user radford1 commented on the issue: https://github.com/apache/spark/pull/18607 @gatorsmile Understood I'll work on including them. @rxin can you help me understand this better? I was trying to add this so spark could call Drill through jdbc. How can we include

[GitHub] spark issue #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Dialect]

2017-08-07 Thread radford1
Github user radford1 commented on the issue: https://github.com/apache/spark/pull/18607 @viirya I have not had a chance to build out the docker tests like @gatorsmile suggested. Will that be a requirement in order to merge it? --- If your project is set up for it, you can reply

[GitHub] spark pull request #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Diale...

2017-08-02 Thread radford1
GitHub user radford1 reopened a pull request: https://github.com/apache/spark/pull/18607 [SPARK-21362][SQL][Adding Apache Drill JDBC Dialect] ## What changes were proposed in this pull request? Adding Apache Drill to the JDBC Dialect ## How was this patch tested

[GitHub] spark issue #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Dialect]

2017-08-02 Thread radford1
Github user radford1 commented on the issue: https://github.com/apache/spark/pull/18607 @viira can you review for me again please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Diale...

2017-08-02 Thread radford1
Github user radford1 closed the pull request at: https://github.com/apache/spark/pull/18607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Diale...

2017-07-25 Thread radford1
Github user radford1 commented on a diff in the pull request: https://github.com/apache/spark/pull/18607#discussion_r129345883 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/ApacheDrillDialect.scala --- @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Dialect]

2017-07-14 Thread radford1
Github user radford1 commented on the issue: https://github.com/apache/spark/pull/18607 I'm very new to this but was just wondering if there is anything else I should do to help with this pull request or does it just take more time? --- If your project is set up for it, you can

[GitHub] spark pull request #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Diale...

2017-07-12 Thread radford1
GitHub user radford1 opened a pull request: https://github.com/apache/spark/pull/18607 [SPARK-21362][SQL][Adding Apache Drill JDBC Dialect] ## What changes were proposed in this pull request? Adding Apache Drill to the JDBC Dialect ## How was this patch tested