[GitHub] spark pull request #18263: [SPARK-21039] [Spark Core] Use treeAggregate inst...

2017-06-10 Thread rishabhbhardwaj
GitHub user rishabhbhardwaj opened a pull request: https://github.com/apache/spark/pull/18263 [SPARK-21039] [Spark Core] Use treeAggregate instead of aggregate in DataFrame.stat.bloomFilter ## What changes were proposed in this pull request? To use treeAggregate instead

[GitHub] spark pull request: [SPARK-14412][ML][PYSPARK] Add StorageLevel pa...

2016-04-25 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on a diff in the pull request: https://github.com/apache/spark/pull/12660#discussion_r60901825 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -374,8 +404,21 @@ class ALS(@Since("1.4.0") overri

[GitHub] spark pull request: [SPARK-14412][ML][WIP]spark.ml ALS prefered st...

2016-04-25 Thread rishabhbhardwaj
Github user rishabhbhardwaj closed the pull request at: https://github.com/apache/spark/pull/12202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-14412][ML][WIP]spark.ml ALS prefered st...

2016-04-25 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/12202#issuecomment-214281787 @MLnick @jkbradley Thanks, I am on it.I tried making the changes as per your comments but closing this PR now, as nick has created a PR for this. --- If your

[GitHub] spark pull request: [SPARK-14412][ML][WIP]spark.ml ALS prefered st...

2016-04-25 Thread rishabhbhardwaj
GitHub user rishabhbhardwaj reopened a pull request: https://github.com/apache/spark/pull/12202 [SPARK-14412][ML][WIP]spark.ml ALS prefered storage level Params ## What changes were proposed in this pull request? Added storage level params in ALSParams. ## How

[GitHub] spark pull request: [SPARK-14412][ML][WIP]spark.ml ALS prefered st...

2016-04-18 Thread rishabhbhardwaj
Github user rishabhbhardwaj closed the pull request at: https://github.com/apache/spark/pull/12202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-14412][ML][WIP]spark.ml ALS prefered st...

2016-04-18 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/12202#issuecomment-211710258 @MLnick : I need to study how MLParam works.For now,I am closing this PR.You can take this forward.Thanks. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-14412][ML][WIP]spark.ml ALS prefered st...

2016-04-06 Thread rishabhbhardwaj
GitHub user rishabhbhardwaj opened a pull request: https://github.com/apache/spark/pull/12202 [SPARK-14412][ML][WIP]spark.ml ALS prefered storage level Params ## What changes were proposed in this pull request? Added storage level params in ALSParams. ## How

[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...

2016-03-28 Thread rishabhbhardwaj
Github user rishabhbhardwaj closed the pull request at: https://github.com/apache/spark/pull/11873 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...

2016-03-21 Thread rishabhbhardwaj
GitHub user rishabhbhardwaj opened a pull request: https://github.com/apache/spark/pull/11873 [SPARK-14036][MLlib]Removed mllib.tree.model.Node.build ## What changes were proposed in this pull request? Removed build method from mllib.tree.model.Node. ## How

[GitHub] spark pull request: [SPARK-11548][DOCS] Replaced example code in m...

2015-11-06 Thread rishabhbhardwaj
GitHub user rishabhbhardwaj opened a pull request: https://github.com/apache/spark/pull/9519 [SPARK-11548][DOCS] Replaced example code in mllib-collaborative-filtering.md using include_example Kindly review the changes. You can merge this pull request into a Git repository

[GitHub] spark pull request: [SPARK-11445][DOCS]Replaced example code in ml...

2015-11-02 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/9407#issuecomment-153251456 @yinxusen Made the changes.Also ran the python files and they are working fine.Thanks for your inputs.WIll keep these points in mind from next time

[GitHub] spark pull request: [SPARK-11445][DOCS]Replaced example code in ml...

2015-11-02 Thread rishabhbhardwaj
GitHub user rishabhbhardwaj opened a pull request: https://github.com/apache/spark/pull/9407 [SPARK-11445][DOCS]Replaced example code in mllib-ensembles.md using include_example I have made the required changes and tested. Kindly review the changes. You can merge this pull

[GitHub] spark pull request: [SPARK-11445][DOCS]Replaced example code in ml...

2015-11-02 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/9407#issuecomment-153231485 @yinxusen Thanks for your comments.Have made the required changes in the files you pointed and others also.Please review. --- If your project is set up

[GitHub] spark pull request: [SPARK-11383][Docs] Replaced example code in m...

2015-10-30 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/9353#issuecomment-152450116 @mengxr Thanks for your comments and patience.I have made the required changes. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-11383][Docs] Replaced example code in m...

2015-10-29 Thread rishabhbhardwaj
GitHub user rishabhbhardwaj opened a pull request: https://github.com/apache/spark/pull/9353 [SPARK-11383][Docs] Replaced example code in mllib using include_example I have made the required changes in mllib-naive-bayes.md/mllib-isotonic-regression.md and also verified them

[GitHub] spark pull request: [SPARK-11383][Docs] Replaced example code in m...

2015-10-29 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/9353#issuecomment-152265104 @mengxr Thanks for your comments.I have corrected the code style issues and locally ran the style checks and they passed. --- If your project is set up

[GitHub] spark pull request: [SPARK-11383][Docs] Replaced example code in m...

2015-10-29 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/9353#issuecomment-152265717 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11383][Docs] Replaced example code in m...

2015-10-29 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/9353#issuecomment-152298344 @yinxusen Thanks for your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11383][Docs] Replaced example code in m...

2015-10-29 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/9353#issuecomment-152390706 @yinxusen I have removed the empty lines.Thanks for the comments. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [ SPARK-11180 ] [ SQL ] DataFrame.na.fill does...

2015-10-19 Thread rishabhbhardwaj
GitHub user rishabhbhardwaj opened a pull request: https://github.com/apache/spark/pull/9166 [ SPARK-11180 ] [ SQL ] DataFrame.na.fill does not support Boolean Type Added support for boolean types in fill and replace methods You can merge this pull request into a Git repository

[GitHub] spark pull request: [ SPARK-11180 ] [ SQL ] DataFrame.na.fill does...

2015-10-19 Thread rishabhbhardwaj
Github user rishabhbhardwaj commented on the pull request: https://github.com/apache/spark/pull/9166#issuecomment-149425165 Thanks @rxin , My jira id is rishabhbhardwaj --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well