[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

Github user sabanas commented on the issue: https://github.com/apache/spark/pull/23043 @adoron indeed this doesn't pass through setFloat, but all values go through - https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions

[GitHub] spark issue #20915: [SPARK-23803][SQL] Support bucket pruning

Github user sabanas commented on the issue: https://github.com/apache/spark/pull/20915 @cloud-fan thanks for the feedback, I fixed accordingly. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20915: [SPARK-23803][SQL] Support bucket pruning

Github user sabanas commented on the issue: https://github.com/apache/spark/pull/20915 ping @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20915: [SPARK-23803][SQL] Support bucket pruning

Github user sabanas commented on the issue: https://github.com/apache/spark/pull/20915 @gatorsmile we would really want to start using this feature in our production stack. could you or anyone else give your feedback on this PR? Thanks

[GitHub] spark issue #20915: [SPARK-23803][SQL] Support bucket pruning

Github user sabanas commented on the issue: https://github.com/apache/spark/pull/20915 @gatorsmile can we please proceed with the review? thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20915: [SPARK-23803][SQL] Support bucket pruning

Github user sabanas commented on a diff in the pull request: https://github.com/apache/spark/pull/20915#discussion_r178299681 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -50,6 +51,85 @@ import

[GitHub] spark pull request #20915: [SPARK-23803][SQL] Support bucket pruning

Github user sabanas commented on a diff in the pull request: https://github.com/apache/spark/pull/20915#discussion_r178299616 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -50,6 +51,85 @@ import

[GitHub] spark pull request #20915: [SPARK-23803][SQL] Support bucket pruning

Github user sabanas commented on a diff in the pull request: https://github.com/apache/spark/pull/20915#discussion_r178090546 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -50,6 +51,85 @@ import

[GitHub] spark issue #20915: [SPARK-23803][SQL] Support bucket pruning

Github user sabanas commented on the issue: https://github.com/apache/spark/pull/20915 org.apache.spark.sql.execution.streaming.sources.RateSourceSuite.overflow test failed. it passes on my local dev env and there are several other PRs failing the same test. possible CI issues

[GitHub] spark pull request #20915: [SPARK-23803][SQL] Filter prune buckets

GitHub user sabanas opened a pull request: https://github.com/apache/spark/pull/20915 [SPARK-23803][SQL] Filter prune buckets ## What changes were proposed in this pull request? support bucket pruning when filtering on a single bucketed column on the following predicates