[GitHub] spark pull request: [SPARK-3580][CORE] Add Consistent Method To Ge...

2015-11-28 Thread schot
Github user schot commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-160271652 @srowen @JoshRosen PR has been rebased to resolve the conflict on MimaExcludes. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-3580][CORE] Add Consistent Method To Ge...

2015-11-25 Thread schot
Github user schot commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-159591402 Because I merged the fix in the previous commit Jenkins retest does not happen automatically? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3580][CORE] Add Consistent Method To Ge...

2015-11-23 Thread schot
Github user schot commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-158928365 @srowen Yes, I added a Mima exclude. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3580][CORE] Add Consistent Method To Ge...

2015-11-18 Thread schot
Github user schot commented on a diff in the pull request: https://github.com/apache/spark/pull/9767#discussion_r45254169 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala --- @@ -62,6 +62,9 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] exte

[GitHub] spark pull request: [SPARK-3580][CORE] Add Consistent Method To Ge...

2015-11-18 Thread schot
Github user schot commented on a diff in the pull request: https://github.com/apache/spark/pull/9767#discussion_r45257971 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala --- @@ -62,6 +62,9 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] exte

[GitHub] spark pull request: [SPARK-3580] Add Consistent Method To Get Numb...

2015-11-17 Thread schot
Github user schot commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-157352481 Although it would be nice to fix the inconsistencies in the usage of partitions.length vs partitions.size, I agree that its better to stick to just adding

[GitHub] spark pull request: [SPARK-3580] Add Consistent Method To Get Numb...

2015-11-17 Thread schot
GitHub user schot opened a pull request: https://github.com/apache/spark/pull/9767 [SPARK-3580] Add Consistent Method To Get Number of RDD Partitions Across Different Languages I have tried to address all the comments in pull request https://github.com/apache/spark/pull/2447

[GitHub] spark pull request: [SPARK-3580][CORE] Add Consistent Method To Ge...

2015-11-17 Thread schot
Github user schot commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-157503489 If I understand the discussion in SPARK-3266 correctly the method should only be added to the JavaRRDLike trait and not the abstract class. I have updated the PR