[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-21 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22668 @felixcheung Thanks for merging. My account name in jira is : shivuson...@gmail.com This issue is assigned to me

[GitHub] spark pull request #22677: [SPARK-25683][Core] Updated the log for the first...

2018-10-18 Thread shivusondur
Github user shivusondur commented on a diff in the pull request: https://github.com/apache/spark/pull/22677#discussion_r226439337 --- Diff: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala --- @@ -169,7 +169,8 @@ private class AsyncEventQueue

[GitHub] spark pull request #22677: [SPARK-25683][Core] Updated the log for the first...

2018-10-18 Thread shivusondur
Github user shivusondur commented on a diff in the pull request: https://github.com/apache/spark/pull/22677#discussion_r226191226 --- Diff: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala --- @@ -169,7 +169,8 @@ private class AsyncEventQueue

[GitHub] spark issue #22677: [SPARK-25683][Core] Updated the log for the firstTime ev...

2018-10-17 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22677 cc @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22677: [SPARK-25683][Core] Updated the log for the firstTime ev...

2018-10-16 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22677 Hi, I have modified the title and description according to code change. Build also passed. Kindly check and merge

[GitHub] spark issue #22677: [SPARK-25683][Core] Make AsyncEventQueue.lastReportTimes...

2018-10-15 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22677 @jiangxb1987 @dongjoon-hyun I have modified accordingly. Tested locally with existing UT (to make drop the event, locally "LISTENER_BUS_EVENT_QUEUE_CAPACITY" is set to

[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-14 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22668 @felixcheung OK. Thank you. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-11 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22668 @gengliangwang @felixcheung If everything okay, can you please merge the PR. --- - To unsubscribe, e-mail: reviews

[GitHub] spark issue #22677: [SPARK-25683][Core] Make AsyncEventQueue.lastReportTimes...

2018-10-11 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22677 @jiangxb1987 Thanks for your comment, i think printing "since Wed Dec 31 16:00:00 PST 1969" still looks strange, Instead we can print "**since start of the applicat

[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...

2018-10-11 Thread shivusondur
Github user shivusondur commented on a diff in the pull request: https://github.com/apache/spark/pull/22668#discussion_r224337547 --- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala --- @@ -154,9 +150,6 @@ private[ui] trait PagedTable[T

[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...

2018-10-10 Thread shivusondur
Github user shivusondur commented on a diff in the pull request: https://github.com/apache/spark/pull/22668#discussion_r224318421 --- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala --- @@ -123,10 +123,9 @@ private[ui] trait PagedTable[T

[GitHub] spark pull request #22677: [SPARK-25683][Core] Make AsyncEventQueue.lastRepo...

2018-10-10 Thread shivusondur
Github user shivusondur commented on a diff in the pull request: https://github.com/apache/spark/pull/22677#discussion_r224007729 --- Diff: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala --- @@ -159,6 +159,11 @@ private class AsyncEventQueue

[GitHub] spark issue #22677: [SPARK-25683] Make AsyncEventQueue.lastReportTimestamp i...

2018-10-09 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22677 cc @HyukjinKwon , @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #22677: [SPARK-25683] Make AsyncEventQueue.lastReportTime...

2018-10-09 Thread shivusondur
GitHub user shivusondur opened a pull request: https://github.com/apache/spark/pull/22677 [SPARK-25683] Make AsyncEventQueue.lastReportTimestamp inital value as the currentTime instead of 0 ## What changes were proposed in this pull request? In AsyncEventQueue

[GitHub] spark issue #22567: [SPARK-25550][WEBUI]Environment Page of Spark Job Histor...

2018-10-09 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22567 @vanzin I modified according to your suggestion and updated the code. Now History properties will come as seperate tab in the EnvironmentPage as shown below snap. ![screenshot

[GitHub] spark issue #22567: [SPARK-25550][WEBUI]Environment Page of Spark Job Histor...

2018-10-08 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22567 @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-08 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22668 @felixcheung If the user inputs **rowcount** in **Show** tab such that all the rows comes in one page, From here on user can't see the pagination and he will not able to inputs **rowcount

[GitHub] spark issue #22669: [SPARK-25677] [Doc] spark.io.compression.codec = org.apa...

2018-10-08 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22669 @felixcheung I searched in all the code base, only this place i found --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #22669: [SPARK-25677] [Spark Compression] spark.io.compre...

2018-10-08 Thread shivusondur
GitHub user shivusondur opened a pull request: https://github.com/apache/spark/pull/22669 [SPARK-25677] [Spark Compression] spark.io.compression.codec = org.apache.spark.io.ZstdCompressionCodec throwing IllegalArgumentException Exception ## What changes were proposed in this pull

[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...

2018-10-07 Thread shivusondur
GitHub user shivusondur opened a pull request: https://github.com/apache/spark/pull/22668 [SPARK-25675] [Spark Job History] Job UI page does not show pagination with one page ## What changes were proposed in this pull request? Currently in PagedTable.scala pageNavigation

[GitHub] spark issue #22567: [SPARK-25550][WEBUI]Environment Page of Spark Job Histor...

2018-09-27 Thread shivusondur
Github user shivusondur commented on the issue: https://github.com/apache/spark/pull/22567 @vanzin Please review this patch. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22567: [WIP]Environment Page of Spark Job History UI sho...

2018-09-27 Thread shivusondur
GitHub user shivusondur reopened a pull request: https://github.com/apache/spark/pull/22567 [WIP]Environment Page of Spark Job History UI showing wrong value for spark.ui.retainedJobs ## What changes were proposed in this pull request? Currently, in History page, Number of Jobs

[GitHub] spark pull request #22567: [SPARK-25550] [WEBUI] Environment Page of Spark J...

2018-09-27 Thread shivusondur
Github user shivusondur closed the pull request at: https://github.com/apache/spark/pull/22567 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22567: [SPARK-25550] [Spark Job History] Environment Pag...

2018-09-27 Thread shivusondur
GitHub user shivusondur opened a pull request: https://github.com/apache/spark/pull/22567 [SPARK-25550] [Spark Job History] Environment Page of Spark Job History UI showing wrong value for spark.ui.retainedJobs ## What changes were proposed in this pull request? In history page