[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-22 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r48229826 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -28,11 +28,13 @@ import

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-22 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r48229820 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -28,11 +28,13 @@ import

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-22 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r48229813 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -69,6 +71,13 @@ object DefaultOptimizer extends

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-22 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r48229791 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerExtendableSuite.scala --- @@ -0,0 +1,54

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-21 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r48126327 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -28,44 +28,53 @@ import

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-18 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r48018543 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala --- @@ -0,0 +1,45

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-15 Thread stephankessler
Github user stephankessler commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-164682419 Just related, currently preparing appropriate documents to propose that to the community! Keep you posted! --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-14 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47472268 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala --- @@ -0,0 +1,45

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-11 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47329605 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala --- @@ -0,0 +1,45

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47097859 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/Strategy.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47071770 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -56,12 +55,16 @@ abstract class RuleExecutor

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47071677 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -17,6 +17,8 @@ package

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-07 Thread stephankessler
GitHub user stephankessler opened a pull request: https://github.com/apache/spark/pull/10174 [SPARK-7727] [SQL] Avoid inner classes in RuleExecutor Moved (case) classes Strategy, Once, FixedPoint and Batch to the companion object. This is necessary if we want to have the Optimizer